abfd44fd75
fix: 3 more high-severity bugs (H19, H20, H25)
...
- H19: /api/v1/mobile/auth/qr/verify no longer returns user_email. Knowing
a QR token now only tells the caller the token is valid; the email is
only revealed by /complete which consumes the token.
- H20: CoverageWorker max_attempts dropped from 3 to 1. The fail/2 path
already returns :ok and writes the failure onto the coverage record,
so the 3-attempt retry policy was never reachable and was misleading.
- H25: ChecksController.create rejects device_ids that don't belong to
the caller's organization (via ScopedResource.fetch). Without this an
API token could attach service checks to devices in another tenant.
Also strip bug ID references from in-code comments (per feedback that
H/M/L numbers don't survive past their bugs.md removal); commit history
keeps the audit trail.
2026-05-12 11:32:20 -05:00
2269f38fc5
test: lift coverage 78.42% → 79.59% with focused unit + integration tests
...
Adds tests across previously-uncovered or under-covered modules:
- Mix tasks: backfill_checks, copy_mibs, import_mibs (new test files)
- Status pages: StatusIncident changeset (new file)
- Webhook signature verification on AgentReleaseWebhookController
- CloudflareBanWorker: HTTP-stubbed success / 5xx / transport-error paths
- FirmwareVersionFetcherWorker: stubbed perform/0 success + non-200 + tx error
- Geoip.Import: production --production code path (HTTP-stubbed)
- AgentLive.Show: superuser restart_agent + update_agent + non-superuser paths
- NetworkMapLive: node_clicked, deep-link node, topology_updated PubSub
- PreseemInsightsLive: toggle_select, deselect_all, filter, dismiss-twice
- AlertQuery: 1-arity defaults variants
- ProfileWatcher: yaml + reload-trigger event passthrough
- MobileAuthController: verify_qr_token success + get/revoke session
- HealthController: redis-configured branch
- RedisHealthCheck: un-tag :integration tests now that Redis is local
- FourOhFourTracker: un-skip module (Redis available)
- PingExecutor: un-tag local-only tests + KeyError surface + clamp branch
- CheckExecutorWorker: dispatch tcp/dns/ssl/ping branches
- UserResetPasswordController: drop dead edit/update + their template
Also removes dead code: edit/update actions on UserResetPasswordController
and the unused edit.html.heex template — both routed via LiveView.
2026-05-07 18:40:43 -05:00
95e3870fec
feat: add Force10 FTOS and optical transceiver monitoring (ProCurve, Comware)
...
Completed Tier 1 (critical network switches) and Tier 2 (optical transceiver monitoring)
from Phase 3 implementation plan. All major network switches now have comprehensive sensor
coverage including temperature and fiber optic link diagnostics.
Files Changed:
- priv/profiles/os_discovery/ftos.yaml (enhanced)
Added Dell Force10 FTOS temperature monitoring for all 3 series:
- S-Series: Stack unit temperature (chStackUnitTemp)
OID: .1.3.6.1.4.1.6027.3.10.1.2.2.1.14
MIB: F10-S-SERIES-CHASSIS-MIB
- C-Series: Card temperature (chSysCardTemp)
OID: .1.3.6.1.4.1.6027.3.8.1.2.1.1.5
MIB: F10-C-SERIES-CHASSIS-MIB
- E-Series: Card upper + lower temperature (chSysCardUpperTemp, chSysCardLowerTemp)
OIDs: .1.3.6.1.4.1.6027.3.1.1.2.3.1.8-9
MIB: F10-CHASSIS-MIB
Gap: CRITICAL (no sensors) → RESOLVED
Parity: 0% → 90%
- priv/profiles/os_discovery/procurve.yaml (enhanced)
Added HP ProCurve transceiver optical monitoring (5 sensor types):
MIB: HP-ICF-TRANSCEIVER-MIB::hpicfXcvrInfoTable
Sensors:
- Temperature: hpicfXcvrTemp (OID .1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.11, divisor 1000)
- Bias Current: hpicfXcvrBias (OID .1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.13, divisor 1000)
- Supply Voltage: hpicfXcvrVoltage (OID .1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.12, divisor 1000)
- RX Power (dBm): hpicfXcvrRxPower (OID .1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.14, divisor 10)
- TX Power (dBm): hpicfXcvrTxPower (OID .1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.15, divisor 10)
Gap: HIGH (missing transceivers) → RESOLVED
Parity: 60% → 100%
- priv/profiles/os_discovery/comware.yaml (enhanced)
Added HP Comware transceiver optical monitoring (5 sensor types):
MIB: HH3C-TRANSCEIVER-INFO-MIB::hh3cTransceiverInfoTable
Sensors:
- Temperature: hh3cTransceiverTemperature (OID .1.3.6.1.4.1.25506.2.70.1.1.1.15)
- Bias Current: hh3cTransceiverBiasCurrent (OID .1.3.6.1.4.1.25506.2.70.1.1.1.17)
- Supply Voltage: hh3cTransceiverVoltage (OID .1.3.6.1.4.1.25506.2.70.1.1.1.16)
- RX Power (dBm): hh3cTransceiverCurRXPower (OID .1.3.6.1.4.1.25506.2.70.1.1.1.9, divisor 100)
- TX Power (dBm): hh3cTransceiverCurTXPower (OID .1.3.6.1.4.1.25506.2.70.1.1.1.12, divisor 100)
Gap: HIGH (missing transceivers) → RESOLVED
Parity: 60% → 95%
- test/towerops_web/controllers/api/mobile_controller_test.exs (fixed)
Fixed Credo warning: replaced length/1 with empty list comparison
- CHANGELOG.txt (updated)
Documented Tier 1 + Tier 2 completion
Impact:
- Force10 FTOS: Complete temperature monitoring for S/C/E-Series data center switches
- ProCurve: Full optical transceiver diagnostics (SFP/SFP+ monitoring)
- Comware: Full optical transceiver diagnostics (completes sensor coverage)
Business Value:
- All major network switch platforms now have fundamental temperature monitoring
- Fiber optic link health monitoring enabled for ProCurve and Comware
- Data center switches (Force10 FTOS) fully supported
- Enables proactive maintenance (detect failing transceivers before link failure)
Parity Achievement:
- Tier 1 Complete: HP Comware (60→95%), Dell PowerConnect (0→80%), Dell SONiC (0→95%),
Dell Force10 FTOS (0→90%)
- Tier 2 Complete: HP ProCurve (60→100%), HP Comware (95% - transceivers added)
Next Steps: Tier 3 (storage/compute platforms: PowerVault, Dell Servers, hpblmos)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-12 08:19:12 -06:00
