fix: return raw session token instead of hash in mobile QR login (#42)

the complete_qr_login endpoint was returning session.token (the SHA256
hash stored in the database) instead of session.raw_token (the plaintext).
this caused all subsequent API calls and WebSocket connections to fail
with 401/REFUSED since the server would hash the already-hashed token.

adds a regression test that verifies the returned token is usable for
authenticated API requests.

Reviewed-on: graham/towerops-web#42
This commit is contained in:
Graham McIntire 2026-03-16 13:59:52 -05:00 committed by graham
parent cdc40b3f3a
commit 33daaf14f0
2 changed files with 29 additions and 1 deletions

View file

@ -98,7 +98,7 @@ defmodule ToweropsWeb.Api.MobileAuthController do
session = Towerops.Repo.preload(session, :user)
json(conn, %{
session_token: session.token,
session_token: session.raw_token,
expires_at: session.expires_at,
user: %{
id: session.user.id,

View file

@ -1,6 +1,10 @@
defmodule ToweropsWeb.Api.MobileAuthControllerTest do
use ToweropsWeb.ConnCase, async: true
import Towerops.AccountsFixtures
alias Towerops.MobileSessions
describe "verify_qr_token" do
test "returns error for missing token", %{conn: conn} do
conn = post(conn, ~p"/api/v1/mobile/auth/qr/verify", %{})
@ -31,5 +35,29 @@ defmodule ToweropsWeb.Api.MobileAuthControllerTest do
assert json_response(conn, 401)["error"] == "Invalid or expired token"
end
test "returns a usable session token on success", %{conn: conn} do
user = user_fixture()
{:ok, qr_token} = MobileSessions.create_qr_login_token(user.id)
conn =
post(conn, ~p"/api/v1/mobile/auth/qr/complete", %{
"token" => qr_token.token,
"device_name" => "Test iPhone",
"device_os" => "iOS 17.2",
"app_version" => "1.0.0"
})
assert %{"session_token" => session_token} = json_response(conn, 200)
assert is_binary(session_token)
# The returned token must be usable for subsequent authenticated requests
authed_conn =
build_conn()
|> put_req_header("authorization", "Bearer #{session_token}")
|> get(~p"/api/v1/mobile/organizations")
assert json_response(authed_conn, 200)
end
end
end