Graham McIntire
1400c38f44
Rework of d61fbd3's dialyzer suppression: the 4 warnings from
LiveTable.LiveResource's macro expansion are now fixed at the
root rather than hidden via .dialyzer_ignore.exs.
Changes:
- Delete .dialyzer_ignore.exs and remove ignore_warnings from
mix.exs. No more hidden suppressions.
- New MicrowavepropWeb.LiveTableResource shim that wraps
use LiveTable.LiveResource and overrides:
* maybe_subscribe/1 — explicit :ok = on Phoenix.PubSub.subscribe/2
(previously discarded, tripping :unmatched_return).
* handle_info/2 — explicit _ = on File.rm, Process.send_after.
Switch all 4 LiveTable-using LiveViews (contact_live/index,
beacon_live/index, admin/contact_edit_live, user_management_live/index)
to use MicrowavepropWeb.LiveTableResource instead.
- New priv/dep_patches/live_table-0.4.1.patch adds _ = in front of
LiveTable.LiveSelectHelpers.restore_live_select_from_params/2 in
the dep's macro-expanded handle_params/3. The call's return was
silently discarded, tripping the fourth warning per LiveView.
- New lib/mix/tasks/deps.patch.ex applies every
priv/dep_patches/*.patch to its target dep idempotently after
mix deps.get. Wired into the :setup alias + overridden
mix deps.get so the patch survives cache regeneration in CI.
- Other modified files in this commit are the spec-coverage
additions from the parallel agent pass (beacons.ex,
commercial.ex, propagation.ex, weather.ex, narr_client.ex,
run_timing.ex, 3 workers) — tighter specs for bounds, tuple
shapes, schema-typed params. Dialyzer remains at 0 after
the changes.
Upstream TODO: send a PR for the live_table `_ =` fix. Once
merged and released, drop the patch + mix task + bump the dep.
mix dialyzer --format short | grep ^lib/ | wc -l -> 0
mix test: 2165 tests, 2 pre-existing flakes (MapLive timestamp +
PropagationPrune ScoresFile), 0 regressions.
42 lines
1.4 KiB
Elixir
42 lines
1.4 KiB
Elixir
defmodule Microwaveprop.Propagation.RunTiming do
|
|
@moduledoc """
|
|
One row per forecast hour of a `PropagationGridWorker` chain, recording
|
|
how long that hour's fetch + score + persist cycle took.
|
|
|
|
Rows are keyed by `(run_time, forecast_hour)`. `run_time` is the HRRR
|
|
model cycle and `forecast_hour` ∈ 0..18.
|
|
"""
|
|
use Ecto.Schema
|
|
|
|
import Ecto.Changeset
|
|
|
|
@type t :: %__MODULE__{}
|
|
|
|
@primary_key {:id, :binary_id, autogenerate: true}
|
|
@foreign_key_type :binary_id
|
|
schema "propagation_run_timings" do
|
|
field :run_time, :utc_datetime
|
|
field :forecast_hour, :integer
|
|
field :valid_time, :utc_datetime
|
|
field :started_at, :utc_datetime_usec
|
|
field :finished_at, :utc_datetime_usec
|
|
field :duration_ms, :integer
|
|
field :status, Ecto.Enum, values: [:ok, :failed]
|
|
field :error, :string
|
|
|
|
timestamps(type: :utc_datetime, updated_at: false)
|
|
end
|
|
|
|
@required ~w(run_time forecast_hour valid_time started_at finished_at duration_ms status)a
|
|
@optional ~w(error)a
|
|
|
|
@spec changeset(t() | Ecto.Changeset.t(), map()) :: Ecto.Changeset.t()
|
|
def changeset(row, attrs) do
|
|
row
|
|
|> cast(attrs, @required ++ @optional)
|
|
|> validate_required(@required)
|
|
|> validate_number(:forecast_hour, greater_than_or_equal_to: 0, less_than_or_equal_to: 18)
|
|
|> validate_number(:duration_ms, greater_than_or_equal_to: 0)
|
|
|> unique_constraint([:run_time, :forecast_hour])
|
|
end
|
|
end
|