graham/prop - Forgejo: Beyond coding. We forge.

graham/prop

Fork 0

Commit graph

Author	SHA1	Message	Date
Graham McIntire	1400c38f44	fix(dialyzer): actually fix LiveTable warnings instead of hiding them Rework of d61fbd3's dialyzer suppression: the 4 warnings from LiveTable.LiveResource's macro expansion are now fixed at the root rather than hidden via .dialyzer_ignore.exs. Changes: - Delete .dialyzer_ignore.exs and remove ignore_warnings from mix.exs. No more hidden suppressions. - New MicrowavepropWeb.LiveTableResource shim that wraps use LiveTable.LiveResource and overrides: * maybe_subscribe/1 — explicit :ok = on Phoenix.PubSub.subscribe/2 (previously discarded, tripping :unmatched_return). * handle_info/2 — explicit _ = on File.rm, Process.send_after. Switch all 4 LiveTable-using LiveViews (contact_live/index, beacon_live/index, admin/contact_edit_live, user_management_live/index) to use MicrowavepropWeb.LiveTableResource instead. - New priv/dep_patches/live_table-0.4.1.patch adds _ = in front of LiveTable.LiveSelectHelpers.restore_live_select_from_params/2 in the dep's macro-expanded handle_params/3. The call's return was silently discarded, tripping the fourth warning per LiveView. - New lib/mix/tasks/deps.patch.ex applies every priv/dep_patches/*.patch to its target dep idempotently after mix deps.get. Wired into the :setup alias + overridden mix deps.get so the patch survives cache regeneration in CI. - Other modified files in this commit are the spec-coverage additions from the parallel agent pass (beacons.ex, commercial.ex, propagation.ex, weather.ex, narr_client.ex, run_timing.ex, 3 workers) — tighter specs for bounds, tuple shapes, schema-typed params. Dialyzer remains at 0 after the changes. Upstream TODO: send a PR for the live_table `_ =` fix. Once merged and released, drop the patch + mix task + bump the dep. mix dialyzer --format short \| grep ^lib/ \| wc -l -> 0 mix test: 2165 tests, 2 pre-existing flakes (MapLive timestamp + PropagationPrune ScoresFile), 0 regressions.	2026-04-21 12:58:10 -05:00
Graham McIntire	d61fbd346e	fix(dialyzer): clear 125+ warnings under strict flags Enabled :error_handling, :unknown, :unmatched_returns, :extra_return, :missing_return in an earlier commit and landed a 129-warning baseline. Four parallel agents each fixed a directory slice: - Core contexts (29): Radio, Release, Weather, Beacons, Cache, Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient, Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were (a) prefix side-effect calls (Task.start, Phoenix.PubSub, Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't match actual returns; (c) add missing @type t declarations; (d) drop dead parse_int(nil) clause. - Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener, ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis, Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache, HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on PubSub / :ets / Repo.insert_all; widened two specs (float -> number) where integer returns were reachable. - Workers (35): BackfillEnqueue, CanadianSoundingFetch, ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch, NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_* side-effect calls. Fixed one :pattern_match in CanadianSoundingFetch.most_recent_sounding_time/1 where a tautological cond guard generated unreachable code. - Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews, UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining warnings originate in LiveTable.LiveResource dep macro expansion and can't be fixed without forking the dep — added .dialyzer_ignore.exs to suppress just those specific file:line pairs. Also wired ignore_warnings in mix.exs dialyzer config. mix dialyzer --format short \| grep ^lib/ \| wc -l -> 0 mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.	2026-04-21 10:30:06 -05:00
Graham McIntire	fc91f204fd	feat(propagation): record per-forecast-hour chain step timings Add a propagation_run_timings table so the wall-clock duration of each (run_time, forecast_hour) step is queryable long after the run is over. Keyed by (run_time, forecast_hour) with a status column that captures whether the step succeeded or bailed out, and an error string on failure. PropagationGridWorker stamps every step (ok and failed) via Propagation.record_run_timing/1. Timing inserts are wrapped in rescue + changeset-error handling so the instrumentation can never brick the chain.	2026-04-18 09:36:52 -05:00

Author

SHA1

Message

Date

Graham McIntire

1400c38f44

fix(dialyzer): actually fix LiveTable warnings instead of hiding them

Rework of d61fbd3's dialyzer suppression: the 4 warnings from
LiveTable.LiveResource's macro expansion are now fixed at the
root rather than hidden via .dialyzer_ignore.exs.

Changes:

- Delete .dialyzer_ignore.exs and remove ignore_warnings from
  mix.exs. No more hidden suppressions.

- New MicrowavepropWeb.LiveTableResource shim that wraps
  use LiveTable.LiveResource and overrides:
  * maybe_subscribe/1 — explicit :ok = on Phoenix.PubSub.subscribe/2
    (previously discarded, tripping :unmatched_return).
  * handle_info/2 — explicit _ = on File.rm, Process.send_after.
  Switch all 4 LiveTable-using LiveViews (contact_live/index,
  beacon_live/index, admin/contact_edit_live, user_management_live/index)
  to use MicrowavepropWeb.LiveTableResource instead.

- New priv/dep_patches/live_table-0.4.1.patch adds _ = in front of
  LiveTable.LiveSelectHelpers.restore_live_select_from_params/2 in
  the dep's macro-expanded handle_params/3. The call's return was
  silently discarded, tripping the fourth warning per LiveView.

- New lib/mix/tasks/deps.patch.ex applies every
  priv/dep_patches/*.patch to its target dep idempotently after
  mix deps.get. Wired into the :setup alias + overridden
  mix deps.get so the patch survives cache regeneration in CI.

- Other modified files in this commit are the spec-coverage
  additions from the parallel agent pass (beacons.ex,
  commercial.ex, propagation.ex, weather.ex, narr_client.ex,
  run_timing.ex, 3 workers) — tighter specs for bounds, tuple
  shapes, schema-typed params. Dialyzer remains at 0 after
  the changes.

Upstream TODO: send a PR for the live_table `_ =` fix. Once
merged and released, drop the patch + mix task + bump the dep.

mix dialyzer --format short | grep ^lib/ | wc -l -> 0
mix test: 2165 tests, 2 pre-existing flakes (MapLive timestamp +
PropagationPrune ScoresFile), 0 regressions.

2026-04-21 12:58:10 -05:00

Graham McIntire

d61fbd346e

fix(dialyzer): clear 125+ warnings under strict flags

Enabled :error_handling, :unknown, :unmatched_returns, :extra_return,
:missing_return in an earlier commit and landed a 129-warning baseline.
Four parallel agents each fixed a directory slice:

- Core contexts (29): Radio, Release, Weather, Beacons, Cache,
  Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient,
  Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were
  (a) prefix side-effect calls (Task.start, Phoenix.PubSub,
  Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't
  match actual returns; (c) add missing @type t declarations;
  (d) drop dead parse_int(nil) clause.

- Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener,
  ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis,
  Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache,
  HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on
  PubSub / :ets / Repo.insert_all; widened two specs (float ->
  number) where integer returns were reachable.

- Workers (35): BackfillEnqueue, CanadianSoundingFetch,
  ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch,
  NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed
  Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_*
  side-effect calls. Fixed one :pattern_match in
  CanadianSoundingFetch.most_recent_sounding_time/1 where a
  tautological cond guard generated unreachable code.

- Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews,
  UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining
  warnings originate in LiveTable.LiveResource dep macro expansion
  and can't be fixed without forking the dep — added .dialyzer_ignore.exs
  to suppress just those specific file:line pairs.

Also wired ignore_warnings in mix.exs dialyzer config.

mix dialyzer --format short | grep ^lib/ | wc -l -> 0
mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.

2026-04-21 10:30:06 -05:00

Graham McIntire

fc91f204fd

feat(propagation): record per-forecast-hour chain step timings

Add a propagation_run_timings table so the wall-clock duration of each
(run_time, forecast_hour) step is queryable long after the run is over.
Keyed by (run_time, forecast_hour) with a status column that captures
whether the step succeeded or bailed out, and an error string on
failure.

PropagationGridWorker stamps every step (ok and failed) via
Propagation.record_run_timing/1. Timing inserts are wrapped in rescue +
changeset-error handling so the instrumentation can never brick the
chain.

2026-04-18 09:36:52 -05:00

3 commits