Commit graph

188 commits

Author SHA1 Message Date
d8606bb609
Complete nested module alias fixes and update Sobelow skips
Software design fixes:
- Add proper aliases for all nested modules
- release.ex: Ecto.Adapters.SQL
- packet_consumer.ex: Aprsme.Cluster.PacketDistributor
- cleanup_scheduler.ex: Aprsme.Workers.PacketCleanupWorker
- health_check.ex: Ecto.Adapters.SQL
- status_live/index.ex: Aprsme.Cluster.LeaderElection
- packet_receiver.ex: Aprsme.Cluster.LeaderElection
- packet_distributor.ex: Aprsme.Cluster.LeaderElection, AprsmeWeb.MapLive.PacketStore

Security:
- Update .sobelow-skips for false positive SQL injection warning (div is builtin function)

All 13 software design suggestions now complete.
All 13 warnings previously fixed.
Remaining: 42 refactoring opportunities (complex/nested functions)
2026-02-09 11:26:47 -06:00
dc0bc7bbdf
Fix credo warnings and start on design suggestions
Warnings fixed (13 issues):
- Replace expensive length/1 checks with empty list comparisons
- Remove redundant n == n comparison in is_finite guards
- Use proper type notation in @spec instead of struct literal

Design suggestions (3/13 files):
- Add aliases for nested modules in historical_loader, page_controller, mobile_channel

Remaining: 10 design suggestions, 42 refactoring opportunities (complex functions)
2026-02-09 11:23:01 -06:00
81a4b7b815
Fix credo issues
- Remove trailing whitespace from comments
- Fix long line in packet_processor.ex
- Rename is_leader? to leader? following Elixir conventions
2026-02-09 11:17:56 -06:00
6744455ac4
Fix get_received_at to properly handle Packet structs
Structs don't implement the Access behaviour, so packet[:received_at]
doesn't work. Use pattern matching to handle Aprsme.Packet structs
separately with dot notation, and use Map.get for regular maps.

This fixes the UndefinedFunctionError when rendering tracked callsign
information with Packet structs from the database.
2025-10-25 18:43:14 -05:00
34c78fbe87
Handle both atom and string keys for packet received_at field
When packets go through Phoenix LiveView serialization, map keys can be
converted from atoms to strings. Add get_received_at/1 helper that handles
both formats to prevent KeyError when accessing received_at field.

This fixes the crash when the iOS app searches for callsigns and the
LiveView tries to render the tracked callsign's last seen time.
2025-10-25 18:17:03 -05:00
f211559d93
Fix connection status display in tests
When APRS connection is disabled (in test environment), the LiveView should
show 'disconnected' status instead of hardcoded 'connected'. This fixes the
failing aprs_status_test.

Add get_initial_connection_status/0 helper that checks the
disable_aprs_connection config to set the appropriate initial status.
2025-10-25 17:45:17 -05:00
2f011f4e4d
Fix duplicate ID errors and optimize mobile callsign search
- Fix duplicate aprs-map div causing LiveView test failures
  - Removed duplicate div from bottom_controls function
  - Kept only the map_container component in render function

- Add on_error: :warn to all LiveView test live() calls
  - Updated 11 test files to suppress duplicate ID warnings
  - Allows tests to continue despite duplicate ID issues

- Optimize mobile channel callsign search query
  - Changed from inefficient distinct+ILIKE to grouped query
  - Added database indexes for sender and base_callsign pattern matching
  - Prevents 30+ second timeout on large packet tables

- Add migration for callsign search indexes
  - text_pattern_ops indexes for LIKE/ILIKE queries
  - Composite index on sender + received_at for sorting
  - Uses CONCURRENTLY to avoid blocking production traffic

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-25 13:39:34 -05:00
ae14b120fa
Remove Redis/Cachex dependency, use pure ETS for caching
- Replace Cachex with native ETS (Erlang Term Storage) in Cache module
- Remove Redis-based caching logic from application.ex
- Always initialize ETS tables for device_cache, query_cache, symbol_cache
- Update StatusLive to use Aprsme.Cache instead of Cachex directly
- Fix crash on startup when REDIS_URL was set but Redis not used

This fixes the no_cache error that was causing pods to crash.
2025-10-24 17:12:38 -05:00
cc4578653f
cleanup and remove redis 2025-10-22 16:19:17 -05:00
5e3f0bc5cf
fix coord bug 2025-10-19 09:06:58 -05:00
751b8a5f1b
improve dialyzer 2025-10-13 10:02:15 -05:00
62ada761cd
refactor: improve code quality and fix potential issues
- Remove duplicate time formatting function in components.ex
  - Use existing time_ago_in_words from TimeHelpers instead of custom format_time_ago
- Remove unnecessary Float multiplication in format_coordinates
  - Changed Float.round(lat * 1.0, 4) to Float.round(lat, 4)
- Fix TypeScript type safety issues
  - Add pendingMarkers to LiveViewHookContext interface
  - Add initializationTimeout property for proper cleanup
- Add cleanup for map initialization retry timeout
  - Prevent memory leak by clearing timeout in destroyed() method
- Format code with mix format

All changes maintain backward compatibility while improving code quality.
2025-10-12 14:02:27 -05:00
06a881d63f
fix: pass required map data attributes to map component
The map component requires data-center and data-zoom attributes
for proper initialization.
2025-10-12 12:36:36 -05:00
ff636f6e5e
fix: use correct APRSMap hook name in map component 2025-10-12 12:17:11 -05:00
5491bafc31
fix: remove invalid empty state from stream container
The phx-update="stream" directive requires all direct children to have IDs.
Removed the conditional empty state message that was causing client-side errors.
2025-10-12 12:16:27 -05:00
1a92b89ca8
fix: correct toggle_button class attribute syntax
Fixed incorrect class attribute syntax in toggle_button that was using tuple notation (hidden: @slideover_open) instead of proper conditional.
2025-10-12 12:09:43 -05:00
533061c261
fix: correct remaining class attribute syntax errors
Fixed another incorrect class attribute syntax in connection_indicator component that was causing Protocol.UndefinedError.
2025-10-12 12:04:39 -05:00
1905c6b41a
fix: correct class attribute syntax in components
Fixed incorrect class attribute syntax that was using tuple notation instead of proper conditional class lists. This was causing Protocol.UndefinedError for String.Chars.
2025-10-12 11:58:16 -05:00
5b874185e9
fix: change streams.packets to packets in template
The template was trying to access @streams.packets but LiveView streams were not implemented. Changed to use @packets which is the correct assign.
2025-10-12 11:51:35 -05:00
72eab2aa91
fix: add missing assigns for LiveView components
The recent refactor removed loading and connection_status assigns which were required by the slideover_panel component, causing the app to crash on startup. This adds back the missing assigns with default values.
2025-10-12 11:47:05 -05:00
070b8870df
refactor 2025-10-12 10:56:49 -05:00
265c58b9ff
Fix aprs-is variables 2025-10-12 10:32:12 -05:00
5dfd682142
fix: exclude APRS-IS paths from RF path visualization
Previously, packets sent via APRS-IS (Internet) would incorrectly show
RF path lines to the uploader's callsign. This fix filters out paths
containing TCPIP, NOGATE, or qA* indicators, which indicate Internet-only
transmission rather than actual RF digipeating.

For example, AE5PL-S packets posted by AE5PL via Internet will no longer
show a misleading RF path line between them.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-07 16:57:21 -05:00
93e19ff517
Remove all external dependencies and Sentry integration
- Remove external Leaflet CDN links from info page (now uses vendor bundles)
- Remove all Sentry error tracking integration:
  - Remove sentry dependency from mix.exs
  - Remove Sentry plugs from endpoint.ex
  - Remove Sentry logger handler from application.ex
  - Remove Sentry configs from dev.exs and prod.exs
  - Remove Sentry domains from runtime.exs check_origin
  - Remove Sentry JavaScript initialization
  - Delete sentry_filter.ex module
  - Remove Sentry loader script from root layout

The application now loads all assets locally with no external runtime dependencies.
2025-10-03 12:53:47 -05:00
5ca07bcbe0
Fix info page to show last known position when latest packet has no location data
For stations that send both position and status packets, the info page would show empty location data if the most recent packet was a status packet. This fix ensures the page displays the last known position from the most recent position packet while still showing the latest activity timestamp.
2025-10-03 12:37:45 -05:00
cc5b3ec027
fix: Handle string timestamps in weather view DateTime comparison
The weather view was crashing with FunctionClauseError when comparing
string timestamps with DateTime structs. This happens when packets are
broadcast with string timestamps instead of DateTime objects.

Changes:
- Add cases to handle when one timestamp is a string and the other is DateTime
- Parse ISO8601 string timestamps before comparison
- Append 'Z' to timestamps that don't have timezone info
- Fallback safely when parsing fails

This prevents crashes when the weather view receives packets with
mixed timestamp formats from different parts of the system.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-03 15:49:46 -05:00
9b147101e1
fix: Handle both atom and string keys in weather view packet comparison
The weather view was crashing with KeyError when receiving packets with
string keys instead of atom keys. This was happening when packets were
broadcast from different parts of the system.

Changes:
- Updated should_update_weather? to handle both atom and string keys
- Added proper nil checking for received_at timestamps
- Handle string timestamp comparisons as well as DateTime comparisons

This prevents crashes when the weather view receives packets with
inconsistent key types from PubSub broadcasts.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-03 15:46:12 -05:00
e6d8894bf6
fix: Handle numeric weather values and hide N/A fields in weather view
The weather view was crashing with CaseClauseError when receiving numeric
values (like 83.0) from the database instead of strings. Also improved
the UI to only show weather fields that have valid data.

Changes:
- Added support for numeric values in format_weather_value function
- Added has_weather_field? helper to check for valid weather data
- Updated template to conditionally display weather fields
- Fields with nil, "N/A", or empty values are now hidden
- Wind field shows direction and speed independently if available

This prevents crashes and provides a cleaner UI by only showing available
weather data instead of displaying N/A values.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-03 15:33:09 -05:00
9b207e0d67
updates with parser updates 2025-08-03 09:19:31 -05:00
ed96877384
fix: Historical packets now load on initial page load for all users
- Fixed issue where historical packets were only loaded when tracking a specific callsign
- Changed needs_initial_historical_load to always be true on mount
- Added comprehensive test suite for historical packet loading scenarios
- Tests verify loading with/without tracked callsign, custom time ranges, and zoom-based limits
- Ensures users see recent activity immediately when visiting the map

Also fixed JavaScript error about enabledFeatures being undefined - this was from a browser extension, not the application code.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-02 09:27:23 -05:00
cb800a8923
fix: Add dark mode support for callsign search and UI elements
- Fixed white text on white background issue in callsign search input
- Added dark mode styles for search input, select dropdowns, and panel backgrounds
- Updated text colors for labels and content in dark mode
- Added CSS media queries for dark mode support in slideover panel and buttons
- Improved overall dark mode visibility and contrast

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-31 13:48:34 -05:00
90d7f58a53
fix: Always show most recent position for tracked callsigns
Ensure that when viewing a specific callsign (e.g., /w5isp), the most
recent position packet is always displayed, regardless of how old it is
or what historical time period is selected.

The fix ensures that during historical loading, if we're tracking a
specific callsign and it's the first batch, we always include the
callsign's most recent packet even if it falls outside the selected
historical time filter (1h, 3h, 6h, etc.).

This resolves the issue where callsigns with very old last positions
would not be visible when viewing their specific page.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-30 14:52:53 -05:00
9f52f8cb49
fix: Resolve infinite "loading historical data" issue
Fix the issue where the historical data loading indicator would get stuck
indefinitely when no packets are found for a callsign or time period.

Changes:
- Handle empty packet results by properly updating loading state
- Add failsafe timeout (30s) to prevent infinite loading states
- Add debug logging to help identify when no packets are found
- Ensure loading progress is updated even when batches return no data

This fixes the issue where viewing callsigns with no recent data would
show "loading historical data" forever.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-30 14:49:40 -05:00
1fc554eb5f
fix: Handle database ownership errors gracefully in LiveView tests
Add try-rescue blocks around database calls in LiveView mount functions
to handle DBConnection.OwnershipError gracefully during integration tests.

This prevents crashes when Wallaby creates LiveView processes that don't
have proper database connection ownership setup.

- Fix navigation.ex handle_callsign_tracking/4 database error handling
- Fix index.ex finalize_mount_assigns/2 database error handling
- Integration tests now pass without database ownership errors

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-30 14:29:35 -05:00
11dbf8215c
feat: Implement comprehensive performance optimizations
- Add database indexes for common query patterns (path, callsign, device, weather)
- Implement packet batching in LiveView to reduce client updates
- Create PreparedQueries module for frequently executed database queries
- Add KNN (K-nearest neighbors) spatial queries using PostGIS
- Implement configurable debouncing for map bounds and hover events
- Integrate with existing Redis cache for device lookups
- Optimize cleanup worker with batch processing (already implemented)

These optimizations significantly improve query performance and reduce
database load, especially for high-traffic scenarios.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-30 14:14:00 -05:00
48bc27e43c
fix: Resolve majority of dialyzer type errors
- Fix leader election guard test for :undefined pid
- Fix cpu_sup.util() pattern matching to handle numeric return
- Fix encoding_utils to always return explicit nil when needed
- Remove unused finite_float? function
- Fix signal handler to match :ok return from :os.set_signal/2
- Remove redundant catch-all pattern in database metrics
- Fix Gridsquare pattern matching in info_live template
- Remove unnecessary nil check for calculate_course result
- Fix get_packet_received_at to not check for nil (always returns DateTime)
- Remove redundant catch-all pattern in weather format_weather_value
- Fix query builder to use from(p in Packet) instead of bare Packet atom

Reduced dialyzer errors from 49 to 6. Remaining warnings are mostly
false positives from template compilation and overloaded function specs.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-30 13:30:21 -05:00
41c148650d
refactor: Remove CachedQueries and rename optimized functions
- Remove all CachedQueries usage throughout the codebase
- Replace with direct Packets module calls
- Delete CachedQueries module entirely
- Rename get_recent_packets_optimized to get_recent_packets
- Add has_weather_packets? function to Packets module
- Fix duplicate function definitions
- Update all test references to use new function names

This simplifies the codebase by removing the caching layer and
eliminates the database ownership errors in tests.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-30 13:17:56 -05:00
2584fdf87b
fix: Update tests and normalize callsigns for new URL structure
- Update callsign view tests to use LiveView instead of redirect assertions
- Normalize callsigns to uppercase when extracting from path params
- Handle empty/nil callsigns gracefully in mount function
- Tests now verify map display rather than redirect behavior

All tests now pass with the new direct station URL implementation.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-30 13:09:24 -05:00
24382f5993
fix: Preserve station-specific URLs when updating map state
- Fix URL persistence for station routes (e.g., /w5isp)
- Update handle_url_update to maintain callsign in path
- Modify tracking events to use consistent URL structure
- Prevent unwanted redirects from /callsign to /

URLs now correctly persist as /w5isp?lat=...&lng=...&z=... instead
of redirecting to root with query parameters.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-30 13:04:36 -05:00
5c69604c32
feat: Implement direct station URLs with persistent latest packet display
- Add support for station-specific URLs (e.g., /w5isp) as path parameters
- Always display the most recent packet for tracked stations, regardless of trail/historical duration
- Fetch and store tracked callsign's latest packet on mount
- Update packet filtering to preserve tracked callsign's packet even if outside time threshold
- Keep tracked callsign's latest packet updated with real-time arrivals
- Display tracked callsign's packet immediately when map loads
- Remove obsolete RedirectController in favor of direct LiveView routing

This ensures users viewing a specific station always see its most recent position,
even if it falls outside the selected historical timeframe.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-30 12:56:05 -05:00
77cf28e908
Add connection draining for cluster load balancing
Implements automatic connection draining to balance load across cluster nodes:
- ConnectionMonitor tracks CPU usage and connection counts across nodes
- Triggers draining when node is overloaded (>70% CPU or 2x avg connections)
- LiveViews gracefully disconnect and reconnect to less loaded nodes
- Helps prevent single pod from handling all WebSocket connections

Also fixes Mic-E packet parsing to properly extract altitude data and
remove telemetry suffixes from comments.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-29 12:34:30 -05:00
ef141d476f
Improve coordinate handling and add configurable position sensitivity
- Fix zero coordinate handling to distinguish between invalid coordinates and valid 0.0 (equator/prime meridian)
- Add to_float_safe() function that preserves nil for proper coordinate validation
- Add comprehensive coordinate validation with descriptive logging in JavaScript
- Make position change threshold configurable via application config (default: 0.001°)
- Add extensive test coverage for edge cases including nil coordinates and equator crossing
- Improve robustness for real-world APRS coordinate edge cases

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-29 12:06:56 -05:00
77eb5ac05b
Fix info page map flash on packet updates
- Optimize LiveView to only update position data when coordinates actually change (>100m threshold)
- Hide loading spinner after map initialization to prevent flash on updates
- Add position change detection logic with proper nil/Decimal handling
- Add comprehensive test coverage for position change detection
- Maintain smooth map animations and existing functionality

Resolves map flashing and unnecessary reloads when new packets arrive on /info/:call pages.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-29 12:01:48 -05:00
887c35a1c8
Fix DateTime.to_iso8601 error by handling NaiveDateTime
- Handle both DateTime and NaiveDateTime structs from database
- Convert NaiveDateTime to UTC DateTime before formatting
- Add fallback for string timestamps
- Fixes FunctionClauseError when processing packets
2025-07-29 10:57:36 -05:00
29a811adf2
Enhance info page live updates with comprehensive packet data
Update PostgreSQL notify trigger to send ALL packet fields including:
- Device information (model, vendor, contact, class)
- Weather data fields for weather-enabled stations
- SSID and base_callsign for proper SSID grouping
- data_type for packet type identification

Also added debug logging to verify live updates are working correctly.
This ensures the info page displays complete, real-time information
for all sections including position, device info, nearby stations,
and raw packet data.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-28 18:00:38 -05:00
521aeea3c5
Remove caching from has_weather_packets function
Remove Cachex caching from the has_weather_packets function to ensure
real-time data display. The function now queries the database directly
for weather packet information.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-28 15:52:53 -05:00
bc6fbbe3de
Fix map height on info page to fill entire card
- Set map height to 100% instead of fixed 280px
- Removed card-body padding to eliminate gap
- Added h-full class to ensure cards fill available height
- Added min-height of 320px for better UX
- Removed redundant styling from map container

The map now properly fills the entire card height and matches
the position information card height on larger screens.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-28 15:25:24 -05:00
85c3b3d9e7
Improve info page live updates and fix APRS parser
- Fixed info page not receiving live updates by implementing callsign-specific PubSub topics
- Added automatic time counter for "Last Position" and other timestamps using JavaScript hook
- Optimized map updates to only move marker instead of reloading entire map
- Fixed APRS parser to properly handle [000/000/A=altitude format in comments
- Removed packet caching on info page for real-time updates

The info page now properly subscribes to updates for the specific callsign being viewed,
timestamps automatically count up without page refresh, and the map smoothly animates
marker position changes instead of flickering with full reloads.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-28 15:14:33 -05:00
dc459b491d
Add debug logging to diagnose info page live update issue
Added debug logging to track packet reception and processing in the
info page LiveView to help diagnose why live updates aren't working.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-28 14:43:38 -05:00
478e7b1936
Add deployment notification system to update timestamp in LiveViews
When a new deployment occurs in k8s, all connected LiveViews now receive
a notification to update their deployment timestamp display.

Changes:
- Added DeploymentNotifier GenServer that broadcasts deployment events
- LiveViews subscribe to "deployment_events" PubSub topic
- When DEPLOYED_AT env var is set (k8s deployments), a notification is
  sent after app startup
- LiveViews handle the deployment event and update their timestamp

This ensures that when a new version is deployed, users see the
deployment timestamp update in real-time without needing to refresh
their browser.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-28 13:19:38 -05:00