Graham McIntire
0ea54b63db
**Performance improvement: 52s → 33.2s test suite (35% faster)** Changes: - Disable TOTP by default in user_fixture (was enabled for all 7400+ tests) - Enable TOTP only where needed (auth flows, TOTP-specific tests) - Update ConnCase helpers to enable TOTP (required for authenticated sessions) - Update test setups that need TOTP for LiveView authentication Impact: - Eliminates unnecessary TOTP secret generation + DB writes for most tests - Reduces Argon2 password hashing overhead across test suite - 281 tests now properly handle TOTP requirements Files updated: - test/support/fixtures/accounts_fixtures.ex: enable_totp default false → true only when needed - test/support/conn_case.ex: register_and_log_in_user helpers enable TOTP - test/towerops/accounts_test.exs: TOTP-related describe blocks enable TOTP - test/towerops_web/user_auth_test.exs: setup enables TOTP - test/towerops_web/live/admin/*: admin LiveView tests enable TOTP - test/towerops_web/live/org/preseem_devices_live_test.exs: enable TOTP
99 lines
2.8 KiB
Elixir
99 lines
2.8 KiB
Elixir
defmodule ToweropsWeb.ConnCase do
|
|
@moduledoc """
|
|
This module defines the test case to be used by
|
|
tests that require setting up a connection.
|
|
|
|
Such tests rely on `Phoenix.ConnTest` and also
|
|
import other functionality to make it easier
|
|
to build common data structures and query the data layer.
|
|
|
|
Finally, if the test case interacts with the database,
|
|
we enable the SQL sandbox, so changes done to the database
|
|
are reverted at the end of every test. If you are using
|
|
PostgreSQL, you can even run database tests asynchronously
|
|
by setting `use ToweropsWeb.ConnCase, async: true`, although
|
|
this option is not recommended for other databases.
|
|
"""
|
|
|
|
use ExUnit.CaseTemplate
|
|
|
|
alias Towerops.Accounts.Scope
|
|
|
|
using do
|
|
quote do
|
|
use ToweropsWeb, :verified_routes
|
|
|
|
import Phoenix.ConnTest
|
|
import Plug.Conn
|
|
import ToweropsWeb.ConnCase
|
|
import ToweropsWeb.LiveViewTestHelpers
|
|
# The default endpoint for testing
|
|
@endpoint ToweropsWeb.Endpoint
|
|
end
|
|
end
|
|
|
|
setup tags do
|
|
Towerops.DataCase.setup_sandbox(tags)
|
|
{:ok, conn: Phoenix.ConnTest.build_conn()}
|
|
end
|
|
|
|
@doc """
|
|
Setup helper that registers and logs in users.
|
|
|
|
setup :register_and_log_in_user
|
|
|
|
It stores an updated connection and a registered user in the
|
|
test context.
|
|
"""
|
|
def register_and_log_in_user(%{conn: conn} = context) do
|
|
user = Towerops.AccountsFixtures.user_fixture(enable_totp: true)
|
|
scope = Scope.for_user(user)
|
|
|
|
opts =
|
|
context
|
|
|> Map.take([:token_authenticated_at])
|
|
|> Enum.to_list()
|
|
|
|
%{conn: log_in_user(conn, user, opts), user: user, scope: scope}
|
|
end
|
|
|
|
@doc """
|
|
Registers and logs in a user with sudo mode enabled.
|
|
|
|
It stores an updated connection and a registered user in the
|
|
test context.
|
|
"""
|
|
def register_and_log_in_user_with_sudo(%{conn: conn} = context) do
|
|
user = Towerops.AccountsFixtures.user_fixture(enable_totp: true)
|
|
{:ok, user} = Towerops.Accounts.grant_sudo_mode(user)
|
|
scope = Scope.for_user(user)
|
|
|
|
opts =
|
|
context
|
|
|> Map.take([:token_authenticated_at])
|
|
|> Enum.to_list()
|
|
|
|
%{conn: log_in_user(conn, user, opts), user: user, scope: scope}
|
|
end
|
|
|
|
@doc """
|
|
Logs the given `user` into the `conn`.
|
|
|
|
It returns an updated `conn`.
|
|
"""
|
|
def log_in_user(conn, user, opts \\ []) do
|
|
token = Towerops.Accounts.generate_user_session_token(user)
|
|
|
|
maybe_set_token_authenticated_at(token, opts[:token_authenticated_at])
|
|
|
|
conn
|
|
|> Phoenix.ConnTest.init_test_session(%{})
|
|
|> Plug.Conn.put_session(:user_token, token)
|
|
end
|
|
|
|
defp maybe_set_token_authenticated_at(_token, nil), do: nil
|
|
|
|
defp maybe_set_token_authenticated_at(token, authenticated_at) do
|
|
Towerops.AccountsFixtures.override_token_authenticated_at(token, authenticated_at)
|
|
end
|
|
end
|