towerops/test/towerops_web/live/admin/audit_live/index_test.exs
Graham McIntire aa9ed52bff
feat: add critical network switch sensor support (HP Comware, Dell PowerConnect, Dell SONiC)
Implemented top 3 critical network switch sensor gaps identified in Phase 3 analysis.
Restores fundamental temperature monitoring for common enterprise switch platforms.

Files Changed:
- priv/profiles/os_discovery/comware.yaml (enhanced)
  Added HP Comware chassis temperature monitoring via HH3C-ENTITY-EXT-MIB
  OID: 1.3.6.1.4.1.25506.2.6.1.1.1.1.12 (hh3cEntityExtTemperature)
  Uses entPhysicalName for sensor descriptions
  Gap: CRITICAL (broke fundamental monitoring) → RESOLVED
  Parity: 40% → 60%

- priv/profiles/os_discovery/powerconnect.yaml (enhanced)
  Added Dell PowerConnect/DNOS CPU temperature monitoring
  OID: 1.3.6.1.4.1.674.10895.5000.2.6132.1.1.43.1.8.1.5
  MIB: FASTPATH-BOXSERVICES-PRIVATE-MIB
  Gap: CRITICAL (no sensors) → RESOLVED
  Parity: 0% → 80%

- priv/profiles/os_discovery/dell-sonic.yaml (new)
  Created comprehensive Dell SONiC sensor profile
  MIB: NETGEAR-BOXSERVICES-PRIVATE-MIB (Quanta-based)
  Sensors:
    - Temperature: boxServicesTempSensorState (OID .1.3.6.1.4.1.4413.1.1.43.1.8.1.4)
    - Fan Speed: boxServicesFanSpeed (OID .1.3.6.1.4.1.4413.1.1.43.1.6.1.4)
    - PSU State: boxServicesPowSupplyItemState (OID .1.3.6.1.4.1.4413.1.1.43.1.7.1.3)
      States: other, notpresent, operational, failed, powering, nopower,
              notpowering, incompatible
  Gap: CRITICAL (OS detected, no sensors) → RESOLVED
  Parity: 0% → 95%

- test/towerops_web/plugs/brute_force_protection_test.exs (fixed)
  Fixed Credo warning: replaced length/1 with empty list comparison

- CHANGELOG.txt (updated)
  Documented Phase 3 analysis completion and critical fix implementation

Impact:
- HP Comware: Enables overheating alerts (fundamental monitoring restored)
- Dell PowerConnect: First sensor support for common access switches
- Dell SONiC: Complete hardware monitoring for modern data center platform

Business Value:
- Resolves production blockers for customers with HP Comware switches
- Adds support for very common Dell enterprise access switches
- Enables monitoring for Dell's modern SONiC-based data center switches

Next Steps: Remaining Tier 1 switches (Dell Force10 FTOS), then Tier 2
(optical transceiver monitoring for ProCurve/Comware).

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-11 17:36:45 -06:00

182 lines
4.8 KiB
Elixir

defmodule ToweropsWeb.Admin.AuditLive.IndexTest do
use ToweropsWeb.ConnCase, async: true
import Phoenix.LiveViewTest
alias Towerops.Admin
setup do
user = Towerops.AccountsFixtures.user_fixture()
user = user |> Ecto.Changeset.change(%{is_superuser: true}) |> Towerops.Repo.update!()
{:ok, organization} = Towerops.Organizations.create_organization(%{name: "Test Org"}, user.id)
token = Towerops.Accounts.generate_user_session_token(user)
conn =
build_conn()
|> Phoenix.ConnTest.init_test_session(%{})
|> Plug.Conn.put_session(:user_token, token)
%{conn: conn, user: user, organization: organization}
end
describe "mount" do
test "renders audit log page for superuser", %{conn: conn} do
{:ok, _view, html} = live(conn, ~p"/admin/audit")
assert html =~ "Audit Logs"
end
test "redirects non-superuser to /orgs" do
regular_user = Towerops.AccountsFixtures.user_fixture()
token = Towerops.Accounts.generate_user_session_token(regular_user)
conn =
build_conn()
|> Phoenix.ConnTest.init_test_session(%{})
|> Plug.Conn.put_session(:user_token, token)
assert {:error, {:redirect, %{to: "/orgs"}}} = live(conn, ~p"/admin/audit")
end
test "shows empty state when no audit logs exist", %{conn: conn} do
{:ok, _view, html} = live(conn, ~p"/admin/audit")
assert html =~ "No audit logs found"
end
test "displays audit logs when they exist", %{conn: conn, user: user} do
{:ok, _log} =
Admin.create_audit_log(%{
action: "impersonate_start",
superuser_id: user.id
})
{:ok, _view, html} = live(conn, ~p"/admin/audit")
assert html =~ "Impersonate start"
assert html =~ user.email
end
end
describe "search" do
setup %{user: user} do
target_user = Towerops.AccountsFixtures.user_fixture()
{:ok, _log1} =
Admin.create_audit_log(%{
action: "impersonate_start",
superuser_id: user.id,
target_user_id: target_user.id
})
{:ok, _log2} =
Admin.create_audit_log(%{
action: "user_delete",
superuser_id: user.id,
metadata: %{email: "deleted@example.com"}
})
%{target_user: target_user}
end
test "filters audit logs by action", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/admin/audit")
html =
view
|> form("form[phx-submit=search]", %{"action" => "impersonate_start"})
|> render_submit()
assert html =~ "Impersonate start"
refute html =~ "User delete"
end
test "filters audit logs by email", %{conn: conn, user: user} do
{:ok, view, _html} = live(conn, ~p"/admin/audit")
html =
view
|> form("form[phx-submit=search]", %{"email" => user.email})
|> render_submit()
assert html =~ user.email
end
end
describe "clear_filters" do
test "resets all search filters", %{conn: conn, user: user} do
{:ok, _log} =
Admin.create_audit_log(%{
action: "impersonate_start",
superuser_id: user.id
})
{:ok, _log2} =
Admin.create_audit_log(%{
action: "user_delete",
superuser_id: user.id
})
{:ok, view, _html} = live(conn, ~p"/admin/audit")
# First, apply a filter
view
|> form("form[phx-submit=search]", %{"action" => "impersonate_start"})
|> render_submit()
# Then clear filters
html = render_click(view, "clear_filters")
# Both logs should be visible again
assert html =~ "Impersonate start"
assert html =~ "User delete"
end
end
describe "pagination" do
test "navigates to next page", %{conn: conn, user: user} do
# Create more than 50 audit logs (the per_page default)
for _i <- 1..51 do
{:ok, _log} =
Admin.create_audit_log(%{
action: "device_created",
superuser_id: user.id
})
end
{:ok, view, html} = live(conn, ~p"/admin/audit")
assert html =~ "Page 1"
html = render_click(view, "next_page")
assert html =~ "Page 2"
end
test "navigates to previous page", %{conn: conn, user: user} do
for _i <- 1..51 do
{:ok, _log} =
Admin.create_audit_log(%{
action: "device_created",
superuser_id: user.id
})
end
{:ok, view, _html} = live(conn, ~p"/admin/audit")
render_click(view, "next_page")
html = render_click(view, "prev_page")
assert html =~ "Page 1"
end
test "does not go below page 1", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/admin/audit")
html = render_click(view, "prev_page")
assert html =~ "Page 1"
end
end
end