Replace expensive length/1 comparisons with direct list comparisons or Enum.empty?/1 checks (13 instances in source code and tests). Add module aliases for Phoenix.HTML.Form and Towerops.Accounts.Scope to reduce nested module references. Changes: - Replace length(list) > 0 with list != [] or refute Enum.empty?(list) - Add Phoenix.HTML.Form alias in CoreComponents - Add Towerops.Accounts.Scope alias in ConnCase test helper This eliminates all credo warnings and software design suggestions.
29 lines
743 B
Elixir
29 lines
743 B
Elixir
defmodule ToweropsWeb.EquipmentLive.Index do
|
|
@moduledoc false
|
|
use ToweropsWeb, :live_view
|
|
|
|
alias Towerops.Equipment
|
|
alias Towerops.Sites
|
|
|
|
@impl true
|
|
def mount(_params, _session, socket) do
|
|
organization = socket.assigns.current_organization
|
|
equipment = Equipment.list_organization_equipment(organization.id)
|
|
sites = Sites.list_organization_sites(organization.id)
|
|
|
|
{:ok,
|
|
socket
|
|
|> assign(:page_title, "Equipment")
|
|
|> assign(:equipment, equipment)
|
|
|> assign(:has_sites, sites != [])}
|
|
end
|
|
|
|
@impl true
|
|
def handle_params(params, _url, socket) do
|
|
{:noreply, apply_action(socket, socket.assigns.live_action, params)}
|
|
end
|
|
|
|
defp apply_action(socket, :index, _params) do
|
|
socket
|
|
end
|
|
end
|