Graham McIntire
9cb4c59638
Changes to eliminate @dialyzer suppressions by fixing underlying causes:
NIF stubs (towerops_native.ex, mib_translator.ex):
- Change stubs to :erlang.nif_error(:nif_not_loaded) (no_return type).
Real NIF replaces stubs at load time; calls to unloaded stubs now fail
loudly instead of returning fake data. Lets dialyzer trust @spec.
- Remove @dialyzer :nowarn_function on three NIFs and on translate/1.
Discovery sync_* functions (snmp/discovery.ex, channels/agent_channel.ex):
- agent_channel passes %{device_id: _, interfaces: _} and %{id: _} maps
into Discovery.sync_ip_addresses/sync_processors/sync_storage, which
@spec'd only %Device{}. Add narrow map-type unions (ip_sync_device,
snmp_device_ref) reflecting what the functions actually access.
- Remove @dialyzer :nowarn_function on three agent_channel helpers.
remote_ip.ex — real bug caught and fixed:
- `:ranch.get_addr(socket.transport_pid)` was always raising since
Bandit uses ThousandIsland, not Ranch; the rescue _ -> nil silently
returned nil every time. Switched to Phoenix's documented
:peer_data connect_info (already enabled in endpoint.ex) via
socket.assigns; remote IP now actually works.
- Remove remote_ip.ex entry from .dialyzer_ignore.exs.
Accounts / Organizations (Ecto.Multi opacity):
- Add @specs to Multi-building helpers, refactor into pipe chains.
- 6 @dialyzer :nowarn_function → 0, but 7 :no_opaque remain. Root
cause is upstream: Ecto.Multi.new/0 returns a struct with a literal
%MapSet{} whose @opaque internal representation trips dialyzer on
every subsequent Multi.* call. Unfixable without an Ecto patch or
bypassing Multi entirely. Comments document the specific upstream
issue rather than a vague "Ecto.Multi opacity" claim.
Devices.ex:
- Adding @specs made it worse (call_without_opaque → contract_with_
opaque); inlining the Multi didn't help either — same MapSet root
cause. Suppression kept with a sharper comment.
38 lines
1.1 KiB
Elixir
38 lines
1.1 KiB
Elixir
defmodule ToweropsWeb.RemoteIpTest do
|
|
use ToweropsWeb.ConnCase, async: true
|
|
|
|
alias ToweropsWeb.RemoteIp
|
|
|
|
test "extracts the first forwarded IP from conn headers", %{conn: conn} do
|
|
conn =
|
|
conn
|
|
|> put_req_header("x-forwarded-for", "203.0.113.10, 10.0.0.1")
|
|
|> put_req_header("x-real-ip", "198.51.100.1")
|
|
|
|
assert RemoteIp.from_conn(conn) == "203.0.113.10"
|
|
end
|
|
|
|
test "formats IPv6 addresses in uppercase hex" do
|
|
assert RemoteIp.format({8193, 3512, 0, 0, 0, 0, 0, 1}) == "2001:DB8:0:0:0:0:0:1"
|
|
end
|
|
|
|
describe "from_socket/1" do
|
|
test "returns formatted IP from peer_data in assigns" do
|
|
socket = %Phoenix.Socket{
|
|
assigns: %{peer_data: %{address: {192, 168, 1, 42}, port: 12_345}}
|
|
}
|
|
|
|
assert RemoteIp.from_socket(socket) == "192.168.1.42"
|
|
end
|
|
|
|
test "returns nil when peer_data is missing" do
|
|
socket = %Phoenix.Socket{assigns: %{}}
|
|
assert RemoteIp.from_socket(socket) == nil
|
|
end
|
|
|
|
test "returns nil when peer_data has no address tuple" do
|
|
socket = %Phoenix.Socket{assigns: %{peer_data: %{}}}
|
|
assert RemoteIp.from_socket(socket) == nil
|
|
end
|
|
end
|
|
end
|