mayor
0c77dd84e7
Adds @spec annotations to all Oban worker perform/1 functions to improve
static analysis and documentation. Return types are specific to each worker's
actual behavior:
Workers returning 🆗
- BackupSummaryWorker
- BackupTimeoutWorker
- DeviceMonitorWorker
- DevicePollerWorker
- JobHealthCheckWorker
- NeighborCleanupWorker
Workers with complex returns:
- DiscoveryWorker: :ok | :discard
- FirmwareVersionFetcherWorker: :ok | {:error, term()}
- LoginHistoryCleanupWorker: {:ok, %{deleted: non_neg_integer(), anonymized_deleted: non_neg_integer()}}
- MikrotikBackupWorker: :ok | {:error, String.t()}
- SessionCleanupWorker: {:ok, %{sessions_deleted: non_neg_integer()}}
Analysis found that none of these workers have complex job parameters that
would benefit from embedded schemas - all use either no parameters or simple
device_id strings passed in job args.
StaleAgentWorker already had a typespec on find_stale_agents/0 from previous work.
All 98 worker tests passing after changes.
18 lines
543 B
Elixir
18 lines
543 B
Elixir
defmodule Towerops.Workers.SessionCleanupWorker do
|
|
@moduledoc """
|
|
Oban worker for cleaning up expired browser sessions.
|
|
|
|
Deletes browser sessions that have passed their expiration timestamp.
|
|
This worker runs daily at 3 AM via Oban cron.
|
|
"""
|
|
use Oban.Worker, queue: :maintenance
|
|
|
|
alias Towerops.Accounts
|
|
|
|
@impl Oban.Worker
|
|
@spec perform(Oban.Job.t()) :: {:ok, %{sessions_deleted: non_neg_integer()}}
|
|
def perform(_job) do
|
|
count = Accounts.delete_expired_browser_sessions()
|
|
{:ok, %{sessions_deleted: count}}
|
|
end
|
|
end
|