towerops/test/towerops_web/live/org/settings_live_test.exs
Graham McIntire 9094f42098
feat: add Dell PowerVault storage array text-based sensor parsing
Implement vendor module for Dell PowerVault storage arrays that parse
text-based sensor messages from FCMGMT-MIB instead of structured tables.

Created vendor post-processing module:
- lib/towerops/snmp/profiles/vendors/powervault.ex
  * Walks FCMGMT-MIB::connUnitSensorMessage (OID 1.3.6.1.3.94.1.8.1.6)
  * Parses text format "Sensor Name: Value Unit" with regex matching
  * Temperature: "25 C 77.0F" → 25°C (extracts Celsius)
  * Voltage: "12.1V" → 12.1V
  * Current: "0.5A" → 0.5A
  * Battery Charge: "95%" → 95% (with threshold limits)

Integrated into discovery pipeline:
- lib/towerops/snmp/profiles/dynamic.ex
  * Added "dell-powervault" case to apply_vendor_post_processing/3
  * Follows Arista vendor module pattern

Comprehensive test coverage:
- test/towerops/snmp/profiles/vendors/powervault_test.exs
  * 21 tests covering all sensor types and edge cases
  * Tests multi-sensor parsing, error handling, format validation
  * All tests passing with Mox SNMP adapter mocking

Technical notes:
- Client.walk returns map {oid => value}, converted to list for parsing
- Sensor indices: powervault_{type}.{oid_index} for uniqueness
- post_process_sensors/2 combines with existing sensors from base discovery

Result: Dell PowerVault arrays now supported with text message parsing.
Gap: CRITICAL (no sensors) → RESOLVED. Parity: 0% → 85%.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-12 08:38:30 -06:00

191 lines
5.7 KiB
Elixir

defmodule ToweropsWeb.Org.SettingsLiveTest do
use ToweropsWeb.ConnCase
import Phoenix.LiveViewTest
import Towerops.AccountsFixtures
import Towerops.AgentsFixtures
import Towerops.OrganizationsFixtures
setup do
user = user_fixture()
organization = organization_fixture(user.id)
%{user: user, organization: organization}
end
describe "Settings page" do
test "displays organization settings form", %{conn: conn, user: user, organization: org} do
{:ok, _view, html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
assert html =~ "Organization Settings"
assert html =~ "Organization Name"
assert html =~ org.name
end
test "shows no agents message when no agents exist", %{
conn: conn,
user: user,
organization: org
} do
{:ok, _view, html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
assert html =~ "No agents configured yet"
assert html =~ "Create an agent"
end
test "shows default agent dropdown when agents exist", %{
conn: conn,
user: user,
organization: org
} do
{:ok, agent_token, _token} = agent_token_fixture(org.id, "Test Agent")
{:ok, _view, html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
assert html =~ "Default Remote Agent"
assert html =~ agent_token.name
assert html =~ "No default agent - cloud polling"
end
test "updates organization name successfully", %{conn: conn, user: user, organization: org} do
{:ok, view, _html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
html =
view
|> form("#organization-form", organization: %{name: "Updated Name"})
|> render_submit()
assert html =~ "Settings saved successfully"
# Verify the organization was actually updated
updated_org = Towerops.Organizations.get_organization!(org.id)
assert updated_org.name == "Updated Name"
end
test "sets default agent for organization", %{conn: conn, user: user, organization: org} do
{:ok, agent_token, _token} = agent_token_fixture(org.id, "Test Agent")
{:ok, view, _html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
html =
view
|> form("#organization-form", organization: %{default_agent_token_id: agent_token.id})
|> render_submit()
assert html =~ "Settings saved successfully"
# Verify the default agent was set
updated_org = Towerops.Organizations.get_organization!(org.id)
assert updated_org.default_agent_token_id == agent_token.id
end
test "clears default agent for organization", %{conn: conn, user: user, organization: org} do
{:ok, agent_token, _token} = agent_token_fixture(org.id, "Test Agent")
# First set a default agent
{:ok, org} =
Towerops.Organizations.update_organization(org, %{
default_agent_token_id: agent_token.id
})
{:ok, view, _html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
# Now clear it
html =
view
|> form("#organization-form", organization: %{default_agent_token_id: ""})
|> render_submit()
assert html =~ "Settings saved successfully"
# Verify the default agent was cleared
updated_org = Towerops.Organizations.get_organization!(org.id)
assert updated_org.default_agent_token_id == nil
end
test "validates organization name", %{conn: conn, user: user, organization: org} do
{:ok, view, _html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
# Form requires name field - submitting empty should fail
html =
view
|> form("#organization-form", organization: %{name: ""})
|> render_submit()
# The form should still be displayed (not redirected)
assert html =~ "Organization Name"
end
test "requires authentication", %{conn: conn, organization: org} do
assert {:error, {:redirect, %{to: "/users/log-in"}}} =
live(conn, ~p"/orgs/#{org.slug}/settings")
end
test "validates organization name on change", %{conn: conn, user: user, organization: org} do
{:ok, view, _html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
html =
view
|> form("#organization-form", organization: %{name: ""})
|> render_change()
assert html =~ "Organization Name"
end
test "applies SNMP config to all devices", %{conn: conn, user: user, organization: org} do
{:ok, view, _html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
html = render_click(view, "apply_snmp_to_all")
assert html =~ "Applied SNMP configuration to"
end
test "applies default agent to all devices", %{conn: conn, user: user, organization: org} do
{:ok, view, _html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
html = render_click(view, "apply_agent_to_all")
assert html =~ "Applied default agent to"
end
test "toggles default organization", %{conn: conn, user: user, organization: org} do
{:ok, view, _html} =
conn
|> log_in_user(user)
|> live(~p"/orgs/#{org.slug}/settings")
html = render_click(view, "toggle_default_org")
# Either sets as default or shows already default message
assert html =~ "default organization" or html =~ "already your default"
end
end
end