Graham McIntire
a8e43b38d6
Replace sequential multi-GET with true batched SNMP GET support.
Previously, Client.get_multiple/2 sent N individual SNMP GET PDUs
for N OIDs. Now sends a single PDU with multiple varbinds, reducing
network round-trips by ~80% for multi-OID operations.
Implementation:
- Add get_multiple/3 callback to SnmpBehaviour
- Implement batched GET in Manager using PDU.build_get_request_multi/2
- Update Client.get_multiple/2 to use batched GET with sequential fallback
- Return map format %{oid => {type, value}} for batched results
- Convert to ordered list for backward compatibility
- Handle SNMP exceptions (noSuchObject, noSuchInstance) in result map
Testing:
- Update all test mocks to use get_multiple expectations
- Add individual get stubs for categorize_device_speed and optional fields
- 2249/2251 tests passing (99.87%)
This addresses F1 from LibreNMS feature parity analysis:
"Replace sequential multi-get with batched GET support."
Impact:
- Discovery system info (6 OIDs): 1 SNMP request instead of 6
- Storage polling (3 OIDs/entry): 1 request per entry instead of 3
- Network round-trips reduced by ~80% for all get_multiple operations
Reviewed-on: graham/towerops-web#183
28 lines
577 B
Elixir
28 lines
577 B
Elixir
defmodule Towerops.Mocks.SnmpKitMock do
|
|
@moduledoc """
|
|
Mock for SnmpKit to be used in tests.
|
|
"""
|
|
|
|
def get(_target, _oid, _opts) do
|
|
{:ok, {:octet_string, "Mock Value"}}
|
|
end
|
|
|
|
def walk(_target, _oid, _opts) do
|
|
# Return empty list to simulate no results
|
|
{:ok, []}
|
|
end
|
|
|
|
def get_bulk(_target, _oid, _opts) do
|
|
{:ok, []}
|
|
end
|
|
|
|
def get_multiple(_target, oids, _opts) do
|
|
# Return map of OID to mock typed values
|
|
result_map =
|
|
Map.new(oids, fn oid ->
|
|
{oid, {:octet_string, "Mock Value"}}
|
|
end)
|
|
|
|
{:ok, result_map}
|
|
end
|
|
end
|