Graham McIntire
b3fae05693
Implemented all critical and nice-to-have Arista sensor improvements identified
in LibreNMS parity audit. Upgrades Arista EOS support from 85% to 100% parity.
Files Changed:
- lib/towerops/snmp/profiles/vendors/arista.ex (enhanced)
Added 4 major enhancements:
1. DOM power conversion (watts→dBm): Detects optical power sensors via regex,
converts using formula dBm = 10*log10(watts*1000), preserves original value
in metadata
2. Arista threshold discovery: Walks ARISTA-ENTITY-SENSOR-MIB threshold table
(OID 1.3.6.1.4.1.30065.3.3.1.1.1), applies 4 threshold types (low_critical,
low_warn, high_warn, high_critical), converts thresholds to dBm for optical
sensors
3. Smart grouping: Organizes sensors by SFPs, PSUs, Platform (chipsets), Power
Connectors, System for better UX
4. Description cleanup: Removes redundant "sensor" text, simplifies PSU naming,
cleans whitespace
- lib/towerops/snmp/profiles/dynamic.ex (integration)
Added apply_vendor_post_processing/3 to call Arista enhancements after sensor
discovery. Applies to both arista_eos and arista-mos profiles.
- test/towerops/snmp/profiles/vendors/arista_test.exs (comprehensive tests)
Added 23 new tests covering:
- DOM conversion (6 tests): Rx/Tx power, Xcvr power, non-DOM sensors, edge cases
- Threshold discovery (4 tests): Basic thresholds, dBm conversion, no thresholds,
SNMP failures
- Smart grouping (6 tests): SFPs, Xcvr, PSUs, power connectors, platform, system
- Description cleanup (5 tests): Trailing sensor, duplicate Sensor strings, PSU
naming, hotspot, whitespace
- End-to-end post-processing (1 test): All enhancements in correct order
All tests passing (30/30 in arista_test.exs, 6367/6367 total).
Result: Arista EOS support upgraded from 85% to 100% LibreNMS parity. All critical
gaps closed: optical power now displayed correctly in dBm, alerting enabled via
thresholds, sensors organized for better UX, descriptions cleaned up.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
26 lines
835 B
Elixir
26 lines
835 B
Elixir
defmodule ToweropsWeb.LiveViewTestHelpers do
|
|
@moduledoc """
|
|
Helpers for LiveView tests using data-testid attributes.
|
|
|
|
Provides `assert_has/2,3` and `refute_has/2` for structural assertions
|
|
that are resilient to text/wording changes in templates.
|
|
"""
|
|
|
|
import ExUnit.Assertions
|
|
import Phoenix.LiveViewTest
|
|
|
|
@doc "Assert an element with the given data-testid exists"
|
|
def assert_has(view, testid) do
|
|
assert has_element?(view, "[data-testid='#{testid}']")
|
|
end
|
|
|
|
@doc "Assert an element with the given data-testid exists and contains text"
|
|
def assert_has(view, testid, text) do
|
|
assert has_element?(view, "[data-testid='#{testid}']", text)
|
|
end
|
|
|
|
@doc "Refute an element with the given data-testid exists"
|
|
def refute_has(view, testid) do
|
|
refute has_element?(view, "[data-testid='#{testid}']")
|
|
end
|
|
end
|