towerops/test/towerops_web/controllers
Graham McIntire 9ff9c4ddc8
fix: address UserSudoController critical issues
Critical fixes:
- Renamed controller actions to follow Phoenix conventions (verify→new, create→verify)
- Added sudo mode check in GET action using last_sudo_at timestamp
- Added TOTP enrollment check in GET action with redirect
- Changed default return path from /orgs to /users/settings
- Updated route paths from /users/sudo/verify to /users/sudo-verify (dash separator)
- Added success flash message "Identity verified."

Implementation details:
- new/2 (GET): Checks recently_verified_sudo?/1 helper that examines last_sudo_at
  instead of authenticated_at to distinguish sudo verification from regular login
- verify/2 (POST): Adds info flash and defaults to /users/settings
- recently_verified_sudo?/1: Private helper checking last_sudo_at within 10 minutes
- Updated all routes, templates, and tests to use new paths and action names

Tests:
- Added tests for already-in-sudo-mode redirect behavior
- Added test for TOTP enrollment requirement
- Updated all test assertions for new route paths and success messages
- All 15 controller tests passing
- Full test suite passing (4076 tests, 0 failures)
2026-02-01 14:45:05 -06:00
..
api remove passkeys for now 2026-01-31 09:50:35 -06:00
error_html_test.exs Add test for ErrorHTML fallback render function 2026-01-13 07:48:23 -06:00
error_json_test.exs init 2025-12-21 11:10:43 -06:00
health_controller_test.exs bring in snmpkit 2026-01-23 12:52:17 -06:00
page_controller_test.exs add marketing site 2026-01-06 14:34:48 -06:00
page_html_test.exs Add test for PageHTML home template 2026-01-13 07:49:25 -06:00
user_session_controller_test.exs fix TOTP enrollment with recovery codes 2026-01-31 14:54:44 -06:00
user_session_html_test.exs use password for user regi 2026-01-21 09:13:08 -06:00
user_settings_controller_test.exs Convert User Settings from controller to LiveView 2026-01-15 16:29:50 -06:00
user_settings_html_test.exs remove passkeys for now 2026-01-31 09:50:35 -06:00
user_sudo_controller_test.exs fix: address UserSudoController critical issues 2026-02-01 14:45:05 -06:00