Graham McIntire
a3cd43d2c2
Replace expensive length/1 comparisons with direct list comparisons or Enum.empty?/1 checks (13 instances in source code and tests). Add module aliases for Phoenix.HTML.Form and Towerops.Accounts.Scope to reduce nested module references. Changes: - Replace length(list) > 0 with list != [] or refute Enum.empty?(list) - Add Phoenix.HTML.Form alias in CoreComponents - Add Towerops.Accounts.Scope alias in ConnCase test helper This eliminates all credo warnings and software design suggestions.
144 lines
4.1 KiB
Elixir
144 lines
4.1 KiB
Elixir
defmodule Towerops.Integration.SnmpIntegrationTest do
|
|
@moduledoc """
|
|
Integration tests for SNMP functionality against real devices.
|
|
|
|
These tests are excluded from the main test suite by default.
|
|
To run them: mix test --only integration
|
|
|
|
Requirements:
|
|
- Network access to test devices
|
|
- SNMP-enabled equipment (configure IP/community below)
|
|
"""
|
|
use ExUnit.Case, async: false
|
|
|
|
alias Towerops.Monitoring.EquipmentMonitor
|
|
alias Towerops.Snmp.Client
|
|
alias Towerops.Snmp.Poller
|
|
|
|
@moduletag :integration
|
|
|
|
# Configure your test device here
|
|
@test_device_opts [
|
|
ip: "10.0.19.254",
|
|
community: "kdyyJrT0Mm",
|
|
version: "2c",
|
|
port: 161,
|
|
timeout: 5000
|
|
]
|
|
|
|
describe "SNMP Client against real device" do
|
|
test "can perform GET operation" do
|
|
case Client.get(@test_device_opts, "1.3.6.1.2.1.1.3.0") do
|
|
{:ok, uptime} ->
|
|
assert is_integer(uptime)
|
|
|
|
{:error, reason} ->
|
|
flunk("SNMP GET failed: #{inspect(reason)}")
|
|
end
|
|
end
|
|
|
|
test "can perform WALK operation" do
|
|
case Client.walk(@test_device_opts, "1.3.6.1.2.1.2.2.1.1") do
|
|
{:ok, results} ->
|
|
assert is_map(results)
|
|
assert map_size(results) > 0
|
|
|
|
{:error, reason} ->
|
|
flunk("SNMP WALK failed: #{inspect(reason)}")
|
|
end
|
|
end
|
|
|
|
test "can test connection" do
|
|
case Client.test_connection(@test_device_opts) do
|
|
{:ok, _message} ->
|
|
assert true
|
|
|
|
{:error, reason} ->
|
|
flunk("Connection test failed: #{inspect(reason)}")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "SNMP Poller against real device" do
|
|
test "can check device reachability" do
|
|
case Poller.check_device(@test_device_opts) do
|
|
{:ok, response_time} ->
|
|
assert is_float(response_time)
|
|
assert response_time > 0
|
|
|
|
{:error, reason} ->
|
|
flunk("Poller check failed: #{inspect(reason)}")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "Discovery against real device" do
|
|
@tag :full_discovery
|
|
test "can discover MikroTik device" do
|
|
alias Towerops.Snmp.Profiles.Mikrotik
|
|
|
|
# Discover system info
|
|
{:ok, system_info} = Mikrotik.discover_system_info(@test_device_opts)
|
|
assert system_info.sys_descr =~ "RouterOS"
|
|
|
|
# Discover interfaces
|
|
{:ok, interfaces} = Mikrotik.discover_interfaces(@test_device_opts)
|
|
refute Enum.empty?(interfaces)
|
|
|
|
# Discover sensors
|
|
{:ok, sensors} = Mikrotik.discover_sensors(@test_device_opts)
|
|
refute Enum.empty?(sensors)
|
|
|
|
# Identify device
|
|
device_info = Mikrotik.identify_device(system_info)
|
|
assert device_info.manufacturer == "MikroTik"
|
|
assert device_info.model
|
|
end
|
|
end
|
|
|
|
describe "Equipment Monitor with SNMP" do
|
|
test "creates SNMP-specific alert messages when device goes down" do
|
|
# This test makes real SNMP calls to an unreachable IP to verify timeout handling
|
|
import Towerops.AccountsFixtures
|
|
|
|
user = user_fixture()
|
|
{:ok, organization} = Towerops.Organizations.create_organization(%{name: "Test Org"}, user.id)
|
|
|
|
{:ok, site} =
|
|
Towerops.Sites.create_site(%{
|
|
name: "Test Site",
|
|
organization_id: organization.id
|
|
})
|
|
|
|
{:ok, equipment} =
|
|
Towerops.Equipment.create_equipment(%{
|
|
name: "SNMP Router",
|
|
ip_address: "192.0.2.1",
|
|
site_id: site.id,
|
|
snmp_enabled: true,
|
|
snmp_version: "2c",
|
|
snmp_community: "public",
|
|
snmp_port: 161,
|
|
monitoring_enabled: true
|
|
})
|
|
|
|
# Set to up first so status change will trigger
|
|
{:ok, equipment} = Towerops.Equipment.update_equipment_status(equipment, :up)
|
|
|
|
{:ok, state} = EquipmentMonitor.init(equipment.id)
|
|
|
|
# Trigger check - will timeout trying to reach 192.0.2.1
|
|
{:noreply, _state} =
|
|
EquipmentMonitor.handle_info(:check_equipment, state)
|
|
|
|
Process.sleep(200)
|
|
|
|
alerts = Towerops.Alerts.list_equipment_alerts(equipment.id)
|
|
refute Enum.empty?(alerts)
|
|
|
|
alert = hd(alerts)
|
|
assert alert.alert_type == :equipment_down
|
|
assert String.contains?(alert.message, "SNMP")
|
|
end
|
|
end
|
|
end
|