towerops/test/towerops_web/live/admin/audit_live/index_test.exs
Graham McIntire aa7fc830e5 test: refactor LiveView tests to use HTML-aware element/form helpers
Apply patterns from testingliveview.com — replace render_click/submit/change
event-name calls with element/form-targeted equivalents that validate the
actual DOM wiring, not just handler logic. Adds stable test selectors
(id="...") to interactive elements across 10 LiveView templates.

Surfaces (and fixes) several real issues that the bypass-style tests masked:
- Removes dead regenerate_token handler in agent_live/index.ex (no UI ever
  triggered it) and its corresponding test.
- Removes dead refresh_topology test in network_map_live_test (event was
  referenced only in the test — no handler, no button, no JS anywhere).
- Corrects "shows notification tab with add device modal" — modal lives on
  the security tab; original test mounted ?tab=notifications and only
  worked because direct event calls bypassed tab gating.
- Corrects form input shape mismatches in agent_live/index_test that the
  handler's defensive case clauses had been masking.
- Expands setup data for org/settings_live_test (snmp_community,
  default_agent_token_id, multi-org membership) so the gated buttons
  actually render.

11 direct render_click/submit/change calls remain — all intentional,
documented server-side guard tests (tampered POSTs, race conditions,
defensive idempotent handlers).

Full LiveView test suite: 1300 tests, 0 failures.
2026-04-29 11:14:20 -05:00

193 lines
5.4 KiB
Elixir

defmodule ToweropsWeb.Admin.AuditLive.IndexTest do
use ToweropsWeb.ConnCase, async: true
import Phoenix.LiveViewTest
alias Towerops.Admin
setup do
user = Towerops.AccountsFixtures.user_fixture(enable_totp: true)
user = user |> Ecto.Changeset.change(%{is_superuser: true}) |> Towerops.Repo.update!()
{:ok, organization} = Towerops.Organizations.create_organization(%{name: "Test Org"}, user.id)
token = Towerops.Accounts.generate_user_session_token(user)
conn =
build_conn()
|> Phoenix.ConnTest.init_test_session(%{})
|> Plug.Conn.put_session(:user_token, token)
%{conn: conn, user: user, organization: organization}
end
describe "mount" do
test "renders audit log page for superuser", %{conn: conn} do
{:ok, _view, html} = live(conn, ~p"/admin/audit")
assert html =~ "Audit Logs"
end
test "redirects non-superuser to /orgs" do
regular_user = Towerops.AccountsFixtures.user_fixture()
token = Towerops.Accounts.generate_user_session_token(regular_user)
conn =
build_conn()
|> Phoenix.ConnTest.init_test_session(%{})
|> Plug.Conn.put_session(:user_token, token)
assert {:error, {:redirect, %{to: "/orgs"}}} = live(conn, ~p"/admin/audit")
end
test "shows empty state when no audit logs exist", %{conn: conn} do
{:ok, _view, html} = live(conn, ~p"/admin/audit")
assert html =~ "No audit logs found"
end
test "displays audit logs when they exist", %{conn: conn, user: user} do
{:ok, _log} =
Admin.create_audit_log(%{
action: "impersonate_start",
superuser_id: user.id
})
{:ok, _view, html} = live(conn, ~p"/admin/audit")
assert html =~ "Impersonate start"
assert html =~ user.email
end
end
describe "search" do
setup %{user: user} do
target_user = Towerops.AccountsFixtures.user_fixture()
{:ok, _log1} =
Admin.create_audit_log(%{
action: "impersonate_start",
superuser_id: user.id,
target_user_id: target_user.id
})
{:ok, _log2} =
Admin.create_audit_log(%{
action: "user_delete",
superuser_id: user.id,
metadata: %{email: "deleted@example.com"}
})
%{target_user: target_user}
end
test "filters audit logs by action", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/admin/audit")
html =
view
|> form("form[phx-submit=search]", %{"action" => "impersonate_start"})
|> render_submit()
assert html =~ "Impersonate start"
# The action dropdown always contains "User delete" as an option,
# so check the table body specifically for absence of the log entry
refute has_element?(view, "td span", "User delete")
end
test "filters audit logs by email", %{conn: conn, user: user} do
{:ok, view, _html} = live(conn, ~p"/admin/audit")
html =
view
|> form("form[phx-submit=search]", %{"email" => user.email})
|> render_submit()
assert html =~ user.email
end
end
describe "clear_filters" do
test "resets all search filters", %{conn: conn, user: user} do
{:ok, _log} =
Admin.create_audit_log(%{
action: "impersonate_start",
superuser_id: user.id
})
{:ok, _log2} =
Admin.create_audit_log(%{
action: "user_delete",
superuser_id: user.id
})
{:ok, view, _html} = live(conn, ~p"/admin/audit")
# First, apply a filter
view
|> form("form[phx-submit=search]", %{"action" => "impersonate_start"})
|> render_submit()
# Then clear filters
html = view |> element("#audit-clear-filters") |> render_click()
# Both logs should be visible again
assert html =~ "Impersonate start"
assert html =~ "User delete"
end
end
describe "pagination" do
test "navigates to next page", %{conn: conn, user: user} do
# Create more than 50 audit logs (the per_page default)
for _i <- 1..51 do
{:ok, _log} =
Admin.create_audit_log(%{
action: "device_created",
superuser_id: user.id
})
end
{:ok, view, html} = live(conn, ~p"/admin/audit")
assert html =~ "Page 1"
html = view |> element("#audit-next-page") |> render_click()
assert html =~ "Page 2"
end
test "navigates to previous page", %{conn: conn, user: user} do
for _i <- 1..51 do
{:ok, _log} =
Admin.create_audit_log(%{
action: "device_created",
superuser_id: user.id
})
end
{:ok, view, _html} = live(conn, ~p"/admin/audit")
view |> element("#audit-next-page") |> render_click()
html = view |> element("#audit-prev-page") |> render_click()
assert html =~ "Page 1"
end
test "does not go below page 1", %{conn: conn, user: user} do
# Need at least one log so the pagination UI renders
{:ok, _log} =
Admin.create_audit_log(%{
action: "device_created",
superuser_id: user.id
})
{:ok, view, _html} = live(conn, ~p"/admin/audit")
# The "Previous" button is disabled when @page == 1, so the UI prevents
# navigation. Test the server-side guard against a tampered event.
html = render_click(view, "prev_page")
assert html =~ "Page 1"
end
end
end