towerops/lib/towerops
Graham McIntire 0e2cc6b7ce chore(coverage,types): clean dialyzer + new tests + ETH canopy provider
Dialyzer:
* Add Lidar.Tile @type, narrow several @specs to match success-typing,
  prefix discarded function returns with `_ =`, fix the broken
  File.stream! call in the ms-buildings worker (it was causing dialyzer
  to mark every private fun unreachable), broaden Antenna.spec key
  types from `float()` to `number()` to match catalog int literals.
* Add :geo, :geo_postgis, :db_connection to plt_add_apps so the dep
  PLT actually contains the modules we use.
* Result: 0 unsuppressed dialyzer warnings (was 50+ in project code).

Tree canopy:
* Replace the dead landfire.gov URL with the ETH Zurich Global
  Canopy Height 10 m product. ETH publishes proper COGs with
  overviews on libdrive.ethz.ch — confirmed working with
  /vsicurl/ byte-range reads. The module now picks the 3°×3° tile
  containing the bbox centroid, with both a `:metres` decoder
  (ETH Byte raster, NoData=255) and a `:landfire_evh` decoder for
  operators self-hosting LANDFIRE EVH COGs.
* Re-enable canopy by default now that there's a working source.

Tests (+105 tests, 0 failures):
* CoverageLive Index/Show/Form/Map — empty/loaded/auth states,
  LiveView event handlers, formatters.
* Coverages.Building changeset + helpers.
* Coverages.TreeCanopy provider tile-URL builder and decoders.
* Workers.MsBuildingsImportWorker (full import flow incl. blank
  lines, MultiPolygon, idempotency, hash fallback) — also fixed
  the partial-index ON CONFLICT bug that prevented imports from
  ever working: the unique index has WHERE ms_footprint_id IS
  NOT NULL, so the worker now uses an :unsafe_fragment conflict
  target that includes the predicate.
* GraphQLDocsController smoke test (was 0%).

Coverage rose from 73.19% → 74% with the major project modules I
touched all moved from 0% / <50% to >75%.
2026-05-07 09:11:17 -05:00
..
accounts refactor: split accounts.ex into cohesive submodules 2026-04-30 14:26:30 -05:00
admin fix: comprehensive security audit fixes (#108) 2026-03-22 10:10:27 -05:00
agents chore: migrate agent repo references from GitHub to Codeberg 2026-05-07 07:44:48 -05:00
alerts refactor: address audit recommendations from results.md 2026-04-30 12:33:41 -05:00
api_tokens dialyzer: fix unknown_type warnings (60 → 0) 2026-04-21 09:43:37 -05:00
billing refactor: adopt Towerops.Result helpers in 8 call sites 2026-04-30 14:43:24 -05:00
capacity refactor: convert 6 Gleam modules to idiomatic Elixir with TDD (#196) 2026-03-28 09:52:07 -05:00
cn_maestro tests: disable Req retries in test env to eliminate ~7s-per-test delays 2026-04-24 10:04:52 -05:00
config_changes tests: raise coverage to 70% via helper promotion + new unit/property tests 2026-04-24 09:49:06 -05:00
contexts help update 2026-02-04 17:56:48 -06:00
coverages chore(coverage,types): clean dialyzer + new tests + ETH canopy provider 2026-05-07 09:11:17 -05:00
devices refactor: address audit recommendations from results.md 2026-04-30 12:33:41 -05:00
ecto_types dialyzer: fix remaining 88 warnings — clean dialyzer run 2026-04-21 10:32:42 -05:00
gaiia refactor: extract per-schema Query modules for organization_id filters 2026-04-30 14:26:30 -05:00
geoip remove Mix.env and support ip database import 2026-01-28 13:08:06 -06:00
integrations paperclip/TOW-21-uisp-integration-phase1 (#31) 2026-03-15 17:57:36 -05:00
job_monitoring more tests and fixes 2026-02-07 11:50:18 -06:00
lidar chore(coverage,types): clean dialyzer + new tests + ETH canopy provider 2026-05-07 09:11:17 -05:00
maintenance refactor: extract per-schema Query modules for organization_id filters 2026-04-30 14:26:30 -05:00
mobile_sessions refactor/dry-improvements (#202) 2026-03-28 10:56:34 -05:00
monitoring chore: track SiteQuery and CheckQuery modules 2026-04-30 14:39:58 -05:00
netbox tests: raise coverage to 70% via helper promotion + new unit/property tests 2026-04-24 09:49:06 -05:00
on_call refactor: extract per-schema Query modules for organization_id filters 2026-04-30 14:26:30 -05:00
organizations refactor: extract per-schema Query modules for organization_id filters 2026-04-30 14:26:30 -05:00
pagerduty tests: remove remaining 1s sleeps in slow tests 2026-04-24 10:13:17 -05:00
preseem tests: disable Req retries in test env to eliminate ~7s-per-test delays 2026-04-24 10:04:52 -05:00
profiles fix: use runtime env config in YamlProfiles init (broken in releases) 2026-05-01 16:40:10 -05:00
proto refactor: adopt Towerops.Result helpers in 8 call sites 2026-04-30 14:43:24 -05:00
rate_limit chore: rate_limit rewrite + on-call redesign plan + handoff_notifications_mode 2026-04-28 12:17:29 -05:00
reports fix: make sidebar sticky with header and resolve all credo issues (#32) 2026-03-15 18:19:09 -05:00
security refactor: adopt Towerops.Result helpers in 8 call sites 2026-04-30 14:43:24 -05:00
settings fix/findings-medium-priority (#188) 2026-03-27 12:31:53 -05:00
sites chore: track SiteQuery and CheckQuery modules 2026-04-30 14:39:58 -05:00
snmp refactor: adopt Towerops.Result helpers in 8 call sites 2026-04-30 14:43:24 -05:00
sonar tests: disable Req retries in test env to eliminate ~7s-per-test delays 2026-04-24 10:04:52 -05:00
splynx tests: disable Req retries in test env to eliminate ~7s-per-test delays 2026-04-24 10:04:52 -05:00
status_pages fix: make sidebar sticky with header and resolve all credo issues (#32) 2026-03-15 18:19:09 -05:00
topology refactor: address audit recommendations from results.md 2026-04-30 12:33:41 -05:00
uisp tests: raise coverage to 70% via helper promotion + new unit/property tests 2026-04-24 09:49:06 -05:00
visp fix: humanize raw error strings in integration sync modules 2026-03-12 13:53:28 -05:00
weather tests: raise coverage to 70% via helper promotion + new unit/property tests 2026-04-24 09:49:06 -05:00
workers chore(coverage,types): clean dialyzer + new tests + ETH canopy provider 2026-05-07 09:11:17 -05:00
accounts.ex refactor: split accounts.ex into cohesive submodules 2026-04-30 14:26:30 -05:00
activity_feed.ex reliability-audit-fixes (#181) 2026-03-26 14:10:36 -05:00
admin.ex fix: replace Repo.rollback with proper error handling for Oban compatibility (#201) 2026-03-28 09:11:21 -05:00
agents.ex chore: migrate agent repo references from GitHub to Codeberg 2026-05-07 07:44:48 -05:00
alerts.ex refactor: extract per-schema Query modules for organization_id filters 2026-04-30 14:26:30 -05:00
api_tokens.ex dialyzer: fix remaining 88 warnings — clean dialyzer run 2026-04-21 10:32:42 -05:00
application.ex feat: add /coverage RF prediction feature scaffold 2026-05-06 13:44:14 -05:00
billing.ex fix: infer device role during discovery and handle string price values 2026-03-10 13:25:51 -05:00
capacity.ex done i think (#177) 2026-03-26 10:23:26 -05:00
config_changes.ex tests: raise coverage to 70% via helper promotion + new unit/property tests 2026-04-24 09:49:06 -05:00
coverages.ex chore(coverage,types): clean dialyzer + new tests + ETH canopy provider 2026-05-07 09:11:17 -05:00
dashboard.ex fix/findings-medium-priority (#188) 2026-03-27 12:31:53 -05:00
devices.ex refactor: extract per-schema Query modules for organization_id filters 2026-04-30 14:26:30 -05:00
error_tracker_ignorer.ex fix: apply Oban Pro 1.7 follow-up cleanup + filter transient DB noise 2026-05-01 16:04:05 -05:00
gaiia.ex refactor: extract per-schema Query modules for organization_id filters 2026-04-30 14:26:30 -05:00
geocoding.ex tests: raise coverage to 70% via helper promotion + new unit/property tests 2026-04-24 09:49:06 -05:00
geoip.ex db-performance-migrations (#234) 2026-04-04 14:22:25 -05:00
honeybadger_filter.ex fix: suppress benign shutdown errors during K8s pod rollouts 2026-02-12 12:16:40 -06:00
http.ex tests: disable Req retries in test env to eliminate ~7s-per-test delays 2026-04-24 10:04:52 -05:00
integrations.ex refactor/dry-improvements (#202) 2026-03-28 10:56:34 -05:00
job_monitoring.ex more tests and fixes 2026-02-07 11:50:18 -06:00
lidar.ex chore(coverage,types): clean dialyzer + new tests + ETH canopy provider 2026-05-07 09:11:17 -05:00
log_filter.ex Add comprehensive Dialyzer type specifications 2026-01-17 10:52:02 -06:00
logger_filters.ex fix: suppress benign shutdown errors during K8s pod rollouts 2026-02-12 12:16:40 -06:00
mailer.ex moduledocs 2026-01-17 15:08:49 -06:00
maintenance.ex refactor(maintenance): use MaintenanceWindowQuery in active_windows_base 2026-04-30 14:26:30 -05:00
mobile_sessions.ex fix: replace Repo.rollback with proper error handling for Oban compatibility (#201) 2026-03-28 09:11:21 -05:00
monitoring.ex refactor: route Sites and Monitoring queries through Query modules 2026-04-30 14:32:00 -05:00
numeric.ex refactor: convert 6 Gleam modules to idiomatic Elixir with TDD (#196) 2026-03-28 09:52:07 -05:00
on_call.ex refactor: extract per-schema Query modules for organization_id filters 2026-04-30 14:26:30 -05:00
organizations.ex refactor: adopt Towerops.Result helpers in 8 call sites 2026-04-30 14:43:24 -05:00
postgrex_types.ex feat: add Texas LIDAR DEM catalog with on-demand elevation reads 2026-05-04 13:03:28 -05:00
preseem.ex fix/findings-medium-priority (#188) 2026-03-27 12:31:53 -05:00
profiles.ex fix/findings-medium-priority (#188) 2026-03-27 12:31:53 -05:00
query_helpers.ex refactor: convert 6 Gleam modules to idiomatic Elixir with TDD (#196) 2026-03-28 09:52:07 -05:00
rate_limit.ex feat(on_call): PagerDuty-style escalation policy redesign + dialyzer fix 2026-04-28 12:36:41 -05:00
redis_health_check.ex fix: remove to_charlist conversion for Redix host option 2026-01-24 17:49:57 -06:00
release.ex fix dialyzer things 2026-01-03 12:56:40 -06:00
repo.ex moduledocs 2026-01-17 15:08:49 -06:00
reports.ex tests: raise coverage to 70% via helper promotion + new unit/property tests 2026-04-24 09:49:06 -05:00
result.ex refactor: convert 6 Gleam modules to idiomatic Elixir with TDD (#196) 2026-03-28 09:52:07 -05:00
rf_links.ex fix: make sidebar sticky with header and resolve all credo issues (#32) 2026-03-15 18:19:09 -05:00
search.ex refactor: extract per-schema Query modules for organization_id filters 2026-04-30 14:26:30 -05:00
settings.ex fix/test-failures (#112) 2026-03-22 13:02:06 -05:00
sites.ex refactor: route Sites and Monitoring queries through Query modules 2026-04-30 14:32:00 -05:00
snmp.ex refactor(snmp): replace extracted sections with delegates 2026-04-30 14:26:31 -05:00
status_pages.ex refactor/dry-improvements (#202) 2026-03-28 10:56:34 -05:00
time.ex refactor/dry-improvements (#202) 2026-03-28 10:56:34 -05:00
topology.ex chore(coverage,types): clean dialyzer + new tests + ETH canopy provider 2026-05-07 09:11:17 -05:00
trace.ex tests: raise coverage to 70% via helper promotion + new unit/property tests 2026-04-24 09:49:06 -05:00
url_validator.ex refactor: convert 6 Gleam modules to idiomatic Elixir with TDD (#196) 2026-03-28 09:52:07 -05:00
vault.ex add mikrotik device handling 2026-02-01 16:42:39 -06:00
weather.ex tests: raise coverage to 70% via helper promotion + new unit/property tests 2026-04-24 09:49:06 -05:00