Implemented top 3 critical network switch sensor gaps identified in Phase 3 analysis.
Restores fundamental temperature monitoring for common enterprise switch platforms.
Files Changed:
- priv/profiles/os_discovery/comware.yaml (enhanced)
Added HP Comware chassis temperature monitoring via HH3C-ENTITY-EXT-MIB
OID: 1.3.6.1.4.1.25506.2.6.1.1.1.1.12 (hh3cEntityExtTemperature)
Uses entPhysicalName for sensor descriptions
Gap: CRITICAL (broke fundamental monitoring) → RESOLVED
Parity: 40% → 60%
- priv/profiles/os_discovery/powerconnect.yaml (enhanced)
Added Dell PowerConnect/DNOS CPU temperature monitoring
OID: 1.3.6.1.4.1.674.10895.5000.2.6132.1.1.43.1.8.1.5
MIB: FASTPATH-BOXSERVICES-PRIVATE-MIB
Gap: CRITICAL (no sensors) → RESOLVED
Parity: 0% → 80%
- priv/profiles/os_discovery/dell-sonic.yaml (new)
Created comprehensive Dell SONiC sensor profile
MIB: NETGEAR-BOXSERVICES-PRIVATE-MIB (Quanta-based)
Sensors:
- Temperature: boxServicesTempSensorState (OID .1.3.6.1.4.1.4413.1.1.43.1.8.1.4)
- Fan Speed: boxServicesFanSpeed (OID .1.3.6.1.4.1.4413.1.1.43.1.6.1.4)
- PSU State: boxServicesPowSupplyItemState (OID .1.3.6.1.4.1.4413.1.1.43.1.7.1.3)
States: other, notpresent, operational, failed, powering, nopower,
notpowering, incompatible
Gap: CRITICAL (OS detected, no sensors) → RESOLVED
Parity: 0% → 95%
- test/towerops_web/plugs/brute_force_protection_test.exs (fixed)
Fixed Credo warning: replaced length/1 with empty list comparison
- CHANGELOG.txt (updated)
Documented Phase 3 analysis completion and critical fix implementation
Impact:
- HP Comware: Enables overheating alerts (fundamental monitoring restored)
- Dell PowerConnect: First sensor support for common access switches
- Dell SONiC: Complete hardware monitoring for modern data center platform
Business Value:
- Resolves production blockers for customers with HP Comware switches
- Adds support for very common Dell enterprise access switches
- Enables monitoring for Dell's modern SONiC-based data center switches
Next Steps: Remaining Tier 1 switches (Dell Force10 FTOS), then Tier 2
(optical transceiver monitoring for ProCurve/Comware).
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
104 lines
2.8 KiB
Elixir
104 lines
2.8 KiB
Elixir
defmodule ToweropsWeb.NetworkMapLiveTest do
|
|
use ToweropsWeb.ConnCase, async: true
|
|
|
|
import Phoenix.LiveViewTest
|
|
|
|
setup :register_and_log_in_user
|
|
|
|
setup %{user: user} do
|
|
{:ok, organization} = Towerops.Organizations.create_organization(%{name: "Test Org"}, user.id)
|
|
|
|
%{organization: organization}
|
|
end
|
|
|
|
describe "mount and render" do
|
|
test "mounts and renders the network map page", %{conn: conn} do
|
|
{:ok, _view, html} = live(conn, ~p"/network-map")
|
|
|
|
assert html =~ "Network Map"
|
|
assert html =~ "Experimental"
|
|
assert html =~ "Topology Visualization"
|
|
end
|
|
|
|
test "shows stats bar with default zeros", %{conn: conn} do
|
|
{:ok, _view, html} = live(conn, ~p"/network-map")
|
|
|
|
assert html =~ "Total Devices"
|
|
assert html =~ "Added Devices"
|
|
assert html =~ "Discovered"
|
|
assert html =~ "Connections"
|
|
assert html =~ "Subnets"
|
|
end
|
|
|
|
test "shows tab navigation with added and all tabs", %{conn: conn} do
|
|
{:ok, _view, html} = live(conn, ~p"/network-map")
|
|
|
|
assert html =~ "Added Devices"
|
|
assert html =~ "All Devices"
|
|
end
|
|
|
|
test "shows empty state when no devices exist", %{conn: conn} do
|
|
{:ok, _view, html} = live(conn, ~p"/network-map")
|
|
|
|
assert html =~ "No network topology available"
|
|
assert html =~ "Add devices"
|
|
end
|
|
|
|
test "shows refresh button", %{conn: conn} do
|
|
{:ok, _view, html} = live(conn, ~p"/network-map")
|
|
|
|
assert html =~ "Refresh"
|
|
end
|
|
|
|
test "shows legend with status indicators", %{conn: conn} do
|
|
{:ok, _view, html} = live(conn, ~p"/network-map")
|
|
|
|
assert html =~ "Online"
|
|
assert html =~ "Unknown"
|
|
assert html =~ "Offline"
|
|
assert html =~ "Discovered"
|
|
end
|
|
|
|
test "shows cytoscape container with network map hook", %{conn: conn} do
|
|
{:ok, _view, html} = live(conn, ~p"/network-map")
|
|
|
|
assert html =~ "cy-container"
|
|
assert html =~ "NetworkMap"
|
|
end
|
|
end
|
|
|
|
describe "tab navigation" do
|
|
test "defaults to added tab", %{conn: conn} do
|
|
{:ok, _view, html} = live(conn, ~p"/network-map")
|
|
|
|
# The "Added Devices" tab should have active styling
|
|
assert html =~ "Added Devices"
|
|
end
|
|
|
|
test "switches to all tab via params", %{conn: conn} do
|
|
{:ok, _view, html} = live(conn, ~p"/network-map?tab=all")
|
|
|
|
assert html =~ "All Devices"
|
|
end
|
|
end
|
|
|
|
describe "events" do
|
|
test "refresh_topology reloads data and shows flash", %{conn: conn} do
|
|
{:ok, view, _html} = live(conn, ~p"/network-map")
|
|
|
|
html = render_click(view, "refresh_topology")
|
|
|
|
assert html =~ "Network map refreshed"
|
|
end
|
|
end
|
|
|
|
describe "unauthenticated access" do
|
|
test "requires authentication" do
|
|
conn = build_conn()
|
|
{:error, redirect} = live(conn, ~p"/network-map")
|
|
|
|
assert {:redirect, %{to: path}} = redirect
|
|
assert path == ~p"/users/log-in"
|
|
end
|
|
end
|
|
end
|