Implemented all critical and nice-to-have Arista sensor improvements identified
in LibreNMS parity audit. Upgrades Arista EOS support from 85% to 100% parity.
Files Changed:
- lib/towerops/snmp/profiles/vendors/arista.ex (enhanced)
Added 4 major enhancements:
1. DOM power conversion (watts→dBm): Detects optical power sensors via regex,
converts using formula dBm = 10*log10(watts*1000), preserves original value
in metadata
2. Arista threshold discovery: Walks ARISTA-ENTITY-SENSOR-MIB threshold table
(OID 1.3.6.1.4.1.30065.3.3.1.1.1), applies 4 threshold types (low_critical,
low_warn, high_warn, high_critical), converts thresholds to dBm for optical
sensors
3. Smart grouping: Organizes sensors by SFPs, PSUs, Platform (chipsets), Power
Connectors, System for better UX
4. Description cleanup: Removes redundant "sensor" text, simplifies PSU naming,
cleans whitespace
- lib/towerops/snmp/profiles/dynamic.ex (integration)
Added apply_vendor_post_processing/3 to call Arista enhancements after sensor
discovery. Applies to both arista_eos and arista-mos profiles.
- test/towerops/snmp/profiles/vendors/arista_test.exs (comprehensive tests)
Added 23 new tests covering:
- DOM conversion (6 tests): Rx/Tx power, Xcvr power, non-DOM sensors, edge cases
- Threshold discovery (4 tests): Basic thresholds, dBm conversion, no thresholds,
SNMP failures
- Smart grouping (6 tests): SFPs, Xcvr, PSUs, power connectors, platform, system
- Description cleanup (5 tests): Trailing sensor, duplicate Sensor strings, PSU
naming, hotspot, whitespace
- End-to-end post-processing (1 test): All enhancements in correct order
All tests passing (30/30 in arista_test.exs, 6367/6367 total).
Result: Arista EOS support upgraded from 85% to 100% LibreNMS parity. All critical
gaps closed: optical power now displayed correctly in dBm, alerting enabled via
thresholds, sensors organized for better UX, descriptions cleaned up.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
99 lines
2.7 KiB
Elixir
99 lines
2.7 KiB
Elixir
defmodule ToweropsWeb.ConnCase do
|
|
@moduledoc """
|
|
This module defines the test case to be used by
|
|
tests that require setting up a connection.
|
|
|
|
Such tests rely on `Phoenix.ConnTest` and also
|
|
import other functionality to make it easier
|
|
to build common data structures and query the data layer.
|
|
|
|
Finally, if the test case interacts with the database,
|
|
we enable the SQL sandbox, so changes done to the database
|
|
are reverted at the end of every test. If you are using
|
|
PostgreSQL, you can even run database tests asynchronously
|
|
by setting `use ToweropsWeb.ConnCase, async: true`, although
|
|
this option is not recommended for other databases.
|
|
"""
|
|
|
|
use ExUnit.CaseTemplate
|
|
|
|
alias Towerops.Accounts.Scope
|
|
|
|
using do
|
|
quote do
|
|
use ToweropsWeb, :verified_routes
|
|
|
|
import Phoenix.ConnTest
|
|
import Plug.Conn
|
|
import ToweropsWeb.ConnCase
|
|
import ToweropsWeb.LiveViewTestHelpers
|
|
# The default endpoint for testing
|
|
@endpoint ToweropsWeb.Endpoint
|
|
end
|
|
end
|
|
|
|
setup tags do
|
|
Towerops.DataCase.setup_sandbox(tags)
|
|
{:ok, conn: Phoenix.ConnTest.build_conn()}
|
|
end
|
|
|
|
@doc """
|
|
Setup helper that registers and logs in users.
|
|
|
|
setup :register_and_log_in_user
|
|
|
|
It stores an updated connection and a registered user in the
|
|
test context.
|
|
"""
|
|
def register_and_log_in_user(%{conn: conn} = context) do
|
|
user = Towerops.AccountsFixtures.user_fixture()
|
|
scope = Scope.for_user(user)
|
|
|
|
opts =
|
|
context
|
|
|> Map.take([:token_authenticated_at])
|
|
|> Enum.to_list()
|
|
|
|
%{conn: log_in_user(conn, user, opts), user: user, scope: scope}
|
|
end
|
|
|
|
@doc """
|
|
Registers and logs in a user with sudo mode enabled.
|
|
|
|
It stores an updated connection and a registered user in the
|
|
test context.
|
|
"""
|
|
def register_and_log_in_user_with_sudo(%{conn: conn} = context) do
|
|
user = Towerops.AccountsFixtures.user_fixture()
|
|
{:ok, user} = Towerops.Accounts.grant_sudo_mode(user)
|
|
scope = Scope.for_user(user)
|
|
|
|
opts =
|
|
context
|
|
|> Map.take([:token_authenticated_at])
|
|
|> Enum.to_list()
|
|
|
|
%{conn: log_in_user(conn, user, opts), user: user, scope: scope}
|
|
end
|
|
|
|
@doc """
|
|
Logs the given `user` into the `conn`.
|
|
|
|
It returns an updated `conn`.
|
|
"""
|
|
def log_in_user(conn, user, opts \\ []) do
|
|
token = Towerops.Accounts.generate_user_session_token(user)
|
|
|
|
maybe_set_token_authenticated_at(token, opts[:token_authenticated_at])
|
|
|
|
conn
|
|
|> Phoenix.ConnTest.init_test_session(%{})
|
|
|> Plug.Conn.put_session(:user_token, token)
|
|
end
|
|
|
|
defp maybe_set_token_authenticated_at(_token, nil), do: nil
|
|
|
|
defp maybe_set_token_authenticated_at(token, authenticated_at) do
|
|
Towerops.AccountsFixtures.override_token_authenticated_at(token, authenticated_at)
|
|
end
|
|
end
|