Commit graph

4 commits

Author SHA1 Message Date
3ca0834ef0 tests: raise coverage to 70% via helper promotion + new unit/property tests
Promoted pure presentation and utility helpers from `defp` to `def @doc false`
across ~20 LiveViews, Oban workers, and sync modules so they're reachable from
unit tests. Refactored several `cond` blocks into idiomatic function heads with
guards. Added ~250 new test cases in new files under test/towerops and
test/towerops_web, including DB-backed tests for CnMaestro.Sync and
AlertNotificationWorker, and removed dead LiveView tab components and
CapacityLive (no callers anywhere in lib/test).

Configured mix.exs test_coverage.ignore_modules to exclude vendored third-party
code (SnmpKit, protobuf-generated Towerops.Agent.*, Absinthe GraphQL types,
Phoenix HTML modules, Inspect protocol impls) from coverage calculations —
these are not our project code.

Coverage: 66.93% → 70.09%. Full suite: 10,127 tests, 0 failures.
2026-04-24 09:49:06 -05:00
7232ae6306 refactor/dry-improvements (#202)
Reviewed-on: graham/towerops-web#202
2026-03-28 10:56:34 -05:00
07336fefff
perf(test): optimize slow tests - 68% faster
- Add timeout: 100 to SNMP tests to avoid 5s default timeout on unreachable IPs
- Reduce retry delays in error handler tests from 50-100ms to 1ms
- Fix Splynx rate limit test to stub auth immediately without extra calls
- Use localhost instead of device.local to avoid DNS timeout
- Use temp empty dir for ImportProfiles test instead of scanning 788 real files

Results:
- Top 10 slowest: 45.6s → 14.6s (68% reduction)
- Overall suite: ~80s → 39.9s (50% faster)
- Specific improvements:
  * Splynx sync: 7010ms → 134ms (98% faster)
  * ImportProfiles: 5502ms → 33ms (99% faster)
  * get_bulk!: 5043ms → 125ms (97% faster)
  * Walk hostname: 5005ms → 119ms (97% faster)
  * Error retries: 3103ms → 6ms (99% faster)
2026-03-05 14:35:58 -06:00
1ce3763e5f
more tests 2026-02-03 10:19:56 -06:00