towerops

graham/towerops

Fork 0

Commit graph

Author	SHA1	Message	Date
Graham McIntire	7232ae6306	refactor/dry-improvements (#202 ) Reviewed-on: graham/towerops-web#202	2026-03-28 10:56:34 -05:00
Graham McIntire	c4e301a84c	fix: address code review findings - memory leaks and redundant queries (#192 ) Fixed 5 critical issues from code review: 1. GlobalSearchTrigger hook listener leak - Added destroyed() callback to remove click listener - Prevents memory leak on LiveView unmount 2. NetworkMap/WeathermapViewer hook listener leaks - Store zoom/fit button handlers as properties - Remove DOM event listeners in destroyed() callback - Fixes leak on every LiveView remount 3. SitesMap uses undocumented window.liveSocket.execJS - Changed to proper LiveView pattern using pushEvent - Attach listener via Leaflet's popupopen event 4. handle_info(:refresh_data) double DB fetch - Removed redundant Devices.get_device call - Reuse device from assign_base_data 5. Redundant DB queries in DeviceLive.Show overview - Changed load_sensor_chart_data to accept snmp_device - Changed load_overall_traffic_chart_data to accept snmp_device - Eliminated 4 redundant Snmp.get_device_with_associations calls Also removed unused functions: - load_equipment_data/2 - reload_active_tab_data/1 - assign_subscriber_impact/1 Note: DeviceLive.Show module size (2252 lines) is acknowledged but deferred as it requires larger architectural refactoring. Reviewed-on: graham/towerops-web#192	2026-03-27 16:34:42 -05:00
Graham McIntire	6aab59dcf5	refactor: centralize LiveView access control checks Extract duplicate access control logic from multiple LiveView files into a reusable AccessControl helper module. Changes: - NEW: lib/towerops_web/live/helpers/access_control.ex - NEW: test/towerops_web/live/helpers/access_control_test.exs - Refactor device_live/index.ex to use AccessControl.verify_site_access/2 and verify_device_access/2 - Refactor device_live/form.ex to use AccessControl.verify_device_access/2 - Refactor alert_live/index.ex to use AccessControl.verify_alert_access/2 - Refactor device_live/show.ex to use AccessControl.verify_device_access/2 - Remove unused Repo aliases from refactored files Benefits: - Reduces code duplication across 7+ locations - Centralizes security-critical access checks - Improves testability (helper module has >90% coverage) - Consistent error handling across all LiveViews 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-02-04 17:51:05 -06:00

Author

SHA1

Message

Date

Graham McIntire

7232ae6306

refactor/dry-improvements (#202 )

Reviewed-on: graham/towerops-web#202

2026-03-28 10:56:34 -05:00

Graham McIntire

c4e301a84c

fix: address code review findings - memory leaks and redundant queries (#192 )

Fixed 5 critical issues from code review:

1. **GlobalSearchTrigger hook listener leak**
   - Added destroyed() callback to remove click listener
   - Prevents memory leak on LiveView unmount

2. **NetworkMap/WeathermapViewer hook listener leaks**
   - Store zoom/fit button handlers as properties
   - Remove DOM event listeners in destroyed() callback
   - Fixes leak on every LiveView remount

3. **SitesMap uses undocumented window.liveSocket.execJS**
   - Changed to proper LiveView pattern using pushEvent
   - Attach listener via Leaflet's popupopen event

4. **handle_info(:refresh_data) double DB fetch**
   - Removed redundant Devices.get_device call
   - Reuse device from assign_base_data

5. **Redundant DB queries in DeviceLive.Show overview**
   - Changed load_sensor_chart_data to accept snmp_device
   - Changed load_overall_traffic_chart_data to accept snmp_device
   - Eliminated 4 redundant Snmp.get_device_with_associations calls

Also removed unused functions:
- load_equipment_data/2
- reload_active_tab_data/1
- assign_subscriber_impact/1

Note: DeviceLive.Show module size (2252 lines) is acknowledged but
deferred as it requires larger architectural refactoring.

Reviewed-on: graham/towerops-web#192

2026-03-27 16:34:42 -05:00

Graham McIntire

6aab59dcf5

refactor: centralize LiveView access control checks

Extract duplicate access control logic from multiple LiveView files into
a reusable AccessControl helper module.

**Changes:**
- NEW: lib/towerops_web/live/helpers/access_control.ex
- NEW: test/towerops_web/live/helpers/access_control_test.exs
- Refactor device_live/index.ex to use AccessControl.verify_site_access/2
  and verify_device_access/2
- Refactor device_live/form.ex to use AccessControl.verify_device_access/2
- Refactor alert_live/index.ex to use AccessControl.verify_alert_access/2
- Refactor device_live/show.ex to use AccessControl.verify_device_access/2
- Remove unused Repo aliases from refactored files

**Benefits:**
- Reduces code duplication across 7+ locations
- Centralizes security-critical access checks
- Improves testability (helper module has >90% coverage)
- Consistent error handling across all LiveViews

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

2026-02-04 17:51:05 -06:00

3 commits