towerops

graham/towerops

Fork 0

Commit graph

Author	SHA1	Message	Date
Graham McIntire	efaf5558ff	refactor: convert 6 Gleam modules to idiomatic Elixir with TDD (#196 ) Phase 1: Foundation Types (100% complete) - query_helpers: SQL LIKE sanitization with pipe operators - numeric: Integer parsing with pattern matching guards - result: Pure Elixir Result monad (map, and_then, unwrap_or) Phase 2: Ecto Domain Types (100% complete) - ip_address: IPv4/IPv6 validation using :inet directly - mac_address: Multi-format MAC parsing (colon/hyphen/dot/compact) - snmp_oid: OID parsing/manipulation with recursive pattern matching All 198 tests passing across converted modules. API changed from Gleam-style {:some/:none to idiomatic {:ok/:error. Refactored parse_numeric_oid to use with statement, reducing nesting depth. Reviewed-on: graham/towerops-web#196	2026-03-28 09:52:07 -05:00
Graham McIntire	c4e301a84c	fix: address code review findings - memory leaks and redundant queries (#192 ) Fixed 5 critical issues from code review: 1. GlobalSearchTrigger hook listener leak - Added destroyed() callback to remove click listener - Prevents memory leak on LiveView unmount 2. NetworkMap/WeathermapViewer hook listener leaks - Store zoom/fit button handlers as properties - Remove DOM event listeners in destroyed() callback - Fixes leak on every LiveView remount 3. SitesMap uses undocumented window.liveSocket.execJS - Changed to proper LiveView pattern using pushEvent - Attach listener via Leaflet's popupopen event 4. handle_info(:refresh_data) double DB fetch - Removed redundant Devices.get_device call - Reuse device from assign_base_data 5. Redundant DB queries in DeviceLive.Show overview - Changed load_sensor_chart_data to accept snmp_device - Changed load_overall_traffic_chart_data to accept snmp_device - Eliminated 4 redundant Snmp.get_device_with_associations calls Also removed unused functions: - load_equipment_data/2 - reload_active_tab_data/1 - assign_subscriber_impact/1 Note: DeviceLive.Show module size (2252 lines) is acknowledged but deferred as it requires larger architectural refactoring. Reviewed-on: graham/towerops-web#192	2026-03-27 16:34:42 -05:00

Author

SHA1

Message

Date

Graham McIntire

efaf5558ff

refactor: convert 6 Gleam modules to idiomatic Elixir with TDD (#196 )

Phase 1: Foundation Types (100% complete)
- query_helpers: SQL LIKE sanitization with pipe operators
- numeric: Integer parsing with pattern matching guards
- result: Pure Elixir Result monad (map, and_then, unwrap_or)

Phase 2: Ecto Domain Types (100% complete)
- ip_address: IPv4/IPv6 validation using :inet directly
- mac_address: Multi-format MAC parsing (colon/hyphen/dot/compact)
- snmp_oid: OID parsing/manipulation with recursive pattern matching

All 198 tests passing across converted modules.
API changed from Gleam-style {:some/:none to idiomatic {:ok/:error.
Refactored parse_numeric_oid to use with statement, reducing nesting depth.

Reviewed-on: graham/towerops-web#196

2026-03-28 09:52:07 -05:00

Graham McIntire

c4e301a84c

fix: address code review findings - memory leaks and redundant queries (#192 )

Fixed 5 critical issues from code review:

1. **GlobalSearchTrigger hook listener leak**
   - Added destroyed() callback to remove click listener
   - Prevents memory leak on LiveView unmount

2. **NetworkMap/WeathermapViewer hook listener leaks**
   - Store zoom/fit button handlers as properties
   - Remove DOM event listeners in destroyed() callback
   - Fixes leak on every LiveView remount

3. **SitesMap uses undocumented window.liveSocket.execJS**
   - Changed to proper LiveView pattern using pushEvent
   - Attach listener via Leaflet's popupopen event

4. **handle_info(:refresh_data) double DB fetch**
   - Removed redundant Devices.get_device call
   - Reuse device from assign_base_data

5. **Redundant DB queries in DeviceLive.Show overview**
   - Changed load_sensor_chart_data to accept snmp_device
   - Changed load_overall_traffic_chart_data to accept snmp_device
   - Eliminated 4 redundant Snmp.get_device_with_associations calls

Also removed unused functions:
- load_equipment_data/2
- reload_active_tab_data/1
- assign_subscriber_impact/1

Note: DeviceLive.Show module size (2252 lines) is acknowledged but
deferred as it requires larger architectural refactoring.

Reviewed-on: graham/towerops-web#192

2026-03-27 16:34:42 -05:00

2 commits