towerops

graham/towerops

Fork 0

Commit graph

Author	SHA1	Message	Date
Graham McIntire	c50dc08ad4	test: fix slow + flaky tests (Mox global, env pollution, pool starvation) - Remove Mox.set_mox_global() in DPW extra test; rely on $callers instead so concurrent vendor SNMP tests stop intermittently failing with VerificationError. - Make ToweropsWeb.Plugs.GraphQLIntrospectionTest async: false. It mutates Application.put_env(:towerops, :env, :prod), which polluted every async vendor test that reads :env via Towerops.Snmp.Client.phoenix_snmp_disabled/0. - Bump test pool queue_target/queue_interval. AgentChannelTest spawns many `:proc_lib` channel processes that hold sandbox connections; the default 50ms queue caused intermittent 'could not checkout the connection' errors. - Tag real-System.cmd("ping") tests as :network so they're excluded by default. Saves ~20s on every full run. - Make JobCleanupTask's internal 1s settle sleep configurable via :job_cleanup_settle_ms; the test overrides it to 0. Plus the pending CoverageLive.Form edit-save / EIRP recompute and TraceLive deep-link tests from before the compact.	2026-05-08 14:43:30 -05:00
Graham McIntire	7adc2fb0a6	test(coverage): add tests for index/form events, raster, buildings, context Push the Coverages namespace coverage up further: * CoverageLive.Index — delete and recompute event handlers, the in-progress flash branch, status_badge_class fallback. 35% → 87%. * CoverageLive.Form — invalid-save round-trip, location_picked and use_site_location event handlers. 61% → 77%. * Coverages.Raster — query_rssi guard branches (not_ready, outside_bbox, raster_missing, missing-bbox), cleanup no-op, and Lidar.Reader parse_aaigrid header parsing. 63% → 75%. * Coverages.Buildings — to_clutter height fallback, polygon coord extraction, for_bbox PostGIS intersect against real DB rows. 43% → ~95%. * Coverages context — topic helpers, subscribe + broadcast, list_ready_for_organization, change_coverage, query_point happy and empty paths, queue_compute idempotency. 65% → 93%. Total project coverage 74.05% → 74.25%.	2026-05-07 09:36:16 -05:00
Graham McIntire	0e2cc6b7ce	chore(coverage,types): clean dialyzer + new tests + ETH canopy provider Dialyzer: * Add Lidar.Tile @type, narrow several @specs to match success-typing, prefix discarded function returns with `_ =`, fix the broken File.stream! call in the ms-buildings worker (it was causing dialyzer to mark every private fun unreachable), broaden Antenna.spec key types from `float()` to `number()` to match catalog int literals. * Add :geo, :geo_postgis, :db_connection to plt_add_apps so the dep PLT actually contains the modules we use. * Result: 0 unsuppressed dialyzer warnings (was 50+ in project code). Tree canopy: * Replace the dead landfire.gov URL with the ETH Zurich Global Canopy Height 10 m product. ETH publishes proper COGs with overviews on libdrive.ethz.ch — confirmed working with /vsicurl/ byte-range reads. The module now picks the 3°×3° tile containing the bbox centroid, with both a `:metres` decoder (ETH Byte raster, NoData=255) and a `:landfire_evh` decoder for operators self-hosting LANDFIRE EVH COGs. * Re-enable canopy by default now that there's a working source. Tests (+105 tests, 0 failures): * CoverageLive Index/Show/Form/Map — empty/loaded/auth states, LiveView event handlers, formatters. * Coverages.Building changeset + helpers. * Coverages.TreeCanopy provider tile-URL builder and decoders. * Workers.MsBuildingsImportWorker (full import flow incl. blank lines, MultiPolygon, idempotency, hash fallback) — also fixed the partial-index ON CONFLICT bug that prevented imports from ever working: the unique index has WHERE ms_footprint_id IS NOT NULL, so the worker now uses an :unsafe_fragment conflict target that includes the predicate. * GraphQLDocsController smoke test (was 0%). Coverage rose from 73.19% → 74% with the major project modules I touched all moved from 0% / <50% to >75%.	2026-05-07 09:11:17 -05:00

Author

SHA1

Message

Date

Graham McIntire

c50dc08ad4

test: fix slow + flaky tests (Mox global, env pollution, pool starvation)

- Remove Mox.set_mox_global() in DPW extra test; rely on $callers
  instead so concurrent vendor SNMP tests stop intermittently failing
  with VerificationError.
- Make ToweropsWeb.Plugs.GraphQLIntrospectionTest async: false. It
  mutates Application.put_env(:towerops, :env, :prod), which polluted
  every async vendor test that reads :env via
  Towerops.Snmp.Client.phoenix_snmp_disabled/0.
- Bump test pool queue_target/queue_interval. AgentChannelTest spawns
  many `:proc_lib` channel processes that hold sandbox connections;
  the default 50ms queue caused intermittent
  'could not checkout the connection' errors.
- Tag real-System.cmd("ping") tests as :network so they're excluded
  by default. Saves ~20s on every full run.
- Make JobCleanupTask's internal 1s settle sleep configurable via
  :job_cleanup_settle_ms; the test overrides it to 0.

Plus the pending CoverageLive.Form edit-save / EIRP recompute and
TraceLive deep-link tests from before the compact.

2026-05-08 14:43:30 -05:00

Graham McIntire

7adc2fb0a6

test(coverage): add tests for index/form events, raster, buildings, context

Push the Coverages namespace coverage up further:

* CoverageLive.Index — delete and recompute event handlers, the
  in-progress flash branch, status_badge_class fallback. 35% → 87%.
* CoverageLive.Form — invalid-save round-trip, location_picked and
  use_site_location event handlers. 61% → 77%.
* Coverages.Raster — query_rssi guard branches (not_ready, outside_bbox,
  raster_missing, missing-bbox), cleanup no-op, and Lidar.Reader
  parse_aaigrid header parsing. 63% → 75%.
* Coverages.Buildings — to_clutter height fallback, polygon coord
  extraction, for_bbox PostGIS intersect against real DB rows. 43% → ~95%.
* Coverages context — topic helpers, subscribe + broadcast,
  list_ready_for_organization, change_coverage, query_point happy and
  empty paths, queue_compute idempotency. 65% → 93%.

Total project coverage 74.05% → 74.25%.

2026-05-07 09:36:16 -05:00

Graham McIntire

0e2cc6b7ce

chore(coverage,types): clean dialyzer + new tests + ETH canopy provider

Dialyzer:
* Add Lidar.Tile @type, narrow several @specs to match success-typing,
  prefix discarded function returns with `_ =`, fix the broken
  File.stream! call in the ms-buildings worker (it was causing dialyzer
  to mark every private fun unreachable), broaden Antenna.spec key
  types from `float()` to `number()` to match catalog int literals.
* Add :geo, :geo_postgis, :db_connection to plt_add_apps so the dep
  PLT actually contains the modules we use.
* Result: 0 unsuppressed dialyzer warnings (was 50+ in project code).

Tree canopy:
* Replace the dead landfire.gov URL with the ETH Zurich Global
  Canopy Height 10 m product. ETH publishes proper COGs with
  overviews on libdrive.ethz.ch — confirmed working with
  /vsicurl/ byte-range reads. The module now picks the 3°×3° tile
  containing the bbox centroid, with both a `:metres` decoder
  (ETH Byte raster, NoData=255) and a `:landfire_evh` decoder for
  operators self-hosting LANDFIRE EVH COGs.
* Re-enable canopy by default now that there's a working source.

Tests (+105 tests, 0 failures):
* CoverageLive Index/Show/Form/Map — empty/loaded/auth states,
  LiveView event handlers, formatters.
* Coverages.Building changeset + helpers.
* Coverages.TreeCanopy provider tile-URL builder and decoders.
* Workers.MsBuildingsImportWorker (full import flow incl. blank
  lines, MultiPolygon, idempotency, hash fallback) — also fixed
  the partial-index ON CONFLICT bug that prevented imports from
  ever working: the unique index has WHERE ms_footprint_id IS
  NOT NULL, so the worker now uses an :unsafe_fragment conflict
  target that includes the predicate.
* GraphQLDocsController smoke test (was 0%).

Coverage rose from 73.19% → 74% with the major project modules I
touched all moved from 0% / <50% to >75%.

2026-05-07 09:11:17 -05:00

3 commits