towerops

graham/towerops

Fork 0

Commit graph

Author	SHA1	Message	Date
Graham McIntire	8fe1850d8a	test: lift coverage 79.78% → 80.92%+ with broad new tests Adds 100+ new tests across: - Snmp.Discovery sync_: mempools/transceivers/printer_supplies/ entity_physical/save_neighbors/save_arp_entries - Topology: compute_wireless_stats, compute_rf_link_stats, get_topology_for_weathermap, LLDP discovery/list/upsert, remove_stale + find_device_by_name fallthroughs - Trace: account/inventory/access_point assemble_trace + trace_from_device inventory→account linking - DiscoveryWorker: assigned-agent fallback, agent offline mid-discovery, device deleted during discovery, perform/1 rescue (34% → 64%) - Snmp.Profiles.Base: discover_state_sensors/vlans/ipv6_addresses/ memory_pools/processors + identify_device for many vendors - ChartBuilders: load__chart_data nil/empty + DB-backed sensor charts - OrgSettingsLive events: apply_snmp/apply_agent/toggle_default/ toggle_enabled - DeviceLive.Form events: edit access errors, validate branches, test_snmp w/o agent + with v2c/v3 credentials, query param prefill - DeviceLive.Index: reorder, search, filter_status, force rediscover - CheckLive.FormComponent: full mount/change_type/validate/save flow for http/tcp/dns/ssl + edit/close	2026-05-08 09:11:06 -05:00
Graham McIntire	3ca0834ef0	tests: raise coverage to 70% via helper promotion + new unit/property tests Promoted pure presentation and utility helpers from `defp` to `def @doc false` across ~20 LiveViews, Oban workers, and sync modules so they're reachable from unit tests. Refactored several `cond` blocks into idiomatic function heads with guards. Added ~250 new test cases in new files under test/towerops and test/towerops_web, including DB-backed tests for CnMaestro.Sync and AlertNotificationWorker, and removed dead LiveView tab components and CapacityLive (no callers anywhere in lib/test). Configured mix.exs test_coverage.ignore_modules to exclude vendored third-party code (SnmpKit, protobuf-generated Towerops.Agent.*, Absinthe GraphQL types, Phoenix HTML modules, Inspect protocol impls) from coverage calculations — these are not our project code. Coverage: 66.93% → 70.09%. Full suite: 10,127 tests, 0 failures.	2026-04-24 09:49:06 -05:00

Author

SHA1

Message

Date

Graham McIntire

8fe1850d8a

test: lift coverage 79.78% → 80.92%+ with broad new tests

Adds 100+ new tests across:

- Snmp.Discovery sync_*: mempools/transceivers/printer_supplies/
  entity_physical/save_neighbors/save_arp_entries
- Topology: compute_wireless_stats, compute_rf_link_stats,
  get_topology_for_weathermap, LLDP discovery/list/upsert,
  remove_stale + find_device_by_name fallthroughs
- Trace: account/inventory/access_point assemble_trace + trace_from_device
  inventory→account linking
- DiscoveryWorker: assigned-agent fallback, agent offline mid-discovery,
  device deleted during discovery, perform/1 rescue (34% → 64%)
- Snmp.Profiles.Base: discover_state_sensors/vlans/ipv6_addresses/
  memory_pools/processors + identify_device for many vendors
- ChartBuilders: load_*_chart_data nil/empty + DB-backed sensor charts
- OrgSettingsLive events: apply_snmp/apply_agent/toggle_default/
  toggle_enabled
- DeviceLive.Form events: edit access errors, validate branches,
  test_snmp w/o agent + with v2c/v3 credentials, query param prefill
- DeviceLive.Index: reorder, search, filter_status, force rediscover
- CheckLive.FormComponent: full mount/change_type/validate/save flow
  for http/tcp/dns/ssl + edit/close

2026-05-08 09:11:06 -05:00

Graham McIntire

3ca0834ef0

tests: raise coverage to 70% via helper promotion + new unit/property tests

Promoted pure presentation and utility helpers from `defp` to `def @doc false`
across ~20 LiveViews, Oban workers, and sync modules so they're reachable from
unit tests. Refactored several `cond` blocks into idiomatic function heads with
guards. Added ~250 new test cases in new files under test/towerops and
test/towerops_web, including DB-backed tests for CnMaestro.Sync and
AlertNotificationWorker, and removed dead LiveView tab components and
CapacityLive (no callers anywhere in lib/test).

Configured mix.exs test_coverage.ignore_modules to exclude vendored third-party
code (SnmpKit, protobuf-generated Towerops.Agent.*, Absinthe GraphQL types,
Phoenix HTML modules, Inspect protocol impls) from coverage calculations —
these are not our project code.

Coverage: 66.93% → 70.09%. Full suite: 10,127 tests, 0 failures.

2026-04-24 09:49:06 -05:00

2 commits