fd75837ae9
test: lift coverage 84.08% → 84.99%; exclude declarative modules from coverage
2026-05-08 11:18:26 -05:00
4b2bc4f739
test: lift coverage 79.59% → 79.85% with more focused tests
...
- TraceLive.Index: mount + search/select/clear handlers + format helpers
- MikrotikBackupLive.Compare: full mount/handle_params/download_config flow
- ConfigTimelineLive: redirect + render + select_range/close_event
- Admin.UserLive.Index: impersonate redirect + delete_user happy/error
- Snmp.Vlans: list/get coverage
- DnsExecutor: AAAA/MX/TXT/CNAME query branches
- PagerDuty.Client: device_up/unknown alert_type severity branches
- Resolvers.Device: create/update/delete/metrics/interfaces happy + error
2026-05-07 19:16:13 -05:00
aa7fc830e5
test: refactor LiveView tests to use HTML-aware element/form helpers
...
Apply patterns from testingliveview.com — replace render_click/submit/change
event-name calls with element/form-targeted equivalents that validate the
actual DOM wiring, not just handler logic. Adds stable test selectors
(id="...") to interactive elements across 10 LiveView templates.
Surfaces (and fixes) several real issues that the bypass-style tests masked:
- Removes dead regenerate_token handler in agent_live/index.ex (no UI ever
triggered it) and its corresponding test.
- Removes dead refresh_topology test in network_map_live_test (event was
referenced only in the test — no handler, no button, no JS anywhere).
- Corrects "shows notification tab with add device modal" — modal lives on
the security tab; original test mounted ?tab=notifications and only
worked because direct event calls bypassed tab gating.
- Corrects form input shape mismatches in agent_live/index_test that the
handler's defensive case clauses had been masking.
- Expands setup data for org/settings_live_test (snmp_community,
default_agent_token_id, multi-org membership) so the gated buttons
actually render.
11 direct render_click/submit/change calls remain — all intentional,
documented server-side guard tests (tampered POSTs, race conditions,
defensive idempotent handlers).
Full LiveView test suite: 1300 tests, 0 failures.
2026-04-29 11:14:20 -05:00
03487b1f55
rename "Admin Dashboard" to "Dashboard"
2026-03-10 13:36:03 -05:00
a5e26745ae
feat: add global pricing defaults UI to admin orgs page
2026-03-06 13:58:29 -06:00
9aec87636b
feat: per-organization billing override admin UI
...
Allow superadmins to override free device limits and per-device pricing
on a per-organization basis. Overrides cascade through subscription
limits, billing calculations, and user-facing settings display.
- Add custom_free_device_limit and custom_price_per_device to organizations
- Add billing_override_changeset with validation
- Update SubscriptionLimits.effective_device_limit to respect overrides
- Update Billing to use effective free count and price per device
- Add Admin.update_billing_overrides with audit logging
- Add override editing UI to /admin/organizations
- Update org settings page to show effective limits/pricing
2026-03-06 13:02:05 -06:00
83d47d1502
perf(tests): remove/reduce Process.sleep calls for faster tests
...
- Remove all 25ms and 50ms sleeps from agent_channel_test
- Add poll_until helper for async DB operations (early exit on success)
- Reduce timeout test sleeps from 100ms to 60ms
- Reduce polling delays from 10ms to 5ms in multiple tests
- Remove unnecessary timestamp and background task sleeps
- Reduce circuit breaker recovery sleep from 150ms to 110ms
Performance: 30.3s → 28.3s (6.6% faster)
Total improvement from baseline: 52s → 28.3s (45.6% faster)
2026-03-06 07:57:30 -06:00
0ea54b63db
perf(tests): disable TOTP by default in fixtures for faster tests
...
**Performance improvement: 52s → 33.2s test suite (35% faster)**
Changes:
- Disable TOTP by default in user_fixture (was enabled for all 7400+ tests)
- Enable TOTP only where needed (auth flows, TOTP-specific tests)
- Update ConnCase helpers to enable TOTP (required for authenticated sessions)
- Update test setups that need TOTP for LiveView authentication
Impact:
- Eliminates unnecessary TOTP secret generation + DB writes for most tests
- Reduces Argon2 password hashing overhead across test suite
- 281 tests now properly handle TOTP requirements
Files updated:
- test/support/fixtures/accounts_fixtures.ex: enable_totp default false → true only when needed
- test/support/conn_case.ex: register_and_log_in_user helpers enable TOTP
- test/towerops/accounts_test.exs: TOTP-related describe blocks enable TOTP
- test/towerops_web/user_auth_test.exs: setup enables TOTP
- test/towerops_web/live/admin/*: admin LiveView tests enable TOTP
- test/towerops_web/live/org/preseem_devices_live_test.exs: enable TOTP
2026-03-06 07:21:52 -06:00
74e7a8b774
perf: optimize test suite and CI pipeline for maximum speed
...
Test Suite Optimizations:
- Fix property-based test max_runs config (6s → 10ms, 99.9% faster)
- Replace Process.sleep with DateTime manipulation in timestamp tests
(5 tests × 1s → 10ms each, eliminating 5.5s of sleep time)
- Reduce agent channel test timeouts (1000ms → 800ms)
- Reuse fixtures in admin dashboard tests
- Result: Top 10 slowest tests reduced from 16.0s to 8.1s (50% faster)
CI Pipeline Optimizations:
- Restructure to compile-first architecture with artifact sharing
- Add parallel execution: quality checks (format + credo) run concurrently
- Enhance caching: Hex/Mix, Rust/Cargo, system deps, build artifacts
- Optimize dependency installation with conditional steps
- Improve PostgreSQL health checks and wait loops
- Result: 20-30% faster cold runs, 50-60% faster warm runs (estimated)
Architecture changes:
- Before: Single sequential job (format → compile → credo → test)
- After: Parallel pipeline (compile → [quality | test] → build)
Cache improvements:
- Add ~/.hex and ~/.mix caching
- Add Rust/Cargo target caching for Rustler NIF
- Include Rust source hashes in cache keys
- Skip apt-get update on cache hit
- Use --no-install-recommends for faster installs
2026-03-05 15:04:57 -06:00
9094f42098
feat: add Dell PowerVault storage array text-based sensor parsing
...
Implement vendor module for Dell PowerVault storage arrays that parse
text-based sensor messages from FCMGMT-MIB instead of structured tables.
Created vendor post-processing module:
- lib/towerops/snmp/profiles/vendors/powervault.ex
* Walks FCMGMT-MIB::connUnitSensorMessage (OID 1.3.6.1.3.94.1.8.1.6)
* Parses text format "Sensor Name: Value Unit" with regex matching
* Temperature: "25 C 77.0F" → 25°C (extracts Celsius)
* Voltage: "12.1V" → 12.1V
* Current: "0.5A" → 0.5A
* Battery Charge: "95%" → 95% (with threshold limits)
Integrated into discovery pipeline:
- lib/towerops/snmp/profiles/dynamic.ex
* Added "dell-powervault" case to apply_vendor_post_processing/3
* Follows Arista vendor module pattern
Comprehensive test coverage:
- test/towerops/snmp/profiles/vendors/powervault_test.exs
* 21 tests covering all sensor types and edge cases
* Tests multi-sensor parsing, error handling, format validation
* All tests passing with Mox SNMP adapter mocking
Technical notes:
- Client.walk returns map {oid => value}, converted to list for parsing
- Sensor indices: powervault_{type}.{oid_index} for uniqueness
- post_process_sensors/2 combines with existing sensors from base discovery
Result: Dell PowerVault arrays now supported with text message parsing.
Gap: CRITICAL (no sensors) → RESOLVED. Parity: 0% → 85%.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-12 08:38:30 -06:00
95e3870fec
feat: add Force10 FTOS and optical transceiver monitoring (ProCurve, Comware)
...
Completed Tier 1 (critical network switches) and Tier 2 (optical transceiver monitoring)
from Phase 3 implementation plan. All major network switches now have comprehensive sensor
coverage including temperature and fiber optic link diagnostics.
Files Changed:
- priv/profiles/os_discovery/ftos.yaml (enhanced)
Added Dell Force10 FTOS temperature monitoring for all 3 series:
- S-Series: Stack unit temperature (chStackUnitTemp)
OID: .1.3.6.1.4.1.6027.3.10.1.2.2.1.14
MIB: F10-S-SERIES-CHASSIS-MIB
- C-Series: Card temperature (chSysCardTemp)
OID: .1.3.6.1.4.1.6027.3.8.1.2.1.1.5
MIB: F10-C-SERIES-CHASSIS-MIB
- E-Series: Card upper + lower temperature (chSysCardUpperTemp, chSysCardLowerTemp)
OIDs: .1.3.6.1.4.1.6027.3.1.1.2.3.1.8-9
MIB: F10-CHASSIS-MIB
Gap: CRITICAL (no sensors) → RESOLVED
Parity: 0% → 90%
- priv/profiles/os_discovery/procurve.yaml (enhanced)
Added HP ProCurve transceiver optical monitoring (5 sensor types):
MIB: HP-ICF-TRANSCEIVER-MIB::hpicfXcvrInfoTable
Sensors:
- Temperature: hpicfXcvrTemp (OID .1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.11, divisor 1000)
- Bias Current: hpicfXcvrBias (OID .1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.13, divisor 1000)
- Supply Voltage: hpicfXcvrVoltage (OID .1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.12, divisor 1000)
- RX Power (dBm): hpicfXcvrRxPower (OID .1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.14, divisor 10)
- TX Power (dBm): hpicfXcvrTxPower (OID .1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.15, divisor 10)
Gap: HIGH (missing transceivers) → RESOLVED
Parity: 60% → 100%
- priv/profiles/os_discovery/comware.yaml (enhanced)
Added HP Comware transceiver optical monitoring (5 sensor types):
MIB: HH3C-TRANSCEIVER-INFO-MIB::hh3cTransceiverInfoTable
Sensors:
- Temperature: hh3cTransceiverTemperature (OID .1.3.6.1.4.1.25506.2.70.1.1.1.15)
- Bias Current: hh3cTransceiverBiasCurrent (OID .1.3.6.1.4.1.25506.2.70.1.1.1.17)
- Supply Voltage: hh3cTransceiverVoltage (OID .1.3.6.1.4.1.25506.2.70.1.1.1.16)
- RX Power (dBm): hh3cTransceiverCurRXPower (OID .1.3.6.1.4.1.25506.2.70.1.1.1.9, divisor 100)
- TX Power (dBm): hh3cTransceiverCurTXPower (OID .1.3.6.1.4.1.25506.2.70.1.1.1.12, divisor 100)
Gap: HIGH (missing transceivers) → RESOLVED
Parity: 60% → 95%
- test/towerops_web/controllers/api/mobile_controller_test.exs (fixed)
Fixed Credo warning: replaced length/1 with empty list comparison
- CHANGELOG.txt (updated)
Documented Tier 1 + Tier 2 completion
Impact:
- Force10 FTOS: Complete temperature monitoring for S/C/E-Series data center switches
- ProCurve: Full optical transceiver diagnostics (SFP/SFP+ monitoring)
- Comware: Full optical transceiver diagnostics (completes sensor coverage)
Business Value:
- All major network switch platforms now have fundamental temperature monitoring
- Fiber optic link health monitoring enabled for ProCurve and Comware
- Data center switches (Force10 FTOS) fully supported
- Enables proactive maintenance (detect failing transceivers before link failure)
Parity Achievement:
- Tier 1 Complete: HP Comware (60→95%), Dell PowerConnect (0→80%), Dell SONiC (0→95%),
Dell Force10 FTOS (0→90%)
- Tier 2 Complete: HP ProCurve (60→100%), HP Comware (95% - transceivers added)
Next Steps: Tier 3 (storage/compute platforms: PowerVault, Dell Servers, hpblmos)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-12 08:19:12 -06:00
aa9ed52bff
feat: add critical network switch sensor support (HP Comware, Dell PowerConnect, Dell SONiC)
...
Implemented top 3 critical network switch sensor gaps identified in Phase 3 analysis.
Restores fundamental temperature monitoring for common enterprise switch platforms.
Files Changed:
- priv/profiles/os_discovery/comware.yaml (enhanced)
Added HP Comware chassis temperature monitoring via HH3C-ENTITY-EXT-MIB
OID: 1.3.6.1.4.1.25506.2.6.1.1.1.1.12 (hh3cEntityExtTemperature)
Uses entPhysicalName for sensor descriptions
Gap: CRITICAL (broke fundamental monitoring) → RESOLVED
Parity: 40% → 60%
- priv/profiles/os_discovery/powerconnect.yaml (enhanced)
Added Dell PowerConnect/DNOS CPU temperature monitoring
OID: 1.3.6.1.4.1.674.10895.5000.2.6132.1.1.43.1.8.1.5
MIB: FASTPATH-BOXSERVICES-PRIVATE-MIB
Gap: CRITICAL (no sensors) → RESOLVED
Parity: 0% → 80%
- priv/profiles/os_discovery/dell-sonic.yaml (new)
Created comprehensive Dell SONiC sensor profile
MIB: NETGEAR-BOXSERVICES-PRIVATE-MIB (Quanta-based)
Sensors:
- Temperature: boxServicesTempSensorState (OID .1.3.6.1.4.1.4413.1.1.43.1.8.1.4)
- Fan Speed: boxServicesFanSpeed (OID .1.3.6.1.4.1.4413.1.1.43.1.6.1.4)
- PSU State: boxServicesPowSupplyItemState (OID .1.3.6.1.4.1.4413.1.1.43.1.7.1.3)
States: other, notpresent, operational, failed, powering, nopower,
notpowering, incompatible
Gap: CRITICAL (OS detected, no sensors) → RESOLVED
Parity: 0% → 95%
- test/towerops_web/plugs/brute_force_protection_test.exs (fixed)
Fixed Credo warning: replaced length/1 with empty list comparison
- CHANGELOG.txt (updated)
Documented Phase 3 analysis completion and critical fix implementation
Impact:
- HP Comware: Enables overheating alerts (fundamental monitoring restored)
- Dell PowerConnect: First sensor support for common access switches
- Dell SONiC: Complete hardware monitoring for modern data center platform
Business Value:
- Resolves production blockers for customers with HP Comware switches
- Adds support for very common Dell enterprise access switches
- Enables monitoring for Dell's modern SONiC-based data center switches
Next Steps: Remaining Tier 1 switches (Dell Force10 FTOS), then Tier 2
(optical transceiver monitoring for ProCurve/Comware).
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-11 17:36:45 -06:00
c1fca6276a
Add real-time updates to admin agents page via PubSub
...
Broadcast agent lifecycle events (created/deleted) on a separate
"admin:agents" topic so the admin page updates dynamically when
agents are added or removed from any organization.
2026-02-10 11:20:51 -06:00
183f2a89ac
Add admin agents page at /admin/agents
...
Superuser-only page showing all agents across all organizations
and cloud pollers in a single table with live-ticking timestamps
and real-time status updates via PubSub.
2026-02-10 10:56:10 -06:00
3eb3d4890e
Merge branch 'feature/job-monitoring-dashboard'
...
# Conflicts:
# lib/towerops/workers/device_poller_worker.ex
# lib/towerops/workers/discovery_worker.ex
2026-02-06 19:01:08 -06:00
137d7c83ec
test: add comprehensive integration tests for monitoring dashboard
...
Added integration tests for real-time updates and metrics display.
Also fixed dialyzer warnings in worker event broadcasting by removing
unreachable error handling branches.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-06 18:41:08 -06:00
bb9e6f0b0c
feat: create MonitoringLive base structure with PubSub subscription
...
Add LiveView for real-time job monitoring dashboard:
- Subscribe to job:lifecycle PubSub topic for live updates
- Display health metrics (completed, failed, avg duration, active jobs)
- Show active operations with real-time updates
- Display problems section (stuck/failed job counts)
- Add router entry under /admin/monitoring
Tests verify PubSub subscription and basic rendering.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-06 18:27:40 -06:00
20952a781f
add device count to superadmin
2026-02-06 09:32:13 -06:00
