towerops

graham/towerops

Fork 0

Commit graph

Author	SHA1	Message	Date
Graham McIntire	4ea64cb550	test: lift coverage from 85.84% → 86.28% Adds focused tests across multiple modules to push toward the 87% threshold: - CoreComponents: pagination/1 (multi-page, ellipsis, params), list/1 (slot rendering), and signal_badge/1 across all RSSI bands. - ApiDocs/GraphQLDocs controllers: bypass-the-router pattern so the "scope-with-organization" branches are actually exercised (the public routes are unscoped, so the org branch is unreachable via get/2). - Mix.Tasks.Unused: text + JSON output, --only / --skip filters. - Mix.Tasks.JobCleanupTask: prod path with phoenix snmp enabled vs disabled (uses :job_cleanup_settle_ms = 0 to avoid the 1s sleep). - Member resolver: success path for remove/update_role on non-owner membership, and the changeset-error branch for an invalid role. - Check resolver: unauthenticated fallback clauses for list / get / create / update / delete. - RfLinks: nil-signal sort ordering, :unknown classification for nil/nil signal+snr, :degraded filter, capacity_utilization edge cases (max_rate 0/missing, both rates nil). - StatusHelpers: status_emoji + title_with_status across green / red branches (warning is unreachable given the active-alerts query). - ApiTokens: spawn_async_update/2 path with env != :test. - ImpactAnalysis: to_json/1 across nil and populated levels. - Maintenance: query helpers (default-arity wrappers, active range) and Show LiveView delete event redirecting to /maintenance. - Coverage map: probe_point event handler. - InvitationQuery: default-arity pending/1.	2026-05-08 17:44:18 -05:00
Graham McIntire	4b2bc4f739	test: lift coverage 79.59% → 79.85% with more focused tests - TraceLive.Index: mount + search/select/clear handlers + format helpers - MikrotikBackupLive.Compare: full mount/handle_params/download_config flow - ConfigTimelineLive: redirect + render + select_range/close_event - Admin.UserLive.Index: impersonate redirect + delete_user happy/error - Snmp.Vlans: list/get coverage - DnsExecutor: AAAA/MX/TXT/CNAME query branches - PagerDuty.Client: device_up/unknown alert_type severity branches - Resolvers.Device: create/update/delete/metrics/interfaces happy + error	2026-05-07 19:16:13 -05:00
Graham McIntire	2e399953c1	test: expand coverage across resolvers, vendors, controllers, workers Add focused tests across many modules to push overall coverage from 75.45% to ~77%. New test files: - test/towerops/snmp/topology_test.exs - test/towerops/vault_test.exs - test/towerops/workers/check_worker_test.exs - test/towerops_web/graphql/resolvers/happy_path_test.exs - test/towerops_web/graphql/schema_test.exs - test/towerops_web/live/reports_live_test.exs Expanded existing tests for: Airos vendor, ProfileWatcher, StormDetector, LLDP, GpsSync, MikrotikBackupWorker, AdminController, MibController, MobileController, GeoipController, OnboardingLive, UserResetPasswordLive, SessionManager, Telemetry, CoverageLive.Show. Also fix a pre-existing dead test in ApplicationSettingTest where the schema default for value_type made the 'invalid without value_type' test unreachable.	2026-05-07 14:23:58 -05:00

Author

SHA1

Message

Date

Graham McIntire

4ea64cb550

test: lift coverage from 85.84% → 86.28%

Adds focused tests across multiple modules to push toward the 87% threshold:

- CoreComponents: pagination/1 (multi-page, ellipsis, params),
  list/1 (slot rendering), and signal_badge/1 across all RSSI bands.
- ApiDocs/GraphQLDocs controllers: bypass-the-router pattern so the
  "scope-with-organization" branches are actually exercised (the public
  routes are unscoped, so the org branch is unreachable via get/2).
- Mix.Tasks.Unused: text + JSON output, --only / --skip filters.
- Mix.Tasks.JobCleanupTask: prod path with phoenix snmp enabled vs
  disabled (uses :job_cleanup_settle_ms = 0 to avoid the 1s sleep).
- Member resolver: success path for remove/update_role on non-owner
  membership, and the changeset-error branch for an invalid role.
- Check resolver: unauthenticated fallback clauses for list / get /
  create / update / delete.
- RfLinks: nil-signal sort ordering, :unknown classification for
  nil/nil signal+snr, :degraded filter, capacity_utilization edge
  cases (max_rate 0/missing, both rates nil).
- StatusHelpers: status_emoji + title_with_status across green / red
  branches (warning is unreachable given the active-alerts query).
- ApiTokens: spawn_async_update/2 path with env != :test.
- ImpactAnalysis: to_json/1 across nil and populated levels.
- Maintenance: query helpers (default-arity wrappers, active range)
  and Show LiveView delete event redirecting to /maintenance.
- Coverage map: probe_point event handler.
- InvitationQuery: default-arity pending/1.

2026-05-08 17:44:18 -05:00

Graham McIntire

4b2bc4f739

test: lift coverage 79.59% → 79.85% with more focused tests

- TraceLive.Index: mount + search/select/clear handlers + format helpers
- MikrotikBackupLive.Compare: full mount/handle_params/download_config flow
- ConfigTimelineLive: redirect + render + select_range/close_event
- Admin.UserLive.Index: impersonate redirect + delete_user happy/error
- Snmp.Vlans: list/get coverage
- DnsExecutor: AAAA/MX/TXT/CNAME query branches
- PagerDuty.Client: device_up/unknown alert_type severity branches
- Resolvers.Device: create/update/delete/metrics/interfaces happy + error

2026-05-07 19:16:13 -05:00

Graham McIntire

2e399953c1

test: expand coverage across resolvers, vendors, controllers, workers

Add focused tests across many modules to push overall coverage from
75.45% to ~77%.

New test files:
- test/towerops/snmp/topology_test.exs
- test/towerops/vault_test.exs
- test/towerops/workers/check_worker_test.exs
- test/towerops_web/graphql/resolvers/happy_path_test.exs
- test/towerops_web/graphql/schema_test.exs
- test/towerops_web/live/reports_live_test.exs

Expanded existing tests for: Airos vendor, ProfileWatcher, StormDetector,
LLDP, GpsSync, MikrotikBackupWorker, AdminController, MibController,
MobileController, GeoipController, OnboardingLive, UserResetPasswordLive,
SessionManager, Telemetry, CoverageLive.Show.

Also fix a pre-existing dead test in ApplicationSettingTest where the
schema default for value_type made the 'invalid without value_type' test
unreachable.

2026-05-07 14:23:58 -05:00

3 commits