towerops

graham/towerops

Fork 0

Commit graph

Author	SHA1	Message	Date
Graham McIntire	2653e2516d	dialyzer: expand PLT, drop blanket codebase suppression Ignore file was silencing every warning under lib/towerops/**. Root cause was plt_add_deps: :apps_direct missing Plug/Phoenix/Oban/Decimal /Redix/ssl/public_key — hundreds of false `unknown_function` warnings were being papered over. Expand plt_add_apps to cover the common deps, narrow the ignore file to real dep-PLT gaps only, and fix two concrete bugs uncovered by the change: - ScopedResource.fetch_preload/4: spec was atom() \| [atom()] but callers pass keyword lists (e.g. [rules: :targets]). - ToweropsNative: tag NIF stubs with @dialyzer :nowarn_function so dialyzer trusts the @spec instead of the fallback body. Remaining 328 real warnings surface for follow-up.	2026-04-21 09:33:22 -05:00
Graham McIntire	532d88ffb9	perf: disable Req retry for faster error tests - Add retry: false to VISP Client HTTP requests - Add retry: false to ReleaseChecker GitHub API requests - Remove unused Plug.Conn import from RemoteIpLogger - Remove unused default parameter from req_get/2 Results: - VISP sync test: 7007ms → 113ms (62x faster) - ReleaseChecker test: 7004ms → 17ms (402x faster) - UserResetPasswordLive test: 1495ms → 284ms (5x faster) Req's default retry behavior (1s, 2s, 4s exponential backoff) was causing 7-second delays for HTTP 500/503 error responses in tests. For these clients, immediate failure is preferred over retries.	2026-03-10 16:19:31 -05:00

Author

SHA1

Message

Date

Graham McIntire

2653e2516d

dialyzer: expand PLT, drop blanket codebase suppression

Ignore file was silencing every warning under lib/towerops/**. Root
cause was plt_add_deps: :apps_direct missing Plug/Phoenix/Oban/Decimal
/Redix/ssl/public_key — hundreds of false `unknown_function` warnings
were being papered over.

Expand plt_add_apps to cover the common deps, narrow the ignore file
to real dep-PLT gaps only, and fix two concrete bugs uncovered by the
change:

- ScopedResource.fetch_preload/4: spec was atom() | [atom()] but
  callers pass keyword lists (e.g. [rules: :targets]).
- ToweropsNative: tag NIF stubs with @dialyzer :nowarn_function so
  dialyzer trusts the @spec instead of the fallback body.

Remaining 328 real warnings surface for follow-up.

2026-04-21 09:33:22 -05:00

Graham McIntire

532d88ffb9

perf: disable Req retry for faster error tests

- Add retry: false to VISP Client HTTP requests
- Add retry: false to ReleaseChecker GitHub API requests
- Remove unused Plug.Conn import from RemoteIpLogger
- Remove unused default parameter from req_get/2

Results:
- VISP sync test: 7007ms → 113ms (62x faster)
- ReleaseChecker test: 7004ms → 17ms (402x faster)
- UserResetPasswordLive test: 1495ms → 284ms (5x faster)

Req's default retry behavior (1s, 2s, 4s exponential backoff) was
causing 7-second delays for HTTP 500/503 error responses in tests.
For these clients, immediate failure is preferred over retries.

2026-03-10 16:19:31 -05:00

2 commits