graham/towerops
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
814 commits 1 branch 0 tags 50 MiB
Commit graph

9 commits

Author SHA1 Message Date
Graham McIntire
6aab59dcf5
refactor: centralize LiveView access control checks 
Extract duplicate access control logic from multiple LiveView files into
a reusable AccessControl helper module.

**Changes:**
- NEW: lib/towerops_web/live/helpers/access_control.ex
- NEW: test/towerops_web/live/helpers/access_control_test.exs
- Refactor device_live/index.ex to use AccessControl.verify_site_access/2
  and verify_device_access/2
- Refactor device_live/form.ex to use AccessControl.verify_device_access/2
- Refactor alert_live/index.ex to use AccessControl.verify_alert_access/2
- Refactor device_live/show.ex to use AccessControl.verify_device_access/2
- Remove unused Repo aliases from refactored files

**Benefits:**
- Reduces code duplication across 7+ locations
- Centralizes security-critical access checks
- Improves testability (helper module has >90% coverage)
- Consistent error handling across all LiveViews

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
 2026-02-04 17:51:05 -06:00
Graham McIntire
89a076fb67
feat: migrate equipment features to gettext and fix sudo mode tests 
Migrates all equipment-related flash messages to gettext for internationalization:
- DeviceLive.Index: device discovery, reordering, error messages
- DeviceLive.Show: backup messages, permission errors
- DeviceLive.Form: device CRUD operations
- AlertLive.Index: alert acknowledgment messages
- SiteLive.Show: site discovery messages
- SiteLive.Form: site CRUD and SNMP/agent propagation

Fixes sudo mode test suite issues:
- Updates Accounts.sudo_mode?/2 test to check last_sudo_at instead of authenticated_at
- Adds register_and_log_in_user_with_sudo/1 helper to ConnCase
- Fixes UserAuth sudo mode tests to use session-based authentication
- Updates MyData tests to use sudo mode (now required per router config)
- Removes obsolete UserSettingsLive "without sudo mode" test
- Fixes grant_sudo_mode/1 DateTime truncation to seconds

All equipment module tests passing. Ready for Phase 3 (Admin Features).
 2026-02-02 12:41:58 -06:00
Graham McIntire
8e739283ad refactoring 2026-01-29 10:03:43 -06:00
Graham McIntire
58b1aa50c2 security fixes 2026-01-28 16:55:41 -06:00
Graham McIntire
d81b025282
Make Active Alerts the first and default tab in alerts page 
Changed the default filter from 'all' to 'active' and reordered tabs
so Active Alerts appears first (leftmost) in the tab bar
 2026-01-17 17:16:35 -06:00
Graham McIntire
a810e75fc4
rename equipment to device 2026-01-17 14:48:46 -06:00
Graham McIntire
c88f2bbf96
Make active alerts the default tab 
Change the default filter from 'all' to 'active' on the alerts page.
This shows only active alerts by default, which is more useful for
monitoring current issues. Users can still click 'All Alerts' to see
the complete history.
 2026-01-17 12:55:03 -06:00
Graham McIntire
0f9266027f
fix dialyzer things 2026-01-03 12:56:40 -06:00
Graham McIntire
fd5c6b3d72
more tests 2025-12-21 17:29:01 -06:00