+ Raw SNMP OID values collected during the last discovery run at + <%= if @snmp_device.last_discovery_at do %> + {Calendar.strftime(@snmp_device.last_discovery_at, "%Y-%m-%d %H:%M:%S UTC")} + <% else %> + unknown time + <% end %>. +
+| + Field + | ++ OID + | ++ Value + | +
|---|---|---|
| + {key} + | ++ {data["oid"]} + | +
+ {inspect(data["value"])}
+ |
+
| + OID + | ++ Value + | +
|---|---|
| + {oid} + | +
+ {inspect(value)}
+ |
+
+ Click the text box to select all data, then copy with Cmd+C or Ctrl+C +
++ No raw discovery data available. Run discovery again to collect debug data. +
+Tab not found
diff --git a/priv/repo/migrations/20260119162749_add_mikrotik_resource_sensors.exs b/priv/repo/migrations/20260119162749_add_mikrotik_resource_sensors.exs new file mode 100644 index 00000000..28e29cee --- /dev/null +++ b/priv/repo/migrations/20260119162749_add_mikrotik_resource_sensors.exs @@ -0,0 +1,23 @@ +defmodule Towerops.Repo.Migrations.AddMikrotikResourceSensors do + use Ecto.Migration + + def up do + # Disable the database MikroTik profile to use the hardcoded profile instead + # The hardcoded profile has comprehensive sensor discovery including: + # - CPU load (per core) + # - Memory and storage (via HOST-RESOURCES-MIB walks) + # - DHCP leases + # - Connection tracking + # - POE sensors + # - Optical/SFP sensors + # + # The database profile system doesn't yet support table walks, + # so we fall back to the hardcoded profile for full discovery. + execute("UPDATE device_profiles SET enabled = false WHERE name = 'mikrotik'") + end + + def down do + # Re-enable the database profile + execute("UPDATE device_profiles SET enabled = true WHERE name = 'mikrotik'") + end +end diff --git a/priv/repo/migrations/20260119163701_add_raw_discovery_data_to_snmp_devices.exs b/priv/repo/migrations/20260119163701_add_raw_discovery_data_to_snmp_devices.exs new file mode 100644 index 00000000..c9b83071 --- /dev/null +++ b/priv/repo/migrations/20260119163701_add_raw_discovery_data_to_snmp_devices.exs @@ -0,0 +1,10 @@ +defmodule Towerops.Repo.Migrations.AddRawDiscoveryDataToSnmpDevices do + use Ecto.Migration + + def change do + alter table(:snmp_devices) do + add :raw_discovery_data, :map + add :last_discovery_at, :utc_datetime + end + end +end diff --git a/test/towerops/snmp/discovery_test.exs b/test/towerops/snmp/discovery_test.exs index 3e4fe95c..bdc7c011 100644 --- a/test/towerops/snmp/discovery_test.exs +++ b/test/towerops/snmp/discovery_test.exs @@ -51,14 +51,10 @@ defmodule Towerops.Snmp.DiscoveryTest do snmp_port: 161 }) - # Mock successful connection test - expect(SnmpMock, :get, fn _, "1.3.6.1.2.1.1.3.0", _ -> - {:ok, {:timeticks, 12_345}} - end) - - # Mock system info discovery - expect(SnmpMock, :get, 6, fn _, oid, _ -> + # Mock all GET calls (connection test + system info + interfaces + health + network sensors) + stub(SnmpMock, :get, fn _, oid, _ -> case oid do + # Connection test + Base system info "1.3.6.1.2.1.1.1.0" -> {:ok, {:octet_string, "RouterOS RB750"}} @@ -77,77 +73,114 @@ defmodule Towerops.Snmp.DiscoveryTest do "1.3.6.1.2.1.1.6.0" -> {:ok, {:octet_string, "Data Center"}} + # MikroTik-specific system info + "1.3.6.1.4.1.14988.1.1.7.3.0" -> + {:ok, {:octet_string, "1234567890"}} + + "1.3.6.1.4.1.14988.1.1.7.4.0" -> + {:ok, {:octet_string, "7.13.2"}} + + "1.3.6.1.4.1.14988.1.1.7.9.0" -> + {:ok, {:octet_string, "RB750Gr3"}} + + "1.3.6.1.4.1.14988.1.1.7.8.0" -> + {:ok, {:octet_string, "Main Router"}} + + "1.3.6.1.4.1.14988.1.1.7.5.0" -> + {:ok, {:integer, 6}} + + # Network sensors (MikroTik-specific) + "1.3.6.1.4.1.14988.1.1.1.3.0" -> + {:ok, {:integer, 10}} + + "1.3.6.1.4.1.14988.1.1.13.1.1.1.0" -> + {:ok, {:integer, 500}} + + # Catch-all for interface data and health sensors _ -> - {:error, :no_such_object} + cond do + # Health sensor OIDs (all return error for this test) + String.starts_with?(oid, "1.3.6.1.4.1.14988.1.1.3.") and + not String.contains?(oid, "1.3.6.1.4.1.14988.1.1.13") -> + {:error, :no_such_object} + + # Interface 1 data + String.ends_with?(oid, ".1") -> + parts = String.split(oid, ".") + second_to_last = Enum.at(parts, -2) + + cond do + second_to_last == "2" -> {:ok, {:octet_string, "ether1"}} + second_to_last == "3" -> {:ok, {:integer, 6}} + second_to_last == "5" -> {:ok, {:gauge32, 1_000_000_000}} + second_to_last == "6" -> {:ok, {:octet_string, <<0x00, 0x11, 0x22, 0x33, 0x44, 0x55>>}} + second_to_last == "7" -> {:ok, {:integer, 1}} + second_to_last == "8" -> {:ok, {:integer, 1}} + second_to_last == "1" and String.contains?(oid, "31.1.1.1") -> {:ok, {:octet_string, "ether1"}} + second_to_last == "18" and String.contains?(oid, "31.1.1.1") -> {:ok, {:octet_string, "WAN"}} + true -> {:error, :no_such_object} + end + + # Interface 2 data + String.ends_with?(oid, ".2") -> + parts = String.split(oid, ".") + second_to_last = Enum.at(parts, -2) + + cond do + second_to_last == "2" -> {:ok, {:octet_string, "ether2"}} + second_to_last == "3" -> {:ok, {:integer, 6}} + second_to_last == "5" -> {:ok, {:gauge32, 1_000_000_000}} + second_to_last == "6" -> {:ok, {:octet_string, <<0x00, 0x11, 0x22, 0x33, 0x44, 0x56>>}} + second_to_last == "7" -> {:ok, {:integer, 1}} + second_to_last == "8" -> {:ok, {:integer, 1}} + second_to_last == "1" and String.contains?(oid, "31.1.1.1") -> {:ok, {:octet_string, "ether2"}} + second_to_last == "18" and String.contains?(oid, "31.1.1.1") -> {:ok, {:octet_string, "LAN"}} + true -> {:error, :no_such_object} + end + + true -> + {:error, :no_such_object} + end end end) - # Mock interface discovery - expect(SnmpMock, :walk, fn _, "1.3.6.1.2.1.2.2.1.1", _ -> - {:ok, - [ - %{oid: "1.3.6.1.2.1.2.2.1.1.1", value: {:integer, 1}}, - %{oid: "1.3.6.1.2.1.2.2.1.1.2", value: {:integer, 2}} - ]} - end) - - # Mock interface data fetches for each interface - expect(SnmpMock, :get, 16, fn _, oid, _ -> - cond do - String.ends_with?(oid, ".1") -> - parts = String.split(oid, ".") - second_to_last = Enum.at(parts, -2) - - cond do - second_to_last == "2" -> {:ok, {:octet_string, "ether1"}} - second_to_last == "3" -> {:ok, {:integer, 6}} - second_to_last == "5" -> {:ok, {:gauge32, 1_000_000_000}} - second_to_last == "6" -> {:ok, {:octet_string, <<0x00, 0x11, 0x22, 0x33, 0x44, 0x55>>}} - second_to_last == "7" -> {:ok, {:integer, 1}} - second_to_last == "8" -> {:ok, {:integer, 1}} - second_to_last == "1" and String.contains?(oid, "31.1.1.1") -> {:ok, {:octet_string, "ether1"}} - second_to_last == "18" and String.contains?(oid, "31.1.1.1") -> {:ok, {:octet_string, "WAN"}} - true -> {:error, :no_such_object} - end - - String.ends_with?(oid, ".2") -> - parts = String.split(oid, ".") - second_to_last = Enum.at(parts, -2) - - cond do - second_to_last == "2" -> {:ok, {:octet_string, "ether2"}} - second_to_last == "3" -> {:ok, {:integer, 6}} - second_to_last == "5" -> {:ok, {:gauge32, 1_000_000_000}} - second_to_last == "6" -> {:ok, {:octet_string, <<0x00, 0x11, 0x22, 0x33, 0x44, 0x56>>}} - second_to_last == "7" -> {:ok, {:integer, 1}} - second_to_last == "8" -> {:ok, {:integer, 1}} - second_to_last == "1" and String.contains?(oid, "31.1.1.1") -> {:ok, {:octet_string, "ether2"}} - second_to_last == "18" and String.contains?(oid, "31.1.1.1") -> {:ok, {:octet_string, "LAN"}} - true -> {:error, :no_such_object} - end - - true -> - {:error, :no_such_object} - end - end) - - # Note: Dynamic profile would try to discover device OIDs and sensor OIDs from database, - # but MibTranslator fails in tests (MIKROTIK-MIB not installed), so no get calls are made - - # Mock sensor discovery - MikroTik profiles make many walk calls for sensors - # CPU (1), storage (3), POE (4), optical (5), ENTITY-SENSOR-MIB (1) = 14 walks + # Mock all walk calls stub(SnmpMock, :walk, fn _, oid, _ -> - if String.starts_with?(oid, "1.3.6.1.2.1.99") do - {:ok, []} - else - {:error, :no_such_object} + cond do + # Interface discovery - return 2 interfaces + oid == "1.3.6.1.2.1.2.2.1.1" -> + {:ok, + [ + %{oid: "1.3.6.1.2.1.2.2.1.1.1", value: {:integer, 1}}, + %{oid: "1.3.6.1.2.1.2.2.1.1.2", value: {:integer, 2}} + ]} + + # ENTITY-SENSOR-MIB + String.starts_with?(oid, "1.3.6.1.2.1.99") -> + {:ok, []} + + # LLDP neighbor discovery + String.starts_with?(oid, "1.0.8802") -> + {:ok, []} + + # CDP neighbor discovery + String.starts_with?(oid, "1.3.6.1.4.1.9.9.23") -> + {:ok, []} + + # MikroTik health sensor table + String.starts_with?(oid, "1.3.6.1.4.1.14988.1.1.3.100") -> + {:ok, []} + + # Other walks (debug data collection, sensors, etc.) + true -> + {:ok, []} end end) assert {:ok, device} = Discovery.discover_device(device) assert device.manufacturer == "MikroTik" - assert device.model == "RouterOS RB750" + assert device.model == "RB750" assert device.sys_name == "router1" # Verify interfaces were created @@ -172,23 +205,18 @@ defmodule Towerops.Snmp.DiscoveryTest do snmp_port: 161 }) - # Mock successful connection test - expect(SnmpMock, :get, fn _, "1.3.6.1.2.1.1.3.0", _ -> - {:ok, {:timeticks, 54_321}} - end) - - # Mock system info discovery - expect(SnmpMock, :get, 6, fn _, oid, _ -> + # Mock all GET calls (connection test + system info + debug data) + stub(SnmpMock, :get, fn _, oid, _ -> case oid do + "1.3.6.1.2.1.1.3.0" -> + {:ok, {:timeticks, 54_321}} + "1.3.6.1.2.1.1.1.0" -> {:ok, {:octet_string, "Cisco IOS Software, C2960 Software"}} "1.3.6.1.2.1.1.2.0" -> {:ok, {:object_identifier, [1, 3, 6, 1, 4, 1, 9, 1, 1208]}} - "1.3.6.1.2.1.1.3.0" -> - {:ok, {:timeticks, 54_321}} - "1.3.6.1.2.1.1.4.0" -> {:ok, {:octet_string, "netadmin@cisco.com"}} @@ -203,10 +231,8 @@ defmodule Towerops.Snmp.DiscoveryTest do end end) - # Mock interface discovery - no interfaces for simplicity - # Walk called 5 times: interfaces (1), cisco sensors (1), base sensors fallback (1), - # LLDP neighbors (1), CDP neighbors (1) - expect(SnmpMock, :walk, 5, fn _, _, _ -> + # Mock all walk calls (debug data collection, interfaces, sensors, neighbors) + stub(SnmpMock, :walk, fn _, _, _ -> {:ok, []} end) @@ -249,14 +275,13 @@ defmodule Towerops.Snmp.DiscoveryTest do snmp_port: 161 }) - # Mock successful connection test - expect(SnmpMock, :get, fn _, "1.3.6.1.2.1.1.3.0", _ -> - {:ok, {:timeticks, 999}} - end) - - # Mock system info discovery - expect(SnmpMock, :get, 6, fn _, oid, _ -> + # Mock all GET calls (connection + system info + debug data) + # Connection: 1, System info: 6, Debug data: 6 = 13 total + stub(SnmpMock, :get, fn _, oid, _ -> case oid do + "1.3.6.1.2.1.1.3.0" -> + {:ok, {:timeticks, 999}} + "1.3.6.1.2.1.1.1.0" -> {:ok, {:octet_string, "Generic Device"}} @@ -265,23 +290,31 @@ defmodule Towerops.Snmp.DiscoveryTest do end end) - # Mock failed interface discovery - expect(SnmpMock, :walk, fn _, "1.3.6.1.2.1.2.2.1.1", _ -> - {:error, :timeout} - end) - - # Mock failed sensor discovery and neighbor discovery (LLDP + CDP) - expect(SnmpMock, :walk, 3, fn _, oid, _ -> + # Mock all walk calls in execution order: + # 1. Debug data collection happens first (inside build_device_info) + # 2. Then interface discovery + # 3. Then sensor discovery + # 4. Then neighbor discovery (LLDP + CDP) + stub(SnmpMock, :walk, fn _, oid, _ -> cond do + # Entity sensor queries (sensor discovery + debug entity_sensor_table) String.starts_with?(oid, "1.3.6.1.2.1.99") -> {:error, :timeout} + # Interface ifIndex + oid == "1.3.6.1.2.1.2.2.1.1" -> + {:error, :timeout} + + # LLDP - return empty String.starts_with?(oid, "1.0.8802") -> - # LLDP - return empty {:ok, []} + # CDP - return empty String.starts_with?(oid, "1.3.6.1.4.1.9.9.23") -> - # CDP - return empty + {:ok, []} + + # Debug data collection (if_table, ifx_table) + String.starts_with?(oid, "1.3.6.1.2.1") -> {:ok, []} true -> @@ -533,13 +566,14 @@ defmodule Towerops.Snmp.DiscoveryTest do end) # Mock interface and sensor discovery - no interfaces/sensors for simplicity - # Walk called 10 times: + # Walk called 15 times: # - LM sensors: temp devices (1), temp values (1), fan devices (1), fan values (1), # voltage devices (1), voltage values (1) # - Base sensors fallback (1) # - Interfaces (1) # - Neighbors: LLDP (1), CDP (1) - expect(SnmpMock, :walk, 10, fn _, _, _ -> + # - Debug data: lm_temp (1), lm_fan (1), lm_voltage (1), ucd_load (1), ucd_memory (1) + expect(SnmpMock, :walk, 15, fn _, _, _ -> {:ok, []} end) @@ -599,13 +633,14 @@ defmodule Towerops.Snmp.DiscoveryTest do end) # Mock interface and sensor discovery - # Walk called 10 times: + # Walk called 15 times: # - LM sensors: temp devices (1), temp values (1), fan devices (1), fan values (1), # voltage devices (1), voltage values (1) # - Base sensors fallback (1) # - Interfaces (1) # - Neighbors: LLDP (1), CDP (1) - expect(SnmpMock, :walk, 10, fn _, _, _ -> + # - Debug data: lm_temp (1), lm_fan (1), lm_voltage (1), ucd_load (1), ucd_memory (1) + expect(SnmpMock, :walk, 15, fn _, _, _ -> {:ok, []} end) diff --git a/test/towerops/snmp/profile_behaviour_test.exs b/test/towerops/snmp/profile_behaviour_test.exs index 9cfd17f0..b72c6d9b 100644 --- a/test/towerops/snmp/profile_behaviour_test.exs +++ b/test/towerops/snmp/profile_behaviour_test.exs @@ -60,7 +60,9 @@ defmodule Towerops.Snmp.ProfileBehaviourTest do case profile.discover_system_info(@test_opts) do {:ok, info} -> assert is_map(info) - assert map_size(info) > 0 + + # Some profiles return empty map (no additional info beyond Base) + # Others return profile-specific data (e.g., MikroTik, Ubiquiti) {:error, _reason} -> # Some profiles might fail if required data is missing diff --git a/test/towerops/snmp/profiles/cisco_test.exs b/test/towerops/snmp/profiles/cisco_test.exs index 13c9401a..e7c3b84b 100644 --- a/test/towerops/snmp/profiles/cisco_test.exs +++ b/test/towerops/snmp/profiles/cisco_test.exs @@ -11,33 +11,13 @@ defmodule Towerops.Snmp.Profiles.CiscoTest do @client_opts [ip: "192.168.1.1", community: "public", version: :v2c, port: 161] describe "discover_system_info/1" do - test "delegates to Base profile" do - # Mock the SNMP calls that Base.discover_system_info makes - # Base profile queries 6 system OIDs - match by OID string - expect(SnmpMock, :get, 6, fn _target, oid, _opts -> - case oid do - # sysDescr - "1.3.6.1.2.1.1.1.0" -> {:ok, "Cisco IOS Software"} - # sysObjectID - "1.3.6.1.2.1.1.2.0" -> {:ok, [1, 3, 6, 1, 4, 1, 9]} - # sysUpTime - "1.3.6.1.2.1.1.3.0" -> {:ok, 12_345} - # sysContact - "1.3.6.1.2.1.1.4.0" -> {:ok, "admin@example.com"} - # sysName - "1.3.6.1.2.1.1.5.0" -> {:ok, "test-device"} - # sysLocation - "1.3.6.1.2.1.1.6.0" -> {:ok, "Test Location"} - _ -> {:error, :unknown_oid} - end - end) - + test "returns empty map (no additional system info beyond Base)" do + # Cisco profile doesn't query additional system OIDs + # Base profile handles all standard system info discovery result = Cisco.discover_system_info(@client_opts) - # Should delegate to Base and return its result assert {:ok, system_info} = result - assert is_map(system_info) - assert system_info.sys_name == "test-device" + assert system_info == %{} end end diff --git a/test/towerops/snmp/profiles/mikrotik_test.exs b/test/towerops/snmp/profiles/mikrotik_test.exs index 25bd4004..b51b71c8 100644 --- a/test/towerops/snmp/profiles/mikrotik_test.exs +++ b/test/towerops/snmp/profiles/mikrotik_test.exs @@ -143,8 +143,9 @@ defmodule Towerops.Snmp.Profiles.MikrotikTest do describe "discover_sensors/1" do test "discovers health sensors (temperature, voltage, fan)" do - # Mock health sensor OIDs - expect(SnmpMock, :get, 15, fn _, oid, _ -> + # Mock health sensor OIDs + network sensors (DHCP leases, connection count) + # Health: 15 OIDs, Network: 2 OIDs = 17 total + expect(SnmpMock, :get, 17, fn _, oid, _ -> case oid do # Voltages "1.3.6.1.4.1.14988.1.1.3.1.0" -> {:ok, {:integer, 12}} @@ -166,31 +167,84 @@ defmodule Towerops.Snmp.Profiles.MikrotikTest do "1.3.6.1.4.1.14988.1.1.3.18.0" -> {:ok, {:integer, 0}} # Processor frequency "1.3.6.1.4.1.14988.1.1.3.14.0" -> {:ok, {:integer, 1400}} + # Network sensors + "1.3.6.1.4.1.14988.1.1.1.3.0" -> {:ok, {:integer, 42}} + "1.3.6.1.4.1.14988.1.1.13.1.1.1.0" -> {:ok, {:integer, 1500}} end end) # Mock all walk calls - use stub to allow any number of calls (code may short-circuit) stub(SnmpMock, :walk, fn _, oid, _ -> case oid do + # Health sensor table (new dynamic sensor discovery) + # SNMP adapter returns list of %{oid:, value:} maps + "1.3.6.1.4.1.14988.1.1.3.100.1.2" -> + {:ok, + [ + %{oid: "1.3.6.1.4.1.14988.1.1.3.100.1.2.1", value: "CPU Temperature"}, + %{oid: "1.3.6.1.4.1.14988.1.1.3.100.1.2.2", value: "Board Temperature"} + ]} + + "1.3.6.1.4.1.14988.1.1.3.100.1.3" -> + {:ok, + [ + %{oid: "1.3.6.1.4.1.14988.1.1.3.100.1.3.1", value: 450}, + %{oid: "1.3.6.1.4.1.14988.1.1.3.100.1.3.2", value: 480} + ]} + + "1.3.6.1.4.1.14988.1.1.3.100.1.4" -> + {:ok, + [ + %{oid: "1.3.6.1.4.1.14988.1.1.3.100.1.4.1", value: 1}, + %{oid: "1.3.6.1.4.1.14988.1.1.3.100.1.4.2", value: 1} + ]} + # CPU sensors - "1.3.6.1.2.1.25.3.3.1.2" -> {:ok, [%{oid: "1.3.6.1.2.1.25.3.3.1.2.1", value: 45}]} + "1.3.6.1.2.1.25.3.3.1.2" -> + {:ok, [%{oid: "1.3.6.1.2.1.25.3.3.1.2.1", value: 45}]} + # Storage sensors - "1.3.6.1.2.1.25.2.3.1.3" -> {:ok, [%{oid: "1.3.6.1.2.1.25.2.3.1.3.1", value: "RAM"}]} - "1.3.6.1.2.1.25.2.3.1.5" -> {:ok, [%{oid: "1.3.6.1.2.1.25.2.3.1.5.1", value: 1000}]} - "1.3.6.1.2.1.25.2.3.1.6" -> {:ok, [%{oid: "1.3.6.1.2.1.25.2.3.1.6.1", value: 750}]} + "1.3.6.1.2.1.25.2.3.1.3" -> + {:ok, [%{oid: "1.3.6.1.2.1.25.2.3.1.3.1", value: "RAM"}]} + + "1.3.6.1.2.1.25.2.3.1.5" -> + {:ok, [%{oid: "1.3.6.1.2.1.25.2.3.1.5.1", value: 1000}]} + + "1.3.6.1.2.1.25.2.3.1.6" -> + {:ok, [%{oid: "1.3.6.1.2.1.25.2.3.1.6.1", value: 750}]} + # POE sensors (empty) - "1.3.6.1.4.1.14988.1.1.15.1.1.3" -> {:error, :no_such_object} - "1.3.6.1.4.1.14988.1.1.15.1.1.5" -> {:error, :no_such_object} - "1.3.6.1.4.1.14988.1.1.15.1.1.6" -> {:error, :no_such_object} - "1.3.6.1.4.1.14988.1.1.15.1.1.7" -> {:error, :no_such_object} + "1.3.6.1.4.1.14988.1.1.15.1.1.3" -> + {:error, :no_such_object} + + "1.3.6.1.4.1.14988.1.1.15.1.1.5" -> + {:error, :no_such_object} + + "1.3.6.1.4.1.14988.1.1.15.1.1.6" -> + {:error, :no_such_object} + + "1.3.6.1.4.1.14988.1.1.15.1.1.7" -> + {:error, :no_such_object} + # Optical sensors (empty) - "1.3.6.1.4.1.14988.1.1.16.1.1.2" -> {:error, :no_such_object} - "1.3.6.1.4.1.14988.1.1.16.1.1.3" -> {:error, :no_such_object} - "1.3.6.1.4.1.14988.1.1.16.1.1.5" -> {:error, :no_such_object} - "1.3.6.1.4.1.14988.1.1.16.1.1.7" -> {:error, :no_such_object} - "1.3.6.1.4.1.14988.1.1.16.1.1.8" -> {:error, :no_such_object} + "1.3.6.1.4.1.14988.1.1.16.1.1.2" -> + {:error, :no_such_object} + + "1.3.6.1.4.1.14988.1.1.16.1.1.3" -> + {:error, :no_such_object} + + "1.3.6.1.4.1.14988.1.1.16.1.1.5" -> + {:error, :no_such_object} + + "1.3.6.1.4.1.14988.1.1.16.1.1.7" -> + {:error, :no_such_object} + + "1.3.6.1.4.1.14988.1.1.16.1.1.8" -> + {:error, :no_such_object} + # Entity sensors from Base - "1.3.6.1.2.1.99.1.1.1.1" -> {:ok, []} + "1.3.6.1.2.1.99.1.1.1.1" -> + {:ok, []} end end) @@ -217,8 +271,16 @@ defmodule Towerops.Snmp.Profiles.MikrotikTest do end test "discovers CPU load sensors" do - # Mock health sensors (none available) - expect(SnmpMock, :get, 15, fn _, _, _ -> {:error, :no_such_object} end) + # Mock health sensors (15, all return error) + network sensors (2) + expect(SnmpMock, :get, 17, fn _, oid, _ -> + case oid do + # Network sensors + "1.3.6.1.4.1.14988.1.1.1.3.0" -> {:ok, {:integer, 10}} + "1.3.6.1.4.1.14988.1.1.13.1.1.1.0" -> {:ok, {:integer, 500}} + # All health sensors return error + _ -> {:error, :no_such_object} + end + end) # Mock all walk calls stub(SnmpMock, :walk, fn _, oid, _ -> @@ -255,8 +317,16 @@ defmodule Towerops.Snmp.Profiles.MikrotikTest do end test "discovers storage sensors with proper status" do - # Mock health sensors (none) - expect(SnmpMock, :get, 15, fn _, _, _ -> {:error, :no_such_object} end) + # Mock health sensors (15, all return error) + network sensors (2) + expect(SnmpMock, :get, 17, fn _, oid, _ -> + case oid do + # Network sensors + "1.3.6.1.4.1.14988.1.1.1.3.0" -> {:ok, {:integer, 10}} + "1.3.6.1.4.1.14988.1.1.13.1.1.1.0" -> {:ok, {:integer, 500}} + # All health sensors return error + _ -> {:error, :no_such_object} + end + end) # Mock all walk calls stub(SnmpMock, :walk, fn _, oid, _ -> @@ -307,12 +377,30 @@ defmodule Towerops.Snmp.Profiles.MikrotikTest do end test "discovers POE sensors per port" do - # Mock health, cpu, storage as empty - expect(SnmpMock, :get, 15, fn _, _, _ -> {:error, :no_such_object} end) + # Mock health sensors (15, all return error) + network sensors (2) + expect(SnmpMock, :get, 17, fn _, oid, _ -> + case oid do + # Network sensors + "1.3.6.1.4.1.14988.1.1.1.3.0" -> {:ok, {:integer, 10}} + "1.3.6.1.4.1.14988.1.1.13.1.1.1.0" -> {:ok, {:integer, 500}} + # All health sensors return error + _ -> {:error, :no_such_object} + end + end) # Mock all walk calls stub(SnmpMock, :walk, fn _, oid, _ -> case oid do + # Health sensor table (checked before POE) + "1.3.6.1.4.1.14988.1.1.3.100.1.2" -> + {:ok, []} + + "1.3.6.1.4.1.14988.1.1.3.100.1.3" -> + {:ok, []} + + "1.3.6.1.4.1.14988.1.1.3.100.1.4" -> + {:ok, []} + # CPU sensors "1.3.6.1.2.1.25.3.3.1.2" -> {:ok, []} @@ -385,7 +473,7 @@ defmodule Towerops.Snmp.Profiles.MikrotikTest do assert result.manufacturer == "MikroTik" assert result.model == "RB5009UG+S+" - assert result.firmware_version == "Mikrotik RouterOS 7.13.2" + assert result.firmware_version == "RouterOS 7.13.2" end test "identifies generic RouterOS device when model not found" do @@ -426,7 +514,16 @@ defmodule Towerops.Snmp.Profiles.MikrotikTest do describe "sensor status determination" do test "CPU status changes with load" do - expect(SnmpMock, :get, 15, fn _, _, _ -> {:error, :no_such_object} end) + # Mock health sensors (15, all return error) + network sensors (2) + expect(SnmpMock, :get, 17, fn _, oid, _ -> + case oid do + # Network sensors + "1.3.6.1.4.1.14988.1.1.1.3.0" -> {:ok, {:integer, 10}} + "1.3.6.1.4.1.14988.1.1.13.1.1.1.0" -> {:ok, {:integer, 500}} + # All health sensors return error + _ -> {:error, :no_such_object} + end + end) stub(SnmpMock, :walk, fn _, oid, _ -> case oid do @@ -455,7 +552,16 @@ defmodule Towerops.Snmp.Profiles.MikrotikTest do end test "memory status changes with usage percentage" do - expect(SnmpMock, :get, 15, fn _, _, _ -> {:error, :no_such_object} end) + # Mock health sensors (15, all return error) + network sensors (2) + expect(SnmpMock, :get, 17, fn _, oid, _ -> + case oid do + # Network sensors + "1.3.6.1.4.1.14988.1.1.1.3.0" -> {:ok, {:integer, 10}} + "1.3.6.1.4.1.14988.1.1.13.1.1.1.0" -> {:ok, {:integer, 500}} + # All health sensors return error + _ -> {:error, :no_such_object} + end + end) stub(SnmpMock, :walk, fn _, oid, _ -> case oid do diff --git a/test/towerops/snmp/profiles/net_snmp_test.exs b/test/towerops/snmp/profiles/net_snmp_test.exs index 4e737fc8..42a28bcf 100644 --- a/test/towerops/snmp/profiles/net_snmp_test.exs +++ b/test/towerops/snmp/profiles/net_snmp_test.exs @@ -11,26 +11,13 @@ defmodule Towerops.Snmp.Profiles.NetSnmpTest do @client_opts [ip: "192.168.1.100", community: "public", version: :v2c, port: 161] describe "discover_system_info/1" do - test "delegates to Base profile" do - # Mock the SNMP calls that Base.discover_system_info makes - # Base profile queries 6 system OIDs - match by OID string - expect(SnmpMock, :get, 6, fn _target, oid, _opts -> - case oid do - "1.3.6.1.2.1.1.1.0" -> {:ok, "Linux ubuntu 5.4.0-42-generic #46-Ubuntu"} - "1.3.6.1.2.1.1.2.0" -> {:ok, [1, 3, 6, 1, 4, 1, 8072]} - "1.3.6.1.2.1.1.3.0" -> {:ok, 123_456} - "1.3.6.1.2.1.1.4.0" -> {:ok, "root@localhost"} - "1.3.6.1.2.1.1.5.0" -> {:ok, "ubuntu-server"} - "1.3.6.1.2.1.1.6.0" -> {:ok, "Data Center"} - _ -> {:error, :unknown_oid} - end - end) - + test "returns empty map (no additional system info beyond Base)" do + # NetSnmp profile doesn't query additional system OIDs + # Base profile handles all standard system info discovery result = NetSnmp.discover_system_info(@client_opts) assert {:ok, system_info} = result - assert is_map(system_info) - assert system_info.sys_name == "ubuntu-server" + assert system_info == %{} end end