fix compile warning

This commit is contained in:
Graham McIntire 2026-02-15 12:38:08 -06:00
parent eb26f704a4
commit fbcf26656e
No known key found for this signature in database

View file

@ -341,6 +341,7 @@ defmodule ToweropsWeb.Org.SettingsLive do
{:noreply, assign(socket, :netbox_config, netbox_config)}
end
@impl true
def handle_event("validate_integration", %{"integration" => params}, socket) do
integration = get_current_integration(socket)
@ -410,46 +411,6 @@ defmodule ToweropsWeb.Org.SettingsLive do
{:noreply, assign(socket, :test_result, result)}
end
defp do_test_connection("netbox", socket) do
{url, token} = extract_netbox_credentials(socket)
with :ok <- validate_present(url, t("Please enter your NetBox URL first")),
:ok <- validate_present(token, t("Please enter your NetBox API token first")) do
format_connection_result(Towerops.NetBox.Client.test_connection(url, token))
end
end
defp do_test_connection("sonar", socket) do
{instance_url, api_token} = extract_sonar_credentials(socket)
with :ok <- validate_present(instance_url, t("Please enter your Sonar instance URL first")),
:ok <- validate_present(api_token, t("Please enter your Sonar API token first")) do
format_connection_result(SonarClient.test_connection(instance_url, api_token))
end
end
defp do_test_connection("splynx", socket) do
{instance_url, api_key, api_secret} = extract_splynx_credentials(socket)
with :ok <- validate_present(instance_url, t("Please enter your Splynx instance URL first")),
:ok <- validate_present(api_key, t("Please enter your Splynx API key first")),
:ok <- validate_present(api_secret, t("Please enter your Splynx API secret first")) do
format_connection_result(SplynxClient.test_connection(instance_url, api_key, api_secret))
end
end
defp do_test_connection(provider, socket) do
api_key = extract_api_key(socket)
with :ok <- validate_present(api_key, t("Please enter an API key first")) do
format_connection_result(test_provider_connection(provider, api_key))
end
end
defp validate_present(nil, msg), do: {:error, msg}
defp validate_present("", msg), do: {:error, msg}
defp validate_present(_, _msg), do: :ok
@impl true
def handle_event("save_webhook_secret", %{"value" => secret}, socket) do
case Map.get(socket.assigns.integrations, "gaiia") do
@ -497,6 +458,46 @@ defmodule ToweropsWeb.Org.SettingsLive do
end
end
defp do_test_connection("netbox", socket) do
{url, token} = extract_netbox_credentials(socket)
with :ok <- validate_present(url, t("Please enter your NetBox URL first")),
:ok <- validate_present(token, t("Please enter your NetBox API token first")) do
format_connection_result(Towerops.NetBox.Client.test_connection(url, token))
end
end
defp do_test_connection("sonar", socket) do
{instance_url, api_token} = extract_sonar_credentials(socket)
with :ok <- validate_present(instance_url, t("Please enter your Sonar instance URL first")),
:ok <- validate_present(api_token, t("Please enter your Sonar API token first")) do
format_connection_result(SonarClient.test_connection(instance_url, api_token))
end
end
defp do_test_connection("splynx", socket) do
{instance_url, api_key, api_secret} = extract_splynx_credentials(socket)
with :ok <- validate_present(instance_url, t("Please enter your Splynx instance URL first")),
:ok <- validate_present(api_key, t("Please enter your Splynx API key first")),
:ok <- validate_present(api_secret, t("Please enter your Splynx API secret first")) do
format_connection_result(SplynxClient.test_connection(instance_url, api_key, api_secret))
end
end
defp do_test_connection(provider, socket) do
api_key = extract_api_key(socket)
with :ok <- validate_present(api_key, t("Please enter an API key first")) do
format_connection_result(test_provider_connection(provider, api_key))
end
end
defp validate_present(nil, msg), do: {:error, msg}
defp validate_present("", msg), do: {:error, msg}
defp validate_present(_, _msg), do: :ok
# === Private helpers (integrations) ===
defp test_provider_connection("preseem", api_key), do: PreseemClient.test_connection(api_key)