graham/towerops
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: add observability logging for invalid MAC addresses

Browse source 
- Log when normalize_mac drops invalid MAC addresses from SNMP data
- Helps diagnose data quality issues from network equipment
This commit is contained in:
Graham McIntire 2026-03-10 11:34:45 -05:00
parent 1a9a6e0ef6
commit e1cfc4ece1
No known key found for this signature in database
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
lib/towerops/gaiia/subscriber_matching.ex
View file

@ -460,13 +460,19 @@ defmodule Towerops.Gaiia.SubscriberMatching do
defp normalize_mac(nil), do: nil defp normalize_mac(nil), do: nil
defp normalize_mac(mac) do defp normalize_mac(mac) do
mac normalized =
|> String.downcase() mac
|> String.replace(~r/[^0-9a-f]/, "") |> String.downcase()
|> case do |> String.replace(~r/[^0-9a-f]/, "")
case normalized do
<<a::binary-2, b::binary-2, c::binary-2, d::binary-2, e::binary-2, f::binary-2>> -> <<a::binary-2, b::binary-2, c::binary-2, d::binary-2, e::binary-2, f::binary-2>> ->
"#{a}:#{b}:#{c}:#{d}:#{e}:#{f}" "#{a}:#{b}:#{c}:#{d}:#{e}:#{f}"
invalid when invalid != "" ->
Logger.debug("Dropping invalid MAC address from SNMP data: #{inspect(mac)} (normalized: #{invalid})")
nil
_ -> _ ->
nil nil
end end