graham/towerops
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: match tab order between settings and my data pages

Browse source 
The My Data page had tabs in a different order (Security before Sessions)
than the main settings page, and tab links used JS.push which never fired
because navigate does a full page load. Now both pages share the same tab
order and links include proper ?tab= query params.
This commit is contained in:
Graham McIntire 2026-02-13 14:54:17 -06:00
parent 20f5f48372
commit e000529654
No known key found for this signature in database
1 changed files with 13 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
lib/towerops_web/live/account_live/my_data.ex
View file

@ -84,7 +84,7 @@ defmodule ToweropsWeb.AccountLive.MyData do
>
<li>
<.link
navigate={~p"/users/settings"}
navigate={~p"/users/settings?tab=personal"}
class="text-gray-500 hover:text-indigo-600 dark:text-gray-400 dark:hover:text-indigo-400"
>
Personal
@ -92,8 +92,7 @@ defmodule ToweropsWeb.AccountLive.MyData do
</li>
<li>
<.link
navigate={~p"/users/settings"}
phx-click={JS.push("switch_tab", value: %{tab: "account"})}
navigate={~p"/users/settings?tab=account"}
class="text-gray-500 hover:text-indigo-600 dark:text-gray-400 dark:hover:text-indigo-400"
>
Account
@ -101,17 +100,7 @@ defmodule ToweropsWeb.AccountLive.MyData do
</li>
<li>
<.link
navigate={~p"/users/settings"}
phx-click={JS.push("switch_tab", value: %{tab: "security"})}
class="text-gray-500 hover:text-indigo-600 dark:text-gray-400 dark:hover:text-indigo-400"
>
Security
</.link>
</li>
<li>
<.link
navigate={~p"/users/settings"}
phx-click={JS.push("switch_tab", value: %{tab: "sessions"})}
navigate={~p"/users/settings?tab=sessions"}
class="text-gray-500 hover:text-indigo-600 dark:text-gray-400 dark:hover:text-indigo-400"
>
Sessions
@ -119,8 +108,7 @@ defmodule ToweropsWeb.AccountLive.MyData do
</li>
<li>
<.link
navigate={~p"/users/settings"}
phx-click={JS.push("switch_tab", value: %{tab: "api"})}
navigate={~p"/users/settings?tab=api"}
class="text-gray-500 hover:text-indigo-600 dark:text-gray-400 dark:hover:text-indigo-400"
>
API
@ -128,13 +116,20 @@ defmodule ToweropsWeb.AccountLive.MyData do
</li>
<li>
<.link
navigate={~p"/users/settings"}
phx-click={JS.push("switch_tab", value: %{tab: "notifications"})}
navigate={~p"/users/settings?tab=notifications"}
class="text-gray-500 hover:text-indigo-600 dark:text-gray-400 dark:hover:text-indigo-400"
>
Notifications
</.link>
</li>
<li>
<.link
navigate={~p"/users/settings?tab=security"}
class="text-gray-500 hover:text-indigo-600 dark:text-gray-400 dark:hover:text-indigo-400"
>
Security
</.link>
</li>
<li>
<.link
navigate={~p"/users/my-data"}