graham/towerops
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: handle "null" string values in SNMP parsing

Browse source 
Some devices (e.g., AirOS 8.7.14) return the literal string "null"
for unavailable metrics like UCD CPU stats. Added explicit handling
in parse_integer/1 and parse_float/1 to return nil for "null" strings,
preventing ArgumentError when attempting binary_to_integer conversion.
This commit is contained in:
Graham McIntire 2026-02-11 16:19:58 -06:00
parent 1f07b3b640
commit dd0b29aefb
No known key found for this signature in database
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
CHANGELOG.txt
View file

@ -1,6 +1,14 @@
CHANGELOG - towerops-web
========================
2026-02-11 - fix: handle "null" string values in SNMP parsing
- File: lib/towerops/snmp/profiles/base.ex (parse_integer/1, parse_float/1)
Added explicit handling for "null" string values before attempting integer/float
conversion. Some devices (e.g., AirOS 8.7.14) return the literal string "null"
for unavailable metrics like UCD CPU stats, which caused ArgumentError when
parse_integer/parse_float tried to convert them. Now returns nil, which gets
coerced to 0 by the || 0 fallback in the calling code.
2026-02-11 - fix: deduplicate sensors with leading-dot OID differences
- File: lib/towerops/snmp/profiles/dynamic.ex (deduplicate_by_oid/1)
Normalized OIDs by stripping leading dots when grouping for deduplication.

3
lib/towerops/snmp/profiles/base.ex
View file

@ -1434,11 +1434,14 @@ defmodule Towerops.Snmp.Profiles.Base do
defp parse_integer(value) when is_integer(value), do: value
defp parse_integer(""), do: nil
defp parse_integer("null"), do: nil
defp parse_integer(value) when is_binary(value), do: String.to_integer(value)
defp parse_integer(_), do: nil
defp parse_float(value) when is_float(value), do: value
defp parse_float(value) when is_integer(value), do: value / 1.0
defp parse_float(""), do: nil
defp parse_float("null"), do: nil
defp parse_float(value) when is_binary(value), do: String.to_float(value)
defp parse_float(_), do: nil