graham/towerops
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add detailed context to SNMP error logs for better diagnostics

Browse source 
Enhance SNMP error logging to include:
- Target IP address
- SNMP version (v1/v2c)
- Timeout value in milliseconds
- OID being queried

Before:
  [warning] SNMP GET failed for "1.3.6.1.2.1.2.2.1.10.15729368": :timeout

After:
  [warning] SNMP GET failed for 192.168.1.1 (v2c, timeout: 5000ms) OID "1.3.6.1.2.1.2.2.1.10.15729368": :timeout

This makes it much easier to diagnose SNMP issues by immediately knowing which
device is timing out and what the network configuration is.

Updated all SNMP operations: GET, WALK, and GET-BULK.
This commit is contained in:
Graham McIntire 2026-01-06 14:00:14 -06:00
parent fd317770fe
commit 7b1aa087d2
No known key found for this signature in database
1 changed files with 27 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
lib/towerops/snmp/client.ex
View file

@ -45,17 +45,22 @@ defmodule Towerops.Snmp.Client do
# Only log warnings for actual communication errors, not missing OIDs
case reason do
:no_such_object ->
Logger.debug("SNMP object not found: #{inspect(oid)}")
Logger.debug("SNMP object not found for #{target}: #{inspect(oid)}")
:no_such_instance ->
Logger.debug("SNMP instance not found: #{inspect(oid)}")
Logger.debug("SNMP instance not found for #{target}: #{inspect(oid)}")
:end_of_mib_view ->
Logger.debug("End of MIB view reached: #{inspect(oid)}")
Logger.debug("End of MIB view reached for #{target}: #{inspect(oid)}")
_ ->
# Actual errors like timeout, network issues, etc.
Logger.warning("SNMP GET failed for #{inspect(oid)}: #{inspect(reason)}")
timeout = Keyword.get(opts, :timeout, @default_timeout)
version = Keyword.fetch!(opts, :version)
Logger.warning(
"SNMP GET failed for #{target} (v#{version}, timeout: #{timeout}ms) OID #{inspect(oid)}: #{inspect(reason)}"
)
end
error
@ -123,16 +128,21 @@ defmodule Towerops.Snmp.Client do
# Only log warnings for actual communication errors
case reason do
:no_such_object ->
Logger.debug("SNMP WALK: object not found at #{inspect(start_oid)}")
Logger.debug("SNMP WALK: object not found for #{target} at #{inspect(start_oid)}")
:no_such_instance ->
Logger.debug("SNMP WALK: instance not found at #{inspect(start_oid)}")
Logger.debug("SNMP WALK: instance not found for #{target} at #{inspect(start_oid)}")
:end_of_mib_view ->
Logger.debug("SNMP WALK: end of MIB view at #{inspect(start_oid)}")
Logger.debug("SNMP WALK: end of MIB view for #{target} at #{inspect(start_oid)}")
_ ->
Logger.warning("SNMP WALK failed for #{inspect(start_oid)}: #{inspect(reason)}")
timeout = Keyword.get(opts, :timeout, @default_timeout)
version = Keyword.fetch!(opts, :version)
Logger.warning(
"SNMP WALK failed for #{target} (v#{version}, timeout: #{timeout}ms) OID #{inspect(start_oid)}: #{inspect(reason)}"
)
end
error
@ -170,16 +180,21 @@ defmodule Towerops.Snmp.Client do
# Only log warnings for actual communication errors
case reason do
:no_such_object ->
Logger.debug("SNMP GET-BULK: object not found at #{inspect(start_oid)}")
Logger.debug("SNMP GET-BULK: object not found for #{target} at #{inspect(start_oid)}")
:no_such_instance ->
Logger.debug("SNMP GET-BULK: instance not found at #{inspect(start_oid)}")
Logger.debug("SNMP GET-BULK: instance not found for #{target} at #{inspect(start_oid)}")
:end_of_mib_view ->
Logger.debug("SNMP GET-BULK: end of MIB view at #{inspect(start_oid)}")
Logger.debug("SNMP GET-BULK: end of MIB view for #{target} at #{inspect(start_oid)}")
_ ->
Logger.warning("SNMP GET-BULK failed for #{inspect(start_oid)}: #{inspect(reason)}")
timeout = Keyword.get(opts, :timeout, @default_timeout)
version = Keyword.fetch!(opts, :version)
Logger.warning(
"SNMP GET-BULK failed for #{target} (v#{version}, timeout: #{timeout}ms) OID #{inspect(start_oid)}: #{inspect(reason)}"
)
end
error