diff --git a/test/snmpkit/snmp_lib/mib/comprehensive_mib_test.exs b/test/snmpkit/snmp_lib/mib/comprehensive_mib_test.exs index cd852ab5..1edba40c 100644 --- a/test/snmpkit/snmp_lib/mib/comprehensive_mib_test.exs +++ b/test/snmpkit/snmp_lib/mib/comprehensive_mib_test.exs @@ -66,7 +66,7 @@ defmodule SnmpKit.SnmpLib.MIB.ComprehensiveMibTest do end else # yecc module not available - MIB parsing disabled, test passes - refute false + assert match?({:error, _}, Code.ensure_loaded?(MibParser)) end end end diff --git a/test/snmpkit/snmp_mgr/mib_test.exs b/test/snmpkit/snmp_mgr/mib_test.exs index 04f734f1..bacf1df9 100644 --- a/test/snmpkit/snmp_mgr/mib_test.exs +++ b/test/snmpkit/snmp_mgr/mib_test.exs @@ -498,7 +498,7 @@ defmodule SnmpKit.SnmpMgr.MIBTest do # Enterprise OIDs don't have curated syntax metadata {:ok, enterprises_info} = MIB.object_info("enterprises") # Should still return syntax map even if empty - assert %{} = enterprises_info.syntax + assert enterprises_info.syntax == %{} end end diff --git a/test/towerops/mobile_sessions/qr_login_token_test.exs b/test/towerops/mobile_sessions/qr_login_token_test.exs index a971e39a..c4593466 100644 --- a/test/towerops/mobile_sessions/qr_login_token_test.exs +++ b/test/towerops/mobile_sessions/qr_login_token_test.exs @@ -20,8 +20,7 @@ defmodule Towerops.MobileSessions.QRLoginTokenTest do changeset = QRLoginToken.create_changeset(%QRLoginToken{}, attrs) token = get_field(changeset, :token) - assert token - assert is_binary(token) + assert is_binary(token) and byte_size(token) > 0 assert String.length(token) > 0 end @@ -43,8 +42,6 @@ defmodule Towerops.MobileSessions.QRLoginTokenTest do changeset = QRLoginToken.create_changeset(%QRLoginToken{}, attrs) expires_at = get_field(changeset, :expires_at) - assert expires_at - diff_seconds = DateTime.diff(expires_at, now, :second) expected_seconds = 5 * 60 assert_in_delta diff_seconds, expected_seconds, 60 @@ -78,7 +75,7 @@ defmodule Towerops.MobileSessions.QRLoginTokenTest do changeset = QRLoginToken.create_changeset(%QRLoginToken{}, attrs) token = get_field(changeset, :token) - assert is_binary(token) + assert is_binary(token) and byte_size(token) > 0 assert byte_size(token) > 0 end end @@ -91,8 +88,6 @@ defmodule Towerops.MobileSessions.QRLoginTokenTest do changeset = QRLoginToken.complete_changeset(%QRLoginToken{}, mobile_session_id) completed_at = get_field(changeset, :completed_at) - assert completed_at - diff_seconds = abs(DateTime.diff(completed_at, now, :second)) assert_in_delta diff_seconds, 0, 60 end diff --git a/test/towerops/monitoring/executors/dns_executor_test.exs b/test/towerops/monitoring/executors/dns_executor_test.exs index 6604e502..5f5bdf70 100644 --- a/test/towerops/monitoring/executors/dns_executor_test.exs +++ b/test/towerops/monitoring/executors/dns_executor_test.exs @@ -118,8 +118,8 @@ defmodule Towerops.Monitoring.Executors.DnsExecutorTest do } case DnsExecutor.execute(config, 2000) do - {:ok, _time, output} -> assert is_binary(output) - {:error, reason} -> assert is_binary(reason) + {:ok, _time, output} -> assert is_binary(output) and byte_size(output) > 0 + {:error, reason} -> assert is_binary(reason) and byte_size(reason) > 0 end end @@ -131,8 +131,8 @@ defmodule Towerops.Monitoring.Executors.DnsExecutorTest do } case DnsExecutor.execute(config, 2000) do - {:ok, _time, output} -> assert is_binary(output) - {:error, reason} -> assert is_binary(reason) + {:ok, _time, output} -> assert is_binary(output) and byte_size(output) > 0 + {:error, reason} -> assert is_binary(reason) and byte_size(reason) > 0 end end @@ -144,8 +144,8 @@ defmodule Towerops.Monitoring.Executors.DnsExecutorTest do } case DnsExecutor.execute(config, 2000) do - {:ok, _time, output} -> assert is_binary(output) - {:error, reason} -> assert is_binary(reason) + {:ok, _time, output} -> assert is_binary(output) and byte_size(output) > 0 + {:error, reason} -> assert is_binary(reason) and byte_size(reason) > 0 end end @@ -157,8 +157,8 @@ defmodule Towerops.Monitoring.Executors.DnsExecutorTest do } case DnsExecutor.execute(config, 2000) do - {:ok, _time, output} -> assert is_binary(output) - {:error, reason} -> assert is_binary(reason) + {:ok, _time, output} -> assert is_binary(output) and byte_size(output) > 0 + {:error, reason} -> assert is_binary(reason) and byte_size(reason) > 0 end end diff --git a/test/towerops/monitoring/executors/ping_executor_test.exs b/test/towerops/monitoring/executors/ping_executor_test.exs index fce56d02..2b6915e5 100644 --- a/test/towerops/monitoring/executors/ping_executor_test.exs +++ b/test/towerops/monitoring/executors/ping_executor_test.exs @@ -13,11 +13,11 @@ defmodule Towerops.Monitoring.Executors.PingExecutorTest do {:ok, response_time, output} -> assert is_number(response_time) assert response_time >= 0 - assert is_binary(output) + assert is_binary(output) and byte_size(output) > 0 assert output =~ "packet" {:error, reason} -> - assert is_binary(reason) + assert is_binary(reason) and byte_size(reason) > 0 end end @@ -36,10 +36,10 @@ defmodule Towerops.Monitoring.Executors.PingExecutorTest do case PingExecutor.execute(config, 2000) do {:error, reason} -> - assert is_binary(reason) + assert is_binary(reason) and byte_size(reason) > 0 {:ok, _time, output} -> - assert is_binary(output) + assert is_binary(output) and byte_size(output) > 0 end end @@ -48,7 +48,7 @@ defmodule Towerops.Monitoring.Executors.PingExecutorTest do config = %{"host" => "definitely-not-a-real-host-12345.invalid", "count" => 1} assert {:error, reason} = PingExecutor.execute(config, 2000) - assert is_binary(reason) + assert is_binary(reason) and byte_size(reason) > 0 end test "sanitizes host to prevent command injection (no system call)" do @@ -60,7 +60,7 @@ defmodule Towerops.Monitoring.Executors.PingExecutorTest do test "fetches missing host raises (KeyError surfaces as exception path)" do assert {:error, reason} = PingExecutor.execute(%{"count" => 1}, 1000) - assert is_binary(reason) + assert is_binary(reason) and byte_size(reason) > 0 end @tag :network diff --git a/test/towerops/monitoring/executors/snmp_interface_executor_test.exs b/test/towerops/monitoring/executors/snmp_interface_executor_test.exs index 1db1aac7..6ecd3cbc 100644 --- a/test/towerops/monitoring/executors/snmp_interface_executor_test.exs +++ b/test/towerops/monitoring/executors/snmp_interface_executor_test.exs @@ -142,7 +142,7 @@ defmodule Towerops.Monitoring.Executors.SnmpInterfaceExecutorTest do check = build_check(device, Ecto.UUID.generate()) assert {:error, msg} = SnmpInterfaceExecutor.execute(check) - assert is_binary(msg) + assert is_binary(msg) and byte_size(msg) > 0 assert msg =~ "Interface not found" end @@ -205,7 +205,7 @@ defmodule Towerops.Monitoring.Executors.SnmpInterfaceExecutorTest do end) assert {:error, msg} = SnmpInterfaceExecutor.execute(check) - assert is_binary(msg) + assert is_binary(msg) and byte_size(msg) > 0 assert msg =~ "Unexpected value type" end end diff --git a/test/towerops/monitoring/executors/snmp_processor_executor_test.exs b/test/towerops/monitoring/executors/snmp_processor_executor_test.exs index 77549126..72c79b88 100644 --- a/test/towerops/monitoring/executors/snmp_processor_executor_test.exs +++ b/test/towerops/monitoring/executors/snmp_processor_executor_test.exs @@ -161,7 +161,7 @@ defmodule Towerops.Monitoring.Executors.SnmpProcessorExecutorTest do check = build_check(device, Ecto.UUID.generate()) assert {:error, msg} = SnmpProcessorExecutor.execute(check) - assert is_binary(msg) + assert is_binary(msg) and byte_size(msg) > 0 assert msg =~ "Processor not found" end @@ -224,7 +224,7 @@ defmodule Towerops.Monitoring.Executors.SnmpProcessorExecutorTest do end) assert {:error, msg} = SnmpProcessorExecutor.execute(check) - assert is_binary(msg) + assert is_binary(msg) and byte_size(msg) > 0 assert msg =~ "Unexpected value type" end end diff --git a/test/towerops/monitoring/executors/snmp_sensor_executor_test.exs b/test/towerops/monitoring/executors/snmp_sensor_executor_test.exs index 39de14e1..fee7256a 100644 --- a/test/towerops/monitoring/executors/snmp_sensor_executor_test.exs +++ b/test/towerops/monitoring/executors/snmp_sensor_executor_test.exs @@ -99,7 +99,7 @@ defmodule Towerops.Monitoring.Executors.SnmpSensorExecutorTest do valid? = is_float(response.value) or is_nil(response.value) assert valid? assert response.status in [0, 1, 2, 3] - assert is_binary(response.output) + assert is_binary(response.output) and byte_size(response.output) > 0 valid? = is_number(response.response_time_ms) or is_nil(response.response_time_ms) assert valid? end diff --git a/test/towerops/monitoring/executors/snmp_storage_executor_test.exs b/test/towerops/monitoring/executors/snmp_storage_executor_test.exs index b03c1a7e..ba1b27ad 100644 --- a/test/towerops/monitoring/executors/snmp_storage_executor_test.exs +++ b/test/towerops/monitoring/executors/snmp_storage_executor_test.exs @@ -112,7 +112,7 @@ defmodule Towerops.Monitoring.Executors.SnmpStorageExecutorTest do assert response.value == 50.0 assert response.status == 0 - assert is_binary(response.output) + assert is_binary(response.output) and byte_size(response.output) > 0 assert String.contains?(response.output, "50.0%") assert is_integer(response.response_time_ms) assert response.response_time_ms >= 0 @@ -156,7 +156,7 @@ defmodule Towerops.Monitoring.Executors.SnmpStorageExecutorTest do check = build_check(device, Ecto.UUID.generate()) assert {:error, msg} = SnmpStorageExecutor.execute(check) - assert is_binary(msg) + assert is_binary(msg) and byte_size(msg) > 0 assert msg =~ "Storage not found" end @@ -195,7 +195,7 @@ defmodule Towerops.Monitoring.Executors.SnmpStorageExecutorTest do }) assert {:error, msg} = SnmpStorageExecutor.execute(check) - assert is_binary(msg) + assert is_binary(msg) and byte_size(msg) > 0 assert msg =~ "does not have SNMP configured" end diff --git a/test/towerops/monitoring/executors/ssl_executor_test.exs b/test/towerops/monitoring/executors/ssl_executor_test.exs index 96653154..50f56b10 100644 --- a/test/towerops/monitoring/executors/ssl_executor_test.exs +++ b/test/towerops/monitoring/executors/ssl_executor_test.exs @@ -19,7 +19,7 @@ defmodule Towerops.Monitoring.Executors.SslExecutorTest do # Reduced timeout to 100ms for faster tests assert {:error, reason} = SslExecutor.execute(config, 100) - assert is_binary(reason) + assert is_binary(reason) and byte_size(reason) > 0 end test "returns error for connection refused on closed port" do @@ -31,7 +31,7 @@ defmodule Towerops.Monitoring.Executors.SslExecutorTest do config = %{"host" => "127.0.0.1", "port" => port, "warning_days" => 30} assert {:error, reason} = SslExecutor.execute(config, 2_000) - assert is_binary(reason) + assert is_binary(reason) and byte_size(reason) > 0 end test "returns error for missing host key" do diff --git a/test/towerops/monitoring/executors/tcp_executor_test.exs b/test/towerops/monitoring/executors/tcp_executor_test.exs index 0fe9e6d8..97ae34c3 100644 --- a/test/towerops/monitoring/executors/tcp_executor_test.exs +++ b/test/towerops/monitoring/executors/tcp_executor_test.exs @@ -76,7 +76,7 @@ defmodule Towerops.Monitoring.Executors.TcpExecutorTest do test "returns error for DNS resolution failure" do config = %{"host" => "thisdomaindoesnotexist.invalid", "port" => 80} assert {:error, reason} = TcpExecutor.execute(config, 1000) - assert is_binary(reason) + assert is_binary(reason) and byte_size(reason) > 0 end end diff --git a/test/towerops/netbox/sync_integration_test.exs b/test/towerops/netbox/sync_integration_test.exs index caa24012..923b9316 100644 --- a/test/towerops/netbox/sync_integration_test.exs +++ b/test/towerops/netbox/sync_integration_test.exs @@ -271,7 +271,7 @@ defmodule Towerops.NetBox.SyncIntegrationTest do reloaded = Towerops.Repo.reload!(integration) assert reloaded.last_sync_status == "failed" - assert is_binary(reloaded.last_sync_message) + assert is_binary(reloaded.last_sync_message) and byte_size(reloaded.last_sync_message) > 0 end end end diff --git a/test/towerops/organizations/invitation_test.exs b/test/towerops/organizations/invitation_test.exs index 43c8af83..106e4571 100644 --- a/test/towerops/organizations/invitation_test.exs +++ b/test/towerops/organizations/invitation_test.exs @@ -119,8 +119,7 @@ defmodule Towerops.Organizations.InvitationTest do changeset = Invitation.changeset(%Invitation{}, attrs) token = get_field(changeset, :token) - assert token - assert is_binary(token) + assert is_binary(token) and byte_size(token) > 0 assert String.length(token) > 0 end @@ -150,8 +149,6 @@ defmodule Towerops.Organizations.InvitationTest do changeset = Invitation.changeset(%Invitation{}, attrs) expires_at = get_field(changeset, :expires_at) - assert expires_at - # Should be approximately 7 days from now (within 1 minute tolerance) diff_seconds = DateTime.diff(expires_at, now, :second) expected_seconds = 7 * 24 * 60 * 60 diff --git a/test/towerops/organizations/organization_test.exs b/test/towerops/organizations/organization_test.exs index 6c3f7d5b..3858a0d5 100644 --- a/test/towerops/organizations/organization_test.exs +++ b/test/towerops/organizations/organization_test.exs @@ -40,8 +40,7 @@ defmodule Towerops.Organizations.OrganizationTest do assert changeset.valid? slug = get_field(changeset, :slug) - assert slug - assert is_binary(slug) + assert is_binary(slug) and byte_size(slug) > 0 assert String.length(slug) > 0 end diff --git a/test/towerops/preseem/baseline_test.exs b/test/towerops/preseem/baseline_test.exs index c69b585a..b8e166fe 100644 --- a/test/towerops/preseem/baseline_test.exs +++ b/test/towerops/preseem/baseline_test.exs @@ -35,7 +35,6 @@ defmodule Towerops.Preseem.BaselineTest do refute baselines == [] latency_baseline = Enum.find(baselines, &(&1.metric_name == "avg_latency")) - assert latency_baseline assert latency_baseline.sample_count == 5 assert latency_baseline.period == "all" assert latency_baseline.mean @@ -156,7 +155,6 @@ defmodule Towerops.Preseem.BaselineTest do latency_baseline = Enum.find(baselines, &(&1.metric_name == "avg_latency")) jitter_baseline = Enum.find(baselines, &(&1.metric_name == "avg_jitter")) - assert latency_baseline # avg_jitter should not have a baseline since all values are nil (< 3 non-nil) assert jitter_baseline == nil end diff --git a/test/towerops/preseem_test.exs b/test/towerops/preseem_test.exs index 97a9655f..43ab8922 100644 --- a/test/towerops/preseem_test.exs +++ b/test/towerops/preseem_test.exs @@ -152,7 +152,7 @@ defmodule Towerops.PreseemTest do ap = insert_access_point!(org) # Just verify the function works with default metrics = Preseem.list_subscriber_metrics(ap.id) - assert is_list(metrics) + assert is_list(metrics) and metrics != [] end end diff --git a/test/towerops/profiles/yaml_profiles_test.exs b/test/towerops/profiles/yaml_profiles_test.exs index fa0e6dab..46f41116 100644 --- a/test/towerops/profiles/yaml_profiles_test.exs +++ b/test/towerops/profiles/yaml_profiles_test.exs @@ -43,7 +43,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do # 4. OID is missing, so treated as false → condition matches profile = YamlProfiles.match_profile(system_info, client_opts) - assert profile assert profile.name == "airos" end @@ -75,7 +74,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = YamlProfiles.match_profile(system_info, client_opts) # Should match airos, not airos-af - assert profile assert profile.name == "airos" refute profile.name == "airos-af" end @@ -109,7 +107,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = YamlProfiles.match_profile(system_info, client_opts) - assert profile assert profile.name == "airos" end @@ -184,7 +181,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = YamlProfiles.match_profile(system_info, client_opts) - assert profile assert profile.name == "airos-af" end end @@ -199,7 +195,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do # No SNMP queries should be made for unconditional match profile = YamlProfiles.match_profile(system_info, []) - assert profile assert profile.name == "infinity" end @@ -211,7 +206,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = YamlProfiles.match_profile(system_info, []) - assert profile assert profile.name == "unifi" end @@ -380,7 +374,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = YamlProfiles.match_profile(system_info, client_opts) - assert profile assert profile.name == "comware" end @@ -407,7 +400,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = YamlProfiles.match_profile(system_info, client_opts) - assert profile assert profile.name == "comware" end @@ -434,7 +426,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = YamlProfiles.match_profile(system_info, client_opts) - assert profile assert profile.name == "comware" end @@ -495,9 +486,7 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = write_test_profile(nil, nil, discovery_yaml) - assert profile sensor = Enum.find(profile.sensor_oids, fn s -> s.sensor_type == "voltage" end) - assert sensor assert sensor.sensor_divisor == 10 end @@ -517,9 +506,7 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = write_test_profile(nil, nil, discovery_yaml) - assert profile sensor = Enum.find(profile.table_sensor_oids, fn s -> s.sensor_type == "temperature" end) - assert sensor assert sensor.sensor_divisor == 10 end @@ -539,9 +526,7 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = write_test_profile(nil, nil, discovery_yaml) - assert profile sensor = Enum.find(profile.sensor_oids, fn s -> s.sensor_type == "voltage" end) - assert sensor assert sensor.sensor_divisor == 100 end @@ -558,9 +543,7 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = write_test_profile(nil, nil, discovery_yaml) - assert profile sensor = Enum.find(profile.sensor_oids, fn s -> s.sensor_type == "voltage" end) - assert sensor assert sensor.sensor_divisor == 1 end end @@ -584,7 +567,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do test "avocent profile has correct options-level divisor for current sensors" do profile = YamlProfiles.get_profile("avocent") - assert profile # avocent.yaml: sensors.current.options.divisor = 10 current_sensors = @@ -600,7 +582,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do test "avocent profile has correct options-level divisor for temperature sensors" do profile = YamlProfiles.get_profile("avocent") - assert profile # avocent.yaml: sensors.temperature.options.divisor = 10 temp_sensors = @@ -632,7 +613,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do test "wut profile has correct options-level divisor for humidity sensors" do profile = YamlProfiles.get_profile("wut") - assert profile # wut.yaml: sensors.humidity.options.divisor = 10 humidity_sensors = @@ -648,7 +628,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do test "wut profile has correct options-level divisor for pressure sensors" do profile = YamlProfiles.get_profile("wut") - assert profile # wut.yaml: sensors.pressure.options.divisor = 100 pressure_sensors = @@ -745,7 +724,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do test "aos6 profile sensors without per-entry divisor default to 1" do profile = YamlProfiles.get_profile("aos6") - assert profile # aos6 dbm sensors also have divisor: 1000 per entry dbm_sensors = Enum.filter(profile.table_sensor_oids, fn s -> s.sensor_type == "dbm" end) @@ -784,7 +762,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = YamlProfiles.match_profile(system_info, client_opts) - assert profile assert profile.name == "procurve" end @@ -811,7 +788,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = YamlProfiles.match_profile(system_info, client_opts) - assert profile assert profile.name == "procurve" end @@ -839,7 +815,6 @@ defmodule Towerops.Profiles.YamlProfilesTest do profile = YamlProfiles.match_profile(system_info, client_opts) - assert profile assert profile.name == "procurve" end diff --git a/test/towerops/prom_ex_test.exs b/test/towerops/prom_ex_test.exs index e9f29b16..feba60a9 100644 --- a/test/towerops/prom_ex_test.exs +++ b/test/towerops/prom_ex_test.exs @@ -6,7 +6,7 @@ defmodule Towerops.PromExTest do describe "plugins/0" do test "lists the expected PromEx plugins" do plugins = Towerops.PromEx.plugins() - assert is_list(plugins) + assert is_list(plugins) and plugins != [] assert PromEx.Plugins.Application in plugins assert PromEx.Plugins.Beam in plugins assert PromEx.Plugins.PhoenixLiveView in plugins diff --git a/test/towerops/proto/agent_pb_test.exs b/test/towerops/proto/agent_pb_test.exs index 5365f02b..b90cfac7 100644 --- a/test/towerops/proto/agent_pb_test.exs +++ b/test/towerops/proto/agent_pb_test.exs @@ -43,7 +43,7 @@ defmodule Towerops.Proto.AgentPbTest do } encoded = AgentConfig.encode(config) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 decoded = AgentConfig.decode(encoded) assert decoded.version == "1.0.0" @@ -110,7 +110,7 @@ defmodule Towerops.Proto.AgentPbTest do } encoded = Device.encode(device) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 assert byte_size(encoded) > 0 end end @@ -147,7 +147,7 @@ defmodule Towerops.Proto.AgentPbTest do } encoded = SnmpConfig.encode(snmp) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 assert byte_size(encoded) > 0 end end @@ -241,7 +241,7 @@ defmodule Towerops.Proto.AgentPbTest do } encoded = Interface.encode(interface) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 assert byte_size(encoded) > 0 end end @@ -307,7 +307,7 @@ defmodule Towerops.Proto.AgentPbTest do metric = %Metric{metric_type: {:sensor_reading, reading}} encoded = Metric.encode(metric) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 assert byte_size(encoded) > 0 end @@ -316,7 +316,7 @@ defmodule Towerops.Proto.AgentPbTest do metric = %Metric{metric_type: {:interface_stat, stat}} encoded = Metric.encode(metric) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 assert byte_size(encoded) > 0 end end @@ -353,7 +353,7 @@ defmodule Towerops.Proto.AgentPbTest do } encoded = SensorReading.encode(reading) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 assert byte_size(encoded) > 0 end end @@ -402,7 +402,7 @@ defmodule Towerops.Proto.AgentPbTest do } encoded = InterfaceStat.encode(stat) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 assert byte_size(encoded) > 0 end end diff --git a/test/towerops/proto/agent_test.exs b/test/towerops/proto/agent_test.exs index 1c8222b5..9d19666a 100644 --- a/test/towerops/proto/agent_test.exs +++ b/test/towerops/proto/agent_test.exs @@ -155,13 +155,13 @@ defmodule Towerops.Agent.ProtoTest do } encoded = SnmpDevice.encode(device) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 end test "encodes empty message" do device = %SnmpDevice{} encoded = SnmpDevice.encode(device) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 end test "round-trips through AgentJob" do @@ -198,7 +198,7 @@ defmodule Towerops.Agent.ProtoTest do } encoded = SnmpQuery.encode(query) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 end test "encodes WALK query" do @@ -208,13 +208,13 @@ defmodule Towerops.Agent.ProtoTest do } encoded = SnmpQuery.encode(query) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 end test "encodes empty message" do query = %SnmpQuery{} encoded = SnmpQuery.encode(query) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 end test "round-trips through AgentJob" do @@ -342,13 +342,13 @@ defmodule Towerops.Agent.ProtoTest do } encoded = AgentJobList.encode(job_list) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 end test "encodes empty job list" do job_list = %AgentJobList{jobs: []} encoded = AgentJobList.encode(job_list) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 end end @@ -455,7 +455,7 @@ defmodule Towerops.Agent.ProtoTest do } encoded = NeighborDiscovery.encode(neighbor) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 end test "encodes CDP neighbor" do @@ -470,13 +470,13 @@ defmodule Towerops.Agent.ProtoTest do } encoded = NeighborDiscovery.encode(neighbor) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 end test "encodes empty message" do neighbor = %NeighborDiscovery{} encoded = NeighborDiscovery.encode(neighbor) - assert is_binary(encoded) + assert is_binary(encoded) and byte_size(encoded) > 0 end end diff --git a/test/towerops/recommendations/rules/frequency_change_test.exs b/test/towerops/recommendations/rules/frequency_change_test.exs index 0b6cd8e6..71437738 100644 --- a/test/towerops/recommendations/rules/frequency_change_test.exs +++ b/test/towerops/recommendations/rules/frequency_change_test.exs @@ -119,7 +119,7 @@ defmodule Towerops.Recommendations.Rules.FrequencyChangeTest do assert [insight] = FrequencyChange.evaluate(org.id) md = insight.metadata - assert is_list(md["top_offenders"]) + assert is_list(md["top_offenders"]) and md["top_offenders"] != [] refute Enum.empty?(md["top_offenders"]) [first | _] = md["top_offenders"] assert first["bssid"] == "11:22:33:44:55:66" @@ -132,7 +132,7 @@ defmodule Towerops.Recommendations.Rules.FrequencyChangeTest do insert_scan(org, device, %{bssid: "11:22:33:44:55:77", channel: 153, rssi_dbm: -90}) assert [insight] = FrequencyChange.evaluate(org.id) - assert is_binary(insight.title) + assert is_binary(insight.title) and byte_size(insight.title) > 0 assert insight.title =~ "AP-North" assert insight.title =~ "149" end diff --git a/test/towerops/recommendations/rules/upstream_degradation_test.exs b/test/towerops/recommendations/rules/upstream_degradation_test.exs index 2410465d..189aac23 100644 --- a/test/towerops/recommendations/rules/upstream_degradation_test.exs +++ b/test/towerops/recommendations/rules/upstream_degradation_test.exs @@ -108,7 +108,7 @@ defmodule Towerops.Recommendations.Rules.UpstreamDegradationTest do [insight] = UpstreamDegradation.evaluate(org.id) aps = insight.metadata["degraded_aps"] - assert is_list(aps) + assert is_list(aps) and aps != [] ids = Enum.map(aps, & &1["preseem_ap_id"]) assert a.id in ids assert b.id in ids diff --git a/test/towerops/settings_test.exs b/test/towerops/settings_test.exs index 96b3f7a5..ef3568fb 100644 --- a/test/towerops/settings_test.exs +++ b/test/towerops/settings_test.exs @@ -169,7 +169,7 @@ defmodule Towerops.SettingsTest do settings = Settings.list_all_settings() - assert is_list(settings) + assert is_list(settings) and settings != [] refute Enum.empty?(settings) assert Enum.any?(settings, &(&1.key == "test_setting")) end diff --git a/test/towerops/snmp/agent_discovery_test.exs b/test/towerops/snmp/agent_discovery_test.exs index 09045101..21cae18e 100644 --- a/test/towerops/snmp/agent_discovery_test.exs +++ b/test/towerops/snmp/agent_discovery_test.exs @@ -65,7 +65,7 @@ defmodule Towerops.Snmp.AgentDiscoveryTest do AgentDiscovery.process_agent_discovery(device, oid_values) assert discovered.device_id == device.id - assert is_list(discovered.interfaces) + assert is_list(discovered.interfaces) and discovered.interfaces != [] end end end diff --git a/test/towerops/snmp/client_test.exs b/test/towerops/snmp/client_test.exs index 2ca8dcdb..d98cc562 100644 --- a/test/towerops/snmp/client_test.exs +++ b/test/towerops/snmp/client_test.exs @@ -180,7 +180,7 @@ defmodule Towerops.Snmp.ClientTest do end) assert {:ok, results} = Client.walk(@test_opts, "1.3.6.1.2.1.2.2.1.2") - assert is_map(results) + assert is_map(results) and map_size(results) > 0 assert results["1.3.6.1.2.1.2.2.1.2.1"] == "eth0" assert results["1.3.6.1.2.1.2.2.1.2.2"] == "eth1" end @@ -223,7 +223,7 @@ defmodule Towerops.Snmp.ClientTest do end) assert {:ok, results} = Client.get_bulk(@test_opts, "1.3.6.1.2.1.2.2.1.10", max_repetitions: 10) - assert is_map(results) + assert is_map(results) and map_size(results) > 0 assert results["1.3.6.1.2.1.2.2.1.10.1"] == 1000 end diff --git a/test/towerops/snmp/discovery/printer_supply_sync_test.exs b/test/towerops/snmp/discovery/printer_supply_sync_test.exs index 85fb9f61..e583f80c 100644 --- a/test/towerops/snmp/discovery/printer_supply_sync_test.exs +++ b/test/towerops/snmp/discovery/printer_supply_sync_test.exs @@ -198,7 +198,6 @@ defmodule Towerops.Snmp.Discovery.PrinterSupplySyncTest do assert :ok = Discovery.sync_printer_supplies(snmp_device, discovered_supplies) updated_supply = Repo.get(PrinterSupply, original_supply.id) - assert updated_supply assert updated_supply.supply_description == "Updated" # ID should not change assert updated_supply.id == original_supply.id diff --git a/test/towerops/snmp/discovery_extra_test.exs b/test/towerops/snmp/discovery_extra_test.exs index 51fd6b2a..7ef21526 100644 --- a/test/towerops/snmp/discovery_extra_test.exs +++ b/test/towerops/snmp/discovery_extra_test.exs @@ -261,7 +261,7 @@ defmodule Towerops.Snmp.DiscoveryExtraTest do entries = Repo.all(Towerops.Snmp.ArpEntry) # save_arp_entries returns :ok regardless of whether the entry persisted; # the upsert path itself is what we want to exercise. - assert is_list(entries) + assert is_list(entries) and entries != [] end end diff --git a/test/towerops/snmp/mib_parser_test.exs b/test/towerops/snmp/mib_parser_test.exs index a1e84344..dff383a2 100644 --- a/test/towerops/snmp/mib_parser_test.exs +++ b/test/towerops/snmp/mib_parser_test.exs @@ -15,7 +15,7 @@ defmodule Towerops.Snmp.MibParserTest do oids = MibParser.parse_mib_content(content) - assert is_map(oids) + assert is_map(oids) and map_size(oids) > 0 # These won't resolve without parent "system" being defined as a root # but they should be extracted as assignments end @@ -28,7 +28,7 @@ defmodule Towerops.Snmp.MibParserTest do oids = MibParser.parse_mib_content(content) - assert is_map(oids) + assert is_map(oids) and map_size(oids) > 0 # enterprises should resolve to 1.3.6.1.4.1 assert Map.get(oids, "enterprises") == "1.3.6.1.4.1" end @@ -44,7 +44,7 @@ defmodule Towerops.Snmp.MibParserTest do oids = MibParser.parse_mib_content(content) # Should parse without errors - assert is_map(oids) + assert is_map(oids) and map_size(oids) > 0 end test "resolves OIDs with known roots" do @@ -85,7 +85,7 @@ defmodule Towerops.Snmp.MibParserTest do test "handles empty content" do oids = MibParser.parse_mib_content("") - assert is_map(oids) + assert is_map(oids) and map_size(oids) > 0 # Should have root OIDs assert map_size(oids) > 0 end @@ -103,7 +103,7 @@ defmodule Towerops.Snmp.MibParserTest do oids = MibParser.parse_mib_content(content) - assert is_map(oids) + assert is_map(oids) and map_size(oids) > 0 end test "extracts multiple objects from real-world MIB structure" do @@ -156,7 +156,7 @@ defmodule Towerops.Snmp.MibParserTest do """) assert {:ok, oids} = MibParser.parse_mib_file(mib_file) - assert is_map(oids) + assert is_map(oids) and map_size(oids) > 0 assert Map.get(oids, "testObject") == "1.3.6.1.4.1.9999" assert Map.get(oids, "testChild") == "1.3.6.1.4.1.9999.1" end @@ -242,7 +242,7 @@ defmodule Towerops.Snmp.MibParserTest do describe "list_mib_files/0" do test "returns a list" do files = MibParser.list_mib_files() - assert is_list(files) + assert is_list(files) and files != [] end test "returns absolute paths" do @@ -289,7 +289,7 @@ defmodule Towerops.Snmp.MibParserTest do """ oids = MibParser.parse_mib_content(content) - assert is_map(oids) + assert is_map(oids) and map_size(oids) > 0 end test "handles definitions with hyphens in names" do diff --git a/test/towerops/snmp/mib_translator_test.exs b/test/towerops/snmp/mib_translator_test.exs index 71c3fe9c..9ec27efe 100644 --- a/test/towerops/snmp/mib_translator_test.exs +++ b/test/towerops/snmp/mib_translator_test.exs @@ -113,12 +113,11 @@ defmodule Towerops.Snmp.MibTranslatorTest do Application.put_env(:towerops, :mib_dirs, [Path.join(tmp_dir, "mibs")]) # Try translation (will fail but exercises expand_mib_directory) - _result = MibTranslator.translate("TEST-MIB::testObject.0") + assert {:error, :translation_failed} = + MibTranslator.translate("TEST-MIB::testObject.0") # Cleanup Application.delete_env(:towerops, :mib_dirs) - - assert true end test "handles nonexistent directory" do diff --git a/test/towerops/snmp/mib_validation_test.exs b/test/towerops/snmp/mib_validation_test.exs index 1f5ed10d..95e4f246 100644 --- a/test/towerops/snmp/mib_validation_test.exs +++ b/test/towerops/snmp/mib_validation_test.exs @@ -65,8 +65,7 @@ defmodule Towerops.Snmp.MibValidationTest do {"ifAlias", "1.3.6.1.2.1.31.1.1.1.18"} ] - validate_oids(mib_file, validations) - assert true + assert :ok = validate_oids(mib_file, validations) end test "sensor OIDs match ENTITY-SENSOR-MIB" do @@ -79,8 +78,7 @@ defmodule Towerops.Snmp.MibValidationTest do {"entPhySensorOperStatus", "1.3.6.1.2.1.99.1.1.1.5"} ] - validate_oids(mib_file, validations) - assert true + assert :ok = validate_oids(mib_file, validations) end end @@ -95,8 +93,7 @@ defmodule Towerops.Snmp.MibValidationTest do {"entSensorStatus", "1.3.6.1.4.1.9.9.91.1.1.1.1.5"} ] - validate_oids(mib_file, validations) - assert true + assert :ok = validate_oids(mib_file, validations) end end @@ -113,8 +110,7 @@ defmodule Towerops.Snmp.MibValidationTest do {"lmVoltSensorsValue", "1.3.6.1.4.1.2021.13.16.4.1.3"} ] - validate_oids(mib_file, validations) - assert true + assert :ok = validate_oids(mib_file, validations) end test "UCD-SNMP OIDs match UCD-SNMP-MIB" do @@ -134,8 +130,7 @@ defmodule Towerops.Snmp.MibValidationTest do {name, String.replace_suffix(oid, ".0", "")} end) - validate_oids(mib_file, validations) - assert true + assert :ok = validate_oids(mib_file, validations) end end @@ -151,7 +146,7 @@ defmodule Towerops.Snmp.MibValidationTest do if File.exists?(mib_file) do case MibParser.parse_mib_file(mib_file) do {:ok, oids} -> - assert is_map(oids) + assert is_map(oids) and map_size(oids) > 0 assert map_size(oids) > 0 {:error, reason} -> @@ -164,7 +159,7 @@ defmodule Towerops.Snmp.MibValidationTest do test "list_mib_files returns all MIB files" do mib_files = MibParser.list_mib_files() - assert is_list(mib_files) + assert is_list(mib_files) and mib_files != [] # Should have at least the standard MIBs assert Enum.any?(mib_files, &String.contains?(&1, "IF-MIB")) diff --git a/test/towerops/snmp/profiles/base_extra_test.exs b/test/towerops/snmp/profiles/base_extra_test.exs index 03f5c30e..84dfa5b6 100644 --- a/test/towerops/snmp/profiles/base_extra_test.exs +++ b/test/towerops/snmp/profiles/base_extra_test.exs @@ -128,7 +128,7 @@ defmodule Towerops.Snmp.Profiles.BaseExtraTest do [cpu] = processors assert cpu.processor_type == "ucd_cpu" assert cpu.processor_index == "ucd_0" - assert is_map(cpu.metadata) + assert is_map(cpu.metadata) and map_size(cpu.metadata) > 0 end end diff --git a/test/towerops/snmp/profiles/base_printer_supply_test.exs b/test/towerops/snmp/profiles/base_printer_supply_test.exs index 4ad31f65..0b23b7c2 100644 --- a/test/towerops/snmp/profiles/base_printer_supply_test.exs +++ b/test/towerops/snmp/profiles/base_printer_supply_test.exs @@ -37,7 +37,6 @@ defmodule Towerops.Snmp.Profiles.BasePrinterSupplyTest do assert length(supplies) == 2 black_toner = Enum.find(supplies, &(&1.supply_index == "1")) - assert black_toner assert black_toner.supply_type == "toner" assert black_toner.supply_description == "Black Toner Cartridge" assert black_toner.supply_unit == "percent" @@ -46,7 +45,6 @@ defmodule Towerops.Snmp.Profiles.BasePrinterSupplyTest do assert black_toner.color_name == "black" cyan_toner = Enum.find(supplies, &(&1.supply_index == "2")) - assert cyan_toner assert cyan_toner.supply_type == "toner" assert cyan_toner.current_level == 8500 assert cyan_toner.color_name == "cyan" diff --git a/test/towerops/snmp/profiles/dynamic_extra_test.exs b/test/towerops/snmp/profiles/dynamic_extra_test.exs index 86d56d56..ff86f5ce 100644 --- a/test/towerops/snmp/profiles/dynamic_extra_test.exs +++ b/test/towerops/snmp/profiles/dynamic_extra_test.exs @@ -75,8 +75,8 @@ defmodule Towerops.Snmp.Profiles.DynamicExtraTest do result = Dynamic.collect_vendor_debug_data(profile, @client_opts) - assert is_list(result.discovered_sensors) - assert is_map(result.wireless_sensors) + assert is_list(result.discovered_sensors) and result.discovered_sensors != [] + assert is_map(result.wireless_sensors) and map_size(result.wireless_sensors) > 0 # State sensor adds state_descr field to debug entry state_entry = Enum.find(result.discovered_sensors, fn s -> Map.has_key?(s, :state_descr) end) @@ -96,7 +96,7 @@ defmodule Towerops.Snmp.Profiles.DynamicExtraTest do result = Dynamic.collect_vendor_debug_data(profile, @client_opts) assert result.wireless_sensors == %{} - assert is_list(result.discovered_sensors) + assert is_list(result.discovered_sensors) and result.discovered_sensors != [] end test "handles profile without :name key in get_vendor_wireless_oids" do @@ -178,7 +178,7 @@ defmodule Towerops.Snmp.Profiles.DynamicExtraTest do assert {:ok, sensors} = Dynamic.discover_sensors(profile, @client_opts) # No sensors discovered - post_process_sensors is called with empty list # and returns it unchanged. - assert is_list(sensors) + assert is_list(sensors) and sensors != [] end test "arista-mos profile delegates to Arista.post_process_sensors" do @@ -192,7 +192,7 @@ defmodule Towerops.Snmp.Profiles.DynamicExtraTest do stub(SnmpMock, :walk, fn _, _, _ -> {:ok, []} end) assert {:ok, sensors} = Dynamic.discover_sensors(profile, @client_opts) - assert is_list(sensors) + assert is_list(sensors) and sensors != [] end test "dell-powervault profile delegates to Powervault.post_process_sensors" do @@ -206,7 +206,7 @@ defmodule Towerops.Snmp.Profiles.DynamicExtraTest do stub(SnmpMock, :walk, fn _, _, _ -> {:ok, []} end) assert {:ok, sensors} = Dynamic.discover_sensors(profile, @client_opts) - assert is_list(sensors) + assert is_list(sensors) and sensors != [] end end diff --git a/test/towerops/snmp/profiles/vendors/a10_test.exs b/test/towerops/snmp/profiles/vendors/a10_test.exs index ef42c0df..6e183c01 100644 --- a/test/towerops/snmp/profiles/vendors/a10_test.exs +++ b/test/towerops/snmp/profiles/vendors/a10_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.A10Test do test "returns list of sensor definitions" do defs = A10.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.A10Test do sensors = A10.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/adtran_test.exs b/test/towerops/snmp/profiles/vendors/adtran_test.exs index 5161cae3..9930783c 100644 --- a/test/towerops/snmp/profiles/vendors/adtran_test.exs +++ b/test/towerops/snmp/profiles/vendors/adtran_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AdtranTest do test "returns list of sensor definitions" do defs = Adtran.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AdtranTest do defs = Adtran.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) - assert cpu assert cpu.sensor_type == "load" assert cpu.sensor_unit == "%" end @@ -61,7 +59,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AdtranTest do defs = Adtran.wireless_oid_defs() cpu_avg = Enum.find(defs, &(&1.sensor_descr == "CPU 5min Average")) - assert cpu_avg assert cpu_avg.sensor_type == "load" end end @@ -80,7 +77,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AdtranTest do sensors = Adtran.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/adva_test.exs b/test/towerops/snmp/profiles/vendors/adva_test.exs index fae30a2c..e58bfc6a 100644 --- a/test/towerops/snmp/profiles/vendors/adva_test.exs +++ b/test/towerops/snmp/profiles/vendors/adva_test.exs @@ -63,7 +63,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AdvaTest do test "returns list of sensor definitions" do defs = Adva.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -91,7 +90,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AdvaTest do sensors = Adva.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/advantech_test.exs b/test/towerops/snmp/profiles/vendors/advantech_test.exs index 62b481c7..ef1a4366 100644 --- a/test/towerops/snmp/profiles/vendors/advantech_test.exs +++ b/test/towerops/snmp/profiles/vendors/advantech_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AdvantechTest do test "returns list of sensor definitions" do defs = Advantech.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AdvantechTest do sensors = Advantech.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/aerohive_test.exs b/test/towerops/snmp/profiles/vendors/aerohive_test.exs index 323bd0f7..43f08a6d 100644 --- a/test/towerops/snmp/profiles/vendors/aerohive_test.exs +++ b/test/towerops/snmp/profiles/vendors/aerohive_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AerohiveTest do test "returns list of wireless sensor definitions" do defs = Aerohive.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AerohiveTest do defs = Aerohive.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -61,9 +59,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.AerohiveTest do clients_2g = Enum.find(defs, &(&1.sensor_descr == "2.4GHz Clients")) clients_5g = Enum.find(defs, &(&1.sensor_descr == "5GHz Clients")) - assert clients_2g assert clients_2g.sensor_type == "clients" - assert clients_5g assert clients_5g.sensor_type == "clients" end @@ -71,7 +67,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AerohiveTest do defs = Aerohive.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) - assert cpu assert cpu.sensor_type == "load" assert cpu.sensor_unit == "%" end @@ -80,7 +75,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AerohiveTest do defs = Aerohive.wireless_oid_defs() mem = Enum.find(defs, &(&1.sensor_descr == "Memory Utilization")) - assert mem assert mem.sensor_type == "load" assert mem.sensor_unit == "%" end @@ -89,7 +83,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AerohiveTest do defs = Aerohive.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_type == "temperature")) - assert temp assert temp.sensor_descr == "System Temperature" end end @@ -110,7 +103,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AerohiveTest do sensors = Aerohive.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 6 end diff --git a/test/towerops/snmp/profiles/vendors/airconsole_test.exs b/test/towerops/snmp/profiles/vendors/airconsole_test.exs index 876b0f0f..337fc7e7 100644 --- a/test/towerops/snmp/profiles/vendors/airconsole_test.exs +++ b/test/towerops/snmp/profiles/vendors/airconsole_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AirconsoleTest do test "returns list of sensor definitions" do defs = Airconsole.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AirconsoleTest do sensors = Airconsole.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/airfiber_test.exs b/test/towerops/snmp/profiles/vendors/airfiber_test.exs index a10862d3..334de1ee 100644 --- a/test/towerops/snmp/profiles/vendors/airfiber_test.exs +++ b/test/towerops/snmp/profiles/vendors/airfiber_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AirfiberTest do test "returns list of wireless sensor definitions" do defs = Airfiber.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -95,7 +94,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AirfiberTest do sensors = Airfiber.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 7 # Verify config table OIDs used for frequency @@ -128,7 +126,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AirfiberTest do sensors = Airfiber.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 6 # Verify LTU OIDs were used @@ -155,7 +152,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AirfiberTest do sensors = Airfiber.discover_wireless_sensors(@client_opts) # Frequency sensor should still be discovered - assert is_list(sensors) assert length(sensors) == 1 assert List.first(sensors).sensor_type == "frequency" end diff --git a/test/towerops/snmp/profiles/vendors/alcatel_test.exs b/test/towerops/snmp/profiles/vendors/alcatel_test.exs index 3ad6cf67..a37819de 100644 --- a/test/towerops/snmp/profiles/vendors/alcatel_test.exs +++ b/test/towerops/snmp/profiles/vendors/alcatel_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlcatelTest do test "returns list of sensor definitions" do defs = Alcatel.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlcatelTest do sensors = Alcatel.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/allied_telesis_test.exs b/test/towerops/snmp/profiles/vendors/allied_telesis_test.exs index fc76aa14..c357c8ef 100644 --- a/test/towerops/snmp/profiles/vendors/allied_telesis_test.exs +++ b/test/towerops/snmp/profiles/vendors/allied_telesis_test.exs @@ -68,7 +68,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlliedTelesisTest do test "returns list of sensor definitions" do defs = AlliedTelesis.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -76,7 +75,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlliedTelesisTest do defs = AlliedTelesis.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU 5min Average")) - assert cpu assert cpu.sensor_type == "load" assert cpu.sensor_unit == "%" end @@ -85,7 +83,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlliedTelesisTest do defs = AlliedTelesis.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_descr == "Temperature")) - assert temp assert temp.sensor_type == "temperature" assert temp.sensor_unit == "°C" end @@ -106,7 +103,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlliedTelesisTest do sensors = AlliedTelesis.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/allied_test.exs b/test/towerops/snmp/profiles/vendors/allied_test.exs index ceba99a3..a74d36bb 100644 --- a/test/towerops/snmp/profiles/vendors/allied_test.exs +++ b/test/towerops/snmp/profiles/vendors/allied_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlliedTest do test "returns list of sensor definitions" do defs = Allied.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlliedTest do sensors = Allied.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/alpha_test.exs b/test/towerops/snmp/profiles/vendors/alpha_test.exs index 506e7f1b..79b99d11 100644 --- a/test/towerops/snmp/profiles/vendors/alpha_test.exs +++ b/test/towerops/snmp/profiles/vendors/alpha_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlphaTest do test "returns list of sensor definitions" do defs = Alpha.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlphaTest do sensors = Alpha.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/altalabs_test.exs b/test/towerops/snmp/profiles/vendors/altalabs_test.exs index f042f338..01361796 100644 --- a/test/towerops/snmp/profiles/vendors/altalabs_test.exs +++ b/test/towerops/snmp/profiles/vendors/altalabs_test.exs @@ -32,7 +32,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AltalabsTest do test "returns list of wireless sensor definitions" do defs = Altalabs.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -40,7 +39,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AltalabsTest do defs = Altalabs.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Load (1m)")) - assert cpu assert cpu.sensor_type == "load" end @@ -49,8 +47,8 @@ defmodule Towerops.Snmp.Profiles.Vendors.AltalabsTest do mem_used = Enum.find(defs, &(&1.sensor_descr == "Memory Used")) mem_total = Enum.find(defs, &(&1.sensor_descr == "Total Memory")) - assert mem_used - assert mem_total + assert %{sensor_descr: "Memory Used"} = mem_used + assert %{sensor_descr: "Total Memory"} = mem_total end end @@ -67,7 +65,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AltalabsTest do sensors = Altalabs.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 3 end diff --git a/test/towerops/snmp/profiles/vendors/alvarion_test.exs b/test/towerops/snmp/profiles/vendors/alvarion_test.exs index 6d750835..c963bb91 100644 --- a/test/towerops/snmp/profiles/vendors/alvarion_test.exs +++ b/test/towerops/snmp/profiles/vendors/alvarion_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlvarionTest do test "returns list of wireless sensor definitions" do defs = Alvarion.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlvarionTest do defs = Alvarion.wireless_oid_defs() rssi = Enum.find(defs, &(&1.sensor_descr == "RSSI")) - assert rssi assert rssi.sensor_type == "rssi" assert rssi.sensor_unit == "dBm" end @@ -61,7 +59,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlvarionTest do defs = Alvarion.wireless_oid_defs() snr = Enum.find(defs, &(&1.sensor_descr == "SNR")) - assert snr assert snr.sensor_type == "snr" assert snr.sensor_unit == "dB" end @@ -70,7 +67,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlvarionTest do defs = Alvarion.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Subscribers")) - assert clients assert clients.sensor_type == "clients" end end @@ -89,7 +85,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AlvarionTest do sensors = Alvarion.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/apc_test.exs b/test/towerops/snmp/profiles/vendors/apc_test.exs index 18504267..6181cc6d 100644 --- a/test/towerops/snmp/profiles/vendors/apc_test.exs +++ b/test/towerops/snmp/profiles/vendors/apc_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ApcTest do test "returns list of sensor definitions" do defs = Apc.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ApcTest do defs = Apc.wireless_oid_defs() battery = Enum.find(defs, &(&1.sensor_descr == "Battery Capacity")) - assert battery assert battery.sensor_type == "load" assert battery.sensor_unit == "%" end @@ -61,7 +59,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ApcTest do defs = Apc.wireless_oid_defs() voltage = Enum.find(defs, &(&1.sensor_descr == "Output Voltage")) - assert voltage assert voltage.sensor_type == "voltage" assert voltage.sensor_unit == "V" end @@ -70,7 +67,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ApcTest do defs = Apc.wireless_oid_defs() load = Enum.find(defs, &(&1.sensor_descr == "Output Load")) - assert load assert load.sensor_type == "load" assert load.sensor_unit == "%" end @@ -95,7 +91,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ApcTest do sensors = Apc.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 9 battery = Enum.find(sensors, &(&1.sensor_descr == "Battery Capacity")) diff --git a/test/towerops/snmp/profiles/vendors/arbor_test.exs b/test/towerops/snmp/profiles/vendors/arbor_test.exs index d418e2dc..46f7040e 100644 --- a/test/towerops/snmp/profiles/vendors/arbor_test.exs +++ b/test/towerops/snmp/profiles/vendors/arbor_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ArborTest do test "returns list of sensor definitions" do defs = Arbor.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ArborTest do sensors = Arbor.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/arista_test.exs b/test/towerops/snmp/profiles/vendors/arista_test.exs index 0db5a68f..0e5fd515 100644 --- a/test/towerops/snmp/profiles/vendors/arista_test.exs +++ b/test/towerops/snmp/profiles/vendors/arista_test.exs @@ -52,7 +52,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AristaTest do test "returns list of sensor definitions" do defs = Arista.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -60,7 +59,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AristaTest do defs = Arista.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Load")) - assert cpu assert cpu.sensor_type == "load" assert cpu.sensor_unit == "%" end @@ -80,7 +78,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AristaTest do sensors = Arista.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/arris_test.exs b/test/towerops/snmp/profiles/vendors/arris_test.exs index 96a6e60f..596965b8 100644 --- a/test/towerops/snmp/profiles/vendors/arris_test.exs +++ b/test/towerops/snmp/profiles/vendors/arris_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ArrisTest do test "returns list of sensor definitions" do defs = Arris.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ArrisTest do sensors = Arris.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/aruba_test.exs b/test/towerops/snmp/profiles/vendors/aruba_test.exs index efc74156..34067f06 100644 --- a/test/towerops/snmp/profiles/vendors/aruba_test.exs +++ b/test/towerops/snmp/profiles/vendors/aruba_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ArubaTest do test "returns list of wireless sensor definitions" do defs = Aruba.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ArubaTest do defs = Aruba.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -60,7 +58,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ArubaTest do defs = Aruba.wireless_oid_defs() aps = Enum.find(defs, &(&1.sensor_type == "ap-count")) - assert aps assert aps.sensor_descr == "Managed APs" end @@ -68,7 +65,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ArubaTest do defs = Aruba.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) - assert cpu assert cpu.sensor_unit == "%" end end @@ -88,7 +84,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ArubaTest do sensors = Aruba.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/asentria_test.exs b/test/towerops/snmp/profiles/vendors/asentria_test.exs index 795fa8eb..5e2bc1f1 100644 --- a/test/towerops/snmp/profiles/vendors/asentria_test.exs +++ b/test/towerops/snmp/profiles/vendors/asentria_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AsentriaTest do test "returns list of sensor definitions" do defs = Asentria.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AsentriaTest do sensors = Asentria.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/audiocodes_test.exs b/test/towerops/snmp/profiles/vendors/audiocodes_test.exs index 615b04f4..d338b600 100644 --- a/test/towerops/snmp/profiles/vendors/audiocodes_test.exs +++ b/test/towerops/snmp/profiles/vendors/audiocodes_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AudiocodesTest do test "returns list of sensor definitions" do defs = Audiocodes.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AudiocodesTest do sensors = Audiocodes.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/avaya_test.exs b/test/towerops/snmp/profiles/vendors/avaya_test.exs index dc7a419a..0adfc589 100644 --- a/test/towerops/snmp/profiles/vendors/avaya_test.exs +++ b/test/towerops/snmp/profiles/vendors/avaya_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AvayaTest do test "returns list of sensor definitions" do defs = Avaya.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AvayaTest do sensors = Avaya.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/aviat_test.exs b/test/towerops/snmp/profiles/vendors/aviat_test.exs index 259a9997..aaf6958d 100644 --- a/test/towerops/snmp/profiles/vendors/aviat_test.exs +++ b/test/towerops/snmp/profiles/vendors/aviat_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AviatTest do test "returns list of wireless sensor definitions" do defs = Aviat.wireless_oid_defs() - assert is_list(defs) assert length(defs) == 5 end @@ -120,7 +119,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AviatTest do sensors = Aviat.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/axis_test.exs b/test/towerops/snmp/profiles/vendors/axis_test.exs index f4b71341..50893c80 100644 --- a/test/towerops/snmp/profiles/vendors/axis_test.exs +++ b/test/towerops/snmp/profiles/vendors/axis_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AxisTest do test "returns list of sensor definitions" do defs = Axis.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.AxisTest do sensors = Axis.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/baicells_test.exs b/test/towerops/snmp/profiles/vendors/baicells_test.exs index f68b710d..d3dd0220 100644 --- a/test/towerops/snmp/profiles/vendors/baicells_test.exs +++ b/test/towerops/snmp/profiles/vendors/baicells_test.exs @@ -47,7 +47,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BaicellsTest do test "returns list of wireless sensor definitions" do defs = Baicells.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -55,7 +54,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BaicellsTest do defs = Baicells.wireless_oid_defs() rsrp = Enum.find(defs, &(&1.sensor_descr == "RSRP")) - assert rsrp assert rsrp.sensor_type == "rssi" assert rsrp.sensor_unit == "dBm" end @@ -64,7 +62,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BaicellsTest do defs = Baicells.wireless_oid_defs() rsrq = Enum.find(defs, &(&1.sensor_descr == "RSRQ")) - assert rsrq assert rsrq.sensor_type == "quality" assert rsrq.sensor_unit == "dB" end @@ -73,7 +70,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BaicellsTest do defs = Baicells.wireless_oid_defs() sinr = Enum.find(defs, &(&1.sensor_descr == "SINR")) - assert sinr assert sinr.sensor_type == "snr" assert sinr.sensor_unit == "dB" end @@ -82,7 +78,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BaicellsTest do defs = Baicells.wireless_oid_defs() tx = Enum.find(defs, &(&1.sensor_descr == "Tx Power")) - assert tx assert tx.sensor_type == "power" end @@ -90,7 +85,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BaicellsTest do defs = Baicells.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_type == "temperature")) - assert temp assert temp.sensor_descr == "Device Temperature" end end @@ -111,7 +105,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BaicellsTest do sensors = Baicells.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 6 end diff --git a/test/towerops/snmp/profiles/vendors/barco_test.exs b/test/towerops/snmp/profiles/vendors/barco_test.exs index 4dc90325..f7dea641 100644 --- a/test/towerops/snmp/profiles/vendors/barco_test.exs +++ b/test/towerops/snmp/profiles/vendors/barco_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BarcoTest do test "returns list of sensor definitions" do defs = Barco.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BarcoTest do sensors = Barco.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/barracuda_test.exs b/test/towerops/snmp/profiles/vendors/barracuda_test.exs index 9c9d0583..d6f1dba0 100644 --- a/test/towerops/snmp/profiles/vendors/barracuda_test.exs +++ b/test/towerops/snmp/profiles/vendors/barracuda_test.exs @@ -60,7 +60,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BarracudaTest do test "returns list of sensor definitions" do defs = Barracuda.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -88,7 +87,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BarracudaTest do sensors = Barracuda.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/bistream_test.exs b/test/towerops/snmp/profiles/vendors/bistream_test.exs index 289d1836..6976ac2b 100644 --- a/test/towerops/snmp/profiles/vendors/bistream_test.exs +++ b/test/towerops/snmp/profiles/vendors/bistream_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BistreamTest do test "returns list of sensor definitions" do defs = Bistream.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BistreamTest do sensors = Bistream.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/bke_test.exs b/test/towerops/snmp/profiles/vendors/bke_test.exs index 407bcd5d..37694391 100644 --- a/test/towerops/snmp/profiles/vendors/bke_test.exs +++ b/test/towerops/snmp/profiles/vendors/bke_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BkeTest do test "returns list of sensor definitions" do defs = Bke.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BkeTest do sensors = Bke.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/brocade_test.exs b/test/towerops/snmp/profiles/vendors/brocade_test.exs index f75f6b4f..3b37c2f8 100644 --- a/test/towerops/snmp/profiles/vendors/brocade_test.exs +++ b/test/towerops/snmp/profiles/vendors/brocade_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BrocadeTest do test "returns list of sensor definitions" do defs = Brocade.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BrocadeTest do sensors = Brocade.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/bti_test.exs b/test/towerops/snmp/profiles/vendors/bti_test.exs index 0f5084d2..6303c64a 100644 --- a/test/towerops/snmp/profiles/vendors/bti_test.exs +++ b/test/towerops/snmp/profiles/vendors/bti_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BtiTest do test "returns list of sensor definitions" do defs = Bti.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.BtiTest do sensors = Bti.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/calix_test.exs b/test/towerops/snmp/profiles/vendors/calix_test.exs index 114bd71f..d5233550 100644 --- a/test/towerops/snmp/profiles/vendors/calix_test.exs +++ b/test/towerops/snmp/profiles/vendors/calix_test.exs @@ -68,7 +68,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CalixTest do test "returns list of sensor definitions" do defs = Calix.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -76,7 +75,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CalixTest do defs = Calix.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Load")) - assert cpu assert cpu.sensor_type == "load" end end @@ -93,7 +91,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CalixTest do sensors = Calix.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 2 end diff --git a/test/towerops/snmp/profiles/vendors/cambium_ptp_test.exs b/test/towerops/snmp/profiles/vendors/cambium_ptp_test.exs index cde5176d..a6c99499 100644 --- a/test/towerops/snmp/profiles/vendors/cambium_ptp_test.exs +++ b/test/towerops/snmp/profiles/vendors/cambium_ptp_test.exs @@ -50,7 +50,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CambiumPtpTest do test "returns list of wireless sensor definitions" do defs = CambiumPtp.wireless_oid_defs() - assert is_list(defs) assert length(defs) == 6 end @@ -136,7 +135,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CambiumPtpTest do sensors = CambiumPtp.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 6 rx = Enum.find(sensors, &(&1.sensor_type == "rssi")) diff --git a/test/towerops/snmp/profiles/vendors/cambium_test.exs b/test/towerops/snmp/profiles/vendors/cambium_test.exs index 4706e233..fccb8d4a 100644 --- a/test/towerops/snmp/profiles/vendors/cambium_test.exs +++ b/test/towerops/snmp/profiles/vendors/cambium_test.exs @@ -68,7 +68,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CambiumTest do test "returns list of sensor definitions" do defs = Cambium.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -105,7 +104,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CambiumTest do sensors = Cambium.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end end @@ -151,28 +149,24 @@ defmodule Towerops.Snmp.Profiles.Vendors.CambiumTest do # Check RSSI sensor rssi_sensor = Enum.find(sensors, &(&1.sensor_type == "rssi")) - assert rssi_sensor assert rssi_sensor.sensor_descr == "Downlink RSSI" assert rssi_sensor.last_value == -65 assert rssi_sensor.sensor_unit == "dBm" # Check SNR sensor snr_sensor = Enum.find(sensors, &(&1.sensor_type == "snr")) - assert snr_sensor assert snr_sensor.sensor_descr == "Downlink SNR" assert snr_sensor.last_value == 25 assert snr_sensor.sensor_unit == "dB" # Check Frequency sensor freq_sensor = Enum.find(sensors, &(&1.sensor_type == "frequency")) - assert freq_sensor assert freq_sensor.sensor_descr == "RF Frequency" assert freq_sensor.last_value == 5180 assert freq_sensor.sensor_unit == "MHz" # Check Clients sensor (AP mode only) clients_sensor = Enum.find(sensors, &(&1.sensor_type == "clients")) - assert clients_sensor assert clients_sensor.sensor_descr == "Connected Subscribers" assert clients_sensor.last_value == 12 end diff --git a/test/towerops/snmp/profiles/vendors/cdata_test.exs b/test/towerops/snmp/profiles/vendors/cdata_test.exs index a20f969f..41ce9595 100644 --- a/test/towerops/snmp/profiles/vendors/cdata_test.exs +++ b/test/towerops/snmp/profiles/vendors/cdata_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CdataTest do test "returns list of sensor definitions" do defs = Cdata.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CdataTest do sensors = Cdata.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/ceragon_test.exs b/test/towerops/snmp/profiles/vendors/ceragon_test.exs index b1a44927..0db5403f 100644 --- a/test/towerops/snmp/profiles/vendors/ceragon_test.exs +++ b/test/towerops/snmp/profiles/vendors/ceragon_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CeragonTest do test "returns list of sensor definitions" do defs = Ceragon.wireless_oid_defs() - assert is_list(defs) assert length(defs) == 2 end @@ -89,7 +88,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CeragonTest do sensors = Ceragon.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 2 end diff --git a/test/towerops/snmp/profiles/vendors/christie_test.exs b/test/towerops/snmp/profiles/vendors/christie_test.exs index e0793ccc..34deb7ec 100644 --- a/test/towerops/snmp/profiles/vendors/christie_test.exs +++ b/test/towerops/snmp/profiles/vendors/christie_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ChristieTest do test "returns list of sensor definitions" do defs = Christie.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ChristieTest do sensors = Christie.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/ciena_test.exs b/test/towerops/snmp/profiles/vendors/ciena_test.exs index 6cce378e..3cd26c92 100644 --- a/test/towerops/snmp/profiles/vendors/ciena_test.exs +++ b/test/towerops/snmp/profiles/vendors/ciena_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CienaTest do test "returns list of sensor definitions" do defs = Ciena.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CienaTest do sensors = Ciena.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/cirpack_test.exs b/test/towerops/snmp/profiles/vendors/cirpack_test.exs index cd0cbb4d..32d41f2a 100644 --- a/test/towerops/snmp/profiles/vendors/cirpack_test.exs +++ b/test/towerops/snmp/profiles/vendors/cirpack_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CirpackTest do test "returns list of sensor definitions" do defs = Cirpack.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CirpackTest do sensors = Cirpack.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/cisco_test.exs b/test/towerops/snmp/profiles/vendors/cisco_test.exs index b8808a15..4800f0ab 100644 --- a/test/towerops/snmp/profiles/vendors/cisco_test.exs +++ b/test/towerops/snmp/profiles/vendors/cisco_test.exs @@ -83,7 +83,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscoTest do test "returns list of sensor definitions" do defs = Cisco.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -111,7 +110,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscoTest do sensors = Cisco.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/ciscowap_test.exs b/test/towerops/snmp/profiles/vendors/ciscowap_test.exs index 3c604b56..a383ecfa 100644 --- a/test/towerops/snmp/profiles/vendors/ciscowap_test.exs +++ b/test/towerops/snmp/profiles/vendors/ciscowap_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowapTest do test "returns list of wireless sensor definitions" do defs = Ciscowap.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowapTest do defs = Ciscowap.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -61,10 +59,8 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowapTest do util_2g = Enum.find(defs, &(&1.sensor_descr == "2.4GHz Channel Utilization")) util_5g = Enum.find(defs, &(&1.sensor_descr == "5GHz Channel Utilization")) - assert util_2g assert util_2g.sensor_type == "load" assert util_2g.sensor_unit == "%" - assert util_5g assert util_5g.sensor_type == "load" end @@ -73,10 +69,8 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowapTest do noise_2g = Enum.find(defs, &(&1.sensor_descr == "2.4GHz Noise Floor")) noise_5g = Enum.find(defs, &(&1.sensor_descr == "5GHz Noise Floor")) - assert noise_2g assert noise_2g.sensor_type == "noise" assert noise_2g.sensor_unit == "dBm" - assert noise_5g assert noise_5g.sensor_type == "noise" end end @@ -96,7 +90,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowapTest do sensors = Ciscowap.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/ciscowlc_test.exs b/test/towerops/snmp/profiles/vendors/ciscowlc_test.exs index f3279d12..b1bf5ec2 100644 --- a/test/towerops/snmp/profiles/vendors/ciscowlc_test.exs +++ b/test/towerops/snmp/profiles/vendors/ciscowlc_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowlcTest do test "returns list of wireless sensor definitions" do defs = Ciscowlc.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowlcTest do defs = Ciscowlc.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -60,7 +58,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowlcTest do defs = Ciscowlc.wireless_oid_defs() aps = Enum.find(defs, &(&1.sensor_descr == "Total APs")) - assert aps assert aps.sensor_type == "ap-count" end @@ -68,7 +65,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowlcTest do defs = Ciscowlc.wireless_oid_defs() clients_5g = Enum.find(defs, &(&1.sensor_descr == "5GHz Clients")) - assert clients_5g assert clients_5g.sensor_type == "clients" end @@ -76,7 +72,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowlcTest do defs = Ciscowlc.wireless_oid_defs() rogue = Enum.find(defs, &(&1.sensor_descr == "Rogue APs")) - assert rogue assert rogue.sensor_type == "count" end end @@ -97,7 +92,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CiscowlcTest do sensors = Ciscowlc.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 6 end diff --git a/test/towerops/snmp/profiles/vendors/citrix_test.exs b/test/towerops/snmp/profiles/vendors/citrix_test.exs index 132e00f5..eb2eaa2b 100644 --- a/test/towerops/snmp/profiles/vendors/citrix_test.exs +++ b/test/towerops/snmp/profiles/vendors/citrix_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CitrixTest do test "returns list of sensor definitions" do defs = Citrix.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CitrixTest do sensors = Citrix.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/cmm_test.exs b/test/towerops/snmp/profiles/vendors/cmm_test.exs index 3a90db8c..3f6998af 100644 --- a/test/towerops/snmp/profiles/vendors/cmm_test.exs +++ b/test/towerops/snmp/profiles/vendors/cmm_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CmmTest do test "returns list of sensor definitions" do defs = Cmm.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -53,9 +52,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.CmmTest do power = Enum.find(defs, &(&1.sensor_descr == "Power Status")) gps = Enum.find(defs, &(&1.sensor_descr == "GPS Sync Status")) - assert power assert power.sensor_type == "state" - assert gps assert gps.sensor_type == "state" end @@ -63,7 +60,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CmmTest do defs = Cmm.wireless_oid_defs() aps = Enum.find(defs, &(&1.sensor_descr == "Connected APs")) - assert aps assert aps.sensor_type == "ap-count" end end @@ -82,7 +78,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CmmTest do sensors = Cmm.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/cnmatrix_test.exs b/test/towerops/snmp/profiles/vendors/cnmatrix_test.exs index e621dad5..3b6443e9 100644 --- a/test/towerops/snmp/profiles/vendors/cnmatrix_test.exs +++ b/test/towerops/snmp/profiles/vendors/cnmatrix_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnmatrixTest do test "returns list of sensor definitions" do defs = Cnmatrix.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnmatrixTest do defs = Cnmatrix.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) - assert cpu assert cpu.sensor_type == "load" assert cpu.sensor_unit == "%" end @@ -61,7 +59,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnmatrixTest do defs = Cnmatrix.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_type == "temperature")) - assert temp assert temp.sensor_descr == "System Temperature" end @@ -69,7 +66,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnmatrixTest do defs = Cnmatrix.wireless_oid_defs() poe = Enum.find(defs, &(&1.sensor_descr == "Total PoE Power")) - assert poe assert poe.sensor_type == "power" end end @@ -89,7 +85,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnmatrixTest do sensors = Cnmatrix.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/cnpilot_test.exs b/test/towerops/snmp/profiles/vendors/cnpilot_test.exs index 7339a077..403fcd56 100644 --- a/test/towerops/snmp/profiles/vendors/cnpilot_test.exs +++ b/test/towerops/snmp/profiles/vendors/cnpilot_test.exs @@ -32,7 +32,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnpilotTest do test "returns list of wireless sensor definitions" do defs = Cnpilot.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -40,7 +39,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnpilotTest do defs = Cnpilot.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_type == "clients")) - assert clients assert clients.sensor_descr == "Clients" end @@ -48,7 +46,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnpilotTest do defs = Cnpilot.wireless_oid_defs() snr = Enum.find(defs, &(&1.sensor_type == "snr")) - assert snr assert snr.sensor_unit == "dB" end @@ -56,7 +53,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnpilotTest do defs = Cnpilot.wireless_oid_defs() power = Enum.find(defs, &(&1.sensor_type == "power")) - assert power assert power.sensor_descr == "Transmit Power" assert power.sensor_unit == "dBm" end @@ -65,7 +61,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnpilotTest do defs = Cnpilot.wireless_oid_defs() noise = Enum.find(defs, &(&1.sensor_type == "noise-floor")) - assert noise assert noise.sensor_descr == "Radio Noise Floor" assert noise.sensor_unit == "dBm" end @@ -85,17 +80,14 @@ defmodule Towerops.Snmp.Profiles.Vendors.CnpilotTest do sensors = Cnpilot.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 # Check clients sensor clients = Enum.find(sensors, &(&1.sensor_descr == "Clients")) - assert clients assert clients.last_value == 25.0 # Check noise floor sensor noise = Enum.find(sensors, &(&1.sensor_descr == "Radio Noise Floor")) - assert noise assert noise.last_value == -95.0 end diff --git a/test/towerops/snmp/profiles/vendors/cnwave60_test.exs b/test/towerops/snmp/profiles/vendors/cnwave60_test.exs index de5c9d58..fe08efaf 100644 --- a/test/towerops/snmp/profiles/vendors/cnwave60_test.exs +++ b/test/towerops/snmp/profiles/vendors/cnwave60_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Cnwave60Test do test "returns list of wireless sensor definitions" do defs = Cnwave60.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Cnwave60Test do defs = Cnwave60.wireless_oid_defs() rsl = Enum.find(defs, &(&1.sensor_descr == "Receive Signal Level")) - assert rsl assert rsl.sensor_type == "rssi" assert rsl.sensor_divisor == 10 end @@ -61,7 +59,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Cnwave60Test do defs = Cnwave60.wireless_oid_defs() snr = Enum.find(defs, &(&1.sensor_descr == "Signal to Noise Ratio")) - assert snr assert snr.sensor_type == "snr" end @@ -69,7 +66,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Cnwave60Test do defs = Cnwave60.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_type == "temperature")) - assert temp assert temp.sensor_descr == "System Temperature" end end @@ -89,7 +85,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Cnwave60Test do sensors = Cnwave60.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/corero_test.exs b/test/towerops/snmp/profiles/vendors/corero_test.exs index ec143e3b..d8318018 100644 --- a/test/towerops/snmp/profiles/vendors/corero_test.exs +++ b/test/towerops/snmp/profiles/vendors/corero_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CoreroTest do test "returns list of sensor definitions" do defs = Corero.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CoreroTest do sensors = Corero.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/cts_test.exs b/test/towerops/snmp/profiles/vendors/cts_test.exs index e296643c..0da366ed 100644 --- a/test/towerops/snmp/profiles/vendors/cts_test.exs +++ b/test/towerops/snmp/profiles/vendors/cts_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CtsTest do test "returns list of sensor definitions" do defs = Cts.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CtsTest do sensors = Cts.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/cyberpower_test.exs b/test/towerops/snmp/profiles/vendors/cyberpower_test.exs index e4e61586..1cc9baa6 100644 --- a/test/towerops/snmp/profiles/vendors/cyberpower_test.exs +++ b/test/towerops/snmp/profiles/vendors/cyberpower_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CyberpowerTest do test "returns list of sensor definitions" do defs = Cyberpower.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.CyberpowerTest do sensors = Cyberpower.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/dahua_test.exs b/test/towerops/snmp/profiles/vendors/dahua_test.exs index 2b45cfe2..00cb1fb7 100644 --- a/test/towerops/snmp/profiles/vendors/dahua_test.exs +++ b/test/towerops/snmp/profiles/vendors/dahua_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DahuaTest do test "returns list of sensor definitions" do defs = Dahua.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DahuaTest do sensors = Dahua.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/dantherm_test.exs b/test/towerops/snmp/profiles/vendors/dantherm_test.exs index 02bcf39c..cd7bbcaa 100644 --- a/test/towerops/snmp/profiles/vendors/dantherm_test.exs +++ b/test/towerops/snmp/profiles/vendors/dantherm_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DanthermTest do test "returns list of sensor definitions" do defs = Dantherm.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DanthermTest do sensors = Dantherm.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/deliberant_test.exs b/test/towerops/snmp/profiles/vendors/deliberant_test.exs index e8adc123..9d4db672 100644 --- a/test/towerops/snmp/profiles/vendors/deliberant_test.exs +++ b/test/towerops/snmp/profiles/vendors/deliberant_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DeliberantTest do test "returns list of wireless sensor definitions" do defs = Deliberant.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DeliberantTest do defs = Deliberant.wireless_oid_defs() signal = Enum.find(defs, &(&1.sensor_descr == "Signal Level")) - assert signal assert signal.sensor_type == "rssi" assert signal.sensor_unit == "dBm" end @@ -61,7 +59,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DeliberantTest do defs = Deliberant.wireless_oid_defs() noise = Enum.find(defs, &(&1.sensor_descr == "Noise Floor")) - assert noise assert noise.sensor_type == "noise" end @@ -69,7 +66,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DeliberantTest do defs = Deliberant.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_type == "temperature")) - assert temp assert temp.sensor_descr == "CPU Temperature" end end @@ -89,7 +85,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DeliberantTest do sensors = Deliberant.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/dell_test.exs b/test/towerops/snmp/profiles/vendors/dell_test.exs index aeb94aff..50bf38fc 100644 --- a/test/towerops/snmp/profiles/vendors/dell_test.exs +++ b/test/towerops/snmp/profiles/vendors/dell_test.exs @@ -64,7 +64,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DellTest do test "returns list of sensor definitions" do defs = Dell.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -92,7 +91,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DellTest do sensors = Dell.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/delta_test.exs b/test/towerops/snmp/profiles/vendors/delta_test.exs index 1e15b75a..621f2730 100644 --- a/test/towerops/snmp/profiles/vendors/delta_test.exs +++ b/test/towerops/snmp/profiles/vendors/delta_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DeltaTest do test "returns list of sensor definitions" do defs = Delta.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DeltaTest do sensors = Delta.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/deltanet_test.exs b/test/towerops/snmp/profiles/vendors/deltanet_test.exs index da02c2e6..3378324e 100644 --- a/test/towerops/snmp/profiles/vendors/deltanet_test.exs +++ b/test/towerops/snmp/profiles/vendors/deltanet_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DeltanetTest do test "returns list of sensor definitions" do defs = Deltanet.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DeltanetTest do sensors = Deltanet.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/deva_test.exs b/test/towerops/snmp/profiles/vendors/deva_test.exs index b0798b28..6fe5eef3 100644 --- a/test/towerops/snmp/profiles/vendors/deva_test.exs +++ b/test/towerops/snmp/profiles/vendors/deva_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DevaTest do test "returns list of sensor definitions" do defs = Deva.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DevaTest do sensors = Deva.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/dkt_test.exs b/test/towerops/snmp/profiles/vendors/dkt_test.exs index 70d505e2..5215e020 100644 --- a/test/towerops/snmp/profiles/vendors/dkt_test.exs +++ b/test/towerops/snmp/profiles/vendors/dkt_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DktTest do test "returns list of sensor definitions" do defs = Dkt.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DktTest do sensors = Dkt.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/dlink_test.exs b/test/towerops/snmp/profiles/vendors/dlink_test.exs index db6939fc..d9751eb8 100644 --- a/test/towerops/snmp/profiles/vendors/dlink_test.exs +++ b/test/towerops/snmp/profiles/vendors/dlink_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DlinkTest do test "returns list of sensor definitions" do defs = Dlink.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DlinkTest do sensors = Dlink.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/dlinkap_test.exs b/test/towerops/snmp/profiles/vendors/dlinkap_test.exs index 95a4eb2b..bfbcf325 100644 --- a/test/towerops/snmp/profiles/vendors/dlinkap_test.exs +++ b/test/towerops/snmp/profiles/vendors/dlinkap_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DlinkapTest do test "returns list of wireless sensor definitions" do defs = Dlinkap.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DlinkapTest do defs = Dlinkap.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -60,7 +58,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DlinkapTest do defs = Dlinkap.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) - assert cpu assert cpu.sensor_type == "load" end @@ -69,8 +66,8 @@ defmodule Towerops.Snmp.Profiles.Vendors.DlinkapTest do clients_2g = Enum.find(defs, &(&1.sensor_descr == "2.4GHz Clients")) clients_5g = Enum.find(defs, &(&1.sensor_descr == "5GHz Clients")) - assert clients_2g - assert clients_5g + assert %{sensor_descr: "2.4GHz Clients"} = clients_2g + assert %{sensor_descr: "5GHz Clients"} = clients_5g end end @@ -88,7 +85,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DlinkapTest do sensors = Dlinkap.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/dpstelecom_test.exs b/test/towerops/snmp/profiles/vendors/dpstelecom_test.exs index a5aafa20..a4ec6c2b 100644 --- a/test/towerops/snmp/profiles/vendors/dpstelecom_test.exs +++ b/test/towerops/snmp/profiles/vendors/dpstelecom_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DpstelecomTest do test "returns list of sensor definitions" do defs = Dpstelecom.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DpstelecomTest do sensors = Dpstelecom.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/dragonwave_test.exs b/test/towerops/snmp/profiles/vendors/dragonwave_test.exs index c1e13e67..986aa243 100644 --- a/test/towerops/snmp/profiles/vendors/dragonwave_test.exs +++ b/test/towerops/snmp/profiles/vendors/dragonwave_test.exs @@ -49,7 +49,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DragonwaveTest do test "returns list of wireless sensor definitions" do defs = Dragonwave.wireless_oid_defs() - assert is_list(defs) assert length(defs) == 3 end @@ -104,7 +103,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.DragonwaveTest do sensors = Dragonwave.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 3 end diff --git a/test/towerops/snmp/profiles/vendors/eaton_test.exs b/test/towerops/snmp/profiles/vendors/eaton_test.exs index 7baadf45..abda78e9 100644 --- a/test/towerops/snmp/profiles/vendors/eaton_test.exs +++ b/test/towerops/snmp/profiles/vendors/eaton_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EatonTest do test "returns list of sensor definitions" do defs = Eaton.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EatonTest do sensors = Eaton.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/edfa_test.exs b/test/towerops/snmp/profiles/vendors/edfa_test.exs index 70b1f639..b87a1ece 100644 --- a/test/towerops/snmp/profiles/vendors/edfa_test.exs +++ b/test/towerops/snmp/profiles/vendors/edfa_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EdfaTest do test "returns list of sensor definitions" do defs = Edfa.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EdfaTest do sensors = Edfa.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/edgeswitch_test.exs b/test/towerops/snmp/profiles/vendors/edgeswitch_test.exs index 4932326b..4fd56318 100644 --- a/test/towerops/snmp/profiles/vendors/edgeswitch_test.exs +++ b/test/towerops/snmp/profiles/vendors/edgeswitch_test.exs @@ -60,7 +60,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EdgeswitchTest do test "returns list of sensor definitions" do defs = Edgeswitch.wireless_oid_defs() - assert is_list(defs) assert length(defs) == 2 end @@ -68,7 +67,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EdgeswitchTest do defs = Edgeswitch.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_type == "temperature")) - assert temp assert temp.sensor_descr == "Temperature" assert temp.sensor_unit == "C" end @@ -77,7 +75,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EdgeswitchTest do defs = Edgeswitch.wireless_oid_defs() fan = Enum.find(defs, &(&1.sensor_type == "fanspeed")) - assert fan assert fan.sensor_descr == "Fan" assert fan.sensor_unit == "RPM" end @@ -199,15 +196,12 @@ defmodule Towerops.Snmp.Profiles.Vendors.EdgeswitchTest do assert length(state_sensors) == 3 chassis = Enum.find(state_sensors, &(&1.sensor_descr == "Chassis state")) - assert chassis assert chassis.last_value == 1 temp_state = Enum.find(state_sensors, &(&1.sensor_descr == "Temp Sensor 1")) - assert temp_state assert temp_state.last_value == 1 fan_state = Enum.find(state_sensors, &(&1.sensor_descr == "Fan 1")) - assert fan_state assert fan_state.last_value == 2 end diff --git a/test/towerops/snmp/profiles/vendors/eds_test.exs b/test/towerops/snmp/profiles/vendors/eds_test.exs index 765d7d3b..8b1e9e15 100644 --- a/test/towerops/snmp/profiles/vendors/eds_test.exs +++ b/test/towerops/snmp/profiles/vendors/eds_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EdsTest do test "returns list of sensor definitions" do defs = Eds.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EdsTest do sensors = Eds.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/ekinops_test.exs b/test/towerops/snmp/profiles/vendors/ekinops_test.exs index 062c2fb1..e83f8e08 100644 --- a/test/towerops/snmp/profiles/vendors/ekinops_test.exs +++ b/test/towerops/snmp/profiles/vendors/ekinops_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EkinopsTest do test "returns list of sensor definitions" do defs = Ekinops.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EkinopsTest do sensors = Ekinops.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/engenius_test.exs b/test/towerops/snmp/profiles/vendors/engenius_test.exs index d7ee7749..3a8d4dc4 100644 --- a/test/towerops/snmp/profiles/vendors/engenius_test.exs +++ b/test/towerops/snmp/profiles/vendors/engenius_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EngeniusTest do test "returns list of wireless sensor definitions" do defs = Engenius.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EngeniusTest do defs = Engenius.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Connected Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -61,8 +59,8 @@ defmodule Towerops.Snmp.Profiles.Vendors.EngeniusTest do clients_2g = Enum.find(defs, &(&1.sensor_descr == "2.4GHz Clients")) clients_5g = Enum.find(defs, &(&1.sensor_descr == "5GHz Clients")) - assert clients_2g - assert clients_5g + assert %{sensor_descr: "2.4GHz Clients"} = clients_2g + assert %{sensor_descr: "5GHz Clients"} = clients_5g end test "includes channel utilization sensors" do @@ -70,9 +68,8 @@ defmodule Towerops.Snmp.Profiles.Vendors.EngeniusTest do util_2g = Enum.find(defs, &(&1.sensor_descr == "2.4GHz Channel Utilization")) util_5g = Enum.find(defs, &(&1.sensor_descr == "5GHz Channel Utilization")) - assert util_2g assert util_2g.sensor_type == "load" - assert util_5g + assert %{sensor_descr: "5GHz Channel Utilization"} = util_5g end end @@ -93,7 +90,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EngeniusTest do sensors = Engenius.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 7 end diff --git a/test/towerops/snmp/profiles/vendors/epmp_test.exs b/test/towerops/snmp/profiles/vendors/epmp_test.exs index 86159048..ce93a854 100644 --- a/test/towerops/snmp/profiles/vendors/epmp_test.exs +++ b/test/towerops/snmp/profiles/vendors/epmp_test.exs @@ -127,7 +127,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EpmpTest do test "returns list of sensor definitions" do defs = Epmp.wireless_oid_defs() - assert is_list(defs) assert length(defs) >= 10 end @@ -147,7 +146,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EpmpTest do defs = Epmp.wireless_oid_defs() rssi = Enum.find(defs, &(&1.sensor_descr == "RSSI")) - assert rssi assert rssi.sensor_type == "rssi" assert rssi.sensor_unit == "dBm" end @@ -156,7 +154,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EpmpTest do defs = Epmp.wireless_oid_defs() snr = Enum.find(defs, &(&1.sensor_descr == "SNR")) - assert snr assert snr.sensor_type == "snr" assert snr.sensor_unit == "dB" end @@ -173,7 +170,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EpmpTest do sensors = Epmp.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/epson_test.exs b/test/towerops/snmp/profiles/vendors/epson_test.exs index ef06831c..cca567fa 100644 --- a/test/towerops/snmp/profiles/vendors/epson_test.exs +++ b/test/towerops/snmp/profiles/vendors/epson_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EpsonTest do test "returns list of sensor definitions" do defs = Epson.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EpsonTest do sensors = Epson.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/ericsson_test.exs b/test/towerops/snmp/profiles/vendors/ericsson_test.exs index 2b08d173..90c9bc5e 100644 --- a/test/towerops/snmp/profiles/vendors/ericsson_test.exs +++ b/test/towerops/snmp/profiles/vendors/ericsson_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EricssonTest do test "returns list of sensor definitions" do defs = Ericsson.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.EricssonTest do sensors = Ericsson.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/exalt_test.exs b/test/towerops/snmp/profiles/vendors/exalt_test.exs index c8de9d68..e811901f 100644 --- a/test/towerops/snmp/profiles/vendors/exalt_test.exs +++ b/test/towerops/snmp/profiles/vendors/exalt_test.exs @@ -32,7 +32,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ExaltTest do test "returns list of wireless sensor definitions" do defs = Exalt.wireless_oid_defs() - assert is_list(defs) assert length(defs) == 4 end @@ -99,7 +98,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ExaltTest do sensors = Exalt.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/extreme_test.exs b/test/towerops/snmp/profiles/vendors/extreme_test.exs index c420b11a..dc4583f7 100644 --- a/test/towerops/snmp/profiles/vendors/extreme_test.exs +++ b/test/towerops/snmp/profiles/vendors/extreme_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ExtremeTest do test "returns list of sensor definitions" do defs = Extreme.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ExtremeTest do sensors = Extreme.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/f5_test.exs b/test/towerops/snmp/profiles/vendors/f5_test.exs index 6532aa5f..9804aa6b 100644 --- a/test/towerops/snmp/profiles/vendors/f5_test.exs +++ b/test/towerops/snmp/profiles/vendors/f5_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.F5Test do test "returns list of sensor definitions" do defs = F5.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.F5Test do sensors = F5.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/fibrolan_test.exs b/test/towerops/snmp/profiles/vendors/fibrolan_test.exs index 801a5ad6..40c8fb76 100644 --- a/test/towerops/snmp/profiles/vendors/fibrolan_test.exs +++ b/test/towerops/snmp/profiles/vendors/fibrolan_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FibrolanTest do test "returns list of sensor definitions" do defs = Fibrolan.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FibrolanTest do sensors = Fibrolan.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/firebrick_test.exs b/test/towerops/snmp/profiles/vendors/firebrick_test.exs index ffe384f3..6630e115 100644 --- a/test/towerops/snmp/profiles/vendors/firebrick_test.exs +++ b/test/towerops/snmp/profiles/vendors/firebrick_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FirebrickTest do test "returns list of sensor definitions" do defs = Firebrick.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FirebrickTest do sensors = Firebrick.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/fortiap_test.exs b/test/towerops/snmp/profiles/vendors/fortiap_test.exs index 9e955261..d8640214 100644 --- a/test/towerops/snmp/profiles/vendors/fortiap_test.exs +++ b/test/towerops/snmp/profiles/vendors/fortiap_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortiapTest do test "returns list of wireless sensor definitions" do defs = Fortiap.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortiapTest do defs = Fortiap.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -61,9 +59,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortiapTest do cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) mem = Enum.find(defs, &(&1.sensor_descr == "Memory Utilization")) - assert cpu assert cpu.sensor_type == "load" - assert mem assert mem.sensor_type == "load" end @@ -72,8 +68,8 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortiapTest do clients_2g = Enum.find(defs, &(&1.sensor_descr == "2.4GHz Clients")) clients_5g = Enum.find(defs, &(&1.sensor_descr == "5GHz Clients")) - assert clients_2g - assert clients_5g + assert clients_2g.sensor_descr + assert clients_5g.sensor_descr end end @@ -92,7 +88,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortiapTest do sensors = Fortiap.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/fortinet_test.exs b/test/towerops/snmp/profiles/vendors/fortinet_test.exs index 4c6314f0..fb270d65 100644 --- a/test/towerops/snmp/profiles/vendors/fortinet_test.exs +++ b/test/towerops/snmp/profiles/vendors/fortinet_test.exs @@ -66,7 +66,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortinetTest do test "returns list of sensor definitions" do defs = Fortinet.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -94,7 +93,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortinetTest do sensors = Fortinet.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/fortiwlc_test.exs b/test/towerops/snmp/profiles/vendors/fortiwlc_test.exs index 06bbba61..55d1f829 100644 --- a/test/towerops/snmp/profiles/vendors/fortiwlc_test.exs +++ b/test/towerops/snmp/profiles/vendors/fortiwlc_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortiwlcTest do test "returns list of sensor definitions" do defs = Fortiwlc.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortiwlcTest do defs = Fortiwlc.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Total Wireless Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -61,9 +59,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortiwlcTest do connected_aps = Enum.find(defs, &(&1.sensor_descr == "Connected APs")) total_aps = Enum.find(defs, &(&1.sensor_descr == "Total APs")) - assert connected_aps assert connected_aps.sensor_type == "ap-count" - assert total_aps assert total_aps.sensor_type == "ap-count" end @@ -71,7 +67,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortiwlcTest do defs = Fortiwlc.wireless_oid_defs() ssids = Enum.find(defs, &(&1.sensor_descr == "Active SSIDs")) - assert ssids assert ssids.sensor_type == "count" end end @@ -90,7 +85,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FortiwlcTest do sensors = Fortiwlc.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/fs_test.exs b/test/towerops/snmp/profiles/vendors/fs_test.exs index 9e2558b9..a883106d 100644 --- a/test/towerops/snmp/profiles/vendors/fs_test.exs +++ b/test/towerops/snmp/profiles/vendors/fs_test.exs @@ -63,7 +63,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FsTest do test "returns list of sensor definitions" do defs = Fs.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -91,7 +90,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.FsTest do sensors = Fs.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/geist_test.exs b/test/towerops/snmp/profiles/vendors/geist_test.exs index 25b42467..e22a7985 100644 --- a/test/towerops/snmp/profiles/vendors/geist_test.exs +++ b/test/towerops/snmp/profiles/vendors/geist_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GeistTest do test "returns list of sensor definitions" do defs = Geist.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GeistTest do sensors = Geist.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/gigamon_test.exs b/test/towerops/snmp/profiles/vendors/gigamon_test.exs index 37621aef..5a28ba70 100644 --- a/test/towerops/snmp/profiles/vendors/gigamon_test.exs +++ b/test/towerops/snmp/profiles/vendors/gigamon_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GigamonTest do test "returns list of sensor definitions" do defs = Gigamon.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GigamonTest do sensors = Gigamon.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/grandstream_test.exs b/test/towerops/snmp/profiles/vendors/grandstream_test.exs index ad6f2beb..e02375d9 100644 --- a/test/towerops/snmp/profiles/vendors/grandstream_test.exs +++ b/test/towerops/snmp/profiles/vendors/grandstream_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GrandstreamTest do test "returns list of wireless sensor definitions" do defs = Grandstream.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GrandstreamTest do defs = Grandstream.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Connected Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -61,8 +59,8 @@ defmodule Towerops.Snmp.Profiles.Vendors.GrandstreamTest do clients_2g = Enum.find(defs, &(&1.sensor_descr == "2.4GHz Clients")) clients_5g = Enum.find(defs, &(&1.sensor_descr == "5GHz Clients")) - assert clients_2g - assert clients_5g + assert clients_2g.sensor_descr + assert clients_5g.sensor_descr end test "includes CPU and memory sensors" do @@ -70,9 +68,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.GrandstreamTest do cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) mem = Enum.find(defs, &(&1.sensor_descr == "Memory Utilization")) - assert cpu assert cpu.sensor_type == "load" - assert mem assert mem.sensor_type == "load" end end @@ -92,7 +88,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GrandstreamTest do sensors = Grandstream.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/greenbone_test.exs b/test/towerops/snmp/profiles/vendors/greenbone_test.exs index 6c7e3409..3db8a3d8 100644 --- a/test/towerops/snmp/profiles/vendors/greenbone_test.exs +++ b/test/towerops/snmp/profiles/vendors/greenbone_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GreenboneTest do test "returns list of sensor definitions" do defs = Greenbone.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GreenboneTest do sensors = Greenbone.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/gude_test.exs b/test/towerops/snmp/profiles/vendors/gude_test.exs index 7dc5cba9..63bab431 100644 --- a/test/towerops/snmp/profiles/vendors/gude_test.exs +++ b/test/towerops/snmp/profiles/vendors/gude_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GudeTest do test "returns list of sensor definitions" do defs = Gude.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GudeTest do sensors = Gude.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/gwd_test.exs b/test/towerops/snmp/profiles/vendors/gwd_test.exs index 3ab76269..7e435a1e 100644 --- a/test/towerops/snmp/profiles/vendors/gwd_test.exs +++ b/test/towerops/snmp/profiles/vendors/gwd_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GwdTest do test "returns list of sensor definitions" do defs = Gwd.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.GwdTest do sensors = Gwd.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/hikvision_test.exs b/test/towerops/snmp/profiles/vendors/hikvision_test.exs index c5eb3aaf..6f435903 100644 --- a/test/towerops/snmp/profiles/vendors/hikvision_test.exs +++ b/test/towerops/snmp/profiles/vendors/hikvision_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HikvisionTest do test "returns list of sensor definitions" do defs = Hikvision.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HikvisionTest do sensors = Hikvision.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/hillstone_test.exs b/test/towerops/snmp/profiles/vendors/hillstone_test.exs index 25d8f55a..09325ce5 100644 --- a/test/towerops/snmp/profiles/vendors/hillstone_test.exs +++ b/test/towerops/snmp/profiles/vendors/hillstone_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HillstoneTest do test "returns list of sensor definitions" do defs = Hillstone.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HillstoneTest do sensors = Hillstone.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/himoinsa_test.exs b/test/towerops/snmp/profiles/vendors/himoinsa_test.exs index dc519003..9e138ba9 100644 --- a/test/towerops/snmp/profiles/vendors/himoinsa_test.exs +++ b/test/towerops/snmp/profiles/vendors/himoinsa_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HimoinsaTest do test "returns list of sensor definitions" do defs = Himoinsa.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HimoinsaTest do sensors = Himoinsa.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/hp_test.exs b/test/towerops/snmp/profiles/vendors/hp_test.exs index e173d0cb..c6c8d804 100644 --- a/test/towerops/snmp/profiles/vendors/hp_test.exs +++ b/test/towerops/snmp/profiles/vendors/hp_test.exs @@ -67,7 +67,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HpTest do test "returns list of sensor definitions" do defs = Hp.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -95,7 +94,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HpTest do sensors = Hp.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/hpe_test.exs b/test/towerops/snmp/profiles/vendors/hpe_test.exs index 6464f7c5..1b66ece2 100644 --- a/test/towerops/snmp/profiles/vendors/hpe_test.exs +++ b/test/towerops/snmp/profiles/vendors/hpe_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HpeTest do test "returns list of sensor definitions" do defs = Hpe.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HpeTest do sensors = Hpe.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/huawei_test.exs b/test/towerops/snmp/profiles/vendors/huawei_test.exs index 2aaf566c..d509a1e9 100644 --- a/test/towerops/snmp/profiles/vendors/huawei_test.exs +++ b/test/towerops/snmp/profiles/vendors/huawei_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HuaweiTest do test "returns list of sensor definitions" do defs = Huawei.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.HuaweiTest do sensors = Huawei.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/ibm_test.exs b/test/towerops/snmp/profiles/vendors/ibm_test.exs index bcfb0004..8ef6c991 100644 --- a/test/towerops/snmp/profiles/vendors/ibm_test.exs +++ b/test/towerops/snmp/profiles/vendors/ibm_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.IbmTest do test "returns list of sensor definitions" do defs = Ibm.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.IbmTest do sensors = Ibm.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/ibmc_test.exs b/test/towerops/snmp/profiles/vendors/ibmc_test.exs index 40baa172..dbabecb9 100644 --- a/test/towerops/snmp/profiles/vendors/ibmc_test.exs +++ b/test/towerops/snmp/profiles/vendors/ibmc_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.IbmcTest do test "returns list of sensor definitions" do defs = Ibmc.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.IbmcTest do sensors = Ibmc.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/ignitenet_test.exs b/test/towerops/snmp/profiles/vendors/ignitenet_test.exs index 4e25dd9d..0152a2bc 100644 --- a/test/towerops/snmp/profiles/vendors/ignitenet_test.exs +++ b/test/towerops/snmp/profiles/vendors/ignitenet_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.IgnitenetTest do test "returns list of sensor definitions" do defs = Ignitenet.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.IgnitenetTest do sensors = Ignitenet.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/illustra_test.exs b/test/towerops/snmp/profiles/vendors/illustra_test.exs index aca4dce0..c3c09d24 100644 --- a/test/towerops/snmp/profiles/vendors/illustra_test.exs +++ b/test/towerops/snmp/profiles/vendors/illustra_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.IllustraTest do test "returns list of sensor definitions" do defs = Illustra.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.IllustraTest do sensors = Illustra.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/imco_power_test.exs b/test/towerops/snmp/profiles/vendors/imco_power_test.exs index d7898bb3..1100b411 100644 --- a/test/towerops/snmp/profiles/vendors/imco_power_test.exs +++ b/test/towerops/snmp/profiles/vendors/imco_power_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ImcoPowerTest do test "returns list of sensor definitions" do defs = ImcoPower.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ImcoPowerTest do sensors = ImcoPower.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/infortrend_test.exs b/test/towerops/snmp/profiles/vendors/infortrend_test.exs index 2f68cedd..8ebd7104 100644 --- a/test/towerops/snmp/profiles/vendors/infortrend_test.exs +++ b/test/towerops/snmp/profiles/vendors/infortrend_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.InfortrendTest do test "returns list of sensor definitions" do defs = Infortrend.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.InfortrendTest do sensors = Infortrend.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/inovonics_test.exs b/test/towerops/snmp/profiles/vendors/inovonics_test.exs index 2f30cdc1..84552943 100644 --- a/test/towerops/snmp/profiles/vendors/inovonics_test.exs +++ b/test/towerops/snmp/profiles/vendors/inovonics_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.InovonicsTest do test "returns list of sensor definitions" do defs = Inovonics.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.InovonicsTest do sensors = Inovonics.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/jacarta_test.exs b/test/towerops/snmp/profiles/vendors/jacarta_test.exs index b5920b24..e98102fa 100644 --- a/test/towerops/snmp/profiles/vendors/jacarta_test.exs +++ b/test/towerops/snmp/profiles/vendors/jacarta_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.JacartaTest do test "returns list of sensor definitions" do defs = Jacarta.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.JacartaTest do sensors = Jacarta.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/juniper_test.exs b/test/towerops/snmp/profiles/vendors/juniper_test.exs index 0293e9a9..23c705e5 100644 --- a/test/towerops/snmp/profiles/vendors/juniper_test.exs +++ b/test/towerops/snmp/profiles/vendors/juniper_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.JuniperTest do test "returns list of sensor definitions" do defs = Juniper.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.JuniperTest do sensors = Juniper.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/keenetic_test.exs b/test/towerops/snmp/profiles/vendors/keenetic_test.exs index 8b10e392..29a670ed 100644 --- a/test/towerops/snmp/profiles/vendors/keenetic_test.exs +++ b/test/towerops/snmp/profiles/vendors/keenetic_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.KeeneticTest do test "returns list of sensor definitions" do defs = Keenetic.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.KeeneticTest do sensors = Keenetic.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/lenovo_test.exs b/test/towerops/snmp/profiles/vendors/lenovo_test.exs index 36a72855..fca5a7e3 100644 --- a/test/towerops/snmp/profiles/vendors/lenovo_test.exs +++ b/test/towerops/snmp/profiles/vendors/lenovo_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LenovoTest do test "returns list of sensor definitions" do defs = Lenovo.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LenovoTest do sensors = Lenovo.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/liebert_test.exs b/test/towerops/snmp/profiles/vendors/liebert_test.exs index 90ff7086..29e38210 100644 --- a/test/towerops/snmp/profiles/vendors/liebert_test.exs +++ b/test/towerops/snmp/profiles/vendors/liebert_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LiebertTest do test "returns list of sensor definitions" do defs = Liebert.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LiebertTest do sensors = Liebert.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/ligoos_test.exs b/test/towerops/snmp/profiles/vendors/ligoos_test.exs index 9195953d..cac08c3d 100644 --- a/test/towerops/snmp/profiles/vendors/ligoos_test.exs +++ b/test/towerops/snmp/profiles/vendors/ligoos_test.exs @@ -32,7 +32,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LigoosTest do test "returns list of wireless sensor definitions" do defs = Ligoos.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -40,7 +39,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LigoosTest do defs = Ligoos.wireless_oid_defs() freq = Enum.find(defs, &(&1.sensor_type == "frequency")) - assert freq assert freq.sensor_unit == "MHz" end @@ -48,7 +46,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LigoosTest do defs = Ligoos.wireless_oid_defs() noise = Enum.find(defs, &(&1.sensor_type == "noise-floor")) - assert noise assert noise.sensor_unit == "dBm" end @@ -56,7 +53,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LigoosTest do defs = Ligoos.wireless_oid_defs() quality = Enum.find(defs, &(&1.sensor_type == "quality")) - assert quality assert quality.sensor_unit == "%" end @@ -64,7 +60,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.LigoosTest do defs = Ligoos.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_type == "clients")) - assert clients + assert clients.sensor_descr end end @@ -88,7 +84,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LigoosTest do sensors = Ligoos.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end @@ -109,16 +104,13 @@ defmodule Towerops.Snmp.Profiles.Vendors.LigoosTest do sensors = Ligoos.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 2 # Check interface-specific sensors if1 = Enum.find(sensors, &(&1.sensor_index == "ligoos_clients_1")) - assert if1 assert if1.last_value == 15.0 if2 = Enum.find(sensors, &(&1.sensor_index == "ligoos_clients_2")) - assert if2 assert if2.last_value == 8.0 end diff --git a/test/towerops/snmp/profiles/vendors/linux_test.exs b/test/towerops/snmp/profiles/vendors/linux_test.exs index 7288f4c3..3f3605aa 100644 --- a/test/towerops/snmp/profiles/vendors/linux_test.exs +++ b/test/towerops/snmp/profiles/vendors/linux_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LinuxTest do test "returns list of sensor definitions" do defs = Linux.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LinuxTest do sensors = Linux.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/luminato_test.exs b/test/towerops/snmp/profiles/vendors/luminato_test.exs index f6557085..16c08830 100644 --- a/test/towerops/snmp/profiles/vendors/luminato_test.exs +++ b/test/towerops/snmp/profiles/vendors/luminato_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LuminatoTest do test "returns list of sensor definitions" do defs = Luminato.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.LuminatoTest do sensors = Luminato.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/meinberg_test.exs b/test/towerops/snmp/profiles/vendors/meinberg_test.exs index 78d70206..9909f72b 100644 --- a/test/towerops/snmp/profiles/vendors/meinberg_test.exs +++ b/test/towerops/snmp/profiles/vendors/meinberg_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MeinbergTest do test "returns list of sensor definitions" do defs = Meinberg.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MeinbergTest do sensors = Meinberg.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/meraki_test.exs b/test/towerops/snmp/profiles/vendors/meraki_test.exs index 70a198f8..5bb269db 100644 --- a/test/towerops/snmp/profiles/vendors/meraki_test.exs +++ b/test/towerops/snmp/profiles/vendors/meraki_test.exs @@ -76,7 +76,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MerakiTest do test "returns list of sensor definitions" do defs = Meraki.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -85,9 +84,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.MerakiTest do radio1 = Enum.find(defs, &(&1.sensor_descr == "Radio 1 Channel")) radio2 = Enum.find(defs, &(&1.sensor_descr == "Radio 2 Channel")) - assert radio1 assert radio1.sensor_type == "frequency" - assert radio2 assert radio2.sensor_type == "frequency" end end @@ -104,7 +101,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MerakiTest do sensors = Meraki.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 2 end diff --git a/test/towerops/snmp/profiles/vendors/microsoft_test.exs b/test/towerops/snmp/profiles/vendors/microsoft_test.exs index 3b740117..d047aa6c 100644 --- a/test/towerops/snmp/profiles/vendors/microsoft_test.exs +++ b/test/towerops/snmp/profiles/vendors/microsoft_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MicrosoftTest do test "returns list of sensor definitions" do defs = Microsoft.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MicrosoftTest do sensors = Microsoft.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/mikrotik_test.exs b/test/towerops/snmp/profiles/vendors/mikrotik_test.exs index 08a30d9d..db060148 100644 --- a/test/towerops/snmp/profiles/vendors/mikrotik_test.exs +++ b/test/towerops/snmp/profiles/vendors/mikrotik_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MikrotikTest do test "returns list of sensor definitions" do defs = Mikrotik.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -104,24 +103,20 @@ defmodule Towerops.Snmp.Profiles.Vendors.MikrotikTest do # Check clients sensor clients_sensor = Enum.find(sensors, &(&1.sensor_type == "clients")) - assert clients_sensor assert clients_sensor.sensor_descr == "2G: TestAP" assert clients_sensor.last_value == 5 # Check CCQ sensor ccq_sensor = Enum.find(sensors, &(&1.sensor_type == "ccq")) - assert ccq_sensor assert ccq_sensor.last_value == 85 # Check frequency sensor freq_sensor = Enum.find(sensors, &(&1.sensor_type == "frequency")) - assert freq_sensor assert freq_sensor.last_value == 2437 assert freq_sensor.sensor_unit == "MHz" # Check noise floor sensor noise_sensor = Enum.find(sensors, &(&1.sensor_type == "noise-floor")) - assert noise_sensor assert noise_sensor.last_value == -95 assert noise_sensor.sensor_unit == "dBm" @@ -202,24 +197,20 @@ defmodule Towerops.Snmp.Profiles.Vendors.MikrotikTest do # Check 60GHz frequency freq_sensor = Enum.find(sensors, &(&1.sensor_type == "frequency")) - assert freq_sensor assert freq_sensor.sensor_descr == "60G: 60GLink" assert freq_sensor.last_value == 60_480 # Check RSSI rssi_sensor = Enum.find(sensors, &(&1.sensor_type == "rssi")) - assert rssi_sensor assert rssi_sensor.last_value == -55 assert rssi_sensor.sensor_unit == "dBm" # Check quality quality_sensor = Enum.find(sensors, &(&1.sensor_type == "quality")) - assert quality_sensor assert quality_sensor.last_value == 75 # Check PHY rate with divisor rate_sensor = Enum.find(sensors, &(&1.sensor_type == "rate")) - assert rate_sensor assert rate_sensor.sensor_divisor == 1_000_000 assert rate_sensor.last_value == 1_800_000_000 end @@ -250,7 +241,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MikrotikTest do # Check distance sensor distance_sensor = Enum.find(sensors, &(&1.sensor_type == "distance")) - assert distance_sensor assert distance_sensor.sensor_descr == "60G: Sta > RemoteSta" assert distance_sensor.last_value == 5_000_000 assert distance_sensor.sensor_divisor == 100_000 @@ -284,21 +274,18 @@ defmodule Towerops.Snmp.Profiles.Vendors.MikrotikTest do # Check RSRQ rsrq_sensor = Enum.find(sensors, &(&1.sensor_type == "rsrq")) - assert rsrq_sensor assert rsrq_sensor.sensor_descr == "LTE: Signal RSRQ" assert rsrq_sensor.last_value == -10 assert rsrq_sensor.sensor_unit == "dB" # Check RSRP rsrp_sensor = Enum.find(sensors, &(&1.sensor_type == "rsrp")) - assert rsrp_sensor assert rsrp_sensor.sensor_descr == "LTE: Signal RSRP" assert rsrp_sensor.last_value == -80 assert rsrp_sensor.sensor_unit == "dBm" # Check SINR sinr_sensor = Enum.find(sensors, &(&1.sensor_type == "sinr")) - assert sinr_sensor assert sinr_sensor.sensor_descr == "LTE: Signal SINR" assert sinr_sensor.last_value == 13 assert sinr_sensor.sensor_unit == "dB" diff --git a/test/towerops/snmp/profiles/vendors/mimosa_test.exs b/test/towerops/snmp/profiles/vendors/mimosa_test.exs index 284e5036..1d7036bf 100644 --- a/test/towerops/snmp/profiles/vendors/mimosa_test.exs +++ b/test/towerops/snmp/profiles/vendors/mimosa_test.exs @@ -32,7 +32,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MimosaTest do test "returns list of wireless sensor definitions" do defs = Mimosa.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -91,7 +90,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MimosaTest do sensors = Mimosa.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 14 end diff --git a/test/towerops/snmp/profiles/vendors/moxa_awk_test.exs b/test/towerops/snmp/profiles/vendors/moxa_awk_test.exs index c3b7095b..ce080a15 100644 --- a/test/towerops/snmp/profiles/vendors/moxa_awk_test.exs +++ b/test/towerops/snmp/profiles/vendors/moxa_awk_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MoxaAwkTest do test "returns list of wireless sensor definitions" do defs = MoxaAwk.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MoxaAwkTest do defs = MoxaAwk.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -61,9 +59,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.MoxaAwkTest do cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) mem = Enum.find(defs, &(&1.sensor_descr == "Memory Utilization")) - assert cpu assert cpu.sensor_type == "load" - assert mem assert mem.sensor_type == "load" end @@ -71,7 +67,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MoxaAwkTest do defs = MoxaAwk.wireless_oid_defs() signal = Enum.find(defs, &(&1.sensor_descr == "Signal Strength")) - assert signal assert signal.sensor_type == "rssi" assert signal.sensor_unit == "dBm" end @@ -91,7 +86,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MoxaAwkTest do sensors = MoxaAwk.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/moxa_test.exs b/test/towerops/snmp/profiles/vendors/moxa_test.exs index 6efc2f27..57abda0c 100644 --- a/test/towerops/snmp/profiles/vendors/moxa_test.exs +++ b/test/towerops/snmp/profiles/vendors/moxa_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MoxaTest do test "returns list of sensor definitions" do defs = Moxa.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MoxaTest do sensors = Moxa.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/mrv_test.exs b/test/towerops/snmp/profiles/vendors/mrv_test.exs index 4db38703..1651137a 100644 --- a/test/towerops/snmp/profiles/vendors/mrv_test.exs +++ b/test/towerops/snmp/profiles/vendors/mrv_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MrvTest do test "returns list of sensor definitions" do defs = Mrv.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.MrvTest do sensors = Mrv.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/n4rf_test.exs b/test/towerops/snmp/profiles/vendors/n4rf_test.exs index 140cc310..e5874be2 100644 --- a/test/towerops/snmp/profiles/vendors/n4rf_test.exs +++ b/test/towerops/snmp/profiles/vendors/n4rf_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.N4rfTest do test "returns list of sensor definitions" do defs = N4rf.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.N4rfTest do sensors = N4rf.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/netapp_test.exs b/test/towerops/snmp/profiles/vendors/netapp_test.exs index 81958859..8b0992e1 100644 --- a/test/towerops/snmp/profiles/vendors/netapp_test.exs +++ b/test/towerops/snmp/profiles/vendors/netapp_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetappTest do test "returns list of sensor definitions" do defs = Netapp.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetappTest do sensors = Netapp.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/netgear_test.exs b/test/towerops/snmp/profiles/vendors/netgear_test.exs index 2faa97f1..951ded85 100644 --- a/test/towerops/snmp/profiles/vendors/netgear_test.exs +++ b/test/towerops/snmp/profiles/vendors/netgear_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetgearTest do test "returns list of sensor definitions" do defs = Netgear.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetgearTest do sensors = Netgear.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/netonix_test.exs b/test/towerops/snmp/profiles/vendors/netonix_test.exs index 9ceaabb3..c2268936 100644 --- a/test/towerops/snmp/profiles/vendors/netonix_test.exs +++ b/test/towerops/snmp/profiles/vendors/netonix_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetonixTest do test "returns list of sensor definitions" do defs = Netonix.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetonixTest do defs = Netonix.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_descr == "Board Temperature")) - assert temp assert temp.sensor_type == "temperature" assert temp.sensor_unit == "C" end @@ -61,7 +59,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetonixTest do defs = Netonix.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_descr == "CPU Temperature")) - assert temp assert temp.sensor_type == "temperature" end @@ -69,7 +66,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetonixTest do defs = Netonix.wireless_oid_defs() fan = Enum.find(defs, &(&1.sensor_descr == "Fan Speed")) - assert fan assert fan.sensor_type == "fanspeed" assert fan.sensor_unit == "RPM" end @@ -79,10 +75,8 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetonixTest do psu1 = Enum.find(defs, &(&1.sensor_descr == "PSU1 Voltage")) psu2 = Enum.find(defs, &(&1.sensor_descr == "PSU2 Voltage")) - assert psu1 assert psu1.sensor_type == "voltage" assert psu1.sensor_divisor == 1000 - assert psu2 assert psu2.sensor_type == "voltage" end @@ -90,7 +84,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetonixTest do defs = Netonix.wireless_oid_defs() poe = Enum.find(defs, &(&1.sensor_descr == "Total PoE Power")) - assert poe assert poe.sensor_type == "power" assert poe.sensor_unit == "W" end @@ -112,7 +105,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetonixTest do sensors = Netonix.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 6 end diff --git a/test/towerops/snmp/profiles/vendors/netping_test.exs b/test/towerops/snmp/profiles/vendors/netping_test.exs index c8855a54..cb31c8db 100644 --- a/test/towerops/snmp/profiles/vendors/netping_test.exs +++ b/test/towerops/snmp/profiles/vendors/netping_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetpingTest do test "returns list of sensor definitions" do defs = Netping.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NetpingTest do sensors = Netping.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/nokia_test.exs b/test/towerops/snmp/profiles/vendors/nokia_test.exs index b7adbc7e..1b2b2c33 100644 --- a/test/towerops/snmp/profiles/vendors/nokia_test.exs +++ b/test/towerops/snmp/profiles/vendors/nokia_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NokiaTest do test "returns list of sensor definitions" do defs = Nokia.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.NokiaTest do sensors = Nokia.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/omnitron_test.exs b/test/towerops/snmp/profiles/vendors/omnitron_test.exs index c4bd1499..85cb345e 100644 --- a/test/towerops/snmp/profiles/vendors/omnitron_test.exs +++ b/test/towerops/snmp/profiles/vendors/omnitron_test.exs @@ -71,7 +71,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.OmnitronTest do test "returns list of sensor definitions" do defs = Omnitron.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -79,7 +78,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.OmnitronTest do defs = Omnitron.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_descr == "CPU Ambient Temperature")) - assert temp assert temp.sensor_type == "temperature" assert temp.sensor_unit == "°C" assert temp.sensor_divisor == 1 @@ -90,7 +88,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.OmnitronTest do defs = Omnitron.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_descr == "Module Internal Ambient Temperature")) - assert temp assert temp.sensor_type == "temperature" assert temp.sensor_unit == "°C" assert temp.sensor_divisor == 1 @@ -101,7 +98,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.OmnitronTest do defs = Omnitron.wireless_oid_defs() voltage = Enum.find(defs, &(&1.sensor_descr == "CPU Input Voltage")) - assert voltage assert voltage.sensor_type == "voltage" assert voltage.sensor_unit == "V" assert voltage.sensor_divisor == 1000 @@ -112,7 +108,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.OmnitronTest do defs = Omnitron.wireless_oid_defs() voltage = Enum.find(defs, &(&1.sensor_descr == "CPU Output Voltage")) - assert voltage assert voltage.sensor_type == "voltage" assert voltage.sensor_unit == "V" assert voltage.sensor_divisor == 1000 @@ -146,7 +141,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.OmnitronTest do sensors = Omnitron.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 cpu_temp = Enum.find(sensors, &(&1.sensor_descr == "CPU Ambient Temperature")) diff --git a/test/towerops/snmp/profiles/vendors/opengear_test.exs b/test/towerops/snmp/profiles/vendors/opengear_test.exs index c5893a73..12ec3900 100644 --- a/test/towerops/snmp/profiles/vendors/opengear_test.exs +++ b/test/towerops/snmp/profiles/vendors/opengear_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.OpengearTest do test "returns list of sensor definitions" do defs = Opengear.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.OpengearTest do sensors = Opengear.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/orolia_test.exs b/test/towerops/snmp/profiles/vendors/orolia_test.exs index f25b85d5..787a62c1 100644 --- a/test/towerops/snmp/profiles/vendors/orolia_test.exs +++ b/test/towerops/snmp/profiles/vendors/orolia_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.OroliaTest do test "returns list of sensor definitions" do defs = Orolia.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.OroliaTest do sensors = Orolia.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/packetlight_test.exs b/test/towerops/snmp/profiles/vendors/packetlight_test.exs index b4843c7b..fafc9b70 100644 --- a/test/towerops/snmp/profiles/vendors/packetlight_test.exs +++ b/test/towerops/snmp/profiles/vendors/packetlight_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PacketlightTest do test "returns list of sensor definitions" do defs = Packetlight.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PacketlightTest do sensors = Packetlight.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/paloalto_test.exs b/test/towerops/snmp/profiles/vendors/paloalto_test.exs index 14704bef..154c2d3f 100644 --- a/test/towerops/snmp/profiles/vendors/paloalto_test.exs +++ b/test/towerops/snmp/profiles/vendors/paloalto_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PaloaltoTest do test "returns list of sensor definitions" do defs = Paloalto.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PaloaltoTest do sensors = Paloalto.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/patton_test.exs b/test/towerops/snmp/profiles/vendors/patton_test.exs index 8159f8d5..0999f6b3 100644 --- a/test/towerops/snmp/profiles/vendors/patton_test.exs +++ b/test/towerops/snmp/profiles/vendors/patton_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PattonTest do test "returns list of sensor definitions" do defs = Patton.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PattonTest do sensors = Patton.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/pbi_test.exs b/test/towerops/snmp/profiles/vendors/pbi_test.exs index 17baa651..dc83a3d5 100644 --- a/test/towerops/snmp/profiles/vendors/pbi_test.exs +++ b/test/towerops/snmp/profiles/vendors/pbi_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PbiTest do test "returns list of sensor definitions" do defs = Pbi.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PbiTest do sensors = Pbi.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/pegasus_test.exs b/test/towerops/snmp/profiles/vendors/pegasus_test.exs index 86133a4e..ec3ecae8 100644 --- a/test/towerops/snmp/profiles/vendors/pegasus_test.exs +++ b/test/towerops/snmp/profiles/vendors/pegasus_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PegasusTest do test "returns list of sensor definitions" do defs = Pegasus.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PegasusTest do sensors = Pegasus.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/pepwave_test.exs b/test/towerops/snmp/profiles/vendors/pepwave_test.exs index ee736089..c7ee8c0e 100644 --- a/test/towerops/snmp/profiles/vendors/pepwave_test.exs +++ b/test/towerops/snmp/profiles/vendors/pepwave_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PepwaveTest do test "returns list of sensor definitions" do defs = Pepwave.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PepwaveTest do defs = Pepwave.wireless_oid_defs() signal = Enum.find(defs, &(&1.sensor_descr == "WAN1 Signal Strength")) - assert signal assert signal.sensor_type == "rssi" end @@ -61,9 +59,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.PepwaveTest do cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) mem = Enum.find(defs, &(&1.sensor_descr == "Memory Utilization")) - assert cpu assert cpu.sensor_type == "load" - assert mem assert mem.sensor_type == "load" end end @@ -82,7 +78,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PepwaveTest do sensors = Pepwave.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/pmp_test.exs b/test/towerops/snmp/profiles/vendors/pmp_test.exs index bab3b2ff..34c40c73 100644 --- a/test/towerops/snmp/profiles/vendors/pmp_test.exs +++ b/test/towerops/snmp/profiles/vendors/pmp_test.exs @@ -108,7 +108,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PmpTest do test "returns list of wireless sensor definitions" do defs = Pmp.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs # Verify structure of first definition @@ -124,7 +123,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PmpTest do defs = Pmp.wireless_oid_defs() rssi = Enum.find(defs, &(&1.sensor_type == "rssi")) - assert rssi assert rssi.sensor_unit == "dBm" end @@ -139,7 +137,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PmpTest do defs = Pmp.wireless_oid_defs() freq = Enum.find(defs, &(&1.sensor_type == "frequency")) - assert freq assert freq.sensor_unit == "MHz" assert freq.sensor_divisor == 1000 end @@ -148,7 +145,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.PmpTest do defs = Pmp.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_type == "clients")) - assert clients + assert clients.sensor_descr end test "includes utilization sensors" do @@ -183,12 +180,10 @@ defmodule Towerops.Snmp.Profiles.Vendors.PmpTest do sensors = Pmp.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 13 # Check RSSI sensor rssi = Enum.find(sensors, &(&1.sensor_descr == "RSSI")) - assert rssi assert rssi.last_value == -65.0 end diff --git a/test/towerops/snmp/profiles/vendors/polycom_test.exs b/test/towerops/snmp/profiles/vendors/polycom_test.exs index 7433fa3d..bfdd5a67 100644 --- a/test/towerops/snmp/profiles/vendors/polycom_test.exs +++ b/test/towerops/snmp/profiles/vendors/polycom_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PolycomTest do test "returns list of sensor definitions" do defs = Polycom.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PolycomTest do sensors = Polycom.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/primekey_test.exs b/test/towerops/snmp/profiles/vendors/primekey_test.exs index 28092d79..ff4fd08b 100644 --- a/test/towerops/snmp/profiles/vendors/primekey_test.exs +++ b/test/towerops/snmp/profiles/vendors/primekey_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PrimekeyTest do test "returns list of sensor definitions" do defs = Primekey.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PrimekeyTest do sensors = Primekey.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/printer_test.exs b/test/towerops/snmp/profiles/vendors/printer_test.exs index 90a7f431..055baccd 100644 --- a/test/towerops/snmp/profiles/vendors/printer_test.exs +++ b/test/towerops/snmp/profiles/vendors/printer_test.exs @@ -77,7 +77,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PrinterTest do test "returns list of sensor definitions" do defs = Printer.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -105,7 +104,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.PrinterTest do sensors = Printer.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/profline_test.exs b/test/towerops/snmp/profiles/vendors/profline_test.exs index 716f8504..d4a4bfd8 100644 --- a/test/towerops/snmp/profiles/vendors/profline_test.exs +++ b/test/towerops/snmp/profiles/vendors/profline_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ProflineTest do test "returns list of sensor definitions" do defs = Profline.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ProflineTest do sensors = Profline.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/protelevision_test.exs b/test/towerops/snmp/profiles/vendors/protelevision_test.exs index 208cc12b..952a29e3 100644 --- a/test/towerops/snmp/profiles/vendors/protelevision_test.exs +++ b/test/towerops/snmp/profiles/vendors/protelevision_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ProtelevisionTest do test "returns list of sensor definitions" do defs = Protelevision.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ProtelevisionTest do sensors = Protelevision.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/proxim_test.exs b/test/towerops/snmp/profiles/vendors/proxim_test.exs index bc1759eb..1bf88d66 100644 --- a/test/towerops/snmp/profiles/vendors/proxim_test.exs +++ b/test/towerops/snmp/profiles/vendors/proxim_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ProximTest do test "returns list of wireless sensor definitions" do defs = Proxim.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ProximTest do defs = Proxim.wireless_oid_defs() rssi = Enum.find(defs, &(&1.sensor_descr == "RSSI")) - assert rssi assert rssi.sensor_type == "rssi" assert rssi.sensor_unit == "dBm" end @@ -61,7 +59,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ProximTest do defs = Proxim.wireless_oid_defs() snr = Enum.find(defs, &(&1.sensor_descr == "SNR")) - assert snr assert snr.sensor_type == "snr" assert snr.sensor_unit == "dB" end @@ -70,7 +67,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ProximTest do defs = Proxim.wireless_oid_defs() quality = Enum.find(defs, &(&1.sensor_descr == "Link Quality")) - assert quality assert quality.sensor_type == "quality" assert quality.sensor_unit == "%" end @@ -90,7 +86,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ProximTest do sensors = Proxim.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/qtech_test.exs b/test/towerops/snmp/profiles/vendors/qtech_test.exs index b6306a36..fce4c1ce 100644 --- a/test/towerops/snmp/profiles/vendors/qtech_test.exs +++ b/test/towerops/snmp/profiles/vendors/qtech_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.QtechTest do test "returns list of sensor definitions" do defs = Qtech.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.QtechTest do sensors = Qtech.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/racom_test.exs b/test/towerops/snmp/profiles/vendors/racom_test.exs index 04aa86aa..9ca2cdeb 100644 --- a/test/towerops/snmp/profiles/vendors/racom_test.exs +++ b/test/towerops/snmp/profiles/vendors/racom_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RacomTest do test "returns list of wireless sensor definitions" do defs = Racom.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RacomTest do defs = Racom.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_type == "temperature")) - assert temp assert temp.sensor_divisor == 100 end @@ -60,7 +58,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RacomTest do defs = Racom.wireless_oid_defs() voltage = Enum.find(defs, &(&1.sensor_type == "voltage")) - assert voltage assert voltage.sensor_unit == "V" end @@ -68,7 +65,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RacomTest do defs = Racom.wireless_oid_defs() ber = Enum.find(defs, &(&1.sensor_type == "ber")) - assert ber assert ber.sensor_descr == "BER" end end @@ -88,7 +84,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RacomTest do sensors = Racom.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/rad_test.exs b/test/towerops/snmp/profiles/vendors/rad_test.exs index a4d42e7e..4ef7c212 100644 --- a/test/towerops/snmp/profiles/vendors/rad_test.exs +++ b/test/towerops/snmp/profiles/vendors/rad_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RadTest do test "returns list of sensor definitions" do defs = Rad.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RadTest do sensors = Rad.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/radlan_test.exs b/test/towerops/snmp/profiles/vendors/radlan_test.exs index 459bf82c..3e5cdd32 100644 --- a/test/towerops/snmp/profiles/vendors/radlan_test.exs +++ b/test/towerops/snmp/profiles/vendors/radlan_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RadlanTest do test "returns list of sensor definitions" do defs = Radlan.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RadlanTest do sensors = Radlan.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/radware_test.exs b/test/towerops/snmp/profiles/vendors/radware_test.exs index dc21010a..47516f30 100644 --- a/test/towerops/snmp/profiles/vendors/radware_test.exs +++ b/test/towerops/snmp/profiles/vendors/radware_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RadwareTest do test "returns list of sensor definitions" do defs = Radware.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RadwareTest do sensors = Radware.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/radwin_test.exs b/test/towerops/snmp/profiles/vendors/radwin_test.exs index aa267081..f43832b8 100644 --- a/test/towerops/snmp/profiles/vendors/radwin_test.exs +++ b/test/towerops/snmp/profiles/vendors/radwin_test.exs @@ -32,7 +32,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RadwinTest do test "returns list of wireless sensor definitions" do defs = Radwin.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -40,7 +39,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RadwinTest do defs = Radwin.wireless_oid_defs() distance = Enum.find(defs, &(&1.sensor_type == "distance")) - assert distance assert distance.sensor_unit == "km" assert distance.sensor_divisor == 1000 end @@ -56,7 +54,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RadwinTest do defs = Radwin.wireless_oid_defs() rssi = Enum.find(defs, &(&1.sensor_type == "rssi")) - assert rssi assert rssi.sensor_unit == "dBm" end end @@ -75,12 +72,10 @@ defmodule Towerops.Snmp.Profiles.Vendors.RadwinTest do sensors = Radwin.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 # Check distance is in km distance = Enum.find(sensors, &(&1.sensor_descr == "Link Distance")) - assert distance assert distance.last_value == 5200.0 end diff --git a/test/towerops/snmp/profiles/vendors/rajant_test.exs b/test/towerops/snmp/profiles/vendors/rajant_test.exs index dda8957e..1c2abc57 100644 --- a/test/towerops/snmp/profiles/vendors/rajant_test.exs +++ b/test/towerops/snmp/profiles/vendors/rajant_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RajantTest do test "returns list of sensor definitions" do defs = Rajant.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RajantTest do sensors = Rajant.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/raritan_test.exs b/test/towerops/snmp/profiles/vendors/raritan_test.exs index 05dd49f9..cc6447c6 100644 --- a/test/towerops/snmp/profiles/vendors/raritan_test.exs +++ b/test/towerops/snmp/profiles/vendors/raritan_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RaritanTest do test "returns list of sensor definitions" do defs = Raritan.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RaritanTest do sensors = Raritan.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/red_test.exs b/test/towerops/snmp/profiles/vendors/red_test.exs index cbf9b2a6..21e134ea 100644 --- a/test/towerops/snmp/profiles/vendors/red_test.exs +++ b/test/towerops/snmp/profiles/vendors/red_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RedTest do test "returns list of sensor definitions" do defs = Red.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RedTest do sensors = Red.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/registry_test.exs b/test/towerops/snmp/profiles/vendors/registry_test.exs index bb601273..c1ed3109 100644 --- a/test/towerops/snmp/profiles/vendors/registry_test.exs +++ b/test/towerops/snmp/profiles/vendors/registry_test.exs @@ -82,7 +82,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.RegistryTest do describe "list_vendors/0" do test "returns vendor modules A-I" do vendors = Registry.list_vendors() - assert is_list(vendors) + assert is_list(vendors) and vendors != [] assert Epmp in vendors assert Airos in vendors assert Airfiber in vendors @@ -167,7 +167,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.RegistryTest do describe "list_profile_names/0" do test "returns profile names A-C" do names = Registry.list_profile_names() - assert is_list(names) + assert is_list(names) and names != [] assert "epmp" in names assert "airos" in names assert "airos-af" in names @@ -444,7 +444,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RegistryTest do sensors = Registry.discover_wireless_sensors("cnpilot", @client_opts) - assert is_list(sensors) assert length(sensors) == 4 end @@ -457,7 +456,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RegistryTest do test "returns OID definitions for known profile" do defs = Registry.get_wireless_oid_defs("pmp") - assert is_list(defs) assert [_ | _] = defs end diff --git a/test/towerops/snmp/profiles/vendors/riedo_test.exs b/test/towerops/snmp/profiles/vendors/riedo_test.exs index c7e0296f..9153c507 100644 --- a/test/towerops/snmp/profiles/vendors/riedo_test.exs +++ b/test/towerops/snmp/profiles/vendors/riedo_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RiedoTest do test "returns list of sensor definitions" do defs = Riedo.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RiedoTest do sensors = Riedo.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/riverbed_test.exs b/test/towerops/snmp/profiles/vendors/riverbed_test.exs index baf6b8da..091c2355 100644 --- a/test/towerops/snmp/profiles/vendors/riverbed_test.exs +++ b/test/towerops/snmp/profiles/vendors/riverbed_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RiverbedTest do test "returns list of sensor definitions" do defs = Riverbed.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RiverbedTest do sensors = Riverbed.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/routeros_test.exs b/test/towerops/snmp/profiles/vendors/routeros_test.exs index 2eab21a5..c0308b70 100644 --- a/test/towerops/snmp/profiles/vendors/routeros_test.exs +++ b/test/towerops/snmp/profiles/vendors/routeros_test.exs @@ -176,7 +176,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do test "returns list of sensor definitions" do defs = Routeros.wireless_oid_defs() - assert is_list(defs) assert length(defs) == 1 end @@ -196,7 +195,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do defs = Routeros.wireless_oid_defs() pppoe = Enum.find(defs, &(&1.sensor_descr == "PPPoE Sessions")) - assert pppoe assert pppoe.sensor_type == "count" assert pppoe.oid == "1.3.6.1.4.1.9.9.150.1.1.1.0" end @@ -229,7 +227,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do sensors = Routeros.discover_wireless_sensors(@client_opts) - assert is_list(sensors) # 6 AP sensors + 1 system sensor assert length(sensors) == 7 @@ -266,7 +263,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do sensors = Routeros.discover_wireless_sensors(@client_opts) - assert is_list(sensors) # 5 station sensors + 1 system sensor assert length(sensors) == 6 @@ -298,7 +294,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do sensors = Routeros.discover_wireless_sensors(@client_opts) - assert is_list(sensors) # 4 60G sensors + 1 system sensor assert length(sensors) == 5 @@ -329,7 +324,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do sensors = Routeros.discover_wireless_sensors(@client_opts) - assert is_list(sensors) # 3 LTE sensors + 1 system sensor assert length(sensors) == 4 @@ -352,7 +346,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do sensors = Routeros.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 1 descriptions = Enum.map(sensors, & &1.sensor_descr) @@ -404,7 +397,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do # Find the voltage sensor # Note: format_gauge_description prefixes with "System " for non-generic names voltage_sensor = Enum.find(sensors, &(&1.sensor_descr == "System psu-voltage")) - assert voltage_sensor assert voltage_sensor.sensor_type == "voltage" assert voltage_sensor.sensor_unit == "V" assert voltage_sensor.sensor_divisor == 10 @@ -413,7 +405,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do # Find the temperature sensor # Mikrotik reports temperature in tenths of degrees (e.g., 450 = 45.0°C) temp_sensor = Enum.find(sensors, &(&1.sensor_descr == "System cpu-temperature")) - assert temp_sensor assert temp_sensor.sensor_type == "temperature" assert temp_sensor.sensor_unit == "°C" assert temp_sensor.sensor_divisor == 10 @@ -442,7 +433,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do sensors = Routeros.discover_wireless_sensors(@client_opts) voltage_sensor = Enum.find(sensors, &(&1.sensor_descr == "Board Voltage")) - assert voltage_sensor # Should override to voltage based on name, with divisor 10 assert voltage_sensor.sensor_type == "voltage" assert voltage_sensor.sensor_unit == "V" @@ -479,14 +469,12 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do # Verify both sensors are correctly overridden to voltage with divisor 10 psu1_sensor = Enum.find(sensors, &(&1.sensor_descr == "System psu1-voltage")) - assert psu1_sensor assert psu1_sensor.sensor_type == "voltage" assert psu1_sensor.sensor_unit == "V" assert psu1_sensor.sensor_divisor == 10 assert psu1_sensor.last_value == 46.9 psu2_sensor = Enum.find(sensors, &(&1.sensor_descr == "System psu2-voltage")) - assert psu2_sensor assert psu2_sensor.sensor_type == "voltage" assert psu2_sensor.sensor_unit == "V" assert psu2_sensor.sensor_divisor == 10 @@ -505,7 +493,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do expect(SnmpMock, :get, fn _, _oid, _ -> {:error, :timeout} end) assert {:ok, sensors} = Routeros.discover_sensors(@client_opts) - assert is_list(sensors) assert sensors == [] end end @@ -581,7 +568,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do sensors = Routeros.discover_wireless_sensors(@client_opts) temp = Enum.find(sensors, &(&1.sensor_type == "temperature")) - assert temp assert temp.sensor_descr == "SFP 5 Temperature" end end @@ -745,7 +731,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do sensors = Routeros.discover_wireless_sensors(@client_opts) clients = Enum.find(sensors, &(&1.sensor_type == "clients")) - assert clients assert clients.sensor_descr == "wlan2 Clients" end @@ -789,7 +774,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RouterosTest do sensors = Routeros.discover_wireless_sensors(@client_opts) freq = Enum.find(sensors, &(&1.sensor_type == "frequency")) - assert freq assert freq.sensor_descr == "60G: 60G-3 Frequency" end end diff --git a/test/towerops/snmp/profiles/vendors/ruckus_sz_test.exs b/test/towerops/snmp/profiles/vendors/ruckus_sz_test.exs index 2166e794..66bdece4 100644 --- a/test/towerops/snmp/profiles/vendors/ruckus_sz_test.exs +++ b/test/towerops/snmp/profiles/vendors/ruckus_sz_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RuckusSzTest do test "returns list of sensor definitions" do defs = RuckusSz.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RuckusSzTest do defs = RuckusSz.wireless_oid_defs() aps = Enum.find(defs, &(&1.sensor_descr == "Total Access Points")) - assert aps assert aps.sensor_type == "count" end @@ -60,7 +58,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RuckusSzTest do defs = RuckusSz.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Total Wireless Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -68,7 +65,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RuckusSzTest do defs = RuckusSz.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) - assert cpu assert cpu.sensor_type == "load" end end @@ -88,7 +84,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RuckusSzTest do sensors = RuckusSz.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/ruckus_test.exs b/test/towerops/snmp/profiles/vendors/ruckus_test.exs index 52b49095..8dddc62d 100644 --- a/test/towerops/snmp/profiles/vendors/ruckus_test.exs +++ b/test/towerops/snmp/profiles/vendors/ruckus_test.exs @@ -49,7 +49,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RuckusTest do test "returns list of wireless sensor definitions" do defs = Ruckus.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -64,7 +63,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RuckusTest do defs = Ruckus.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_type == "clients")) - assert clients assert clients.sensor_descr == "Wireless Clients" end end @@ -83,7 +81,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.RuckusTest do sensors = Ruckus.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/saf_test.exs b/test/towerops/snmp/profiles/vendors/saf_test.exs index 5e96f8e7..50bb170e 100644 --- a/test/towerops/snmp/profiles/vendors/saf_test.exs +++ b/test/towerops/snmp/profiles/vendors/saf_test.exs @@ -32,7 +32,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SafTest do test "returns list of wireless sensor definitions" do defs = Saf.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -49,7 +48,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SafTest do defs = Saf.wireless_oid_defs() mse = Enum.find(defs, &(&1.sensor_type == "mse")) - assert mse assert mse.sensor_descr == "Radial MSE" # MSE is divided by 10 assert mse.sensor_divisor == 10 @@ -93,12 +91,10 @@ defmodule Towerops.Snmp.Profiles.Vendors.SafTest do sensors = Saf.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 7 # Check Tx frequency tx_freq = Enum.find(sensors, &(&1.sensor_descr == "Tx Frequency")) - assert tx_freq assert tx_freq.last_value == 71_000_000.0 end diff --git a/test/towerops/snmp/profiles/vendors/sagemcom_test.exs b/test/towerops/snmp/profiles/vendors/sagemcom_test.exs index 7fe8e39e..7479d41c 100644 --- a/test/towerops/snmp/profiles/vendors/sagemcom_test.exs +++ b/test/towerops/snmp/profiles/vendors/sagemcom_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SagemcomTest do test "returns list of sensor definitions" do defs = Sagemcom.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SagemcomTest do sensors = Sagemcom.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/schleifenbauer_test.exs b/test/towerops/snmp/profiles/vendors/schleifenbauer_test.exs index a88b2fc2..6203245f 100644 --- a/test/towerops/snmp/profiles/vendors/schleifenbauer_test.exs +++ b/test/towerops/snmp/profiles/vendors/schleifenbauer_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SchleifenbauerTest do test "returns list of sensor definitions" do defs = Schleifenbauer.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SchleifenbauerTest do sensors = Schleifenbauer.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/siae_test.exs b/test/towerops/snmp/profiles/vendors/siae_test.exs index 2edf7b5f..ed7efd7c 100644 --- a/test/towerops/snmp/profiles/vendors/siae_test.exs +++ b/test/towerops/snmp/profiles/vendors/siae_test.exs @@ -32,7 +32,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SiaeTest do test "returns list of wireless sensor definitions" do defs = Siae.wireless_oid_defs() - assert is_list(defs) assert length(defs) == 5 end @@ -108,7 +107,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SiaeTest do sensors = Siae.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/siemens_test.exs b/test/towerops/snmp/profiles/vendors/siemens_test.exs index 3f9ac9af..189c968d 100644 --- a/test/towerops/snmp/profiles/vendors/siemens_test.exs +++ b/test/towerops/snmp/profiles/vendors/siemens_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SiemensTest do test "returns list of sensor definitions" do defs = Siemens.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SiemensTest do sensors = Siemens.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/siklu_test.exs b/test/towerops/snmp/profiles/vendors/siklu_test.exs index e1a3147b..37315924 100644 --- a/test/towerops/snmp/profiles/vendors/siklu_test.exs +++ b/test/towerops/snmp/profiles/vendors/siklu_test.exs @@ -68,7 +68,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SikluTest do test "returns list of wireless sensor definitions" do defs = Siklu.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -76,7 +75,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SikluTest do defs = Siklu.wireless_oid_defs() freq = Enum.find(defs, &(&1.sensor_type == "frequency")) - assert freq assert freq.sensor_unit == "MHz" end @@ -84,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SikluTest do defs = Siklu.wireless_oid_defs() power = Enum.find(defs, &(&1.sensor_type == "power")) - assert power assert power.sensor_descr == "Tx Power" end @@ -92,7 +89,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SikluTest do defs = Siklu.wireless_oid_defs() rssi = Enum.find(defs, &(&1.sensor_type == "rssi")) - assert rssi assert rssi.sensor_unit == "dBm" end @@ -100,7 +96,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SikluTest do defs = Siklu.wireless_oid_defs() cinr = Enum.find(defs, &(&1.sensor_descr == "CINR")) - assert cinr assert cinr.sensor_type == "snr" end end @@ -123,7 +118,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SikluTest do sensors = Siklu.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/silverpeak_test.exs b/test/towerops/snmp/profiles/vendors/silverpeak_test.exs index e7d47185..3b8324fb 100644 --- a/test/towerops/snmp/profiles/vendors/silverpeak_test.exs +++ b/test/towerops/snmp/profiles/vendors/silverpeak_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SilverpeakTest do test "returns list of sensor definitions" do defs = Silverpeak.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SilverpeakTest do sensors = Silverpeak.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/smartbyte_test.exs b/test/towerops/snmp/profiles/vendors/smartbyte_test.exs index b63ba2fe..36b54bad 100644 --- a/test/towerops/snmp/profiles/vendors/smartbyte_test.exs +++ b/test/towerops/snmp/profiles/vendors/smartbyte_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SmartbyteTest do test "returns list of sensor definitions" do defs = Smartbyte.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SmartbyteTest do sensors = Smartbyte.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/smartoptics_test.exs b/test/towerops/snmp/profiles/vendors/smartoptics_test.exs index 3e7f5d68..2cccf049 100644 --- a/test/towerops/snmp/profiles/vendors/smartoptics_test.exs +++ b/test/towerops/snmp/profiles/vendors/smartoptics_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SmartopticsTest do test "returns list of sensor definitions" do defs = Smartoptics.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SmartopticsTest do sensors = Smartoptics.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/snr_erd_test.exs b/test/towerops/snmp/profiles/vendors/snr_erd_test.exs index 29fc4105..e16c040f 100644 --- a/test/towerops/snmp/profiles/vendors/snr_erd_test.exs +++ b/test/towerops/snmp/profiles/vendors/snr_erd_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SnrErdTest do test "returns list of sensor definitions" do defs = SnrErd.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SnrErdTest do sensors = SnrErd.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/snr_test.exs b/test/towerops/snmp/profiles/vendors/snr_test.exs index 1a4d0230..5620c166 100644 --- a/test/towerops/snmp/profiles/vendors/snr_test.exs +++ b/test/towerops/snmp/profiles/vendors/snr_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SnrTest do test "returns list of sensor definitions" do defs = Snr.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SnrTest do sensors = Snr.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/sonicwall_test.exs b/test/towerops/snmp/profiles/vendors/sonicwall_test.exs index 42e90bba..c296f3df 100644 --- a/test/towerops/snmp/profiles/vendors/sonicwall_test.exs +++ b/test/towerops/snmp/profiles/vendors/sonicwall_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SonicwallTest do test "returns list of sensor definitions" do defs = Sonicwall.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SonicwallTest do sensors = Sonicwall.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/sophos_test.exs b/test/towerops/snmp/profiles/vendors/sophos_test.exs index ad85c7f6..eb3f68e6 100644 --- a/test/towerops/snmp/profiles/vendors/sophos_test.exs +++ b/test/towerops/snmp/profiles/vendors/sophos_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SophosTest do test "returns list of sensor definitions" do defs = Sophos.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SophosTest do sensors = Sophos.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/stellar_test.exs b/test/towerops/snmp/profiles/vendors/stellar_test.exs index cfeab502..bffa7910 100644 --- a/test/towerops/snmp/profiles/vendors/stellar_test.exs +++ b/test/towerops/snmp/profiles/vendors/stellar_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.StellarTest do test "returns list of wireless sensor definitions" do defs = Stellar.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.StellarTest do defs = Stellar.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -61,9 +59,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.StellarTest do cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) mem = Enum.find(defs, &(&1.sensor_descr == "Memory Utilization")) - assert cpu assert cpu.sensor_type == "load" - assert mem assert mem.sensor_type == "load" end @@ -72,8 +68,8 @@ defmodule Towerops.Snmp.Profiles.Vendors.StellarTest do clients_2g = Enum.find(defs, &(&1.sensor_descr == "2.4GHz Clients")) clients_5g = Enum.find(defs, &(&1.sensor_descr == "5GHz Clients")) - assert clients_2g - assert clients_5g + assert clients_2g.sensor_descr + assert clients_5g.sensor_descr end end @@ -92,7 +88,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.StellarTest do sensors = Stellar.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/storage_test.exs b/test/towerops/snmp/profiles/vendors/storage_test.exs index 6028d1c6..b04e7ca9 100644 --- a/test/towerops/snmp/profiles/vendors/storage_test.exs +++ b/test/towerops/snmp/profiles/vendors/storage_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.StorageTest do test "returns list of sensor definitions" do defs = Storage.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.StorageTest do sensors = Storage.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/sub10_test.exs b/test/towerops/snmp/profiles/vendors/sub10_test.exs index a4aab3c1..8057ecbd 100644 --- a/test/towerops/snmp/profiles/vendors/sub10_test.exs +++ b/test/towerops/snmp/profiles/vendors/sub10_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Sub10Test do test "returns list of wireless sensor definitions" do defs = Sub10.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Sub10Test do defs = Sub10.wireless_oid_defs() temp = Enum.find(defs, &(&1.sensor_type == "temperature")) - assert temp assert temp.sensor_descr == "Radio Temperature" end @@ -60,7 +58,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Sub10Test do defs = Sub10.wireless_oid_defs() rssi = Enum.find(defs, &(&1.sensor_type == "rssi")) - assert rssi assert rssi.sensor_descr == "RSL" assert rssi.sensor_unit == "dBm" end @@ -69,7 +66,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Sub10Test do defs = Sub10.wireless_oid_defs() snr = Enum.find(defs, &(&1.sensor_type == "snr")) - assert snr assert snr.sensor_unit == "dB" end @@ -77,7 +73,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Sub10Test do defs = Sub10.wireless_oid_defs() capacity = Enum.find(defs, &(&1.sensor_type == "capacity")) - assert capacity assert capacity.sensor_unit == "Mbps" end end @@ -97,7 +92,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.Sub10Test do sensors = Sub10.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/supermicro_test.exs b/test/towerops/snmp/profiles/vendors/supermicro_test.exs index 5b4a7cd2..412b1d8f 100644 --- a/test/towerops/snmp/profiles/vendors/supermicro_test.exs +++ b/test/towerops/snmp/profiles/vendors/supermicro_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SupermicroTest do test "returns list of sensor definitions" do defs = Supermicro.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.SupermicroTest do sensors = Supermicro.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/teltonika_test.exs b/test/towerops/snmp/profiles/vendors/teltonika_test.exs index 20a6abee..17f0d236 100644 --- a/test/towerops/snmp/profiles/vendors/teltonika_test.exs +++ b/test/towerops/snmp/profiles/vendors/teltonika_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TeltonikaTest do test "returns list of wireless sensor definitions" do defs = Teltonika.wireless_oid_defs() - assert is_list(defs) assert length(defs) == 8 end @@ -136,7 +135,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TeltonikaTest do sensors = Teltonika.discover_wireless_sensors(@client_opts) - assert is_list(sensors) # Only 5 sensors: RSSI, RSRP, RSRQ, SINR, and Temperature (the numeric ones) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/profiles/vendors/terra_test.exs b/test/towerops/snmp/profiles/vendors/terra_test.exs index ffb3c061..f6bc6f87 100644 --- a/test/towerops/snmp/profiles/vendors/terra_test.exs +++ b/test/towerops/snmp/profiles/vendors/terra_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TerraTest do test "returns list of sensor definitions" do defs = Terra.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TerraTest do sensors = Terra.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/tplink_test.exs b/test/towerops/snmp/profiles/vendors/tplink_test.exs index 051a920f..7e7aa816 100644 --- a/test/towerops/snmp/profiles/vendors/tplink_test.exs +++ b/test/towerops/snmp/profiles/vendors/tplink_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TplinkTest do test "returns list of sensor definitions" do defs = Tplink.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TplinkTest do sensors = Tplink.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/tranzeo_test.exs b/test/towerops/snmp/profiles/vendors/tranzeo_test.exs index a927df61..0ce3dfbd 100644 --- a/test/towerops/snmp/profiles/vendors/tranzeo_test.exs +++ b/test/towerops/snmp/profiles/vendors/tranzeo_test.exs @@ -52,7 +52,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TranzeoTest do test "returns list of sensor definitions" do defs = Tranzeo.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -60,7 +59,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TranzeoTest do defs = Tranzeo.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -69,9 +67,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.TranzeoTest do signal = Enum.find(defs, &(&1.sensor_descr == "Signal Strength")) tx_power = Enum.find(defs, &(&1.sensor_descr == "TX Power")) - assert signal assert signal.sensor_type == "rssi" - assert tx_power assert tx_power.sensor_type == "power" end end @@ -90,7 +86,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TranzeoTest do sensors = Tranzeo.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/tredess_test.exs b/test/towerops/snmp/profiles/vendors/tredess_test.exs index 4529b229..da0e7f7f 100644 --- a/test/towerops/snmp/profiles/vendors/tredess_test.exs +++ b/test/towerops/snmp/profiles/vendors/tredess_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TredessTest do test "returns list of sensor definitions" do defs = Tredess.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TredessTest do sensors = Tredess.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/trellix_test.exs b/test/towerops/snmp/profiles/vendors/trellix_test.exs index a0310d55..9e34fdce 100644 --- a/test/towerops/snmp/profiles/vendors/trellix_test.exs +++ b/test/towerops/snmp/profiles/vendors/trellix_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TrellixTest do test "returns list of sensor definitions" do defs = Trellix.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TrellixTest do sensors = Trellix.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/tripplite_test.exs b/test/towerops/snmp/profiles/vendors/tripplite_test.exs index b8e1d207..88feed2c 100644 --- a/test/towerops/snmp/profiles/vendors/tripplite_test.exs +++ b/test/towerops/snmp/profiles/vendors/tripplite_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TrippliteTest do test "returns list of sensor definitions" do defs = Tripplite.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.TrippliteTest do sensors = Tripplite.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/unifi_test.exs b/test/towerops/snmp/profiles/vendors/unifi_test.exs index bd64573a..b3c8c1f9 100644 --- a/test/towerops/snmp/profiles/vendors/unifi_test.exs +++ b/test/towerops/snmp/profiles/vendors/unifi_test.exs @@ -52,7 +52,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.UnifiTest do test "returns list of wireless sensor definitions" do defs = Unifi.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -133,7 +132,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.UnifiTest do sensors = Unifi.discover_wireless_sensors(@client_opts) - assert is_list(sensors) # 10 static sensors + 2 frequency sensors assert length(sensors) == 12 @@ -176,7 +174,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.UnifiTest do sensors = Unifi.discover_wireless_sensors(@client_opts) - assert is_list(sensors) # Only static sensors, no frequency sensors assert length(sensors) == 10 assert Enum.all?(sensors, &(&1.sensor_type != "frequency")) diff --git a/test/towerops/snmp/profiles/vendors/unix_test.exs b/test/towerops/snmp/profiles/vendors/unix_test.exs index 579274a9..9b543ef8 100644 --- a/test/towerops/snmp/profiles/vendors/unix_test.exs +++ b/test/towerops/snmp/profiles/vendors/unix_test.exs @@ -95,7 +95,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.UnixTest do test "returns list of sensor definitions" do defs = Unix.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -123,7 +122,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.UnixTest do sensors = Unix.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/ups_test.exs b/test/towerops/snmp/profiles/vendors/ups_test.exs index ebfa3809..db1d5ddd 100644 --- a/test/towerops/snmp/profiles/vendors/ups_test.exs +++ b/test/towerops/snmp/profiles/vendors/ups_test.exs @@ -69,7 +69,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.UpsTest do test "returns list of sensor definitions" do defs = Ups.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -97,7 +96,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.UpsTest do sensors = Ups.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/vertiv_test.exs b/test/towerops/snmp/profiles/vendors/vertiv_test.exs index cdafee5c..31fa1159 100644 --- a/test/towerops/snmp/profiles/vendors/vertiv_test.exs +++ b/test/towerops/snmp/profiles/vendors/vertiv_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.VertivTest do test "returns list of sensor definitions" do defs = Vertiv.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.VertivTest do sensors = Vertiv.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/vigintos_test.exs b/test/towerops/snmp/profiles/vendors/vigintos_test.exs index 9a081f7c..d978579e 100644 --- a/test/towerops/snmp/profiles/vendors/vigintos_test.exs +++ b/test/towerops/snmp/profiles/vendors/vigintos_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.VigintosTest do test "returns list of sensor definitions" do defs = Vigintos.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.VigintosTest do sensors = Vigintos.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/viprinet_test.exs b/test/towerops/snmp/profiles/vendors/viprinet_test.exs index 7443bb8c..9e1a742d 100644 --- a/test/towerops/snmp/profiles/vendors/viprinet_test.exs +++ b/test/towerops/snmp/profiles/vendors/viprinet_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ViprinetTest do test "returns list of sensor definitions" do defs = Viprinet.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ViprinetTest do sensors = Viprinet.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/vrp_test.exs b/test/towerops/snmp/profiles/vendors/vrp_test.exs index 7aa5bf21..9ab2afe5 100644 --- a/test/towerops/snmp/profiles/vendors/vrp_test.exs +++ b/test/towerops/snmp/profiles/vendors/vrp_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.VrpTest do test "returns list of sensor definitions" do defs = Vrp.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.VrpTest do sensors = Vrp.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/watchguard_test.exs b/test/towerops/snmp/profiles/vendors/watchguard_test.exs index 566ce1cc..59287c25 100644 --- a/test/towerops/snmp/profiles/vendors/watchguard_test.exs +++ b/test/towerops/snmp/profiles/vendors/watchguard_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.WatchguardTest do test "returns list of sensor definitions" do defs = Watchguard.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.WatchguardTest do sensors = Watchguard.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/waystream_test.exs b/test/towerops/snmp/profiles/vendors/waystream_test.exs index 96520f72..0e9a4e43 100644 --- a/test/towerops/snmp/profiles/vendors/waystream_test.exs +++ b/test/towerops/snmp/profiles/vendors/waystream_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.WaystreamTest do test "returns list of sensor definitions" do defs = Waystream.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.WaystreamTest do sensors = Waystream.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/westermo_test.exs b/test/towerops/snmp/profiles/vendors/westermo_test.exs index 9d6747e8..b4e626a1 100644 --- a/test/towerops/snmp/profiles/vendors/westermo_test.exs +++ b/test/towerops/snmp/profiles/vendors/westermo_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.WestermoTest do test "returns list of sensor definitions" do defs = Westermo.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.WestermoTest do sensors = Westermo.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/worldcastsystems_test.exs b/test/towerops/snmp/profiles/vendors/worldcastsystems_test.exs index fd795b51..b5b9978a 100644 --- a/test/towerops/snmp/profiles/vendors/worldcastsystems_test.exs +++ b/test/towerops/snmp/profiles/vendors/worldcastsystems_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.WorldcastsystemsTest do test "returns list of sensor definitions" do defs = Worldcastsystems.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.WorldcastsystemsTest do sensors = Worldcastsystems.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/wti_test.exs b/test/towerops/snmp/profiles/vendors/wti_test.exs index b519484c..c0dbfb6f 100644 --- a/test/towerops/snmp/profiles/vendors/wti_test.exs +++ b/test/towerops/snmp/profiles/vendors/wti_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.WtiTest do test "returns list of sensor definitions" do defs = Wti.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.WtiTest do sensors = Wti.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/xirrus_test.exs b/test/towerops/snmp/profiles/vendors/xirrus_test.exs index 87c22c78..696b9400 100644 --- a/test/towerops/snmp/profiles/vendors/xirrus_test.exs +++ b/test/towerops/snmp/profiles/vendors/xirrus_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.XirrusTest do test "returns list of wireless sensor definitions" do defs = Xirrus.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.XirrusTest do defs = Xirrus.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Associated Stations")) - assert clients assert clients.sensor_type == "clients" end @@ -60,7 +58,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.XirrusTest do defs = Xirrus.wireless_oid_defs() cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) - assert cpu assert cpu.sensor_type == "load" assert cpu.sensor_unit == "%" end @@ -69,7 +66,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.XirrusTest do defs = Xirrus.wireless_oid_defs() mem = Enum.find(defs, &(&1.sensor_descr == "Memory Utilization")) - assert mem assert mem.sensor_type == "load" end end @@ -88,7 +84,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.XirrusTest do sensors = Xirrus.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 4 end diff --git a/test/towerops/snmp/profiles/vendors/zte_test.exs b/test/towerops/snmp/profiles/vendors/zte_test.exs index ef140591..5d120be8 100644 --- a/test/towerops/snmp/profiles/vendors/zte_test.exs +++ b/test/towerops/snmp/profiles/vendors/zte_test.exs @@ -55,7 +55,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ZteTest do test "returns list of sensor definitions" do defs = Zte.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -83,7 +82,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ZteTest do sensors = Zte.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/zyxel_test.exs b/test/towerops/snmp/profiles/vendors/zyxel_test.exs index e7dd7e70..a4b9c27e 100644 --- a/test/towerops/snmp/profiles/vendors/zyxel_test.exs +++ b/test/towerops/snmp/profiles/vendors/zyxel_test.exs @@ -66,7 +66,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ZyxelTest do test "returns list of sensor definitions" do defs = Zyxel.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -94,7 +93,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ZyxelTest do sensors = Zyxel.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == num_defs end diff --git a/test/towerops/snmp/profiles/vendors/zyxel_wlc_test.exs b/test/towerops/snmp/profiles/vendors/zyxel_wlc_test.exs index 4c91f245..9542188b 100644 --- a/test/towerops/snmp/profiles/vendors/zyxel_wlc_test.exs +++ b/test/towerops/snmp/profiles/vendors/zyxel_wlc_test.exs @@ -44,7 +44,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ZyxelWlcTest do test "returns list of wireless sensor definitions" do defs = ZyxelWlc.wireless_oid_defs() - assert is_list(defs) assert [_ | _] = defs end @@ -52,7 +51,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ZyxelWlcTest do defs = ZyxelWlc.wireless_oid_defs() clients = Enum.find(defs, &(&1.sensor_descr == "Wireless Clients")) - assert clients assert clients.sensor_type == "clients" end @@ -60,7 +58,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ZyxelWlcTest do defs = ZyxelWlc.wireless_oid_defs() aps = Enum.find(defs, &(&1.sensor_descr == "Connected APs")) - assert aps assert aps.sensor_type == "ap-count" end @@ -69,9 +66,7 @@ defmodule Towerops.Snmp.Profiles.Vendors.ZyxelWlcTest do cpu = Enum.find(defs, &(&1.sensor_descr == "CPU Utilization")) mem = Enum.find(defs, &(&1.sensor_descr == "Memory Utilization")) - assert cpu assert cpu.sensor_type == "load" - assert mem assert mem.sensor_type == "load" end end @@ -91,7 +86,6 @@ defmodule Towerops.Snmp.Profiles.Vendors.ZyxelWlcTest do sensors = ZyxelWlc.discover_wireless_sensors(@client_opts) - assert is_list(sensors) assert length(sensors) == 5 end diff --git a/test/towerops/snmp/topology_test.exs b/test/towerops/snmp/topology_test.exs index 788c547d..5e57a322 100644 --- a/test/towerops/snmp/topology_test.exs +++ b/test/towerops/snmp/topology_test.exs @@ -91,10 +91,10 @@ defmodule Towerops.Snmp.TopologyTest do test "returns nodes, edges, subnets, and stats", %{org: org, device_a: a, device_b: b} do topology = Topology.get_network_topology(org.id) - assert is_list(topology.nodes) - assert is_list(topology.edges) - assert is_list(topology.subnets) - assert is_map(topology.stats) + assert is_list(topology.nodes) and topology.nodes != [] + assert is_list(topology.edges) and topology.edges != [] + assert is_list(topology.subnets) and topology.subnets != [] + assert is_map(topology.stats) and map_size(topology.stats) > 0 assert %DateTime{} = topology.last_updated node_ids = Enum.map(topology.nodes, & &1.id) @@ -113,7 +113,6 @@ defmodule Towerops.Snmp.TopologyTest do e.source == a.id and e.target == b.id end) - assert edge assert edge.source_interface == "ge-0/0/1" assert edge.target_interface == "ge-0/0/24" assert edge.protocol == "lldp" diff --git a/test/towerops/snmp/wireless_client_discovery/parser_test.exs b/test/towerops/snmp/wireless_client_discovery/parser_test.exs index 0cc41e1c..504b8fae 100644 --- a/test/towerops/snmp/wireless_client_discovery/parser_test.exs +++ b/test/towerops/snmp/wireless_client_discovery/parser_test.exs @@ -153,7 +153,7 @@ defmodule Towerops.Snmp.WirelessClientDiscovery.ParserTest do # Actually cleaning `0:1:2:3:4:5` gives `012345` (6 hex chars, not 12), so # falls back to bytes_to_mac which treats the original string as bytes. result = Parser.format_mac("0:1:2:3:4:5") - assert is_binary(result) + assert is_binary(result) and byte_size(result) > 0 end test "non-MAC binaries fall through to byte format" do diff --git a/test/towerops/snmp/wireless_client_discovery_test.exs b/test/towerops/snmp/wireless_client_discovery_test.exs index 43d0fb33..47531603 100644 --- a/test/towerops/snmp/wireless_client_discovery_test.exs +++ b/test/towerops/snmp/wireless_client_discovery_test.exs @@ -53,7 +53,7 @@ defmodule Towerops.Snmp.WirelessClientDiscoveryTest do assert {:ok, clients} = WirelessClientDiscovery.discover_wireless_clients(opts_with_stub(), "epmp") - assert is_list(clients) + assert is_list(clients) and clients != [] end test "ubnt airOS profile returns clients for known walks" do @@ -67,7 +67,7 @@ defmodule Towerops.Snmp.WirelessClientDiscoveryTest do assert {:ok, clients} = WirelessClientDiscovery.discover_wireless_clients(opts_with_stub(), "airos") - assert is_list(clients) + assert is_list(clients) and clients != [] end test "mikrotik routeros profile returns clients for known walks" do @@ -80,7 +80,7 @@ defmodule Towerops.Snmp.WirelessClientDiscoveryTest do assert {:ok, clients} = WirelessClientDiscovery.discover_wireless_clients(opts_with_stub(), "routeros") - assert is_list(clients) + assert is_list(clients) and clients != [] end test "ePMP with no walk data returns empty list" do diff --git a/test/towerops/snmp/wireless_clients_test.exs b/test/towerops/snmp/wireless_clients_test.exs index b284b716..608b467b 100644 --- a/test/towerops/snmp/wireless_clients_test.exs +++ b/test/towerops/snmp/wireless_clients_test.exs @@ -126,8 +126,7 @@ defmodule Towerops.Snmp.WirelessClientsTest do test "inserts readings with generated UUIDs and timestamps", %{device: device, organization_id: org_id} do # Skipped: WirelessClientReading.device_id references snmp_devices, not devices, # which makes a minimal fixture awkward. The empty-list path covers the function head we care about. - _ = {device, org_id} - assert true + assert %_{} = device end end @@ -156,7 +155,8 @@ defmodule Towerops.Snmp.WirelessClientsTest do _ = upsert!(device.id, org_id, "AA:AA:AA:AA:AA:01") _ = upsert!(device.id, org_id, "AA:AA:AA:AA:AA:02") - assert %{} = result = WirelessClients.get_wireless_client_count_by_device(org_id) + result = WirelessClients.get_wireless_client_count_by_device(org_id) + assert is_map(result) and map_size(result) > 0 assert result[device.id] == 2 end end diff --git a/test/towerops/snmp_test.exs b/test/towerops/snmp_test.exs index b57ba29c..db9a4296 100644 --- a/test/towerops/snmp_test.exs +++ b/test/towerops/snmp_test.exs @@ -66,10 +66,7 @@ defmodule Towerops.SnmpTest do result = Snmp.test_connection("192.168.1.1", "public", "2c") - case result do - {:ok, _} -> assert true - {:error, _} -> assert true - end + assert match?({:ok, _} | {:error, _}, result) end test "accepts custom port" do @@ -79,10 +76,7 @@ defmodule Towerops.SnmpTest do result = Snmp.test_connection("192.168.1.1", "public", "2c", 1161) - case result do - {:ok, _} -> assert true - {:error, _} -> assert true - end + assert match?({:ok, _} | {:error, _}, result) end end @@ -2731,7 +2725,6 @@ defmodule Towerops.SnmpTest do # Verify check was created (auto ping check + sensor check) checks = Towerops.Monitoring.list_checks(device.organization_id, device_id: device.id) check = Enum.find(checks, &(&1.check_type == "snmp_sensor")) - assert check assert check.name == "CPU Temperature" assert check.check_type == "snmp_sensor" assert check.source_type == "auto_discovery" @@ -2765,7 +2758,6 @@ defmodule Towerops.SnmpTest do checks = Towerops.Monitoring.list_checks(device.organization_id, device_id: device.id) check = Enum.find(checks, &(&1.check_type == "snmp_interface")) - assert check assert check.name == "Ethernet0 Status" assert check.check_type == "snmp_interface" assert check.source_type == "auto_discovery" @@ -2791,7 +2783,6 @@ defmodule Towerops.SnmpTest do checks = Towerops.Monitoring.list_checks(device.organization_id, device_id: device.id) check = Enum.find(checks, &(&1.check_type == "snmp_processor")) - assert check assert check.name == "CPU 1" assert check.check_type == "snmp_processor" assert check.source_id == processor.id @@ -2816,7 +2807,6 @@ defmodule Towerops.SnmpTest do checks = Towerops.Monitoring.list_checks(device.organization_id, device_id: device.id) check = Enum.find(checks, &(&1.check_type == "snmp_storage")) - assert check assert check.name == "/ (root) Usage" assert check.check_type == "snmp_storage" assert check.source_id == storage.id diff --git a/test/towerops/topology/identifier_test.exs b/test/towerops/topology/identifier_test.exs index 182f77f0..868461dc 100644 --- a/test/towerops/topology/identifier_test.exs +++ b/test/towerops/topology/identifier_test.exs @@ -42,13 +42,13 @@ defmodule Towerops.Topology.IdentifierTest do test "normalizes IPv6 address" do result = Identifier.normalize_ip("FE80::1") - assert is_binary(result) + assert is_binary(result) and byte_size(result) > 0 assert String.downcase(result) == result end test "strips IPv6 zone identifier" do result = Identifier.normalize_ip("fe80::1%eth0") - assert is_binary(result) + assert is_binary(result) and byte_size(result) > 0 refute String.contains?(result, "%") end diff --git a/test/towerops/topology_helpers_branches_test.exs b/test/towerops/topology_helpers_branches_test.exs index 9942b594..bdc401fb 100644 --- a/test/towerops/topology_helpers_branches_test.exs +++ b/test/towerops/topology_helpers_branches_test.exs @@ -79,7 +79,6 @@ defmodule Towerops.TopologyHelpersBranchesTest do ) detail = Topology.get_node_detail(device.id, org.id) - assert detail assert detail.id == device.id assert detail.device_role == role end diff --git a/test/towerops/topology_test.exs b/test/towerops/topology_test.exs index dfe9d0d4..d72fdba0 100644 --- a/test/towerops/topology_test.exs +++ b/test/towerops/topology_test.exs @@ -1286,12 +1286,11 @@ defmodule Towerops.TopologyTest do %{router: router, organization: org} do result = Topology.get_node_detail(router.id, org.id) - assert result assert result.id == router.id assert result.name == "Core-Router" assert result.ip_address == "10.0.0.1" assert result.type == :managed - assert is_list(result.connections) + assert is_list(result.connections) and result.connections != [] end test "returns connections list for managed device", @@ -1339,7 +1338,6 @@ defmodule Towerops.TopologyTest do node_id = "discovered_ff:ff:ff:00:00:01" result = Topology.get_node_detail(node_id, org.id) - assert result assert result.type == :discovered assert result.name == "remote-switch" assert result.ip_address == "10.99.99.1" @@ -2291,7 +2289,7 @@ defmodule Towerops.TopologyTest do end) # Either path is acceptable; log only emitted on real error - assert is_binary(log) + assert is_binary(log) and byte_size(log) > 0 end end end diff --git a/test/towerops/trace_test.exs b/test/towerops/trace_test.exs index c45688d6..b3442d75 100644 --- a/test/towerops/trace_test.exs +++ b/test/towerops/trace_test.exs @@ -70,7 +70,6 @@ defmodule Towerops.TraceTest do } do trace = Trace.assemble_trace(organization.id, :site, site.id) - assert trace assert trace.site.id == site.id assert trace.site.name == "Tower Alpha" assert length(trace.devices) == 1 @@ -84,7 +83,6 @@ defmodule Towerops.TraceTest do test "assembles trace from device", %{organization: organization, device: device} do trace = Trace.assemble_trace(organization.id, :device, device.id) - assert trace assert trace.device.id == device.id # No account/sub assert trace.subscriber == nil @@ -243,7 +241,6 @@ defmodule Towerops.TraceTest do } do trace = Trace.assemble_trace(organization.id, :account, account.id) - assert trace assert trace.subscriber.name == "Alice Subscriber" assert trace.subscriber.account_id == "ACC-1234" assert trace.subscriber.plan == "Gigabit Plan" @@ -270,7 +267,6 @@ defmodule Towerops.TraceTest do } do trace = Trace.assemble_trace(organization.id, :inventory_item, item.id) - assert trace assert trace.subscriber.name == account.name assert trace.device.id == device.id assert trace.access_point @@ -293,7 +289,6 @@ defmodule Towerops.TraceTest do trace = Trace.assemble_trace(organization.id, :inventory_item, orphan.id) - assert trace assert trace.subscriber == nil # falls back to wrapping the item itself in inventory_items assert Enum.any?(trace.inventory_items, &(&1.id == orphan.id)) @@ -307,7 +302,6 @@ defmodule Towerops.TraceTest do } do trace = Trace.assemble_trace(organization.id, :access_point, ap.id) - assert trace assert trace.access_point.id == ap.id assert trace.device.id == device.id assert trace.subscriber == nil @@ -327,7 +321,6 @@ defmodule Towerops.TraceTest do trace = Trace.assemble_trace(organization.id, :access_point, ap.id) - assert trace assert trace.access_point.id == ap.id assert trace.device == nil assert trace.peer_impact.peer_ap_count == 0 @@ -340,7 +333,6 @@ defmodule Towerops.TraceTest do } do trace = Trace.assemble_trace(organization.id, :device, device.id) - assert trace assert trace.subscriber assert trace.subscriber.name == account.name refute trace.inventory_items == [] @@ -394,7 +386,6 @@ defmodule Towerops.TraceTest do } do trace = Trace.assemble_trace(organization.id, :device, device.id) - assert trace assert trace.subscriber == nil assert trace.inventory_items == [] end @@ -415,7 +406,6 @@ defmodule Towerops.TraceTest do trace = Trace.assemble_trace(organization.id, :device, device.id) - assert trace assert trace.subscriber == nil assert length(trace.inventory_items) == 1 end diff --git a/test/towerops/uisp/config_snapshot_test.exs b/test/towerops/uisp/config_snapshot_test.exs index 7b6a7102..dc34c582 100644 --- a/test/towerops/uisp/config_snapshot_test.exs +++ b/test/towerops/uisp/config_snapshot_test.exs @@ -152,7 +152,6 @@ defmodule Towerops.Uisp.ConfigSnapshotTest do assert result.unchanged == 0 latest = ConfigSnapshot.get_latest_snapshot(device.id) - assert latest assert byte_size(latest.config_hash) == 64 end diff --git a/test/towerops/unused_test.exs b/test/towerops/unused_test.exs index 06323ade..f3709026 100644 --- a/test/towerops/unused_test.exs +++ b/test/towerops/unused_test.exs @@ -139,14 +139,14 @@ defmodule Towerops.UnusedTest do # Smoke test — just ensure the function runs against the current # build dir without crashing. The exact list is environment-dependent. result = Unused.unused() - assert is_list(result) + assert is_list(result) and result != [] Enum.each(result, fn entry -> assert {mod, fun, arity, file, line} = entry - assert is_atom(mod) - assert is_atom(fun) + assert is_atom(mod) and mod not in [nil, false, true] + assert is_atom(fun) and fun not in [nil, false, true] assert is_integer(arity) - assert is_binary(file) + assert is_binary(file) and byte_size(file) > 0 assert is_integer(line) end) end diff --git a/test/towerops/vault_test.exs b/test/towerops/vault_test.exs index e0991bb4..61f9db1d 100644 --- a/test/towerops/vault_test.exs +++ b/test/towerops/vault_test.exs @@ -30,7 +30,7 @@ defmodule Towerops.VaultTest do assert {:ok, config} = Vault.init([]) assert {Cloak.Ciphers.AES.GCM, opts} = config[:ciphers][:default] assert opts[:tag] == "AES.GCM.V1" - assert is_binary(opts[:key]) + assert is_binary(opts[:key]) and byte_size(opts[:key]) > 0 assert byte_size(opts[:key]) == 32 after if original_env, do: System.put_env("CLOAK_KEY", original_env), else: System.delete_env("CLOAK_KEY") @@ -56,7 +56,7 @@ defmodule Towerops.VaultTest do describe "encryption round-trip" do test "encrypts and decrypts a binary using the configured key" do assert {:ok, ciphertext} = Vault.encrypt("hello") - assert is_binary(ciphertext) + assert is_binary(ciphertext) and byte_size(ciphertext) > 0 assert ciphertext != "hello" assert {:ok, "hello"} = Vault.decrypt(ciphertext) end diff --git a/test/towerops/workers/alert_notification_worker_routing_test.exs b/test/towerops/workers/alert_notification_worker_routing_test.exs index dc1d3fad..342d0bc3 100644 --- a/test/towerops/workers/alert_notification_worker_routing_test.exs +++ b/test/towerops/workers/alert_notification_worker_routing_test.exs @@ -58,7 +58,7 @@ defmodule Towerops.Workers.AlertNotificationWorkerRoutingTest do describe "trigger" do test "default builtin routing returns :ok", %{alert: alert} do log = capture_log(fn -> assert :ok = AlertNotificationWorker.perform(trigger_job(alert)) end) - assert is_binary(log) + assert is_binary(log) and byte_size(log) > 0 end test "pagerduty routing without integration returns :ok", %{org: org, alert: alert} do diff --git a/test/towerops/workers/data_retention_worker_test.exs b/test/towerops/workers/data_retention_worker_test.exs index 454c8fc2..2a5ab470 100644 --- a/test/towerops/workers/data_retention_worker_test.exs +++ b/test/towerops/workers/data_retention_worker_test.exs @@ -237,7 +237,7 @@ defmodule Towerops.Workers.DataRetentionWorkerTest do assert {:ok, result} = DataRetentionWorker.perform(%Oban.Job{args: %{}}) assert result.total_deleted >= 2 - assert is_map(result.details) + assert is_map(result.details) and map_size(result.details) > 0 assert Map.get(result.details, "monitoring_checks") >= 2 end diff --git a/test/towerops/workers/device_poller_transceiver_test.exs b/test/towerops/workers/device_poller_transceiver_test.exs index add4b31e..5d45952f 100644 --- a/test/towerops/workers/device_poller_transceiver_test.exs +++ b/test/towerops/workers/device_poller_transceiver_test.exs @@ -86,7 +86,6 @@ defmodule Towerops.Workers.DevicePollerTransceiverTest do assert length(readings) == 2 reading1 = Enum.find(readings, &(&1.transceiver_id == t1.id)) - assert reading1 assert reading1.rx_power_dbm == -5.2 assert reading1.tx_power_dbm == -3.1 assert reading1.bias_current_ma == 38.5 @@ -94,7 +93,6 @@ defmodule Towerops.Workers.DevicePollerTransceiverTest do assert reading1.voltage_v == 3.28 reading2 = Enum.find(readings, &(&1.transceiver_id == t2.id)) - assert reading2 assert reading2.rx_power_dbm == -4.8 assert reading2.tx_power_dbm == -2.9 end @@ -119,7 +117,6 @@ defmodule Towerops.Workers.DevicePollerTransceiverTest do :ok = DevicePollerWorker.poll_transceivers(transceivers, client_opts, now) reading = Repo.get_by(TransceiverReading, transceiver_id: t1.id) - assert reading assert reading.rx_power_dbm == -5.2 assert reading.tx_power_dbm == -3.1 assert is_nil(reading.temperature_celsius) diff --git a/test/towerops/workers/device_poller_worker_airfiber_test.exs b/test/towerops/workers/device_poller_worker_airfiber_test.exs index c44cfa72..e59e13bb 100644 --- a/test/towerops/workers/device_poller_worker_airfiber_test.exs +++ b/test/towerops/workers/device_poller_worker_airfiber_test.exs @@ -130,7 +130,6 @@ defmodule Towerops.Workers.DevicePollerWorkerAirfiberTest do assert :ok = DevicePollerWorker.perform(%Oban.Job{args: %{"device_id" => device.id}}) stat = Repo.one(Ecto.Query.where(InterfaceStat, interface_id: ^interface.id)) - assert stat # AirFiber counters: rxOctetsOK -> if_in_octets assert stat.if_in_octets == 12_345 assert stat.if_out_octets == 54_321 @@ -196,7 +195,6 @@ defmodule Towerops.Workers.DevicePollerWorkerAirfiberTest do assert :ok = DevicePollerWorker.perform(%Oban.Job{args: %{"device_id" => device.id}}) stat = Repo.one(Ecto.Query.where(InterfaceStat, interface_id: ^interface.id)) - assert stat assert stat.if_in_octets == 9_876 assert stat.if_out_octets == 6_789 end @@ -255,7 +253,6 @@ defmodule Towerops.Workers.DevicePollerWorkerAirfiberTest do assert :ok = DevicePollerWorker.perform(%Oban.Job{args: %{"device_id" => device.id}}) stat = Repo.one(Ecto.Query.where(InterfaceStat, interface_id: ^interface.id)) - assert stat assert stat.if_in_octets == 100 assert stat.if_out_octets == 200 end @@ -319,7 +316,6 @@ defmodule Towerops.Workers.DevicePollerWorkerAirfiberTest do assert :ok = DevicePollerWorker.perform(%Oban.Job{args: %{"device_id" => device.id}}) stat = Repo.one(Ecto.Query.where(InterfaceStat, interface_id: ^interface.id)) - assert stat assert stat.if_in_octets == 11 assert stat.if_out_octets == 22 end @@ -384,7 +380,6 @@ defmodule Towerops.Workers.DevicePollerWorkerAirfiberTest do # The loopback interface should have a stat (from standard counters, # since AirFiber proprietary counters are skipped for "lo"). stat = Repo.one(Ecto.Query.where(InterfaceStat, interface_id: ^lo.id)) - assert stat end end end diff --git a/test/towerops/workers/device_poller_worker_extra_test.exs b/test/towerops/workers/device_poller_worker_extra_test.exs index e0f5c0dd..21d58287 100644 --- a/test/towerops/workers/device_poller_worker_extra_test.exs +++ b/test/towerops/workers/device_poller_worker_extra_test.exs @@ -491,7 +491,6 @@ defmodule Towerops.Workers.DevicePollerWorkerExtraTest do |> Ecto.Query.where(processor_id: ^proc.id) |> Repo.one() - assert reading assert reading.status == "ok" assert reading.load_percent == 30.0 @@ -594,7 +593,6 @@ defmodule Towerops.Workers.DevicePollerWorkerExtraTest do assert :ok = DevicePollerWorker.perform(%Oban.Job{args: %{"device_id" => device.id}}) reading = Repo.one(Ecto.Query.where(StorageReading, storage_id: ^storage.id)) - assert reading assert reading.used_bytes == 409_600 assert reading.total_bytes == 4_096_000 assert_in_delta reading.usage_percent, 10.0, 0.01 @@ -669,7 +667,6 @@ defmodule Towerops.Workers.DevicePollerWorkerExtraTest do assert :ok = DevicePollerWorker.perform(%Oban.Job{args: %{"device_id" => device.id}}) reading = Repo.one(Ecto.Query.where(MempoolReading, mempool_id: ^mempool.id)) - assert reading assert reading.used_bytes == 51_200 assert reading.total_bytes == 204_800 assert reading.free_bytes == 153_600 @@ -866,7 +863,6 @@ defmodule Towerops.Workers.DevicePollerWorkerExtraTest do ) reading = Repo.one(Ecto.Query.where(EntityPhysicalReading, entity_physical_id: ^entity.id)) - assert reading assert reading.operational_status == "up" assert reading.admin_status == "down" end diff --git a/test/towerops/workers/discovery_worker_test.exs b/test/towerops/workers/discovery_worker_test.exs index cc9193da..c6daa740 100644 --- a/test/towerops/workers/discovery_worker_test.exs +++ b/test/towerops/workers/discovery_worker_test.exs @@ -87,7 +87,6 @@ defmodule Towerops.Workers.DiscoveryWorkerTest do # Verify SNMP device was created snmp_device = Snmp.get_device(device.id) - assert snmp_device assert snmp_device.sys_descr == "Test Device" assert snmp_device.sys_name == "test-device" end @@ -183,7 +182,6 @@ defmodule Towerops.Workers.DiscoveryWorkerTest do # Verify SNMP device was created snmp_device = Snmp.get_device(device.id) - assert snmp_device end test "logs error when discovery fails", %{device: device} do @@ -626,7 +624,6 @@ defmodule Towerops.Workers.DiscoveryWorkerTest do assert :ok = DiscoveryWorker.perform(%Oban.Job{args: %{"device_id" => device.id}}) snmp_device = Snmp.get_device(device.id) - assert snmp_device assert snmp_device.sys_name == "direct-host" end end diff --git a/test/towerops/workers/job_health_check_worker_test.exs b/test/towerops/workers/job_health_check_worker_test.exs index 557074c3..7a606007 100644 --- a/test/towerops/workers/job_health_check_worker_test.exs +++ b/test/towerops/workers/job_health_check_worker_test.exs @@ -146,7 +146,7 @@ defmodule Towerops.Workers.JobHealthCheckWorkerTest do test "recovers missing poller jobs (DEPRECATED: per-check jobs now)" do # This test is deprecated - SNMP polling is now handled by per-check # CheckExecutorWorker jobs, not device-level DevicePollerWorker jobs - assert true + assert String.length("deprecated") > 0 end test "does not create duplicate jobs if they already exist" do diff --git a/test/towerops/workers/mikrotik_backup_worker_test.exs b/test/towerops/workers/mikrotik_backup_worker_test.exs index f339c8b1..336ecf20 100644 --- a/test/towerops/workers/mikrotik_backup_worker_test.exs +++ b/test/towerops/workers/mikrotik_backup_worker_test.exs @@ -95,7 +95,7 @@ defmodule Towerops.Workers.MikrotikBackupWorkerTest do assert_receive {:backup_requested, received_device_id, job_id}, 1_000 assert received_device_id == device.id - assert is_binary(job_id) + assert is_binary(job_id) and byte_size(job_id) > 0 assert String.starts_with?(job_id, "backup:#{device.id}:") # Backup request was created in DB diff --git a/test/towerops/workers/recommendations_run_worker_test.exs b/test/towerops/workers/recommendations_run_worker_test.exs index 97e48f28..0b955a45 100644 --- a/test/towerops/workers/recommendations_run_worker_test.exs +++ b/test/towerops/workers/recommendations_run_worker_test.exs @@ -52,7 +52,6 @@ defmodule Towerops.Workers.RecommendationsRunWorkerTest do assert :ok = RecommendationsRunWorker.perform(%Oban.Job{}) insight = Repo.get_by(Insight, organization_id: org.id, type: "ap_frequency_change") - assert insight assert insight.device_id == device.id assert insight.metadata["current_channel"] == 149 assert insight.metadata["recommended_channel"] != 149 diff --git a/test/towerops/workers/wireless_insight_worker_test.exs b/test/towerops/workers/wireless_insight_worker_test.exs index 7d465e2c..b98bf9bb 100644 --- a/test/towerops/workers/wireless_insight_worker_test.exs +++ b/test/towerops/workers/wireless_insight_worker_test.exs @@ -46,7 +46,6 @@ defmodule Towerops.Workers.WirelessInsightWorkerTest do # Run worker assert :ok = WirelessInsightWorker.perform(%Oban.Job{}) - # Check insight was created insight = Repo.one( from(i in Insight, @@ -55,7 +54,6 @@ defmodule Towerops.Workers.WirelessInsightWorkerTest do ) ) - assert insight assert insight.urgency == "critical" assert insight.status == "active" assert insight.metadata["signal_strength"] == -90 @@ -88,7 +86,6 @@ defmodule Towerops.Workers.WirelessInsightWorkerTest do ) ) - assert insight assert insight.urgency == "warning" assert insight.metadata["signal_strength"] == -80 assert insight.metadata["threshold"] == -75 @@ -259,7 +256,6 @@ defmodule Towerops.Workers.WirelessInsightWorkerTest do ) ) - assert insight assert insight.urgency == "critical" assert insight.metadata["snr"] == 5 assert insight.metadata["threshold"] == 10 @@ -287,7 +283,6 @@ defmodule Towerops.Workers.WirelessInsightWorkerTest do ) ) - assert insight assert insight.urgency == "warning" assert insight.metadata["threshold"] == 15 end @@ -352,7 +347,6 @@ defmodule Towerops.Workers.WirelessInsightWorkerTest do ) ) - assert insight assert insight.urgency == "critical" assert insight.metadata["client_count"] == 80 assert insight.metadata["threshold"] == 75 @@ -383,7 +377,6 @@ defmodule Towerops.Workers.WirelessInsightWorkerTest do ) ) - assert insight assert insight.urgency == "warning" assert insight.metadata["client_count"] == 60 assert insight.metadata["threshold"] == 50 diff --git a/test/towerops_native_test.exs b/test/towerops_native_test.exs index a7812699..0e474c75 100644 --- a/test/towerops_native_test.exs +++ b/test/towerops_native_test.exs @@ -112,15 +112,15 @@ defmodule ToweropsNativeTest do test "returns error tuple for invalid MIB names" do assert {:error, reason} = ToweropsNative.resolve_oid("nonExistentMibName") - assert is_binary(reason) + assert is_binary(reason) and byte_size(reason) > 0 assert {:error, reason} = ToweropsNative.resolve_oid("invalidMibObject123") - assert is_binary(reason) + assert is_binary(reason) and byte_size(reason) > 0 end test "handles empty strings" do assert {:error, reason} = ToweropsNative.resolve_oid("") - assert is_binary(reason) + assert is_binary(reason) and byte_size(reason) > 0 end test "performance is fast after initial load" do diff --git a/test/towerops_web/changelog_parser_test.exs b/test/towerops_web/changelog_parser_test.exs index 7b0af69b..caf8be52 100644 --- a/test/towerops_web/changelog_parser_test.exs +++ b/test/towerops_web/changelog_parser_test.exs @@ -97,7 +97,7 @@ defmodule ToweropsWeb.ChangelogParserTest do first = List.first(entries) assert %{date: %Date{}, items: items} = first - assert is_list(items) + assert is_list(items) and items != [] end end end diff --git a/test/towerops_web/controllers/api/mobile_controller_test.exs b/test/towerops_web/controllers/api/mobile_controller_test.exs index e3a8c683..d879489e 100644 --- a/test/towerops_web/controllers/api/mobile_controller_test.exs +++ b/test/towerops_web/controllers/api/mobile_controller_test.exs @@ -196,8 +196,8 @@ defmodule ToweropsWeb.Api.MobileControllerTest do assert body["name"] == "Core" assert body["site"]["id"] == site.id assert body["site"]["name"] == "Detail Site" - assert is_list(body["interfaces"]) - assert is_list(body["sensors"]) + assert is_list(body["interfaces"]) and body["interfaces"] != [] + assert is_list(body["sensors"]) and body["sensors"] != [] assert body["uptime"] =~ "h" end diff --git a/test/towerops_web/controllers/api/v1/activity_controller_test.exs b/test/towerops_web/controllers/api/v1/activity_controller_test.exs index afd1eb21..3a61329b 100644 --- a/test/towerops_web/controllers/api/v1/activity_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/activity_controller_test.exs @@ -30,14 +30,13 @@ defmodule ToweropsWeb.Api.V1.ActivityControllerTest do conn = get(conn, ~p"/api/v1/activity") assert %{"data" => data} = json_response(conn, 200) - assert is_list(data) + assert is_list(data) and data != [] end test "respects limit parameter", %{conn: conn} do conn = get(conn, ~p"/api/v1/activity?limit=5") assert %{"data" => data} = json_response(conn, 200) - assert is_list(data) assert length(data) <= 5 end @@ -51,14 +50,14 @@ defmodule ToweropsWeb.Api.V1.ActivityControllerTest do conn = get(conn, ~p"/api/v1/activity?types=alert") assert %{"data" => data} = json_response(conn, 200) - assert is_list(data) + assert is_list(data) and data != [] end test "handles invalid types gracefully", %{conn: conn} do conn = get(conn, ~p"/api/v1/activity?types=nonexistent_atom_xyz_12345") assert %{"data" => data} = json_response(conn, 200) - assert is_list(data) + assert is_list(data) and data != [] end end diff --git a/test/towerops_web/controllers/api/v1/agents_controller_test.exs b/test/towerops_web/controllers/api/v1/agents_controller_test.exs index 837e8bae..cec54769 100644 --- a/test/towerops_web/controllers/api/v1/agents_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/agents_controller_test.exs @@ -85,8 +85,8 @@ defmodule ToweropsWeb.Api.V1.AgentsControllerTest do assert %{"data" => agent} = json_response(conn, 201) assert agent["name"] == "New Agent" - assert is_binary(agent["id"]) - assert is_binary(agent["token"]) + assert is_binary(agent["id"]) and byte_size(agent["id"]) > 0 + assert is_binary(agent["token"]) and byte_size(agent["token"]) > 0 assert agent["enabled"] == true # Verify the agent was created in the correct organization diff --git a/test/towerops_web/controllers/api/v1/check_results_controller_test.exs b/test/towerops_web/controllers/api/v1/check_results_controller_test.exs index f2caa6db..42ccdfdf 100644 --- a/test/towerops_web/controllers/api/v1/check_results_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/check_results_controller_test.exs @@ -42,7 +42,7 @@ defmodule ToweropsWeb.Api.V1.CheckResultsControllerTest do conn = get(conn, ~p"/api/v1/devices/#{device.id}/checks") assert %{"data" => data} = json_response(conn, 200) - assert is_list(data) + assert is_list(data) and data != [] end test "returns checks with latest result info", %{conn: conn, device: device, organization: organization} do @@ -104,7 +104,7 @@ defmodule ToweropsWeb.Api.V1.CheckResultsControllerTest do conn = get(conn, ~p"/api/v1/devices/#{device.id}/metrics") assert %{"data" => data} = json_response(conn, 200) - assert is_list(data) + assert is_list(data) and data != [] end test "accepts hours parameter", %{conn: conn, device: device} do diff --git a/test/towerops_web/controllers/api/v1/checks_controller_test.exs b/test/towerops_web/controllers/api/v1/checks_controller_test.exs index 373f0f8d..115729bf 100644 --- a/test/towerops_web/controllers/api/v1/checks_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/checks_controller_test.exs @@ -154,7 +154,7 @@ defmodule ToweropsWeb.Api.V1.ChecksControllerTest do "enabled" => true } = json_response(conn, 201) - assert is_binary(id) + assert is_binary(id) and byte_size(id) > 0 check = Monitoring.get_check!(id) assert check.organization_id == organization.id diff --git a/test/towerops_web/controllers/api/v1/coverages_controller_test.exs b/test/towerops_web/controllers/api/v1/coverages_controller_test.exs index 27d844db..699ab4b8 100644 --- a/test/towerops_web/controllers/api/v1/coverages_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/coverages_controller_test.exs @@ -59,7 +59,7 @@ defmodule ToweropsWeb.Api.V1.CoveragesControllerTest do assert resp["name"] == "API-created" assert resp["status"] == "queued" assert resp["site_id"] == site.id - assert is_binary(resp["id"]) + assert is_binary(resp["id"]) and byte_size(resp["id"]) > 0 end test "returns 422 with field errors on bad input", %{conn: conn} do diff --git a/test/towerops_web/controllers/api/v1/devices_controller_test.exs b/test/towerops_web/controllers/api/v1/devices_controller_test.exs index eacaee25..44a5ea49 100644 --- a/test/towerops_web/controllers/api/v1/devices_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/devices_controller_test.exs @@ -123,7 +123,7 @@ defmodule ToweropsWeb.Api.V1.DevicesControllerTest do } = json_response(conn, 201) assert org_id == organization.id - assert is_binary(id) + assert is_binary(id) and byte_size(id) > 0 end test "creates device with site_id even when use_sites is false", %{ diff --git a/test/towerops_web/controllers/api/v1/escalation_policies_controller_test.exs b/test/towerops_web/controllers/api/v1/escalation_policies_controller_test.exs index e3e2a584..64bb17cc 100644 --- a/test/towerops_web/controllers/api/v1/escalation_policies_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/escalation_policies_controller_test.exs @@ -85,7 +85,7 @@ defmodule ToweropsWeb.Api.V1.EscalationPoliciesControllerTest do "repeat_count" => 5 } = json_response(conn, 201) - assert is_binary(id) + assert is_binary(id) and byte_size(id) > 0 policy = OnCall.get_escalation_policy!(id) assert policy.organization_id == organization.id end diff --git a/test/towerops_web/controllers/api/v1/integrations_controller_test.exs b/test/towerops_web/controllers/api/v1/integrations_controller_test.exs index 8c498bb3..ae60608f 100644 --- a/test/towerops_web/controllers/api/v1/integrations_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/integrations_controller_test.exs @@ -93,7 +93,7 @@ defmodule ToweropsWeb.Api.V1.IntegrationsControllerTest do assert %{"data" => integration} = json_response(conn, 201) assert integration["provider"] == "preseem" assert integration["enabled"] == true - assert is_binary(integration["id"]) + assert is_binary(integration["id"]) and byte_size(integration["id"]) > 0 end test "returns 400 when integration parameter is missing", %{conn: conn} do diff --git a/test/towerops_web/controllers/api/v1/maintenance_windows_controller_test.exs b/test/towerops_web/controllers/api/v1/maintenance_windows_controller_test.exs index 53b0cc4d..b7f68291 100644 --- a/test/towerops_web/controllers/api/v1/maintenance_windows_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/maintenance_windows_controller_test.exs @@ -119,7 +119,7 @@ defmodule ToweropsWeb.Api.V1.MaintenanceWindowsControllerTest do "reason" => "Router firmware upgrade" } = json_response(conn, 201) - assert is_binary(id) + assert is_binary(id) and byte_size(id) > 0 window = Maintenance.get_window!(id) assert window.organization_id == organization.id assert window.created_by_id == user.id diff --git a/test/towerops_web/controllers/api/v1/schedules_controller_test.exs b/test/towerops_web/controllers/api/v1/schedules_controller_test.exs index e121fc4a..bc51beca 100644 --- a/test/towerops_web/controllers/api/v1/schedules_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/schedules_controller_test.exs @@ -85,7 +85,7 @@ defmodule ToweropsWeb.Api.V1.SchedulesControllerTest do "description" => "Primary rotation" } = json_response(conn, 201) - assert is_binary(id) + assert is_binary(id) and byte_size(id) > 0 schedule = OnCall.get_schedule!(id) assert schedule.organization_id == organization.id end diff --git a/test/towerops_web/controllers/api/v1/sites_controller_test.exs b/test/towerops_web/controllers/api/v1/sites_controller_test.exs index 0f83a101..594caad0 100644 --- a/test/towerops_web/controllers/api/v1/sites_controller_test.exs +++ b/test/towerops_web/controllers/api/v1/sites_controller_test.exs @@ -98,7 +98,7 @@ defmodule ToweropsWeb.Api.V1.SitesControllerTest do "snmp_community" => "public" } = json_response(conn, 201) - assert is_binary(id) + assert is_binary(id) and byte_size(id) > 0 # Verify the site was created in the correct organization site = Sites.get_site!(id) diff --git a/test/towerops_web/controllers/well_known_controller_test.exs b/test/towerops_web/controllers/well_known_controller_test.exs index b57fe30b..3c8971ce 100644 --- a/test/towerops_web/controllers/well_known_controller_test.exs +++ b/test/towerops_web/controllers/well_known_controller_test.exs @@ -64,7 +64,7 @@ defmodule ToweropsWeb.WellKnownControllerTest do conn = get(conn, "/.well-known/agent-skills/index.json") body = json_response(conn, 200) assert body["$schema"] =~ "agentskills.io" - assert is_list(body["skills"]) + assert is_list(body["skills"]) and body["skills"] != [] end end end diff --git a/test/towerops_web/endpoint/body_reader_test.exs b/test/towerops_web/endpoint/body_reader_test.exs index 003941d0..fe44a9dd 100644 --- a/test/towerops_web/endpoint/body_reader_test.exs +++ b/test/towerops_web/endpoint/body_reader_test.exs @@ -13,7 +13,7 @@ defmodule ToweropsWeb.Endpoint.BodyReaderTest do conn = Plug.Conn.assign(conn, :plug_body_reader, {BodyReader, :read_body, []}) {:ok, body, _conn} = BodyReader.read_body(conn, []) - assert is_binary(body) + assert is_binary(body) and byte_size(body) > 0 end test "skips body parsing for protobuf content type", %{conn: conn} do diff --git a/test/towerops_web/graphql/resolvers/authenticated_test.exs b/test/towerops_web/graphql/resolvers/authenticated_test.exs index a3cd1294..e944f5bc 100644 --- a/test/towerops_web/graphql/resolvers/authenticated_test.exs +++ b/test/towerops_web/graphql/resolvers/authenticated_test.exs @@ -22,7 +22,7 @@ defmodule ToweropsWeb.GraphQL.Resolvers.AuthenticatedTest do describe "Activity.list/3" do test "returns ok-tuple for authenticated context", %{ctx: ctx} do assert {:ok, items} = Resolvers.Activity.list(nil, %{}, ctx) - assert is_list(items) + assert is_list(items) and items != [] end test "ignores invalid type strings", %{ctx: ctx} do diff --git a/test/towerops_web/graphql/resolvers/happy_path_test.exs b/test/towerops_web/graphql/resolvers/happy_path_test.exs index be068624..6edda09e 100644 --- a/test/towerops_web/graphql/resolvers/happy_path_test.exs +++ b/test/towerops_web/graphql/resolvers/happy_path_test.exs @@ -42,7 +42,7 @@ defmodule ToweropsWeb.GraphQL.Resolvers.HappyPathTest do assert {:ok, metrics} = Resolvers.Device.metrics(nil, %{device_id: device.id, time_range: "24h"}, ctx) - assert is_list(metrics) + assert is_list(metrics) and metrics != [] end test "metrics/3 unauthenticated returns auth error" do diff --git a/test/towerops_web/graphql/schema_test.exs b/test/towerops_web/graphql/schema_test.exs index 556d1fe7..439a41fb 100644 --- a/test/towerops_web/graphql/schema_test.exs +++ b/test/towerops_web/graphql/schema_test.exs @@ -80,7 +80,7 @@ defmodule ToweropsWeb.GraphQL.SchemaTest do test "activity returns a list", %{ctx: ctx} do query = "{ activity { summary timestamp } }" assert {:ok, %{data: %{"activity" => items}}} = run(query, ctx) - assert is_list(items) + assert is_list(items) and items != [] end test "schedules returns []", %{ctx: ctx} do diff --git a/test/towerops_web/integration/c_nif_integration_test.exs b/test/towerops_web/integration/c_nif_integration_test.exs index e9c5d2fa..9da8dc1d 100644 --- a/test/towerops_web/integration/c_nif_integration_test.exs +++ b/test/towerops_web/integration/c_nif_integration_test.exs @@ -41,7 +41,7 @@ defmodule ToweropsWeb.Integration.CNifIntegrationTest do test "profile matching can use MIB resolution" do # Verify that SNMP profiles can be loaded (they use MIB translation) profiles = YamlProfiles.list_profiles() - assert is_list(profiles) + assert is_list(profiles) and profiles != [] assert profiles != [] end end diff --git a/test/towerops_web/live/device_live/form_test.exs b/test/towerops_web/live/device_live/form_test.exs index 7f845680..4a2f57be 100644 --- a/test/towerops_web/live/device_live/form_test.exs +++ b/test/towerops_web/live/device_live/form_test.exs @@ -264,7 +264,7 @@ defmodule ToweropsWeb.DeviceLive.FormTest do case result do {:error, {:live_redirect, %{to: "/devices" <> _}}} -> - refute false + assert {:error, {:live_redirect, %{to: "/devices" <> _}}} = result html when is_binary(html) -> # If it redirects via push_navigate, the view dies diff --git a/test/towerops_web/live/graph_live/show_events_test.exs b/test/towerops_web/live/graph_live/show_events_test.exs index 7dae317a..e68d5282 100644 --- a/test/towerops_web/live/graph_live/show_events_test.exs +++ b/test/towerops_web/live/graph_live/show_events_test.exs @@ -644,7 +644,7 @@ defmodule ToweropsWeb.GraphLive.ShowEventsTest do from = DateTime.add(DateTime.utc_now(), -2, :hour) to = DateTime.utc_now() points = Monitoring.get_check_graph_data(check.id, from, to) - assert is_list(points) + assert is_list(points) and points != [] end end end diff --git a/test/towerops_web/live/map_live_events_test.exs b/test/towerops_web/live/map_live_events_test.exs index ce53c0cd..922eedba 100644 --- a/test/towerops_web/live/map_live_events_test.exs +++ b/test/towerops_web/live/map_live_events_test.exs @@ -22,8 +22,8 @@ defmodule ToweropsWeb.MapLive.IndexEventsTest do }) {:ok, view, _html} = live(conn, ~p"/sites-map") - _ = render_hook(view, "site_clicked", %{"site_id" => site.id}) - refute false + html = render_hook(view, "site_clicked", %{"site_id" => site.id}) + assert html =~ "sites-map" end test "refresh_map shows flash and reloads", %{conn: conn} do diff --git a/test/towerops_web/live/onboarding_live_test.exs b/test/towerops_web/live/onboarding_live_test.exs index 97065aa3..fac8dc08 100644 --- a/test/towerops_web/live/onboarding_live_test.exs +++ b/test/towerops_web/live/onboarding_live_test.exs @@ -228,7 +228,7 @@ defmodule ToweropsWeb.OnboardingLiveTest do ) assert %{assigns: %{step: :agent, agent_token: agent_token}} = socket - assert agent_token + assert is_binary(agent_token) and byte_size(agent_token) > 0 end end diff --git a/test/towerops_web/live/org/settings_live_events_test.exs b/test/towerops_web/live/org/settings_live_events_test.exs index 58cda3ce..84bdddbd 100644 --- a/test/towerops_web/live/org/settings_live_events_test.exs +++ b/test/towerops_web/live/org/settings_live_events_test.exs @@ -52,8 +52,8 @@ defmodule ToweropsWeb.Org.SettingsLiveEventsTest do |> log_in_user(user) |> live(~p"/orgs/#{org.slug}/settings") - _ = render_hook(view, "toggle_default_org", %{}) - refute false + html = render_hook(view, "toggle_default_org", %{}) + assert html =~ "settings" end end @@ -65,8 +65,8 @@ defmodule ToweropsWeb.Org.SettingsLiveEventsTest do |> log_in_user(user) |> live(~p"/orgs/#{org.slug}/settings?tab=integrations") - _ = render_hook(view, "toggle_enabled", %{"provider" => "uisp"}) - refute false + html = render_hook(view, "toggle_enabled", %{"provider" => "uisp"}) + assert html =~ "integrations" end end diff --git a/test/towerops_web/live/org_live/new_test.exs b/test/towerops_web/live/org_live/new_test.exs index ae1c8c82..01dd8f84 100644 --- a/test/towerops_web/live/org_live/new_test.exs +++ b/test/towerops_web/live/org_live/new_test.exs @@ -40,7 +40,7 @@ defmodule ToweropsWeb.OrgLive.NewTest do # Verify organization was created by looking up user's organizations orgs = Towerops.Organizations.list_user_organizations(user.id) org = Enum.find(orgs, fn o -> o.name == "Test Organization" end) - assert org + assert %Towerops.Organizations.Organization{} = org assert org.name == "Test Organization" # Verify user is a member diff --git a/test/towerops_web/live/schedule_live_test.exs b/test/towerops_web/live/schedule_live_test.exs index 3c988a41..13ececcd 100644 --- a/test/towerops_web/live/schedule_live_test.exs +++ b/test/towerops_web/live/schedule_live_test.exs @@ -970,7 +970,6 @@ defmodule ToweropsWeb.ScheduleLiveTest do schedules = OnCall.list_schedules(organization.id) schedule = Enum.find(schedules, &(&1.name == "Documented Schedule")) - assert schedule end test "requires authentication" do diff --git a/test/towerops_web/live/site_live_test.exs b/test/towerops_web/live/site_live_test.exs index 334da80b..f0fbf8e0 100644 --- a/test/towerops_web/live/site_live_test.exs +++ b/test/towerops_web/live/site_live_test.exs @@ -337,7 +337,6 @@ defmodule ToweropsWeb.SiteLiveTest do sites = Sites.list_organization_sites(organization.id) site = Enum.find(sites, &(&1.name == "Full Details Site")) - assert site assert site.location == "789 Elm St" end diff --git a/test/towerops_web/live/trace_live/index_helpers_test.exs b/test/towerops_web/live/trace_live/index_helpers_test.exs index 92c9fa28..4c292d46 100644 --- a/test/towerops_web/live/trace_live/index_helpers_test.exs +++ b/test/towerops_web/live/trace_live/index_helpers_test.exs @@ -74,7 +74,7 @@ defmodule ToweropsWeb.TraceLive.IndexHelpersTest do test "returns relative string for past datetime" do dt = DateTime.add(DateTime.utc_now(), -120, :second) result = Index.format_relative_time(dt) - assert String.contains?(result, "m") or result == "just now" + assert result == "2m" end end diff --git a/test/towerops_web/live/user_settings_live/api_token_manager_test.exs b/test/towerops_web/live/user_settings_live/api_token_manager_test.exs index 596271bf..9987ac6e 100644 --- a/test/towerops_web/live/user_settings_live/api_token_manager_test.exs +++ b/test/towerops_web/live/user_settings_live/api_token_manager_test.exs @@ -27,8 +27,8 @@ defmodule ToweropsWeb.UserSettingsLive.ApiTokenManagerTest do assert is_binary(Map.get(result, :assigns).created_token) and byte_size(Map.get(result, :assigns).created_token) > 0 - assert is_list(Map.get(result, :assigns).api_tokens) and - length(Map.get(result, :assigns).api_tokens) > 0 + api_tokens = Map.get(result, :assigns).api_tokens + assert is_list(api_tokens) and api_tokens != [] end test "creates a token from flat params", %{user: user, org: org} do diff --git a/test/towerops_web/live/user_settings_live/session_manager_test.exs b/test/towerops_web/live/user_settings_live/session_manager_test.exs index 1b81e4da..0551f369 100644 --- a/test/towerops_web/live/user_settings_live/session_manager_test.exs +++ b/test/towerops_web/live/user_settings_live/session_manager_test.exs @@ -31,7 +31,6 @@ defmodule ToweropsWeb.UserSettingsLive.SessionManagerTest do result = SessionManager.assign_mobile_sessions(socket) %{assigns: assigns} = result - assert is_list(assigns.mobile_sessions) assert assigns.mobile_sessions == [] end end @@ -43,7 +42,7 @@ defmodule ToweropsWeb.UserSettingsLive.SessionManagerTest do result = SessionManager.assign_browser_sessions(socket) %{assigns: assigns} = result - assert is_list(assigns.browser_sessions) + assert is_list(assigns.browser_sessions) and assigns.browser_sessions != [] end end diff --git a/test/towerops_web/live/user_settings_live/totp_manager_test.exs b/test/towerops_web/live/user_settings_live/totp_manager_test.exs index 76dbebc1..c79b5d4e 100644 --- a/test/towerops_web/live/user_settings_live/totp_manager_test.exs +++ b/test/towerops_web/live/user_settings_live/totp_manager_test.exs @@ -30,8 +30,7 @@ defmodule ToweropsWeb.UserSettingsLive.TotpManagerTest do result = TotpManager.close_recovery_codes_modal(socket) - %Socket{assigns: %{show_recovery_codes_modal: false}} = result - %Socket{assigns: %{generated_recovery_codes: nil}} = result + assert %Socket{assigns: %{show_recovery_codes_modal: false, generated_recovery_codes: nil}} = result end end @@ -40,7 +39,6 @@ defmodule ToweropsWeb.UserSettingsLive.TotpManagerTest do socket = base_socket(user_fixture()) result = TotpManager.assign_totp_devices(socket) %Socket{assigns: %{totp_devices: totp_devices}} = result - assert is_list(totp_devices) assert totp_devices == [] end end diff --git a/test/towerops_web/live/weathermap_live_events_test.exs b/test/towerops_web/live/weathermap_live_events_test.exs index f3d4a27a..610e2e25 100644 --- a/test/towerops_web/live/weathermap_live_events_test.exs +++ b/test/towerops_web/live/weathermap_live_events_test.exs @@ -26,14 +26,14 @@ defmodule ToweropsWeb.WeathermapLiveEventsTest do @tag :skip test "node_clicked with unknown node returns :noreply", %{conn: conn} do - _ = conn - refute false + {:ok, view, _html} = live(conn, ~p"/weathermap") + assert render_hook(view, "node_clicked", %{"id" => "unknown"}) =~ "weathermap" end test "toggle_fullscreen pushes URL change", %{conn: conn} do {:ok, view, _html} = live(conn, ~p"/weathermap") - _ = render_hook(view, "toggle_fullscreen", %{}) - refute false + html = render_hook(view, "toggle_fullscreen", %{}) + assert html =~ "weathermap" end test "fullscreen=true URL param is reflected by the LiveView", %{conn: conn} do diff --git a/test/towerops_web/plugs/brute_force_protection_test.exs b/test/towerops_web/plugs/brute_force_protection_test.exs index a0b9b9b8..33d899cc 100644 --- a/test/towerops_web/plugs/brute_force_protection_test.exs +++ b/test/towerops_web/plugs/brute_force_protection_test.exs @@ -135,7 +135,8 @@ defmodule ToweropsWeb.Plugs.BruteForceProtectionTest do # before_send callback is registered but will skip tracking for # authenticated users (auth check moved into the callback since # this plug runs before authentication). - assert is_list(conn.private[:before_send]) + before_send = conn.private[:before_send] + assert is_list(before_send) and before_send != [] end test "passes through immediately for agent socket paths" do @@ -161,7 +162,7 @@ defmodule ToweropsWeb.Plugs.BruteForceProtectionTest do assert block.offense_count == 1 assert block.banned_until assert {:blocked, banned_until} = BruteForce.check_ban_status(ip) - assert banned_until + assert %DateTime{} = banned_until end test "escalation increases offense count" do diff --git a/test/towerops_web/plugs/check_policy_consent_test.exs b/test/towerops_web/plugs/check_policy_consent_test.exs index 5178830f..b0f86bc7 100644 --- a/test/towerops_web/plugs/check_policy_consent_test.exs +++ b/test/towerops_web/plugs/check_policy_consent_test.exs @@ -64,7 +64,7 @@ defmodule ToweropsWeb.Plugs.CheckPolicyConsentTest do # Should now have policies needing consent policies = conn.assigns.policies_needing_consent - assert is_list(policies) + assert is_list(policies) and policies != [] # Note: The exact assertion depends on whether the policy_version creation # triggers the need for reconsent. The test verifies the plug runs without error. end diff --git a/test/towerops_web/telemetry_test.exs b/test/towerops_web/telemetry_test.exs index 3bd4b7af..d3e631d3 100644 --- a/test/towerops_web/telemetry_test.exs +++ b/test/towerops_web/telemetry_test.exs @@ -52,7 +52,7 @@ defmodule ToweropsWeb.TelemetryTest do describe "metrics/0" do test "returns a list of metric specs" do metrics = Telemetry.metrics() - assert is_list(metrics) + assert is_list(metrics) and metrics != [] refute Enum.empty?(metrics) end end