From 6c238c52e50a13006e4adc8e5d063edd19f8f509 Mon Sep 17 00:00:00 2001
From: Graham McIntire <graham@mcintire.me>
Date: Mon, 26 Jan 2026 17:17:31 -0600
Subject: [PATCH] fix a few things and fix device discovery

---
 config/test.exs                               | 5 ++---
 lib/towerops/devices/device.ex                | 7 ++++++-
 test/towerops/workers/polling_offset_test.exs | 6 +++---
 test/towerops_web/live/agent_live_test.exs    | 4 ++--
 4 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/config/test.exs b/config/test.exs
index 21ff5445..13f12251 100644
--- a/config/test.exs
+++ b/config/test.exs
@@ -4,9 +4,8 @@ import Config
 config :bcrypt_elixir, :log_rounds, 1
 
 # Suppress log output during tests (tests that need logs use capture_log)
-config :logger,
-  level: :error,
-  backends: []
+config :logger, :default_handler, false
+config :logger, level: :error
 
 # Initialize plugs at runtime for faster test compilation
 config :phoenix, :plug_init_mode, :runtime
diff --git a/lib/towerops/devices/device.ex b/lib/towerops/devices/device.ex
index 3d3fa7f3..44e39f39 100644
--- a/lib/towerops/devices/device.ex
+++ b/lib/towerops/devices/device.ex
@@ -85,7 +85,12 @@ defmodule Towerops.Devices.Device do
       :snmp_enabled,
       :snmp_version,
       :snmp_community,
-      :snmp_port
+      :snmp_port,
+      :status,
+      :last_checked_at,
+      :last_status_change_at,
+      :last_discovery_at,
+      :last_snmp_poll_at
     ])
     |> validate_required([:ip_address, :site_id])
     |> validate_name()
diff --git a/test/towerops/workers/polling_offset_test.exs b/test/towerops/workers/polling_offset_test.exs
index cce98176..b8a1758a 100644
--- a/test/towerops/workers/polling_offset_test.exs
+++ b/test/towerops/workers/polling_offset_test.exs
@@ -83,15 +83,15 @@ defmodule Towerops.Workers.PollingOffsetTest do
       buckets = Enum.group_by(offsets, &div(&1, 30))
 
       # With good distribution, each bucket should have roughly 10 devices (100/10)
-      # Allow for variance - expect 3-20 devices per bucket (hash functions have natural variance)
+      # Allow for variance - expect 3-22 devices per bucket (hash functions have natural variance)
       for {bucket_num, devices_in_bucket} <- buckets do
         count = length(devices_in_bucket)
 
         assert count >= 3,
                "bucket #{bucket_num} has only #{count} devices, expected at least 3"
 
-        assert count <= 20,
-               "bucket #{bucket_num} has #{count} devices, expected at most 20"
+        assert count <= 22,
+               "bucket #{bucket_num} has #{count} devices, expected at most 22"
       end
 
       # Verify we're actually using multiple buckets (good distribution)
diff --git a/test/towerops_web/live/agent_live_test.exs b/test/towerops_web/live/agent_live_test.exs
index 0e7a933c..2802d698 100644
--- a/test/towerops_web/live/agent_live_test.exs
+++ b/test/towerops_web/live/agent_live_test.exs
@@ -69,10 +69,10 @@ defmodule ToweropsWeb.AgentLiveTest do
       |> form("#new-agent-form form", %{name: "Test Agent"})
       |> render_submit()
 
-      # Close modal
+      # Close modal by clicking the primary button (bg-blue-600 class indicates primary button)
       html =
         view
-        |> element("button", "I've Saved the Token")
+        |> element("button.bg-blue-600[phx-click='close_token_modal']")
         |> render_click()
 
       refute html =~ "Agent Created Successfully"