graham/towerops
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix all mix credo --strict and compiler warnings

Browse source
This commit is contained in:
Graham McIntire 2026-06-13 15:45:09 -05:00
parent bc1a8bd4bd
commit 5bb55180a7
150 changed files with 503 additions and 375 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.credo.exs
View file

@ -172,8 +172,8 @@
{Jump.CredoChecks.AssertReceiveTimeout, [min_assert_receive_timeout: 1_000, max_refute_receive_timeout: 100]},
{Jump.CredoChecks.AvoidFunctionLevelElse},
{Jump.CredoChecks.AvoidLoggerConfigureInTest},
{Jump.CredoChecks.AvoidSocketAssignsInTest, [excluded: ["test/support/live_view_test_helpers.ex"]]}
# {Jump.CredoChecks.ConditionalAssertion},
{Jump.CredoChecks.AvoidSocketAssignsInTest, [excluded: ["test/support/live_view_test_helpers.ex"]]},
{Jump.CredoChecks.ConditionalAssertion}
# {Jump.CredoChecks.DoctestIExExamples,
# [
# derive_test_path: fn filename ->

6
lib/snmpkit/snmp_lib/security/priv.ex
View file

@ -302,10 +302,8 @@ defmodule SnmpKit.SnmpLib.Security.Priv do
Encrypts a batch of plaintexts efficiently.
## Examples
iex> plaintexts = ["msg1", "msg2"]
iex> {:ok, encrypted_list} = Priv.encrypt_batch(:aes128, priv_key, auth_key, plaintexts)
iex> length(encrypted_list)
2
iex> length(Priv.encrypt_batch(:aes128, <<1::128>>, <<1::128>>, ["msg1"]))
1
"""
@spec encrypt_batch(priv_protocol(), priv_key(), auth_key(), [plaintext()]) ::
{:ok, [{ciphertext(), priv_params()}]} | {:error, atom()}

8
lib/towerops/accounts/consents.ex
View file

@ -62,10 +62,6 @@ defmodule Towerops.Accounts.Consents do
@doc """
Lists all consents for a user.
## Examples
iex> list_user_consents(user_id)
[%UserConsent{}, ...]
"""
def list_user_consents(user_id) when is_binary(user_id) do
UserConsent
@ -115,10 +111,6 @@ defmodule Towerops.Accounts.Consents do
@doc """
Checks if a user has granted all required consents.
## Examples
iex> has_all_required_consents?(user_id)
true
"""
def has_all_required_consents?(user_id) when is_binary(user_id) do
Enum.all?(UserConsent.consent_types(), fn consent_type ->

5
lib/towerops/accounts/emails.ex
View file

@ -23,11 +23,6 @@ defmodule Towerops.Accounts.Emails do
See `Towerops.Accounts.User.email_changeset/3` for a list of supported options.
## Examples
iex> change_user_email(user)
%Ecto.Changeset{data: %User{}}
"""
def change_user_email(user, attrs \\ %{}, opts \\ []) do
User.email_changeset(user, attrs, opts)

11
lib/towerops/accounts/login_attempt.ex
View file

@ -52,17 +52,6 @@ defmodule Towerops.Accounts.LoginAttempt do
## Conditional validation
- If `success` is false, `:failure_reason` is required
- If `success` is true, `:failure_reason` must be nil
## Examples
iex> changeset(%LoginAttempt{}, %{
...> user_id: "123",
...> email: "user@example.com",
...> success: true,
...> method: "password",
...> ip_address: "192.168.1.1",
...> country_name: "United States"
...> })
"""
def changeset(login_attempt, attrs) do
login_attempt

6
lib/towerops/agents/agent_assignment.ex
View file

@ -37,12 +37,6 @@ defmodule Towerops.Agents.AgentAssignment do
@doc """
Changeset for creating and updating agent assignments.
## Examples
iex> changeset(%AgentAssignment{}, %{agent_token_id: token_id, device_id: equip_id})
%Ecto.Changeset{valid?: true}
"""
def changeset(assignment, attrs) do
assignment

4
lib/towerops/query_helpers.ex
View file

@ -12,10 +12,10 @@ defmodule Towerops.QueryHelpers do
## Examples
iex> Towerops.QueryHelpers.sanitize_like("100%")
"100\\%"
"100\\\\%"
iex> Towerops.QueryHelpers.sanitize_like("some_value")
"some\\_value"
"some\\\\_value"
iex> Towerops.QueryHelpers.sanitize_like("hello world")
"hello world"

2
lib/towerops/workers/check_executor_worker.ex
View file

@ -30,7 +30,7 @@ defmodule Towerops.Workers.CheckExecutorWorker do
max_attempts: 3,
unique: [
keys: [:check_id],
states: [:available, :scheduled, :retryable, :suspended],
states: [:available, :scheduled, :executing, :retryable, :suspended],
period: :infinity
]

2
lib/towerops/workers/device_monitor_worker.ex
View file

@ -12,7 +12,7 @@ defmodule Towerops.Workers.DeviceMonitorWorker do
unique: [
period: :infinity,
keys: [:device_id],
states: [:available, :scheduled, :retryable, :suspended]
states: [:available, :scheduled, :executing, :retryable, :suspended]
],
replace: [
scheduled: [:scheduled_at],

2
lib/towerops/workers/device_poller_worker.ex
View file

@ -18,7 +18,7 @@ defmodule Towerops.Workers.DevicePollerWorker do
unique: [
period: :infinity,
keys: [:device_id],
states: [:available, :scheduled, :retryable, :suspended]
states: [:available, :scheduled, :executing, :retryable, :suspended]
],
replace: [
scheduled: [:scheduled_at],

11
lib/towerops_web/live/helpers/access_control.ex
View file

@ -48,17 +48,6 @@ defmodule ToweropsWeb.Live.Helpers.AccessControl do
Returns `{:ok, alert}` if access is granted, or an error tuple.
The alert is preloaded with `device: [site: :organization]` for access checking.
## Examples
iex> verify_alert_access(alert_id, org_id)
{:ok, %Alert{device: %Device{site: %Site{organization: %Organization{}}}}}
iex> verify_alert_access(alert_id, wrong_org_id)
{:error, :unauthorized}
iex> verify_alert_access("nonexistent", org_id)
{:error, :not_found}
"""
@spec verify_alert_access(binary(), binary()) ::
{:ok, Alert.t()} | {:error, :not_found | :unauthorized}

6
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/palette.txt Normal file
View file

@ -0,0 +1,6 @@
-50 0 200 0 230
-65 200 230 0 230
-75 255 165 0 220
-85 220 60 60 200
-95 100 0 0 160
nv 0 0 0 0

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h1219cm.f32 Normal file
View file

Binary file not shown.

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h1219cm.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h1219cm.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h1219cm.tif Normal file
View file

Binary file not shown.

12
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h1219cm.vrt Normal file
View file

@ -0,0 +1,12 @@
<VRTDataset rasterXSize="50" rasterYSize="50">
<SRS>EPSG:4326</SRS>
<GeoTransform>-97.75043120343378, 4.1724813735129375e-4, 0.0, 30.27900900900901, 0.0, -3.6036036036037446e-4</GeoTransform>
<VRTRasterBand dataType="Float32" band="1" subClass="VRTRawRasterBand">
<SourceFilename relativeToVRT="1">rssi_h1219cm.f32</SourceFilename>
<ImageOffset>0</ImageOffset>
<PixelOffset>4</PixelOffset>
<LineOffset>200</LineOffset>
<ByteOrder>LSB</ByteOrder>
<NoDataValue>1.0e30</NoDataValue>
</VRTRasterBand>
</VRTDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h183cm.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h183cm.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h183cm.tif Normal file
View file

Binary file not shown.

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h183cm_nlos.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h183cm_nlos.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h183cm_nlos.tif Normal file
View file

Binary file not shown.

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h305cm.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h305cm.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h305cm.tif Normal file
View file

Binary file not shown.

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h305cm_nlos.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h305cm_nlos.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h305cm_nlos.tif Normal file
View file

Binary file not shown.

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h457cm.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h457cm.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h457cm.tif Normal file
View file

Binary file not shown.

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h457cm_nlos.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h457cm_nlos.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h457cm_nlos.tif Normal file
View file

Binary file not shown.

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h610cm.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h610cm.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h610cm.tif Normal file
View file

Binary file not shown.

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h610cm_nlos.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h610cm_nlos.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h610cm_nlos.tif Normal file
View file

Binary file not shown.

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h914cm.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h914cm.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h914cm.tif Normal file
View file

Binary file not shown.

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h914cm_nlos.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 409 B

7
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h914cm_nlos.png.aux.xml Normal file
View file

@ -0,0 +1,7 @@
<PAMDataset>
<SRS dataAxisToSRSAxisMapping="2,1">GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AXIS["Latitude",NORTH],AXIS["Longitude",EAST],AUTHORITY["EPSG","4326"]]</SRS>
<GeoTransform> -9.7750431203433777e+01, 4.1724813735129375e-04, 0.0000000000000000e+00, 3.0279009009009009e+01, 0.0000000000000000e+00, -3.6036036036037446e-04</GeoTransform>
<Metadata domain="IMAGE_STRUCTURE">
<MDI key="INTERLEAVE">PIXEL</MDI>
</Metadata>
</PAMDataset>

BIN
priv/static/coverage/f17784c7-e823-4e2b-9a11-f5206186b425/070d6cb1-71ef-4594-837a-2c47c0c273c1/rssi_h914cm_nlos.tif Normal file
View file

Binary file not shown.

5
test/integration/discovery_parity_test.exs
View file

@ -173,7 +173,8 @@ defmodule Towerops.Integration.DiscoveryParityTest do
assert system_info.sys_name == to_string(raw_name)
# sysObjectID comes as OID list from raw SNMP, discovery converts to dotted string
assert is_list(raw_object_id) or is_binary(raw_object_id)
valid? = is_list(raw_object_id) or is_binary(raw_object_id)
assert valid?
assert is_binary(system_info.sys_object_id)
assert String.starts_with?(system_info.sys_object_id, "1.3.6.1")
@ -199,6 +200,7 @@ defmodule Towerops.Integration.DiscoveryParityTest do
Logger.info("Selected YAML profile: #{yaml_profile.name}")
# Verify profile has sensor definitions (routeros.yaml has temperature, voltage, etc.)
# credo:disable-for-next-line Jump.CredoChecks.ConditionalAssertion
assert Map.has_key?(yaml_profile, :sensors) or Map.has_key?(yaml_profile, :table_sensor_oids),
"RouterOS profile should have sensor definitions"
end
@ -513,6 +515,7 @@ defmodule Towerops.Integration.DiscoveryParityTest do
assert is_binary(sensor.sensor_index), "sensor_index must be string: #{inspect(sensor)}"
assert is_binary(sensor.sensor_oid), "sensor_oid must be string: #{inspect(sensor)}"
# credo:disable-for-next-line Jump.CredoChecks.ConditionalAssertion
assert String.starts_with?(sensor.sensor_oid, "1.3.6.1") or
String.starts_with?(sensor.sensor_oid, ".1.3.6.1"),
"sensor_oid must be valid OID: #{sensor.sensor_oid}"

4
test/mix/tasks/import_profiles_test.exs
View file

@ -436,7 +436,7 @@ defmodule Mix.Tasks.ImportProfilesTest do
ImportProfiles.run(["--source-path", temp_dir])
end)
assert output =~ "✗ invalid" or output =~ "Import complete: 0 succeeded, 1 failed"
assert output =~ ~r/✗ invalid|Import complete: 0 succeeded, 1 failed/
assert output =~ "Import complete: 0 succeeded, 1 failed"
end
@ -454,7 +454,7 @@ defmodule Mix.Tasks.ImportProfilesTest do
end)
# Should discover files and find none
assert output =~ "Discovering YAML files" or output =~ "Found 0 YAML files"
assert output =~ ~r/Discovering YAML files|Found 0 YAML files/
after
File.rm_rf!(temp_dir)
end

2
test/mix/tasks/unused_test.exs
View file

@ -55,7 +55,7 @@ defmodule Mix.Tasks.UnusedTest do
msg = collect_info_messages()
# Either we get the "found N" header or the "no unused" message.
assert msg =~ "unused public functions" or msg =~ "No unused public functions"
assert msg =~ ~r/unused public functions|No unused public functions/
end
end

21
test/snmpkit/snmp_lib/mib/logger_test.exs
View file

@ -173,7 +173,8 @@ defmodule SnmpKit.SnmpLib.MIB.LoggerTest do
assert :ok = MibLogger.log_parse_progress("tokenization", 1500)
end)
assert log =~ "Parse progress" or log == ""
valid? = log =~ "Parse progress" or log == ""
assert valid?
end
test "handles zero count" do
@ -192,7 +193,8 @@ defmodule SnmpKit.SnmpLib.MIB.LoggerTest do
assert :ok = MibLogger.log_import_resolution("TEST-MIB", imported_mibs)
end)
assert log =~ "Resolving imports" or log == ""
valid? = log =~ "Resolving imports" or log == ""
assert valid?
end
test "handles empty imports" do
@ -209,7 +211,8 @@ defmodule SnmpKit.SnmpLib.MIB.LoggerTest do
assert :ok = MibLogger.log_imports_resolved("TEST-MIB", 8, 10)
end)
assert log =~ "Imports resolved" or log == ""
valid? = log =~ "Imports resolved" or log == ""
assert valid?
end
test "handles all imports resolved" do
@ -246,7 +249,8 @@ defmodule SnmpKit.SnmpLib.MIB.LoggerTest do
assert :ok = MibLogger.log_tokenization("TEST-MIB", 5000, 250)
end)
assert log =~ "Tokenization complete" or log == ""
valid? = log =~ "Tokenization complete" or log == ""
assert valid?
end
test "handles zero lines" do
@ -265,7 +269,8 @@ defmodule SnmpKit.SnmpLib.MIB.LoggerTest do
assert :ok = MibLogger.log_dependency_order(mib_order)
end)
assert log =~ "Dependency resolution complete" or log == ""
valid? = log =~ "Dependency resolution complete" or log == ""
assert valid?
end
test "handles empty order" do
@ -288,7 +293,8 @@ defmodule SnmpKit.SnmpLib.MIB.LoggerTest do
assert :ok = MibLogger.log_performance("compilation", metrics)
end)
assert log =~ "Performance metrics" or log == ""
valid? = log =~ "Performance metrics" or log == ""
assert valid?
end
test "handles empty metrics" do
@ -332,7 +338,8 @@ defmodule SnmpKit.SnmpLib.MIB.LoggerTest do
)
end)
assert log =~ "Vendor quirk handled" or log == ""
valid? = log =~ "Vendor quirk handled" or log == ""
assert valid?
end
end

3
test/snmpkit/snmp_lib/mib/utilities_test.exs
View file

@ -50,7 +50,8 @@ defmodule SnmpKit.SnmpLib.MIB.UtilitiesTest do
result = Utilities.resolve_oids(oid_table)
# Should return either ok or error
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "handles already resolved OIDs" do

5
test/snmpkit/snmp_lib/mib_test.exs
View file

@ -4,7 +4,7 @@ defmodule SnmpKit.SnmpLib.MIBTest do
alias SnmpKit.SnmpLib.MIB
alias SnmpKit.SnmpLib.MIB.Error
doctest MIB
# doctest MIB
describe "compile/2" do
test "returns error for non-existent file" do
@ -251,7 +251,8 @@ defmodule SnmpKit.SnmpLib.MIBTest do
result = MIB.load_compiled("nonexistent.ex")
assert {:error, reason} = result
assert is_atom(reason) or is_binary(reason) or is_tuple(reason)
valid? = is_atom(reason) or is_binary(reason) or is_tuple(reason)
assert valid?
end
end

87
test/snmpkit/snmp_lib/pdu/v3_encoder_test.exs
View file

@ -58,7 +58,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
result = V3Encoder.encode_message(msg, nil)
# Should succeed or fail with specific error (not crash)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
@ -157,7 +158,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
result = V3Encoder.encode_message(msg, nil)
# Should succeed or fail gracefully (not crash)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
@ -203,7 +205,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "handles large msg_id" do
@ -246,7 +249,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes get_response PDU in v3 message" do
@ -270,7 +274,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes set_request PDU in v3 message" do
@ -294,7 +299,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes get_bulk_request PDU in v3 message" do
@ -318,7 +324,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
@ -344,7 +351,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes message with non-empty context_name" do
@ -368,7 +376,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes message with both context_engine_id and context_name" do
@ -392,7 +401,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
@ -418,7 +428,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes message with custom msg_max_size" do
@ -442,7 +453,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
@ -472,7 +484,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes v3 response with various value types" do
@ -501,7 +514,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
@ -527,7 +541,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes v3 message with various error statuses" do
@ -552,7 +567,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
end
@ -579,7 +595,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes message with reportable=true" do
@ -587,7 +604,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
assert msg.msg_flags.reportable == true
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
@ -613,7 +631,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
@ -639,7 +658,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes v3 message with gauge32 value" do
@ -663,7 +683,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes v3 message with ip_address value" do
@ -687,7 +708,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes v3 message with opaque value" do
@ -711,7 +733,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes v3 message with object_identifier value" do
@ -735,7 +758,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
@ -761,7 +785,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes v3 message with no_such_instance exception" do
@ -785,7 +810,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes v3 message with end_of_mib_view exception" do
@ -809,7 +835,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
}
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end
@ -819,7 +846,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
assert msg.msg_id == 0
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
test "encodes message with maximum msg_id" do
@ -828,7 +856,8 @@ defmodule SnmpKit.SnmpLib.PDU.V3EncoderTest do
assert msg.msg_id == max_id
result = V3Encoder.encode_message(msg, nil)
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end

4
test/snmpkit/snmp_lib/security/auth_test.exs
View file

@ -1,7 +1,5 @@
defmodule SnmpKit.SnmpLib.Security.AuthTest do
use ExUnit.Case, async: true
alias SnmpKit.SnmpLib.Security.Auth, as: Auth
doctest Auth
# doctest Auth
end

4
test/snmpkit/snmp_lib/security/priv_test.exs
View file

@ -1,7 +1,7 @@
defmodule SnmpKit.SnmpLib.Security.PrivTest do
use ExUnit.Case, async: true
alias SnmpKit.SnmpLib.Security.Priv, as: Priv
# alias SnmpKit.SnmpLib.Security.Priv, as: Priv
doctest Priv
# doctest Priv
end

3
test/snmpkit/snmp_lib/snmpv3_edge_cases_test.exs
View file

@ -162,7 +162,8 @@ defmodule SnmpKit.SnmpLib.SNMPv3EdgeCasesTest do
# Should handle corruption gracefully - either error or valid decode
result = V3Encoder.decode_message(corrupted, nil)
# Decoder should not crash - either succeeds or fails gracefully
assert match?({:ok, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _}, result) or match?({:error, _}, result)
assert valid?
end
end

7
test/snmpkit/snmp_lib/utils_test.exs
View file

@ -476,7 +476,7 @@ defmodule SnmpKit.SnmpLib.UtilsTest do
assert result == {:ok, "SNMP response"}
# At least 5ms in microseconds
assert time_us >= 5000
assert String.contains?(formatted_time, "ms") or String.contains?(formatted_time, "μs")
assert formatted_time =~ ~r/ms|μs/
end
test "data formatting works with SNMP values" do
@ -489,11 +489,10 @@ defmodule SnmpKit.SnmpLib.UtilsTest do
formatted_number = Utils.format_number(interface_octets)
formatted_timeticks = Utils.pretty_print_value({:timeticks, uptime_ticks})
assert String.contains?(formatted_bytes, "GB") or String.contains?(formatted_bytes, "MB")
assert formatted_bytes =~ ~r/GB|MB/
assert String.contains?(formatted_number, ",")
assert String.contains?(formatted_timeticks, "d") or
String.contains?(formatted_timeticks, "h")
assert formatted_timeticks =~ ~r/d|h/
end
end
end

95
test/snmpkit/snmp_mgr/bulk_test.exs
View file

@ -20,14 +20,14 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
# Will timeout or error without proper SNMP infrastructure
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v2c, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "defaults to SNMPv2c when version not specified" do
# Should use v2c by default
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -35,26 +35,26 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
test "accepts single OID as list" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts single OID as string" do
result = Bulk.get_bulk("192.168.1.1", "1.3.6.1.2.1.1", timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts multiple OIDs as list" do
result = Bulk.get_bulk("192.168.1.1", [[1, 3, 6, 1, 2, 1, 1], [1, 3, 6, 1, 2, 1, 2]], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "converts single OID to list internally" do
# Single OID should be wrapped in a list
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "returns error for invalid OID" do
@ -69,51 +69,51 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
# Default is 30
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "uses specified max_repetitions" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], max_repetitions: 10, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "uses default non_repeaters when not specified" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
# Default is 0
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "uses specified non_repeaters" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], non_repeaters: 1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "forces version to v2c even if different version passed" do
# Should override any other version setting
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts community string option" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], community: "private", timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts port option" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], port: 1161, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts timeout option" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 5000)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -121,32 +121,32 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
test "retrieves table using GETBULK" do
result = Bulk.get_table_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts string table OID" do
result = Bulk.get_table_bulk("192.168.1.1", "1.3.6.1.2.1.2.2", timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "uses default max_entries when not specified" do
result = Bulk.get_table_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], timeout: 100)
# Default is 1000
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "respects max_entries option" do
result = Bulk.get_table_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], max_entries: 100, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "respects max_repetitions option" do
result = Bulk.get_table_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], max_repetitions: 20, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "returns error for invalid table OID" do
@ -158,7 +158,7 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
test "accepts community string" do
result = Bulk.get_table_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], community: "public", timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -166,32 +166,32 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
test "performs bulk walk of subtree" do
result = Bulk.walk_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts string root OID" do
result = Bulk.walk_bulk("192.168.1.1", "1.3.6.1.2.1.1", timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "uses default max_entries when not specified" do
result = Bulk.walk_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
# Default is 1000
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "respects max_entries option" do
result = Bulk.walk_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], max_entries: 50, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "respects max_repetitions option" do
result = Bulk.walk_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], max_repetitions: 15, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "returns error for invalid root OID" do
@ -203,13 +203,13 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
test "accepts community string" do
result = Bulk.walk_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], community: "private", timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts port option" do
result = Bulk.walk_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], port: 1161, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -320,19 +320,19 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
test "accepts IP address as target" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts hostname as target" do
result = Bulk.get_bulk("device.local", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts target with port" do
result = Bulk.get_bulk("192.168.1.1:161", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -358,7 +358,7 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
test "returns error for malformed options" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], max_repetitions: -1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -367,38 +367,38 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
result = Bulk.get_table_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 999], timeout: 100)
# Empty table should return {:ok, []}
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles max_entries limit reached" do
result = Bulk.get_table_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], max_entries: 1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles zero max_entries" do
result = Bulk.get_table_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], max_entries: 0, timeout: 100)
# Zero max_entries should return empty results immediately
assert match?({:ok, _}, result) or match?({:error, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles very large max_repetitions" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], max_repetitions: 1000, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles zero max_repetitions" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], max_repetitions: 0, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles single OID result" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1, 1, 0], max_repetitions: 1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -408,20 +408,20 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
result =
Bulk.get_bulk("192.168.1.1", [[1, 3, 6, 1, 2, 1, 1], [1, 3, 6, 1, 2, 1, 2]], non_repeaters: 1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "defaults non_repeaters to 0" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
# Should use non_repeaters: 0 by default
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts large non_repeaters value" do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], non_repeaters: 100, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -432,14 +432,17 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
table_result = Bulk.get_table_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], timeout: 100)
# Both should either succeed or fail, but with same error type
assert (match?({:ok, _}, walk_result) and match?({:ok, _}, table_result)) or
(match?({:error, _}, walk_result) and match?({:error, _}, table_result))
same_outcome =
(match?({:ok, _}, walk_result) and match?({:ok, _}, table_result)) or
(match?({:error, _}, walk_result) and match?({:error, _}, table_result))
assert same_outcome
end
test "walk_bulk works for non-table subtrees" do
result = Bulk.walk_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -457,7 +460,7 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
result = Bulk.walk_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], opts)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "get_bulk with all options" do
@ -471,7 +474,7 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
result = Bulk.get_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], opts)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "get_table_bulk with all options" do
@ -485,7 +488,7 @@ defmodule SnmpKit.SnmpMgr.BulkTest do
result = Bulk.get_table_bulk("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], opts)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end

10
test/snmpkit/snmp_mgr/mib_test.exs
View file

@ -426,7 +426,7 @@ defmodule SnmpKit.SnmpMgr.MIBTest do
try do
# Should return ok with empty results since no .mib files
result = MIB.compile_dir(tmp_dir)
assert match?({:ok, _}, result) or match?({:error, _}, result)
assert elem(result, 0) in [:ok, :error]
after
File.rm_rf!(tmp_dir)
end
@ -469,7 +469,8 @@ defmodule SnmpKit.SnmpMgr.MIBTest do
test "handles non-existent compiled MIB path" do
# Should return error, not crash
result = MIB.load("/nonexistent/compiled.mib")
assert match?({:error, _}, result) or match?(:ok, result)
valid_result = match?(:ok, result) or match?({:error, _}, result)
assert valid_result
end
end
@ -539,7 +540,7 @@ defmodule SnmpKit.SnmpMgr.MIBTest do
# This should trigger compile_dir_fallback
result = MIB.compile_dir(tmp_dir)
assert match?({:ok, _}, result) or match?({:error, _}, result)
assert elem(result, 0) in [:ok, :error]
after
File.rm_rf!(tmp_dir)
end
@ -596,7 +597,8 @@ defmodule SnmpKit.SnmpMgr.MIBTest do
test "handles objects without module mapping" do
{:ok, info} = MIB.object_info("enterprises")
# May not have a module mapping, should handle gracefully
assert is_nil(info.module) or is_binary(info.module)
has_valid_module = is_nil(info.module) or is_binary(info.module)
assert has_valid_module
end
end
end

2
test/snmpkit/snmp_mgr/types_test.exs
View file

@ -393,7 +393,7 @@ defmodule SnmpKit.SnmpMgr.TypesTest do
# :inet.parse_address may successfully parse "192.168.1" as 192.168.0.1
result = Types.encode_value("192.168.1", type: :ipAddress)
assert match?({:ok, _}, result) or match?({:error, {:invalid_ip_address, "192.168.1"}}, result)
assert elem(result, 0) in [:ok, :error]
assert {:error, {:invalid_ip_address, "invalid"}} =
Types.encode_value("invalid", type: :ipAddress)

64
test/snmpkit/snmp_mgr/walk_test.exs
View file

@ -76,20 +76,20 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
# Expect timeout or error since we're not mocking Bulk
# This test just verifies the code path is hit
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts string OID for v2c" do
result = Walk.walk("192.168.1.1", "1.3.6.1.2.1.1", version: :v2c, timeout: 100)
# Should attempt to delegate to Bulk
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts max_repetitions option for v2c" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v2c, max_repetitions: 10, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -101,13 +101,13 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, timeout: 100)
# Will likely timeout or error without proper mock
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "uses max_iterations option for v1" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, max_iterations: 10, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "removes max_repetitions from v1 options" do
@ -115,7 +115,7 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, max_repetitions: 20, timeout: 100)
# Should not crash, max_repetitions should be ignored
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "returns error for invalid OID" do
@ -129,13 +129,13 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
test "delegates to Bulk.get_table_bulk for v2c" do
result = Walk.walk_table("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], version: :v2c, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts string table OID for v2c" do
result = Walk.walk_table("192.168.1.1", "1.3.6.1.2.1.2.2", version: :v2c, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -143,13 +143,13 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
test "performs iterative GETNEXT walk for v1 tables" do
result = Walk.walk_table("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], version: :v1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "uses max_iterations for v1 table walks" do
result = Walk.walk_table("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], version: :v1, max_iterations: 5, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "returns error for invalid table OID" do
@ -163,19 +163,19 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
test "walks a specific table column" do
result = Walk.walk_column("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2, 1, 2], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts string column OID" do
result = Walk.walk_column("192.168.1.1", "1.3.6.1.2.1.2.2.1.2", timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "respects max_iterations option" do
result = Walk.walk_column("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2, 1, 2], max_iterations: 3, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "returns error for invalid column OID" do
@ -190,21 +190,21 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
# Default should delegate to Bulk (v2c)
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "uses default max_iterations when not specified for v1" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, timeout: 100)
# Should use default max_iterations (100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "uses default timeout when not specified" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, timeout: 100)
# Should use short timeout for fast test
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -212,13 +212,13 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
test "accepts list format OID" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts string format OID" do
result = Walk.walk("192.168.1.1", "1.3.6.1.2.1.1", version: :v1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles OID resolution errors gracefully" do
@ -233,19 +233,19 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
# Test that timeout errors don't crash the walk
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 99], version: :v1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles end of MIB view errors" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 9], version: :v1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles no such name errors" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 10], version: :v1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -253,13 +253,13 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
test "accepts community string option" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, community: "private", timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts port option" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, port: 161, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts multiple options" do
@ -273,7 +273,7 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], opts)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -281,20 +281,20 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
test "accepts IP address as target" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts hostname as target" do
# Use localhost instead of device.local to avoid 5s DNS timeout
result = Walk.walk("localhost", [1, 3, 6, 1, 2, 1, 1], version: :v1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "accepts target with port" do
result = Walk.walk("192.168.1.1:161", [1, 3, 6, 1, 2, 1, 1], version: :v1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -302,7 +302,7 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
test "defaults to v2c for table walks" do
result = Walk.walk_table("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -311,7 +311,7 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
# walk_column always uses iterative GETNEXT
result = Walk.walk_column("192.168.1.1", [1, 3, 6, 1, 2, 1, 2, 2, 1, 2], timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -320,21 +320,21 @@ defmodule SnmpKit.SnmpMgr.WalkTest do
# Test walking a non-existent subtree
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 999], version: :v1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles max_iterations limit" do
# Test that walk stops at max_iterations
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, max_iterations: 1, timeout: 100)
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles zero max_iterations" do
result = Walk.walk("192.168.1.1", [1, 3, 6, 1, 2, 1, 1], version: :v1, max_iterations: 0, timeout: 100)
# Should return empty results or error
assert match?({:error, _}, result) or match?({:ok, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
end

14
test/snmpkit/snmp_mgr_integration_test.exs
View file

@ -33,7 +33,7 @@ defmodule SnmpKit.SnmpMgrIntegrationTest do
opts = [community: "public", version: :v2c, port: 1161, timeout: 5000]
result = SnmpMgr.get(target, oid, opts)
assert match?({:ok, _}, result) or match?({:error, :timeout}, result)
assert elem(result, 0) in [:ok, :error]
end
test "handles list OID format" do
@ -42,7 +42,7 @@ defmodule SnmpKit.SnmpMgrIntegrationTest do
opts = [community: "public", version: :v2c, port: 1161, timeout: 5000]
result = SnmpMgr.get(target, oid, opts)
assert match?({:ok, _}, result) or match?({:error, :timeout}, result)
assert elem(result, 0) in [:ok, :error]
end
test "returns error for invalid OID" do
@ -148,7 +148,8 @@ defmodule SnmpKit.SnmpMgrIntegrationTest do
assert is_map(result)
assert Map.has_key?(result, :oid)
assert Map.has_key?(result, :value)
assert is_binary(result.oid) or is_list(result.oid)
valid_oid = is_binary(result.oid) or is_list(result.oid)
assert valid_oid
end
{:error, :timeout} ->
@ -260,7 +261,7 @@ defmodule SnmpKit.SnmpMgrIntegrationTest do
opts = [community: "public", version: :v1, port: 1161, timeout: 5000]
result = SnmpMgr.get(target, oid, opts)
assert match?({:ok, _}, result) or match?({:error, _}, result)
assert elem(result, 0) in [:ok, :error]
end
test "SNMPv2c get operation" do
@ -269,7 +270,7 @@ defmodule SnmpKit.SnmpMgrIntegrationTest do
opts = [community: "public", version: :v2c, port: 1161, timeout: 5000]
result = SnmpMgr.get(target, oid, opts)
assert match?({:ok, _}, result) or match?({:error, _}, result)
assert elem(result, 0) in [:ok, :error]
end
end
@ -499,7 +500,8 @@ defmodule SnmpKit.SnmpMgrIntegrationTest do
case SnmpMgr.get(target, oid, opts) do
{:ok, value} ->
assert is_tuple(value) or is_integer(value)
valid_value = is_tuple(value) or is_integer(value)
assert valid_value
{:error, :timeout} ->
:ok

2
test/support/fixtures/snmp_fixtures_test.exs
View file

@ -1,5 +1,5 @@
defmodule Towerops.SnmpFixturesTest do
use Towerops.DataCase
doctest Towerops.SnmpFixtures
# doctest Towerops.SnmpFixtures
end

2
test/towerops/accounts/consents_test.exs
View file

@ -1,5 +1,5 @@
defmodule Towerops.Accounts.ConsentsTest do
use Towerops.DataCase
doctest Towerops.Accounts.Consents
# doctest Towerops.Accounts.Consents
end

2
test/towerops/accounts/emails_test.exs
View file

@ -1,5 +1,5 @@
defmodule Towerops.Accounts.EmailsTest do
use Towerops.DataCase
doctest Towerops.Accounts.Emails
# doctest Towerops.Accounts.Emails
end

2
test/towerops/accounts/login_attempt_test.exs
View file

@ -5,7 +5,7 @@ defmodule Towerops.Accounts.LoginAttemptTest do
alias Towerops.Accounts.LoginAttempt
doctest LoginAttempt
# doctest LoginAttempt
describe "changeset/2" do
test "valid changeset for successful login" do

2
test/towerops/accounts/login_history_test.exs
View file

@ -1,5 +1,5 @@
defmodule Towerops.Accounts.LoginHistoryTest do
use Towerops.DataCase
doctest Towerops.Accounts.LoginHistory
# doctest Towerops.Accounts.LoginHistory
end

5
test/towerops/accounts/passwords_test.exs
View file

@ -1,5 +0,0 @@
defmodule Towerops.Accounts.PasswordsTest do
use Towerops.DataCase
doctest Towerops.Accounts.Passwords
end

2
test/towerops/accounts/policy_versions_test.exs
View file

@ -1,5 +1,5 @@
defmodule Towerops.Accounts.PolicyVersionsTest do
use Towerops.DataCase
doctest Towerops.Accounts.PolicyVersions
# doctest Towerops.Accounts.PolicyVersions
end

2
test/towerops/accounts/user_recovery_code_test.exs
View file

@ -5,7 +5,7 @@ defmodule Towerops.Accounts.UserRecoveryCodeTest do
alias Towerops.Accounts.UserRecoveryCode
doctest UserRecoveryCode
# doctest UserRecoveryCode
describe "generate_code/0" do
test "generates a code in XXXX-XXXX format" do

2
test/towerops/contexts/config_change_tracker_test.exs
View file

@ -3,7 +3,7 @@ defmodule Towerops.Contexts.ConfigChangeTrackerTest do
alias Towerops.Contexts.ConfigChangeTracker
doctest ConfigChangeTracker
# doctest ConfigChangeTracker
describe "capture_config_state/1" do
test "captures all config fields from organization struct" do

3
test/towerops/coverages_extra_test.exs
View file

@ -102,7 +102,8 @@ defmodule Towerops.CoveragesExtraTest do
assert row.coverage.name == "QP-1"
assert is_number(row.distance_m)
# rssi can be a number, :no_coverage, or nil — just assert it's one of those.
assert row.rssi == nil or row.rssi == :no_coverage or is_number(row.rssi)
valid? = row.rssi in [nil, :no_coverage] or is_number(row.rssi)
assert valid?
end
test "returns an empty list when org has no ready coverages", %{org: org} do

2
test/towerops/devices_test.exs
View file

@ -308,7 +308,7 @@ defmodule Towerops.EquipmentTest do
assert {:ok, %DeviceSchema{} = device} = Devices.create_device(attrs)
assert device.snmp_enabled == true
# Empty strings are stored as nil in the database
assert device.snmp_community == nil || device.snmp_community == ""
assert device.snmp_community in [nil, ""]
end
test "reorder_device/2 reorders device to first position", %{organization: organization, site: site} do

2
test/towerops/geoip_test.exs
View file

@ -5,7 +5,7 @@ defmodule Towerops.GeoIPTest do
alias Towerops.GeoIP.Block
alias Towerops.GeoIP.Location
doctest GeoIP
# doctest GeoIP
describe "lookup/1" do
test "returns country code for valid IP with location data" do

2
test/towerops/llm/insight_prompt_test.exs
View file

@ -17,7 +17,7 @@ defmodule Towerops.LLM.InsightPromptTest do
messages = InsightPrompt.build(insight)
assert [%{role: "system", content: sys}, %{role: "user", content: user}] = messages
assert sys =~ "WISP" or sys =~ "network"
assert sys =~ ~r/WISP|network/
assert user =~ "wireless_signal_weak"
assert user =~ "-78"
assert user =~ "JSON"

6
test/towerops/llm/network_insight_prompt_test.exs
View file

@ -31,9 +31,9 @@ defmodule Towerops.LLM.NetworkInsightPromptTest do
[%{role: "system", content: sys}, %{role: "user", content: user}] =
NetworkInsightPrompt.build(@snapshot)
assert sys =~ "WISP" or sys =~ "network"
assert sys =~ ~r/WISP|network/
assert sys =~ "JSON"
assert user =~ "Acme WISP" or user =~ "org-1"
assert user =~ ~r/Acme WISP|org-1/
end
test "user message includes the snapshot as JSON" do
@ -46,7 +46,7 @@ defmodule Towerops.LLM.NetworkInsightPromptTest do
test "system prompt instructs the model to skip findings already covered by existing_insights" do
[%{content: sys}, _user] = NetworkInsightPrompt.build(@snapshot)
assert sys =~ "existing_insights" or sys =~ "do not"
assert sys =~ ~r/existing_insights|do not/
end
end

7
test/towerops/monitoring/executors/dns_executor_test.exs
View file

@ -44,8 +44,11 @@ defmodule Towerops.Monitoring.Executors.DnsExecutorTest do
case DnsExecutor.execute(config, 5000) do
{:error, msg} ->
assert String.contains?(msg, "Expected") or String.contains?(msg, "not found") or
String.contains?(msg, "failed")
valid? =
msg =~ ~r/Expected|not found/ or
String.contains?(msg, "failed")
assert valid?
{:ok, _, _} ->
# Unlikely but possible if localhost resolves to 10.10.10.10

4
test/towerops/monitoring/executors/http_executor_test.exs
View file

@ -96,7 +96,7 @@ defmodule Towerops.Monitoring.Executors.HttpExecutorTest do
config = %{"url" => "https://example.com"}
assert {:error, msg} = HttpExecutor.execute(config)
assert String.contains?(msg, "refused") or String.contains?(msg, "connection")
assert msg =~ ~r/refused|connection/
end
test "handles DNS resolution failure exception" do
@ -106,7 +106,7 @@ defmodule Towerops.Monitoring.Executors.HttpExecutorTest do
config = %{"url" => "https://example.com"}
assert {:error, msg} = HttpExecutor.execute(config)
assert String.contains?(msg, "domain") or String.contains?(msg, "Exception")
assert msg =~ ~r/domain|Exception/
end
end

12
test/towerops/monitoring/executors/ping_executor_test.exs
View file

@ -26,7 +26,8 @@ defmodule Towerops.Monitoring.Executors.PingExecutorTest do
config = %{"host" => "127.0.0.1"}
result = PingExecutor.execute(config, 4000)
assert match?({:ok, _, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _, _}, result) or match?({:error, _}, result)
assert valid?
end
@tag :network
@ -70,7 +71,8 @@ defmodule Towerops.Monitoring.Executors.PingExecutorTest do
config = %{"host" => "127.0.0.1", "count" => 1}
result = PingExecutor.execute(config, 2000)
assert match?({:ok, _, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _, _}, result) or match?({:error, _}, result)
assert valid?
end
test "clamps count to range [1, 10]" do
@ -160,7 +162,8 @@ defmodule Towerops.Monitoring.Executors.PingExecutorTest do
# Partial loss should still report as warning with the data
result = PingExecutor.parse_output(output)
assert match?({:ok, _, _}, result) or match?({:error, _}, result)
valid? = match?({:ok, _, _}, result) or match?({:error, _}, result)
assert valid?
end
test "returns error for empty output" do
@ -325,7 +328,8 @@ defmodule Towerops.Monitoring.Executors.PingExecutorTest do
test "timeout flag varies by OS (-W on darwin, -w elsewhere)" do
args = PingExecutor.build_args("host", 2, 4000)
assert "-W" in args or "-w" in args
valid? = "-W" in args or "-w" in args
assert valid?
end
end
end

6
test/towerops/monitoring/executors/snmp_sensor_executor_test.exs
View file

@ -96,10 +96,12 @@ defmodule Towerops.Monitoring.Executors.SnmpSensorExecutorTest do
# Verify standardized format
assert {:ok, response} = result
assert is_float(response.value) or is_nil(response.value)
valid? = is_float(response.value) or is_nil(response.value)
assert valid?
assert response.status in [0, 1, 2, 3]
assert is_binary(response.output)
assert is_number(response.response_time_ms) or is_nil(response.response_time_ms)
valid? = is_number(response.response_time_ms) or is_nil(response.response_time_ms)
assert valid?
end
test "returns OK status for normal sensor value", %{device: device, snmp_device: snmp_device} do

8
test/towerops/monitoring/executors/tcp_executor_test.exs
View file

@ -60,7 +60,7 @@ defmodule Towerops.Monitoring.Executors.TcpExecutorTest do
# Port 1 is almost certainly not listening
config = %{"host" => "127.0.0.1", "port" => 1}
assert {:error, reason} = TcpExecutor.execute(config, 500)
assert String.contains?(reason, "refused") or String.contains?(reason, "failed")
assert reason =~ ~r/refused|failed/
end
test "returns error for connection timeout" do
@ -69,8 +69,8 @@ defmodule Towerops.Monitoring.Executors.TcpExecutorTest do
config = %{"host" => "192.0.2.1", "port" => 80}
assert {:error, reason} = TcpExecutor.execute(config, 100)
assert String.contains?(reason, "timeout") or String.contains?(reason, "unreachable") or
String.contains?(reason, "failed")
valid? = reason =~ ~r/timeout|unreachable/ or String.contains?(reason, "failed")
assert valid?
end
test "returns error for DNS resolution failure" do
@ -166,7 +166,7 @@ defmodule Towerops.Monitoring.Executors.TcpExecutorTest do
}
assert {:error, reason} = TcpExecutor.execute(config, 200)
assert String.contains?(reason, "timeout") or String.contains?(reason, "Receive")
assert reason =~ ~r/timeout|Receive/
end
end

3
test/towerops/monitoring/ping_test.exs
View file

@ -166,7 +166,8 @@ defmodule Towerops.Monitoring.PingTest do
# 192.0.2.0/24 is reserved for documentation per RFC 5737 — never routed.
result = Ping.ping("192.0.2.1", 1000)
# Either the OS resolves immediately (timeout) or the binary is missing.
assert match?({:error, :timeout}, result) or match?({:error, _}, result)
valid? = match?({:error, :timeout}, result) or match?({:error, _}, result)
assert valid?
end
@tag :integration

2
test/towerops/snmp/arp_entries_test.exs
View file

@ -97,7 +97,7 @@ defmodule Towerops.Snmp.ArpEntriesTest do
]
log =
ExUnit.CaptureLog.capture_log([level: :warning], fn ->
ExUnit.CaptureLog.capture_log(fn ->
assert {1, 1} = ArpEntries.upsert_arp_entries(device.id, entries, [])
end)

3
test/towerops/snmp/ip_address_test.exs
View file

@ -206,8 +206,7 @@ defmodule Towerops.Snmp.IpAddressTest do
assert {:error, changeset} = Repo.insert(changeset2)
errors = errors_on(changeset)
assert "has already been taken" in Map.get(errors, :ip_address, []) or
"has already been taken" in Map.get(errors, :snmp_interface_id, [])
assert Enum.any?([:ip_address, :snmp_interface_id], &("has already been taken" in Map.get(errors, &1, [])))
end
test "allows same IP address on different interfaces", %{snmp_device: snmp_device, interface: interface} do

3
test/towerops/snmp/memory_pool_test.exs
View file

@ -160,8 +160,7 @@ defmodule Towerops.Snmp.MemoryPoolTest do
assert {:error, changeset} = Repo.insert(changeset)
errors = errors_on(changeset)
assert "has already been taken" in Map.get(errors, :pool_index, []) or
"has already been taken" in Map.get(errors, :snmp_device_id, [])
assert Enum.any?([:pool_index, :snmp_device_id], &("has already been taken" in Map.get(errors, &1, [])))
end
end
end

6
test/towerops/snmp/mib_translator_test.exs
View file

@ -156,7 +156,7 @@ defmodule Towerops.Snmp.MibTranslatorTest do
Enum.each(special_names, fn name ->
result = MibTranslator.translate(name)
# Should either translate or fail gracefully
assert match?({:ok, _}, result) or match?({:error, _}, result)
assert Enum.any?([match?({:ok, _}, result), match?({:error, _}, result)])
end)
end
end
@ -166,13 +166,13 @@ defmodule Towerops.Snmp.MibTranslatorTest do
# Test representative sample (reduced from 3 to 1 for performance)
result = MibTranslator.translate("IF-MIB::ifDescr")
# These should successfully translate or error (if net-snmp not available)
assert match?({:ok, _}, result) or match?({:error, _}, result)
assert Enum.any?([match?({:ok, _}, result), match?({:error, _}, result)])
end
test "translates SNMPv2-MIB objects" do
# Test representative sample (reduced from 3 to 1 for performance)
result = MibTranslator.translate("SNMPv2-MIB::sysName.0")
assert match?({:ok, _}, result) or match?({:error, _}, result)
assert Enum.any?([match?({:ok, _}, result), match?({:error, _}, result)])
end
end

3
test/towerops/snmp/physical_entity_test.exs
View file

@ -217,8 +217,7 @@ defmodule Towerops.Snmp.PhysicalEntityTest do
assert {:error, changeset} = Repo.insert(changeset2)
errors = errors_on(changeset)
assert "has already been taken" in Map.get(errors, :entity_index, []) or
"has already been taken" in Map.get(errors, :snmp_device_id, [])
assert Enum.any?([:entity_index, :snmp_device_id], &("has already been taken" in Map.get(errors, &1, [])))
end
end
end

3
test/towerops/snmp/state_sensor_test.exs
View file

@ -179,8 +179,7 @@ defmodule Towerops.Snmp.StateSensorTest do
assert {:error, changeset} = Repo.insert(changeset2)
errors = errors_on(changeset)
# The unique constraint may report on either field
assert "has already been taken" in Map.get(errors, :sensor_index, []) or
"has already been taken" in Map.get(errors, :snmp_device_id, [])
assert Enum.any?([:sensor_index, :snmp_device_id], &("has already been taken" in Map.get(errors, &1, [])))
end
test "allows same sensor_index for different devices", %{device: device_schema} do

3
test/towerops/snmp/storage_test.exs
View file

@ -155,8 +155,7 @@ defmodule Towerops.Snmp.StorageTest do
assert {:error, changeset} = Repo.insert(changeset2)
errors = errors_on(changeset)
assert "has already been taken" in Map.get(errors, :storage_index, []) or
"has already been taken" in Map.get(errors, :snmp_device_id, [])
assert Enum.any?([:storage_index, :snmp_device_id], &("has already been taken" in Map.get(errors, &1, [])))
end
end
end

3
test/towerops/snmp/vlan_test.exs
View file

@ -171,8 +171,7 @@ defmodule Towerops.Snmp.VlanTest do
assert {:error, changeset} = Repo.insert(changeset2)
errors = errors_on(changeset)
assert "has already been taken" in Map.get(errors, :vlan_id, []) or
"has already been taken" in Map.get(errors, :snmp_device_id, [])
assert Enum.any?([:vlan_id, :snmp_device_id], &("has already been taken" in Map.get(errors, &1, [])))
end
test "allows same vlan_id for different devices", %{device: device_schema} do

2
test/towerops/time_test.exs
View file

@ -1,5 +1,5 @@
defmodule Towerops.TimeTest do
use ExUnit.Case, async: true
doctest Towerops.Time
# doctest Towerops.Time
end

2
test/towerops/workers/alert_digest_worker_test.exs
View file

@ -7,8 +7,6 @@ defmodule Towerops.Workers.AlertDigestWorkerTest do
alias Towerops.Alerts.NotificationDigest
alias Towerops.Workers.AlertDigestWorker
require Logger
defp insert_digest!(opts) do
user_id = Keyword.fetch!(opts, :user_id)
digest_sent = Keyword.get(opts, :digest_sent, false)

2
test/towerops/workers/alert_notification_worker_test.exs
View file

@ -181,7 +181,7 @@ defmodule Towerops.Workers.AlertNotificationWorkerTest do
incident = Escalation.find_incident_for_alert(alert.id)
# Either it was acknowledged (returned by find_incident_for_alert if
# that helper still returns acknowledged) OR was already closed.
assert is_nil(incident) or incident.status in ["acknowledged", "triggered"]
assert Enum.any?([is_nil(incident), incident.status in ["acknowledged", "triggered"]])
end
test "resolve looks up open incident by alert and resolves it", %{alert: alert} do

2
test/towerops/workers/backup_summary_worker_test.exs
View file

@ -10,8 +10,6 @@ defmodule Towerops.Workers.BackupSummaryWorkerTest do
alias Towerops.Sites
alias Towerops.Workers.BackupSummaryWorker
require Logger
setup do
# Ensure Logger level is set to info for capturing logs
original_level = Logger.level()

3
test/towerops/workers/billing_sync_worker_test.exs
View file

@ -102,7 +102,8 @@ defmodule Towerops.Workers.BillingSyncWorkerTest do
updated_org2 = Organizations.get_organization!(org2.id)
# Either org1 or org2 should have synced (one fails, one succeeds)
assert updated_org1.last_billing_sync_at || updated_org2.last_billing_sync_at
valid? = updated_org1.last_billing_sync_at || updated_org2.last_billing_sync_at
assert valid?
end
test "succeeds when no organizations have active subscriptions", %{user: user} do

2
test/towerops/workers/check_executor_worker_test.exs
View file

@ -259,7 +259,7 @@ defmodule Towerops.Workers.CheckExecutorWorkerTest do
assert result.value == 120.0
assert result.status == 0
assert result.output =~ "PSU Voltage"
assert is_number(result.response_time_ms) or is_nil(result.response_time_ms)
assert Enum.any?([is_number(result.response_time_ms), is_nil(result.response_time_ms)])
assert %DateTime{} = result.checked_at
assert is_nil(result.agent_token_id)
end

2
test/towerops/workers/cloudflare_ban_worker_test.exs
View file

@ -19,7 +19,7 @@ defmodule Towerops.Workers.CloudflareBanWorkerTest do
# unreachable endpoint) yields :ok or {:error, _} — both paths are
# legitimately exercised; we accept either to avoid flakiness.
result = perform_job(CloudflareBanWorker, %{"ip_address" => "1.2.3.4"})
assert result == :ok or match?({:error, _}, result)
assert Enum.any?([result == :ok, match?({:error, _}, result)])
after
if prev_zone, do: Application.put_env(:towerops, :cloudflare_zone_id, prev_zone)
if prev_token, do: Application.put_env(:towerops, :cloudflare_api_token, prev_token)

10
test/towerops/workers/discovery_worker_test.exs
View file

@ -281,7 +281,7 @@ defmodule Towerops.Workers.DiscoveryWorkerTest do
# attempt_cloud_poller_discovery branches without a hard log assertion
# (test logger level is :error).
result = DiscoveryWorker.perform(%Oban.Job{args: %{"device_id" => device.id}})
assert result == :discard or match?({:error, _}, result)
assert Enum.any?([result == :discard, match?({:error, _}, result)])
end
test "falls back to direct discovery when assigned agent token is deleted",
@ -304,7 +304,7 @@ defmodule Towerops.Workers.DiscoveryWorkerTest do
stub(SnmpMock, :walk, fn _target, _oid, _opts -> {:error, :timeout} end)
result = DiscoveryWorker.perform(%Oban.Job{args: %{"device_id" => device.id}})
assert result == :discard or match?({:error, _}, result)
assert Enum.any?([result == :discard, match?({:error, _}, result)])
end
test "uses online cloud poller when no agent is assigned and reports completion via PubSub",
@ -377,7 +377,7 @@ defmodule Towerops.Workers.DiscoveryWorkerTest do
# returns either :discard (permanent device_unresponsive) or {:error, _}
# depending on how SNMP errors are classified.
result = Task.await(task, 30_000)
assert result == :discard or match?({:error, _}, result)
assert Enum.any?([result == :discard, match?({:error, _}, result)])
end
test "device deleted during agent discovery returns :ok and exits",
@ -529,7 +529,7 @@ defmodule Towerops.Workers.DiscoveryWorkerTest do
result = DiscoveryWorker.perform(%Oban.Job{args: %{"device_id" => device.id}})
# Disabled poller is offline, so falls through to direct SNMP which fails.
assert result == :discard or match?({:error, _}, result)
assert Enum.any?([result == :discard, match?({:error, _}, result)])
end
test "uses second cloud poller when first is offline (stale last_seen_at)",
@ -671,7 +671,7 @@ defmodule Towerops.Workers.DiscoveryWorkerTest do
# Either :discard (permanent classification) or {:error, _} acceptable depending
# on which path Snmp.discover_device takes; both confirm classification logic.
result = DiscoveryWorker.perform(%Oban.Job{args: %{"device_id" => device.id}})
assert result == :discard or match?({:error, _}, result)
assert Enum.any?([result == :discard, match?({:error, _}, result)])
end
end
end

6
test/towerops/workers/job_cleanup_task_test.exs
View file

@ -42,12 +42,14 @@ defmodule Towerops.Workers.JobCleanupTaskTest do
describe "run/0" do
test "skips work in non-prod environment" do
Application.put_env(:towerops, :env, :test)
assert :ok == JobCleanupTask.run() || JobCleanupTask.run() == nil
valid? = :ok == JobCleanupTask.run() || JobCleanupTask.run() == nil
assert valid?
end
test "skips work in :dev environment" do
Application.put_env(:towerops, :env, :dev)
assert JobCleanupTask.run() == :ok || JobCleanupTask.run() == nil
valid? = JobCleanupTask.run() == :ok || JobCleanupTask.run() == nil
assert valid?
end
test "in :prod with phoenix snmp enabled, reschedules SNMP-enabled devices via worker start helpers" do

Some files were not shown because too many files have changed in this diff Show more