From 179f0494e58a97dd4ee8867eb5f2de539e2b377e Mon Sep 17 00:00:00 2001
From: Graham McIntire <graham@mcintire.me>
Date: Mon, 16 Feb 2026 16:11:18 -0600
Subject: [PATCH] Fix pre-existing test failures from role enum and MikroTik
 changes

- invitation_test: default role is now :technician not :member
- settings_live_members_test: use "technician" role in invite form (member removed from select)
- form_test: MikroTik API section is intentionally disabled, expect refute
---
 test/towerops/organizations/invitation_test.exs           | 4 ++--
 test/towerops_web/live/device_live/form_test.exs          | 6 +++---
 test/towerops_web/live/org/settings_live_members_test.exs | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/test/towerops/organizations/invitation_test.exs b/test/towerops/organizations/invitation_test.exs
index 5e64764d..39faeee6 100644
--- a/test/towerops/organizations/invitation_test.exs
+++ b/test/towerops/organizations/invitation_test.exs
@@ -35,7 +35,7 @@ defmodule Towerops.Organizations.InvitationTest do
       assert %{email: ["can't be blank"]} = errors_on(changeset)
     end
 
-    test "defaults role to :member when not provided" do
+    test "defaults role to :technician when not provided" do
       attrs = %{
         email: "test@example.com",
         organization_id: Ecto.UUID.generate(),
@@ -45,7 +45,7 @@ defmodule Towerops.Organizations.InvitationTest do
       changeset = Invitation.changeset(%Invitation{}, attrs)
 
       assert changeset.valid?
-      assert Ecto.Changeset.get_field(changeset, :role) == :member
+      assert Ecto.Changeset.get_field(changeset, :role) == :technician
     end
 
     test "requires organization_id" do
diff --git a/test/towerops_web/live/device_live/form_test.exs b/test/towerops_web/live/device_live/form_test.exs
index 3d78978b..f5516e77 100644
--- a/test/towerops_web/live/device_live/form_test.exs
+++ b/test/towerops_web/live/device_live/form_test.exs
@@ -56,7 +56,7 @@ defmodule ToweropsWeb.DeviceLive.FormTest do
       assert html =~ device.name
     end
 
-    test "renders MikroTik section when device is MikroTik", %{
+    test "MikroTik section is hidden even for MikroTik devices (currently disabled)", %{
       conn: conn,
       site: site,
       organization: organization
@@ -95,8 +95,8 @@ defmodule ToweropsWeb.DeviceLive.FormTest do
       assert html =~ "Edit Device"
       assert html =~ device.name
 
-      # MikroTik section SHOULD be visible for all users with MikroTik devices
-      assert html =~ "MikroTik API Configuration"
+      # MikroTik section is currently disabled in the template
+      refute html =~ "MikroTik API Configuration"
     end
 
     test "does not render MikroTik section when device is not MikroTik", %{
diff --git a/test/towerops_web/live/org/settings_live_members_test.exs b/test/towerops_web/live/org/settings_live_members_test.exs
index 16135bc2..78485272 100644
--- a/test/towerops_web/live/org/settings_live_members_test.exs
+++ b/test/towerops_web/live/org/settings_live_members_test.exs
@@ -58,7 +58,7 @@ defmodule ToweropsWeb.Org.SettingsLiveMembersTest do
 
       html =
         view
-        |> form("#invite-form", %{"email" => "newuser@example.com", "role" => "member"})
+        |> form("#invite-form", %{"email" => "newuser@example.com", "role" => "technician"})
         |> render_submit()
 
       assert html =~ "Invitation sent to newuser@example.com"
@@ -113,7 +113,7 @@ defmodule ToweropsWeb.Org.SettingsLiveMembersTest do
         |> live(~p"/orgs/#{org.slug}/settings?tab=members")
 
       view
-      |> form("#invite-form", %{"email" => "swoosh-test@example.com", "role" => "member"})
+      |> form("#invite-form", %{"email" => "swoosh-test@example.com", "role" => "technician"})
       |> render_submit()
 
       # Verify the invitation was created
@@ -131,7 +131,7 @@ defmodule ToweropsWeb.Org.SettingsLiveMembersTest do
       check all(email <- string(:alphanumeric, min_length: 1, max_length: 50)) do
         # Should not crash, may flash error for invalid emails
         view
-        |> form("#invite-form", %{"email" => email, "role" => "member"})
+        |> form("#invite-form", %{"email" => email, "role" => "technician"})
         |> render_submit()
       end
     end