From ec12c1d7bc33a5d2f8c537c086a9acdaf05768b7 Mon Sep 17 00:00:00 2001 From: Graham McIntire Date: Tue, 24 Mar 2026 09:16:17 -0500 Subject: [PATCH] test: fix TestWSDialWriteHandshakeError assertion Remove duplicate assertion that expected only 'write handshake' error. After SetDeadline error checking improvements, closed connections now properly return 'set deadline' errors instead of proceeding to write. Test now accepts both error types as valid. --- websocket_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/websocket_test.go b/websocket_test.go index 2a2cf58..5679479 100644 --- a/websocket_test.go +++ b/websocket_test.go @@ -550,11 +550,11 @@ func TestWSDialWriteHandshakeError(t *testing.T) { } _, err := WSDial("ws://127.0.0.1:9999/socket") - if err == nil || (!strings.Contains(err.Error(), "write handshake") && !strings.Contains(err.Error(), "set deadline")) { - t.Errorf("expected 'write handshake' or 'set deadline' in error, got: %v", err) + if err == nil { + t.Error("expected connection error") } - if !strings.Contains(err.Error(), "write handshake") { - t.Errorf("expected 'write handshake' in error, got: %v", err) + if !strings.Contains(err.Error(), "write handshake") && !strings.Contains(err.Error(), "set deadline") { + t.Errorf("expected 'write handshake' or 'set deadline' in error, got: %v", err) } }