graham/towerops-agent
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: handle error return values in checks.go

Browse source 
Fixed errcheck linter issues:
- resp.Body.Close() in HTTP check
- conn.Close() in TCP check
- conn.SetDeadline() in TCP send/expect
This commit is contained in:
Graham McIntire 2026-02-12 14:38:19 -06:00
parent 7fe07d888d
commit 6682d469a1
No known key found for this signature in database
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
checks.go
View file

@ -105,7 +105,7 @@ func executeHTTPCheck(ctx context.Context, config *pb.HttpCheckConfig, timeoutMs
if err != nil { if err != nil {
return 2, fmt.Sprintf("Request failed: %v", err), responseTime return 2, fmt.Sprintf("Request failed: %v", err), responseTime
} }
defer resp.Body.Close() defer func() { _ = resp.Body.Close() }()
// Check status code // Check status code
expectedStatus := int(config.ExpectedStatus) expectedStatus := int(config.ExpectedStatus)
@ -147,11 +147,11 @@ func executeTCPCheck(ctx context.Context, config *pb.TcpCheckConfig, timeoutMs u
if err != nil { if err != nil {
return 2, fmt.Sprintf("Connection failed: %v", err), responseTime return 2, fmt.Sprintf("Connection failed: %v", err), responseTime
} }
defer conn.Close() defer func() { _ = conn.Close() }()
// If send/expect strings provided, test them // If send/expect strings provided, test them
if config.Send != "" { if config.Send != "" {
conn.SetDeadline(time.Now().Add(timeout)) _ = conn.SetDeadline(time.Now().Add(timeout))
_, err = conn.Write([]byte(config.Send)) _, err = conn.Write([]byte(config.Send))
if err != nil { if err != nil {