Add scalability improvements for 10,000+ equipment

Implemented two critical optimizations for handling large equipment counts:

1. **Concurrent polling limiter**: Added semaphore to limit concurrent
   SNMP polling tasks to 100 at a time, preventing system overload when
   polling 10,000+ devices simultaneously.

2. **Batched metrics flushing**: Increased batch size from 100 to 500
   metrics and added loop to process up to 10,000 metrics per flush cycle
   (20 batches × 500). Prevents metric backlog with high-volume polling.

Performance characteristics:
- 10,000 equipment with 5 sensors each = 50,000 metrics per poll cycle
- Flush cycle handles 10,000 metrics every 30 seconds
- Concurrent polling processes 100 devices at a time instead of unlimited

System resource usage remains bounded regardless of equipment count.
This commit is contained in:
Graham McIntire 2026-01-14 19:01:04 -06:00
parent b9db4133be
commit 6462bdbf81
No known key found for this signature in database

View file

@ -55,7 +55,9 @@ use crate::snmp::SnmpClient;
use crate::metrics::Timestamp; use crate::metrics::Timestamp;
use log::{error, info, warn}; use log::{error, info, warn};
use std::sync::Arc;
use std::time::Duration; use std::time::Duration;
use tokio::sync::Semaphore;
use tokio::time::interval; use tokio::time::interval;
/// Main scheduler that orchestrates polling, config refresh, and metrics submission /// Main scheduler that orchestrates polling, config refresh, and metrics submission
@ -165,28 +167,46 @@ impl Scheduler {
} }
async fn flush_metrics(&self) -> Result<()> { async fn flush_metrics(&self) -> Result<()> {
let pending = self.storage.get_pending_metrics(100)?; // Process metrics in batches until queue is empty or we hit an error
// This handles high-volume scenarios with 10,000+ equipment
let mut total_flushed = 0;
const BATCH_SIZE: usize = 500;
const MAX_BATCHES: usize = 20; // Limit to 10,000 metrics per flush cycle
if pending.is_empty() { for _ in 0..MAX_BATCHES {
return Ok(()); let pending = self.storage.get_pending_metrics(BATCH_SIZE)?;
}
info!("Flushing {} pending metrics to API", pending.len()); if pending.is_empty() {
break;
let ids: Vec<i64> = pending.iter().map(|(id, _)| *id).collect();
let metrics: Vec<_> = pending.into_iter().map(|(_, m)| m).collect();
match self.api_client.submit_metrics(metrics).await {
Ok(_) => {
self.storage.mark_metrics_sent(&ids)?;
info!("Successfully submitted {} metrics", ids.len());
Ok(())
} }
Err(e) => {
warn!("Failed to submit metrics, will retry later: {}", e); let batch_size = pending.len();
Err(e.into()) let ids: Vec<i64> = pending.iter().map(|(id, _)| *id).collect();
let metrics: Vec<_> = pending.into_iter().map(|(_, m)| m).collect();
match self.api_client.submit_metrics(metrics).await {
Ok(_) => {
self.storage.mark_metrics_sent(&ids)?;
total_flushed += batch_size;
}
Err(e) => {
warn!("Failed to submit batch of {} metrics: {}", batch_size, e);
// Don't return error, just log and continue with remaining batches
break;
}
}
// If we got less than batch size, we've emptied the queue
if batch_size < BATCH_SIZE {
break;
} }
} }
if total_flushed > 0 {
info!("Successfully flushed {} metrics to API", total_flushed);
}
Ok(())
} }
async fn send_heartbeat(&self) -> Result<()> { async fn send_heartbeat(&self) -> Result<()> {
@ -240,14 +260,23 @@ impl Scheduler {
equipment_to_poll.len() equipment_to_poll.len()
); );
// Spawn parallel polling tasks // Limit concurrent polling to prevent overwhelming the system
// With 10,000+ equipment, we don't want 10,000 concurrent tasks
const MAX_CONCURRENT_POLLS: usize = 100;
let semaphore = Arc::new(Semaphore::new(MAX_CONCURRENT_POLLS));
// Spawn parallel polling tasks with concurrency limit
let mut tasks = Vec::new(); let mut tasks = Vec::new();
for equipment in equipment_to_poll { for equipment in equipment_to_poll {
let executor = self.executor.clone(); let executor = self.executor.clone();
let storage = self.storage.clone(); let storage = self.storage.clone();
let equipment = equipment.clone(); let equipment = equipment.clone();
let permit = semaphore.clone();
let task = tokio::spawn(async move { let task = tokio::spawn(async move {
// Acquire permit before polling (limits concurrency)
let _permit = permit.acquire().await.unwrap();
info!("Polling equipment: {}", equipment.name); info!("Polling equipment: {}", equipment.name);
// Poll sensors and interfaces in parallel // Poll sensors and interfaces in parallel