From 3d98105853f6f2513572bafc2fb15b0864be4da5 Mon Sep 17 00:00:00 2001 From: Graham McIntire Date: Mon, 23 Mar 2026 12:54:32 -0500 Subject: [PATCH] fix: resolve lint issues from reconnect change Remove unused osExit var and os import, convert if/else chain to tagged switch per staticcheck QF1003. --- agent.go | 2 -- agent_test.go | 7 ++++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/agent.go b/agent.go index 5c9a72c..9d5303c 100644 --- a/agent.go +++ b/agent.go @@ -8,7 +8,6 @@ import ( "fmt" "log/slog" "math/rand/v2" - "os" "runtime" "strconv" "strings" @@ -20,7 +19,6 @@ import ( "google.golang.org/protobuf/proto" ) -var osExit = os.Exit var doSelfUpdate = selfUpdate var errRestartRequested = fmt.Errorf("restart requested") diff --git a/agent_test.go b/agent_test.go index 7152e9d..187cfbb 100644 --- a/agent_test.go +++ b/agent_test.go @@ -1075,14 +1075,15 @@ func TestRunAgentReconnectOnError(t *testing.T) { key := extractWSKey(string(buf[:n])) accept := computeAcceptKey(key) - if count == 1 { + switch count { + case 1: // First connection: upgrade then close immediately (triggers error reconnect) resp := "HTTP/1.1 101 Switching Protocols\r\nUpgrade: websocket\r\nConnection: Upgrade\r\nSec-WebSocket-Accept: " + accept + "\r\n\r\n" _, _ = conn.Write([]byte(resp)) frameBuf := make([]byte, 4096) _, _ = conn.Read(frameBuf) _ = conn.Close() - } else if count == 2 { + case 2: // Second connection: proper session with restart (triggers restart reconnect) resp := "HTTP/1.1 101 Switching Protocols\r\nUpgrade: websocket\r\nConnection: Upgrade\r\nSec-WebSocket-Accept: " + accept + "\r\n\r\n" _, _ = conn.Write([]byte(resp)) @@ -1104,7 +1105,7 @@ func TestRunAgentReconnectOnError(t *testing.T) { _, _ = conn.Write(makeTextFrame(restart)) time.Sleep(time.Second) _ = conn.Close() - } else { + default: // Third connection: agent successfully reconnected after restart _ = conn.Close() }