graham/towerops-agent
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix SNMP client tests for Linux CI environment

Browse source 
- Map "Failed to parse OID" C library errors to InvalidOid variant
- Walk to unreachable host may return empty results instead of error
  on some Linux configurations
This commit is contained in:
Graham McIntire 2026-02-10 08:26:19 -06:00
parent 62f0e1572a
commit 23ccd24210
No known key found for this signature in database
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/snmp/client.rs
View file

@ -340,6 +340,8 @@ impl SnmpSession {
if err_msg.contains("timeout") {
return Err(SnmpError::Timeout);
} else if err_msg.contains("Failed to parse OID") {
return Err(SnmpError::InvalidOid(err_msg));
} else {
return Err(SnmpError::RequestFailed(err_msg));
}
@ -444,6 +446,9 @@ impl SnmpSession {
let err_msg = CStr::from_ptr(error_buf.as_ptr())
.to_string_lossy()
.to_string();
if err_msg.contains("Failed to parse OID") {
return Err(SnmpError::InvalidOid(err_msg));
}
return Err(SnmpError::RequestFailed(err_msg));
}
@ -776,9 +781,15 @@ mod tests {
.walk("192.0.2.1", "public", "2c", 161, "1.3.6.1.2.1.1", None)
.await;
// Both should fail but not panic
// Get should fail (unreachable host), walk may fail or return empty
assert!(get_result.is_err());
assert!(walk_result.is_err());
match walk_result {
Err(_) => {} // Expected on most systems
Ok(results) => assert!(
results.is_empty(),
"Walk to unreachable host should return no results"
),
}
}
#[test]