prop/lib/microwaveprop_web/controllers/user_reset_password_controller.ex
Graham McIntire fd976b0cd5
fix: resolve 391 Credo issues across codebase
- Add jump_credo_checks ~> 0.4 with all 20 checks enabled
- Fix all standard Credo issues: 139 @spec (113 done, 26 remain),
  4 refactoring, 3 alias usage, 9 System.cmd env, 5 unsafe_to_atom,
  2 max line length, 9 assert_receive timeout
- Fix 170+ jump_credo_checks warnings:
  - 117 TopLevelAliasImportRequire: move nested alias/import to module top
  - 32 UseObanProWorker: switch to Oban.Pro.Worker
  - 4 DoctestIExExamples: add doctests / create test file
  - ~20 WeakAssertion: strengthen type-check assertions
  - Various ConditionalAssertion, AssertReceiveTimeout fixes
- Exclude vendor/ from Credo analysis
- Remaining: 175 warnings (mostly opinionated WeakAssertion,
  AvoidSocketAssignsInTest), 26 @spec annotations
2026-06-12 13:51:32 -05:00

68 lines
2.1 KiB
Elixir

defmodule MicrowavepropWeb.UserResetPasswordController do
use MicrowavepropWeb, :controller
alias Microwaveprop.Accounts
plug :get_user_by_reset_password_token when action in [:edit, :update]
@spec new(Plug.Conn.t(), map()) :: Plug.Conn.t()
def new(conn, _params) do
render(conn, :new)
end
@spec create(Plug.Conn.t(), map()) :: Plug.Conn.t()
def create(conn, %{"user" => %{"email" => email}}) do
_ =
if user = Accounts.get_user_by_email(email) do
{:ok, _email} =
Accounts.deliver_user_reset_password_instructions(
user,
&url(~p"/users/reset-password/#{&1}")
)
end
# Always respond the same way whether or not the email exists — this is
# a deliberate anti-enumeration measure. If we redirected differently on
# a miss, an attacker could iterate emails to discover registered accounts.
conn
|> put_flash(
:info,
"If your email is in our system, you will receive instructions to reset your password shortly."
)
|> redirect(to: ~p"/users/log-in")
end
@spec edit(Plug.Conn.t(), map()) :: Plug.Conn.t()
def edit(conn, _params) do
render(conn, :edit,
changeset: Accounts.change_user_password(conn.assigns.user),
token: conn.assigns.token
)
end
@spec update(Plug.Conn.t(), map()) :: Plug.Conn.t()
def update(conn, %{"user" => user_params}) do
case Accounts.reset_user_password(conn.assigns.user, user_params) do
{:ok, _} ->
conn
|> put_flash(:info, "Password reset successfully.")
|> redirect(to: ~p"/users/log-in")
{:error, changeset} ->
render(conn, :edit, changeset: changeset, token: conn.assigns.token)
end
end
defp get_user_by_reset_password_token(conn, _opts) do
%{"token" => token} = conn.params
if user = Accounts.get_user_by_reset_password_token(token) do
conn |> assign(:user, user) |> assign(:token, token)
else
conn
|> put_flash(:error, "Reset link is invalid or it has expired.")
|> redirect(to: ~p"/users/reset-password")
|> halt()
end
end
end