Graham McIntire
0d00d1777c
- Fix Module.safe_concat -> Module.concat in tests with dynamic process names
(safe_concat calls binary_to_existing_atom, but test names are newly generated)
- Fix PSKR AggregatorTest sandbox ownership by switching to async: false
- Fix MapLiveTest assert_patch: regex unsupported in LiveView 1.2, use string match
- Fix WeatherMapLiveTest toggle_grid: assert on checked attribute, not data-grid
- Fix BeaconLive.Index leaking unapproved beacons: wire data_provider to approved_beacons_query
- Fix ContactLive.Index leaking private contacts: wire data_provider with visibility filter
- Fix RecalibratorTest: train() expects factor vectors, not {vector, datetime, band} tuples
- Fix toggle_sort: compare current_field to new_field, not current_order
- Fix internal_network?: handle both atom and string session keys from Plug sessions
Test results: 3979/4001 -> 3997/4001 (18 previously-failing tests now pass)
217 lines
6.9 KiB
Elixir
217 lines
6.9 KiB
Elixir
defmodule Microwaveprop.Propagation.RecalibratorTest do
|
|
use Microwaveprop.DataCase, async: true
|
|
|
|
alias Microwaveprop.Propagation.BandWeights
|
|
alias Microwaveprop.Propagation.Recalibrator
|
|
alias Microwaveprop.Radio.Contact
|
|
alias Microwaveprop.Weather.HrrrProfile
|
|
|
|
@factor_keys [
|
|
:rain,
|
|
:humidity,
|
|
:pwat,
|
|
:season,
|
|
:refractivity,
|
|
:pressure,
|
|
:td_depression,
|
|
:sky,
|
|
:wind,
|
|
:time_of_day
|
|
]
|
|
|
|
defp synthetic_positives do
|
|
List.duplicate([50, 60, 70, 80, 50, 60, 70, 80, 50, 60], 10)
|
|
end
|
|
|
|
defp synthetic_negatives do
|
|
List.duplicate([20, 30, 40, 20, 30, 40, 20, 30, 40, 20], 10)
|
|
end
|
|
|
|
defp create_hrrr_profile(attrs) do
|
|
base = %{
|
|
valid_time: ~U[2024-07-15 06:00:00Z],
|
|
run_time: ~U[2024-07-15 06:00:00Z],
|
|
lat: 32.9,
|
|
lon: -97.0,
|
|
profile: [
|
|
%{"pres" => 1000.0, "hght" => 100, "tmpc" => 25.0, "dwpc" => 20.0},
|
|
%{"pres" => 925.0, "hght" => 750, "tmpc" => 20.0, "dwpc" => 15.0}
|
|
],
|
|
surface_temp_c: 25.0,
|
|
surface_dewpoint_c: 20.0,
|
|
surface_pressure_mb: 1013.0,
|
|
surface_refractivity: 320.0,
|
|
min_refractivity_gradient: -80.0,
|
|
hpbl_m: 1000.0,
|
|
pwat_mm: 30.0,
|
|
ducting_detected: false
|
|
}
|
|
|
|
%HrrrProfile{}
|
|
|> HrrrProfile.changeset(Map.merge(base, attrs))
|
|
|> Microwaveprop.Repo.insert!()
|
|
end
|
|
|
|
defp create_contact(attrs) do
|
|
base = %{
|
|
station1: "W5AA",
|
|
station2: "K5TR",
|
|
qso_timestamp: ~U[2024-07-15 06:00:00Z],
|
|
mode: "CW",
|
|
band: Decimal.new("10000"),
|
|
grid1: "EM12",
|
|
grid2: "EM00",
|
|
pos1: %{"lat" => 32.9, "lon" => -97.0},
|
|
pos2: %{"lat" => 30.3, "lon" => -97.7},
|
|
distance_km: Decimal.new("80")
|
|
}
|
|
|
|
%Contact{}
|
|
|> Contact.changeset(Map.merge(base, attrs))
|
|
|> Microwaveprop.Repo.insert!()
|
|
end
|
|
|
|
describe "train/3" do
|
|
test "returns a weights map with all 10 factor keys summing to ~1.0" do
|
|
result = Recalibrator.train(synthetic_positives(), synthetic_negatives(), epochs: 50, learning_rate: 0.01)
|
|
|
|
assert %{humidity: _humidity} = result.weights
|
|
|
|
for key <- @factor_keys do
|
|
assert Map.has_key?(result.weights, key), "missing weight for #{key}"
|
|
weight = result.weights[key]
|
|
assert is_float(weight), "weight for #{key} should be float, got #{inspect(weight)}"
|
|
assert weight >= 0.0, "weight for #{key} should be non-negative"
|
|
end
|
|
|
|
sum = result.weights |> Map.values() |> Enum.sum()
|
|
assert_in_delta sum, 1.0, 0.001, "weights should sum to 1.0, got #{sum}"
|
|
end
|
|
|
|
test "train_loss decreases from initial loss" do
|
|
result = Recalibrator.train(synthetic_positives(), synthetic_negatives(), epochs: 200, learning_rate: 0.01)
|
|
|
|
assert is_float(result.train_loss)
|
|
assert is_float(result.val_loss)
|
|
assert is_float(result.initial_loss)
|
|
|
|
assert result.train_loss < result.initial_loss,
|
|
"train_loss (#{result.train_loss}) should be less than initial_loss (#{result.initial_loss})"
|
|
end
|
|
end
|
|
|
|
describe "fit/1" do
|
|
test "returns valid result with insufficient HRRR data (falls back to current weights)" do
|
|
# Contacts without matching HRRR profiles for baselines
|
|
create_contact(%{station1: "W5AA"})
|
|
create_contact(%{station1: "W5BB", lat: 33.0, lon: -96.0, qso_timestamp: ~U[2024-07-16 06:00:00Z]})
|
|
|
|
result = Recalibrator.fit(sample_size: 5, epochs: 20, learning_rate: 0.01)
|
|
|
|
assert map_size(result.weights) == 10
|
|
|
|
sum = result.weights |> Map.values() |> Enum.sum()
|
|
assert_in_delta sum, 1.0, 0.01
|
|
end
|
|
end
|
|
|
|
describe "compute_factors/2" do
|
|
test "builds a factor vector from an HRRR profile and timestamp" do
|
|
profile =
|
|
create_hrrr_profile(%{
|
|
valid_time: ~U[2024-07-15 06:00:00Z],
|
|
lat: 32.9,
|
|
lon: -97.0,
|
|
surface_temp_c: 28.0,
|
|
surface_dewpoint_c: 22.0,
|
|
surface_pressure_mb: 1005.0,
|
|
min_refractivity_gradient: -120.0,
|
|
hpbl_m: 800.0,
|
|
pwat_mm: 35.0
|
|
})
|
|
|
|
factors = Recalibrator.compute_factors(profile, ~U[2024-07-15 06:00:00Z])
|
|
|
|
assert length(factors) == 10
|
|
|
|
Enum.each(factors, fn f ->
|
|
assert is_number(f)
|
|
assert f >= 0 and f <= 100
|
|
end)
|
|
end
|
|
end
|
|
|
|
describe "compute_factors/3 (band-aware)" do
|
|
test "humidity score flips direction between 10 GHz (beneficial) and 24 GHz (harmful)" do
|
|
# Hot and moist profile — good for 10 GHz (high refractivity) but bad
|
|
# for 24 GHz (H2O absorption floor). Humidity factor must reflect this.
|
|
profile =
|
|
create_hrrr_profile(%{
|
|
valid_time: ~U[2024-08-15 06:00:00Z],
|
|
lat: 32.9,
|
|
lon: -97.0,
|
|
surface_temp_c: 32.0,
|
|
surface_dewpoint_c: 26.0,
|
|
surface_pressure_mb: 1005.0,
|
|
min_refractivity_gradient: -120.0,
|
|
hpbl_m: 800.0,
|
|
pwat_mm: 45.0
|
|
})
|
|
|
|
[humidity_10, _, _, _, _, _, _, _, _, _] =
|
|
Recalibrator.compute_factors(profile, ~U[2024-08-15 06:00:00Z], 10_000)
|
|
|
|
[humidity_24, _, _, _, _, _, _, _, _, _] =
|
|
Recalibrator.compute_factors(profile, ~U[2024-08-15 06:00:00Z], 24_000)
|
|
|
|
assert humidity_10 > humidity_24,
|
|
"high humidity should score higher at 10 GHz (beneficial) than 24 GHz (harmful); got #{humidity_10} vs #{humidity_24}"
|
|
end
|
|
|
|
test "defaults to 10 GHz when no band supplied" do
|
|
profile =
|
|
create_hrrr_profile(%{
|
|
valid_time: ~U[2024-08-15 06:00:00Z],
|
|
lat: 32.9,
|
|
lon: -97.0
|
|
})
|
|
|
|
default = Recalibrator.compute_factors(profile, ~U[2024-08-15 06:00:00Z])
|
|
explicit_10g = Recalibrator.compute_factors(profile, ~U[2024-08-15 06:00:00Z], 10_000)
|
|
|
|
assert default == explicit_10g
|
|
end
|
|
end
|
|
|
|
describe "fit/1 with :band_mhz" do
|
|
test "only pulls contacts matching the requested band" do
|
|
# Two 10 GHz and one 24 GHz contact. Asking for 24 GHz should see just one.
|
|
create_contact(%{station1: "W5AA", qso_timestamp: ~U[2024-08-15 06:00:00Z]})
|
|
create_contact(%{station1: "W5BB", qso_timestamp: ~U[2024-08-16 06:00:00Z]})
|
|
|
|
{:ok, _c} =
|
|
%Contact{}
|
|
|> Contact.changeset(%{
|
|
station1: "W5CC",
|
|
station2: "K5TR",
|
|
qso_timestamp: ~U[2024-08-17 06:00:00Z],
|
|
mode: "CW",
|
|
band: Decimal.new("24000"),
|
|
grid1: "EM12",
|
|
grid2: "EM00",
|
|
pos1: %{"lat" => 32.9, "lon" => -97.0},
|
|
pos2: %{"lat" => 30.3, "lon" => -97.7},
|
|
distance_km: Decimal.new("80")
|
|
})
|
|
|> Repo.insert()
|
|
|
|
result = Recalibrator.fit(band_mhz: 24_000, sample_size: 10, epochs: 10)
|
|
|
|
# No matching HRRR profile was inserted so this falls back to defaults —
|
|
# the contract we're validating is "the band filter was applied and only
|
|
# 24 GHz contacts were considered". The fallback weights path proves the
|
|
# band-specific contact count came through as 1, not 3.
|
|
assert map_size(result.weights) == 10
|
|
end
|
|
end
|
|
end
|