Enabled :error_handling, :unknown, :unmatched_returns, :extra_return, :missing_return in an earlier commit and landed a 129-warning baseline. Four parallel agents each fixed a directory slice: - Core contexts (29): Radio, Release, Weather, Beacons, Cache, Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient, Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were (a) prefix side-effect calls (Task.start, Phoenix.PubSub, Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't match actual returns; (c) add missing @type t declarations; (d) drop dead parse_int(nil) clause. - Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener, ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis, Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache, HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on PubSub / :ets / Repo.insert_all; widened two specs (float -> number) where integer returns were reachable. - Workers (35): BackfillEnqueue, CanadianSoundingFetch, ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch, NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_* side-effect calls. Fixed one :pattern_match in CanadianSoundingFetch.most_recent_sounding_time/1 where a tautological cond guard generated unreachable code. - Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews, UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining warnings originate in LiveTable.LiveResource dep macro expansion and can't be fixed without forking the dep — added .dialyzer_ignore.exs to suppress just those specific file:line pairs. Also wired ignore_warnings in mix.exs dialyzer config. mix dialyzer --format short | grep ^lib/ | wc -l -> 0 mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.
206 lines
6.4 KiB
Elixir
206 lines
6.4 KiB
Elixir
defmodule Microwaveprop.Weather.GridCache do
|
|
@moduledoc """
|
|
Node-local ETS cache of derived HRRR grid rows keyed by `valid_time`. Mirrors
|
|
`Microwaveprop.Propagation.ScoreCache` but for the `/weather` map.
|
|
|
|
The Weather map LiveView calls `latest_weather_grid/1` on mount and every
|
|
pan/zoom. Each call otherwise hits the 42M-row partitioned `hrrr_profiles`
|
|
table, runs per-row `derive_and_clean` transforms, and returns 3-10k rows.
|
|
With this cache those calls become in-memory map iterations.
|
|
|
|
Each cache entry stores `%{{lat, lon} => derived_row}` so per-point lookups
|
|
(used by `weather_point_detail/3`) are O(1). Populated by
|
|
`Microwaveprop.Weather.warm_grid_cache/1` after the hourly worker upserts
|
|
new HRRR data, fanned out across the cluster via the `"weather:cache"`
|
|
PubSub topic so every node stays in sync.
|
|
"""
|
|
use GenServer
|
|
|
|
alias Phoenix.PubSub
|
|
|
|
@table :weather_grid_cache
|
|
@lock_table :weather_grid_fill_locks
|
|
@topic "weather:cache"
|
|
@pubsub Microwaveprop.PubSub
|
|
|
|
@type row :: %{required(:lat) => float(), required(:lon) => float(), optional(atom()) => any()}
|
|
@type bounds :: %{optional(String.t()) => float()}
|
|
|
|
@spec start_link(keyword()) :: GenServer.on_start()
|
|
def start_link(opts), do: GenServer.start_link(__MODULE__, opts, name: __MODULE__)
|
|
|
|
@spec fetch(DateTime.t()) :: {:ok, [row()]} | :miss
|
|
def fetch(valid_time) do
|
|
case :ets.lookup(@table, valid_time) do
|
|
[{_, grid}] -> {:ok, grid_to_list(grid)}
|
|
[] -> :miss
|
|
end
|
|
end
|
|
|
|
@spec fetch_bounds(DateTime.t(), bounds() | nil) :: {:ok, [row()]} | :miss
|
|
def fetch_bounds(valid_time, bounds) do
|
|
case :ets.lookup(@table, valid_time) do
|
|
[{_, grid}] -> {:ok, grid_to_filtered_list(grid, bounds)}
|
|
[] -> :miss
|
|
end
|
|
end
|
|
|
|
@spec fetch_point(DateTime.t(), float(), float()) :: {:ok, row()} | :miss
|
|
def fetch_point(valid_time, lat, lon) do
|
|
case :ets.lookup(@table, valid_time) do
|
|
[{_, grid}] ->
|
|
case Map.get(grid, {lat, lon}) do
|
|
nil -> :miss
|
|
row -> {:ok, row}
|
|
end
|
|
|
|
[] ->
|
|
:miss
|
|
end
|
|
end
|
|
|
|
@spec put(DateTime.t(), [row()]) :: :ok
|
|
def put(valid_time, rows) do
|
|
grid = list_to_grid(rows)
|
|
:ets.insert(@table, {valid_time, grid})
|
|
:ok
|
|
end
|
|
|
|
@doc "Insert locally AND broadcast to peer nodes via PubSub."
|
|
@spec broadcast_put(DateTime.t(), [row()]) :: :ok
|
|
def broadcast_put(valid_time, rows) do
|
|
_ = PubSub.broadcast(@pubsub, @topic, {:weather_cache_refresh, valid_time, rows})
|
|
:ok
|
|
end
|
|
|
|
@spec latest_valid_time() :: DateTime.t() | nil
|
|
def latest_valid_time do
|
|
match_spec = [{{:"$1", :_}, [], [:"$1"]}]
|
|
|
|
case :ets.select(@table, match_spec) do
|
|
[] -> nil
|
|
times -> Enum.max(times, DateTime)
|
|
end
|
|
end
|
|
|
|
@spec prune_older_than(DateTime.t()) :: non_neg_integer()
|
|
def prune_older_than(cutoff) do
|
|
match_spec = [{{:"$1", :_}, [{:<, :"$1", {:const, cutoff}}], [true]}]
|
|
:ets.select_delete(@table, match_spec)
|
|
end
|
|
|
|
@spec clear() :: :ok
|
|
def clear do
|
|
GenServer.call(__MODULE__, :clear)
|
|
end
|
|
|
|
@doc """
|
|
Atomically claim the right to fill the cache for `valid_time`. Returns
|
|
`true` if this caller won the claim and should run the fill; `false` if
|
|
another caller is already filling. Prevents N concurrent /weather mounts
|
|
after a pod restart from each firing the 15-second cold-fill read and
|
|
starving the Postgres connection pool.
|
|
|
|
The GenServer `Process.monitor`s the caller: if the caller crashes
|
|
before calling `release_fill/1`, the lock is released automatically.
|
|
"""
|
|
@spec claim_fill(DateTime.t()) :: boolean()
|
|
def claim_fill(valid_time) do
|
|
GenServer.call(__MODULE__, {:claim_fill, valid_time, self()})
|
|
end
|
|
|
|
@doc "Release a fill lock claimed via `claim_fill/1`."
|
|
@spec release_fill(DateTime.t()) :: :ok
|
|
def release_fill(valid_time) do
|
|
GenServer.call(__MODULE__, {:release_fill, valid_time})
|
|
end
|
|
|
|
@spec sync() :: :ok
|
|
def sync do
|
|
GenServer.call(__MODULE__, :sync)
|
|
end
|
|
|
|
@impl true
|
|
def init(_opts) do
|
|
_ = :ets.new(@table, [:set, :named_table, :public, :compressed, read_concurrency: true])
|
|
_ = :ets.new(@lock_table, [:set, :named_table, :protected])
|
|
:ok = PubSub.subscribe(@pubsub, @topic)
|
|
{:ok, %{monitors: %{}}}
|
|
end
|
|
|
|
@impl true
|
|
def handle_call(:sync, _from, state), do: {:reply, :ok, state}
|
|
|
|
def handle_call(:clear, _from, state) do
|
|
:ets.delete_all_objects(@table)
|
|
|
|
# Demonitor all tracked callers and drop every lock so tests start clean.
|
|
for {ref, _vt} <- state.monitors, do: Process.demonitor(ref, [:flush])
|
|
:ets.delete_all_objects(@lock_table)
|
|
|
|
{:reply, :ok, %{state | monitors: %{}}}
|
|
end
|
|
|
|
def handle_call({:claim_fill, valid_time, caller}, _from, state) do
|
|
if :ets.insert_new(@lock_table, {valid_time, caller}) do
|
|
ref = Process.monitor(caller)
|
|
{:reply, true, %{state | monitors: Map.put(state.monitors, ref, valid_time)}}
|
|
else
|
|
{:reply, false, state}
|
|
end
|
|
end
|
|
|
|
def handle_call({:release_fill, valid_time}, _from, state) do
|
|
{monitors, _matched} = pop_monitor_for(state.monitors, valid_time)
|
|
:ets.delete(@lock_table, valid_time)
|
|
{:reply, :ok, %{state | monitors: monitors}}
|
|
end
|
|
|
|
@impl true
|
|
def handle_info({:DOWN, ref, :process, _pid, _reason}, state) do
|
|
case Map.pop(state.monitors, ref) do
|
|
{nil, _} ->
|
|
{:noreply, state}
|
|
|
|
{valid_time, monitors} ->
|
|
:ets.delete(@lock_table, valid_time)
|
|
{:noreply, %{state | monitors: monitors}}
|
|
end
|
|
end
|
|
|
|
def handle_info({:weather_cache_refresh, valid_time, rows}, state) do
|
|
put(valid_time, rows)
|
|
{:noreply, state}
|
|
end
|
|
|
|
def handle_info(_msg, state), do: {:noreply, state}
|
|
|
|
defp pop_monitor_for(monitors, valid_time) do
|
|
case Enum.find(monitors, fn {_ref, vt} -> vt == valid_time end) do
|
|
nil ->
|
|
{monitors, nil}
|
|
|
|
{ref, ^valid_time} ->
|
|
Process.demonitor(ref, [:flush])
|
|
{Map.delete(monitors, ref), ref}
|
|
end
|
|
end
|
|
|
|
# ---------- Internal ----------
|
|
|
|
defp list_to_grid(rows) do
|
|
Map.new(rows, fn %{lat: lat, lon: lon} = row -> {{lat, lon}, row} end)
|
|
end
|
|
|
|
defp grid_to_list(grid), do: Enum.map(grid, fn {_, row} -> row end)
|
|
|
|
defp grid_to_filtered_list(grid, nil), do: grid_to_list(grid)
|
|
|
|
defp grid_to_filtered_list(grid, %{"south" => s, "north" => n, "west" => w, "east" => e}) do
|
|
grid
|
|
|> Enum.filter(fn {{lat, lon}, _} ->
|
|
lat >= s and lat <= n and lon >= w and lon <= e
|
|
end)
|
|
|> Enum.map(fn {_, row} -> row end)
|
|
end
|
|
end
|