Graham McIntire
0c3be97abb
P0 (security-critical): - Gate CSV/ADIF upload tabs behind authentication, add 30s cooldown to all upload handlers - Cap CSV/ADIF imports at 2,000 rows server-side in both parsers - Add submitter_verified boolean to contacts (client-cannot-set, anonymous=false) - Create k8s/secret.example.yaml with placeholders, add LIVE_VIEW_SIGNING_SALT P1 (high-priority): - Add Mox.verify_on_exit!() to valkey_test.exs - Replace DateTime.utc_now() truncation with static ~U literals in map_live_test.exs - Replace Process.sleep with render_async in pskr_spots_live_test.exs (6 occurrences) - Add MonitorLive.Show test coverage (4 tests: owner view, non-owner redirect, config success/error) - Extract duct-detection and mechanism-classification logic from ContactLive.Show into Propagation.PathAnalysis - Split ContactLive.Show render into 12 function components - Update CLAUDE.md: remove stale ML model, mark HRDPS active, add backtest/pskr dirs - Batch CSV import enrichment jobs via new enqueue_for_contacts/1 P2 (medium-priority): - Set secure:true on session and remember-me cookies in production - Change SMTP TLS from verify_none to verify_peer with public_key cacerts - Make /metrics fail-closed in production when PROMETHEUS_AUTH_TOKEN unset - Add RateLimiter (anon_limit:10, auth_limit:60) to /api/contacts/map - Add content-security-policy-report-only header - Add comment noting String.to_atom is compile-time safe in hrdps_client.ex - Delegate duplicated haversine_km to canonical Microwaveprop.Geo.haversine_km/4 - Consolidate score-tier/color/verdict formatting into Microwaveprop.Format - Update CLAUDE.md testing section to match actual raw-string-matching practice - Batch HrrrPointEnqueuer Repo.insert_all calls to single round-trip - Split weather.ex (1696→216 lines) and radio.ex (1285→54 lines) into purpose-based sub-facades P3 (low-priority): - Add LIVE_VIEW_SIGNING_SALT warning comment, extend filter_parameters - Add host/community validation to snmp_client.ex - Add raw/1 safety comment in algo_live.ex - Add hex-audit and cargo-audit Makefile targets - Add privacy_live smoke test - Replace notify_listener busy-poll loop with Process.monitor/1 + assert_receive - Add ContactCommonVolumeRadar changeset validation tests (5 tests)
75 lines
2.2 KiB
Elixir
75 lines
2.2 KiB
Elixir
defmodule MicrowavepropWeb.MonitorLive.ShowTest do
|
|
use MicrowavepropWeb.ConnCase, async: false
|
|
|
|
import Microwaveprop.AccountsFixtures
|
|
import Phoenix.LiveViewTest
|
|
|
|
alias Microwaveprop.BeaconMonitors
|
|
|
|
defp owner_and_monitor do
|
|
owner = user_fixture()
|
|
{:ok, monitor} = BeaconMonitors.create_monitor(owner, %{"name" => "Test Monitor"})
|
|
{owner, monitor}
|
|
end
|
|
|
|
describe "mount" do
|
|
test "owner can view their own monitor", %{conn: conn} do
|
|
{owner, monitor} = owner_and_monitor()
|
|
conn = log_in_user(conn, owner)
|
|
|
|
{:ok, _lv, html} = live(conn, ~p"/beacon-monitors/#{monitor.id}")
|
|
|
|
assert html =~ monitor.name
|
|
assert html =~ "Your beacon monitor"
|
|
end
|
|
|
|
test "non-owner is redirected to /users/settings with error flash", %{conn: conn} do
|
|
{_owner, monitor} = owner_and_monitor()
|
|
stranger = user_fixture()
|
|
conn = log_in_user(conn, stranger)
|
|
|
|
assert {:error, {:live_redirect, %{to: "/users/settings"}}} =
|
|
live(conn, ~p"/beacon-monitors/#{monitor.id}")
|
|
end
|
|
end
|
|
|
|
describe "config form" do
|
|
test "successful update shows info flash", %{conn: conn} do
|
|
{owner, monitor} = owner_and_monitor()
|
|
conn = log_in_user(conn, owner)
|
|
|
|
{:ok, lv, _html} = live(conn, ~p"/beacon-monitors/#{monitor.id}")
|
|
|
|
html =
|
|
lv
|
|
|> form("#config-form",
|
|
beacon_monitor: %{
|
|
name: "Updated Monitor",
|
|
config_frequency_hz: 144_400_000,
|
|
config_integration_s: 60,
|
|
config_mode: "wspr"
|
|
}
|
|
)
|
|
|> render_submit()
|
|
|
|
assert html =~ "Configuration updated."
|
|
end
|
|
|
|
test "invalid config re-renders form with validation error", %{conn: conn} do
|
|
{owner, monitor} = owner_and_monitor()
|
|
conn = log_in_user(conn, owner)
|
|
|
|
{:ok, lv, _html} = live(conn, ~p"/beacon-monitors/#{monitor.id}")
|
|
|
|
# config_integration_s must be >= 5; submitting 2 triggers a validation error.
|
|
html =
|
|
lv
|
|
|> form("#config-form", beacon_monitor: %{config_integration_s: 2})
|
|
|> render_submit()
|
|
|
|
refute html =~ "Configuration updated."
|
|
# The form should still be visible (not a server error).
|
|
assert html =~ "config-form"
|
|
end
|
|
end
|
|
end
|