Rework of d61fbd3's dialyzer suppression: the 4 warnings from
LiveTable.LiveResource's macro expansion are now fixed at the
root rather than hidden via .dialyzer_ignore.exs.
Changes:
- Delete .dialyzer_ignore.exs and remove ignore_warnings from
mix.exs. No more hidden suppressions.
- New MicrowavepropWeb.LiveTableResource shim that wraps
use LiveTable.LiveResource and overrides:
* maybe_subscribe/1 — explicit :ok = on Phoenix.PubSub.subscribe/2
(previously discarded, tripping :unmatched_return).
* handle_info/2 — explicit _ = on File.rm, Process.send_after.
Switch all 4 LiveTable-using LiveViews (contact_live/index,
beacon_live/index, admin/contact_edit_live, user_management_live/index)
to use MicrowavepropWeb.LiveTableResource instead.
- New priv/dep_patches/live_table-0.4.1.patch adds _ = in front of
LiveTable.LiveSelectHelpers.restore_live_select_from_params/2 in
the dep's macro-expanded handle_params/3. The call's return was
silently discarded, tripping the fourth warning per LiveView.
- New lib/mix/tasks/deps.patch.ex applies every
priv/dep_patches/*.patch to its target dep idempotently after
mix deps.get. Wired into the :setup alias + overridden
mix deps.get so the patch survives cache regeneration in CI.
- Other modified files in this commit are the spec-coverage
additions from the parallel agent pass (beacons.ex,
commercial.ex, propagation.ex, weather.ex, narr_client.ex,
run_timing.ex, 3 workers) — tighter specs for bounds, tuple
shapes, schema-typed params. Dialyzer remains at 0 after
the changes.
Upstream TODO: send a PR for the live_table `_ =` fix. Once
merged and released, drop the patch + mix task + bump the dep.
mix dialyzer --format short | grep ^lib/ | wc -l -> 0
mix test: 2165 tests, 2 pre-existing flakes (MapLive timestamp +
PropagationPrune ScoresFile), 0 regressions.
142 lines
4 KiB
Elixir
142 lines
4 KiB
Elixir
defmodule Microwaveprop.Beacons do
|
|
@moduledoc """
|
|
The Beacons context. Anyone can submit a beacon — authenticated or not —
|
|
but submissions are held as unapproved until an admin approves them.
|
|
Only approved beacons appear in the public list.
|
|
"""
|
|
|
|
import Ecto.Query, warn: false
|
|
|
|
alias Microwaveprop.Accounts.User
|
|
alias Microwaveprop.Beacons.Beacon
|
|
alias Microwaveprop.Repo
|
|
|
|
@topic "beacons"
|
|
|
|
@doc """
|
|
Subscribes to beacon change notifications. Messages:
|
|
|
|
* `{:created, %Beacon{}}`
|
|
* `{:updated, %Beacon{}}`
|
|
* `{:deleted, %Beacon{}}`
|
|
"""
|
|
@spec subscribe_beacons() :: :ok | {:error, term()}
|
|
def subscribe_beacons do
|
|
Phoenix.PubSub.subscribe(Microwaveprop.PubSub, @topic)
|
|
end
|
|
|
|
defp broadcast(message) do
|
|
Phoenix.PubSub.broadcast(Microwaveprop.PubSub, @topic, message)
|
|
end
|
|
|
|
@doc "Returns approved beacons ordered by most recently added."
|
|
@spec list_beacons() :: [Beacon.t()]
|
|
def list_beacons do
|
|
Repo.all(
|
|
from b in Beacon,
|
|
where: b.approved == true,
|
|
order_by: [desc: b.inserted_at]
|
|
)
|
|
end
|
|
|
|
@doc """
|
|
Base Ecto query for approved beacons. Used as a `live_table`
|
|
`data_provider` so sort/search/pagination can be applied on top.
|
|
"""
|
|
@spec approved_beacons_query() :: Ecto.Query.t()
|
|
def approved_beacons_query do
|
|
from b in Beacon, as: :resource, where: b.approved == true
|
|
end
|
|
|
|
@doc "Returns unapproved beacons awaiting admin review."
|
|
@spec list_pending_beacons() :: [Beacon.t()]
|
|
def list_pending_beacons do
|
|
Repo.all(
|
|
from b in Beacon,
|
|
where: b.approved == false,
|
|
order_by: [asc: b.inserted_at]
|
|
)
|
|
end
|
|
|
|
@doc """
|
|
Returns every beacon (approved or pending) that the given user submitted,
|
|
newest first. Used by the public `/u/:callsign` profile page.
|
|
"""
|
|
@spec list_beacons_for_user(User.t()) :: [Beacon.t()]
|
|
def list_beacons_for_user(%User{id: user_id}) do
|
|
Repo.all(
|
|
from b in Beacon,
|
|
where: b.user_id == ^user_id,
|
|
order_by: [desc: b.inserted_at]
|
|
)
|
|
end
|
|
|
|
@doc "Gets a single beacon. Raises if not found."
|
|
@spec get_beacon!(Ecto.UUID.t()) :: Beacon.t() | [Beacon.t()] | nil
|
|
def get_beacon!(id), do: Beacon |> Repo.get!(id) |> Repo.preload(:user)
|
|
|
|
@doc """
|
|
Creates a beacon. When a user is provided they are recorded as the
|
|
creator; anonymous submissions pass `nil` and leave `user_id` unset.
|
|
"""
|
|
@spec create_beacon(User.t() | nil, map()) :: {:ok, Beacon.t()} | {:error, Ecto.Changeset.t()}
|
|
def create_beacon(user, attrs)
|
|
|
|
def create_beacon(%User{} = user, attrs) do
|
|
%Beacon{user_id: user.id}
|
|
|> Beacon.changeset(attrs)
|
|
|> Repo.insert()
|
|
|> broadcast_if_ok(:created)
|
|
end
|
|
|
|
def create_beacon(nil, attrs) do
|
|
%Beacon{}
|
|
|> Beacon.changeset(attrs)
|
|
|> Repo.insert()
|
|
|> broadcast_if_ok(:created)
|
|
end
|
|
|
|
@doc "Updates a beacon."
|
|
@spec update_beacon(Beacon.t(), map()) :: {:ok, Beacon.t()} | {:error, Ecto.Changeset.t()}
|
|
def update_beacon(%Beacon{} = beacon, attrs) do
|
|
beacon
|
|
|> Beacon.changeset(attrs)
|
|
|> Repo.update()
|
|
|> broadcast_if_ok(:updated)
|
|
end
|
|
|
|
@doc "Marks a beacon as approved, making it visible in the public list."
|
|
@spec approve_beacon(Beacon.t()) :: {:ok, Beacon.t()} | {:error, Ecto.Changeset.t()}
|
|
def approve_beacon(%Beacon{} = beacon) do
|
|
beacon
|
|
|> Ecto.Changeset.change(approved: true)
|
|
|> Repo.update()
|
|
|> broadcast_if_ok(:updated)
|
|
end
|
|
|
|
@doc "Deletes a beacon."
|
|
@spec delete_beacon(Beacon.t()) :: {:ok, Beacon.t()} | {:error, Ecto.Changeset.t()}
|
|
def delete_beacon(%Beacon{} = beacon) do
|
|
case Repo.delete(beacon) do
|
|
{:ok, beacon} ->
|
|
_ = broadcast({:deleted, beacon})
|
|
{:ok, beacon}
|
|
|
|
other ->
|
|
other
|
|
end
|
|
end
|
|
|
|
@doc "Returns an `%Ecto.Changeset{}` for tracking beacon changes."
|
|
@spec change_beacon(Beacon.t(), map()) :: Ecto.Changeset.t()
|
|
def change_beacon(%Beacon{} = beacon, attrs \\ %{}) do
|
|
Beacon.changeset(beacon, attrs)
|
|
end
|
|
|
|
defp broadcast_if_ok({:ok, beacon} = result, type) do
|
|
_ = broadcast({type, beacon})
|
|
result
|
|
end
|
|
|
|
defp broadcast_if_ok(other, _type), do: other
|
|
end
|