Graham McIntire
d61fbd346e
Enabled :error_handling, :unknown, :unmatched_returns, :extra_return, :missing_return in an earlier commit and landed a 129-warning baseline. Four parallel agents each fixed a directory slice: - Core contexts (29): Radio, Release, Weather, Beacons, Cache, Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient, Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were (a) prefix side-effect calls (Task.start, Phoenix.PubSub, Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't match actual returns; (c) add missing @type t declarations; (d) drop dead parse_int(nil) clause. - Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener, ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis, Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache, HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on PubSub / :ets / Repo.insert_all; widened two specs (float -> number) where integer returns were reachable. - Workers (35): BackfillEnqueue, CanadianSoundingFetch, ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch, NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_* side-effect calls. Fixed one :pattern_match in CanadianSoundingFetch.most_recent_sounding_time/1 where a tautological cond guard generated unreachable code. - Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews, UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining warnings originate in LiveTable.LiveResource dep macro expansion and can't be fixed without forking the dep — added .dialyzer_ignore.exs to suppress just those specific file:line pairs. Also wired ignore_warnings in mix.exs dialyzer config. mix dialyzer --format short | grep ^lib/ | wc -l -> 0 mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.
80 lines
2.8 KiB
Elixir
80 lines
2.8 KiB
Elixir
defmodule Mix.Tasks.HrrrClimatology do
|
|
@shortdoc "Build surface temperature climatology from hrrr_profiles"
|
|
@moduledoc """
|
|
Aggregates `hrrr_profiles.surface_temp_c` by (lat, lon, month, hour)
|
|
into `hrrr_climatology` for use by the temperature-anomaly feature.
|
|
|
|
Discovers which (month, hour) combos have data first, then processes
|
|
only those batches. Idempotent via ON CONFLICT.
|
|
|
|
mix hrrr_climatology # build from all grid-point profiles
|
|
mix hrrr_climatology --min-samples 5 # require at least 5 observations per cell
|
|
"""
|
|
use Mix.Task
|
|
|
|
alias Microwaveprop.Repo
|
|
|
|
@impl Mix.Task
|
|
def run(argv) do
|
|
Mix.Task.run("app.start")
|
|
_ = Oban.pause_all_queues(Oban)
|
|
|
|
{opts, _, _} = OptionParser.parse(argv, switches: [min_samples: :integer])
|
|
min_samples = Keyword.get(opts, :min_samples, 3)
|
|
|
|
# Discover which (month, hour) combos actually have data
|
|
%{rows: combos} =
|
|
Repo.query!(
|
|
"""
|
|
SELECT EXTRACT(MONTH FROM valid_time)::int AS month,
|
|
EXTRACT(HOUR FROM valid_time)::int AS hour
|
|
FROM hrrr_profiles
|
|
WHERE surface_temp_c IS NOT NULL AND is_grid_point = true
|
|
GROUP BY 1, 2
|
|
ORDER BY 1, 2
|
|
""",
|
|
[],
|
|
timeout: 120_000
|
|
)
|
|
|
|
Mix.shell().info("Building climatology (min_samples=#{min_samples}, #{length(combos)} batches)...")
|
|
|
|
total =
|
|
combos
|
|
|> Enum.with_index(1)
|
|
|> Enum.reduce(0, fn {[month, hour], idx}, acc ->
|
|
%{num_rows: count} =
|
|
Repo.query!(
|
|
"""
|
|
INSERT INTO hrrr_climatology (id, lat, lon, month, hour,
|
|
mean_surface_temp_c, stddev_surface_temp_c, sample_count)
|
|
SELECT gen_random_uuid(), lat, lon,
|
|
$2 AS month,
|
|
$3 AS hour,
|
|
AVG(surface_temp_c),
|
|
STDDEV_SAMP(surface_temp_c),
|
|
COUNT(*)
|
|
FROM hrrr_profiles
|
|
WHERE surface_temp_c IS NOT NULL
|
|
AND is_grid_point = true
|
|
AND EXTRACT(MONTH FROM valid_time)::int = $2
|
|
AND EXTRACT(HOUR FROM valid_time)::int = $3
|
|
GROUP BY lat, lon
|
|
HAVING COUNT(*) >= $1
|
|
ON CONFLICT (lat, lon, month, hour)
|
|
DO UPDATE SET
|
|
mean_surface_temp_c = EXCLUDED.mean_surface_temp_c,
|
|
stddev_surface_temp_c = EXCLUDED.stddev_surface_temp_c,
|
|
sample_count = EXCLUDED.sample_count
|
|
""",
|
|
[min_samples, month, hour],
|
|
timeout: 300_000
|
|
)
|
|
|
|
Mix.shell().info(" [#{idx}/#{length(combos)}] month=#{month} hour=#{hour}: #{count} rows")
|
|
acc + count
|
|
end)
|
|
|
|
Mix.shell().info("Upserted #{total} climatology records total.")
|
|
end
|
|
end
|