Graham McIntire
d61fbd346e
Enabled :error_handling, :unknown, :unmatched_returns, :extra_return, :missing_return in an earlier commit and landed a 129-warning baseline. Four parallel agents each fixed a directory slice: - Core contexts (29): Radio, Release, Weather, Beacons, Cache, Backtest.Features, Terrain.Srtm, Ionosphere.GiroClient, Propagation.RunTiming, Accounts.Scope, RepoListener. Fixes were (a) prefix side-effect calls (Task.start, Phoenix.PubSub, Logger, :ets.new) with _ = ; (b) tighten/widen specs that didn't match actual returns; (c) add missing @type t declarations; (d) drop dead parse_int(nil) clause. - Propagation + weather subdirs (15): FreshnessMonitor, NotifyListener, ScoreCache, ScoreCacheReconciler, Weather.FrontalAnalysis, Weather.Grib2.Extractor, Weather.Grib2.Wgrib2, GridCache, HrrrPointEnqueuer, NexradCache. Same patterns — mostly _ = on PubSub / :ets / Repo.insert_all; widened two specs (float -> number) where integer returns were reachable. - Workers (35): BackfillEnqueue, CanadianSoundingFetch, ContactImport, ContactWeatherEnqueue, GefsFetch, IemreFetch, NarrFetch, SolarIndex, TerrainProfile, WeatherFetch. Prefixed Repo.update_all / Radio.set_enrichment_status! / Weather.upsert_* side-effect calls. Fixed one :pattern_match in CanadianSoundingFetch.most_recent_sounding_time/1 where a tautological cond guard generated unreachable code. - Web + Mix tasks + lib_ml (46 of 50): controllers, LiveViews, UserAuth, and 11 mix tasks. Same prefix strategy. 4 remaining warnings originate in LiveTable.LiveResource dep macro expansion and can't be fixed without forking the dep — added .dialyzer_ignore.exs to suppress just those specific file:line pairs. Also wired ignore_warnings in mix.exs dialyzer config. mix dialyzer --format short | grep ^lib/ | wc -l -> 0 mix test: 2163 tests, 3 pre-existing flakes, 0 regressions.
72 lines
1.9 KiB
Elixir
72 lines
1.9 KiB
Elixir
defmodule Microwaveprop.Cache do
|
|
@moduledoc """
|
|
Tiny ETS-backed TTL cache for values that are expensive to compute but
|
|
tolerate short staleness. Used for things like `Repo.aggregate` counts that
|
|
would otherwise run on every page load.
|
|
|
|
Not a replacement for `Microwaveprop.Propagation.ScoreCache` or
|
|
`Microwaveprop.Weather.NexradCache` — those have bespoke invalidation logic
|
|
driven by PubSub. This module is for generic time-boxed memoization.
|
|
"""
|
|
use GenServer
|
|
|
|
@table :microwaveprop_cache
|
|
|
|
@spec start_link(keyword()) :: GenServer.on_start()
|
|
def start_link(opts) do
|
|
GenServer.start_link(__MODULE__, opts, name: __MODULE__)
|
|
end
|
|
|
|
@doc """
|
|
Return the cached value for `key` if it's still fresh, otherwise invoke
|
|
`fun`, store the result with `ttl_ms` lifetime, and return it.
|
|
"""
|
|
@spec fetch_or_store(term(), non_neg_integer(), (-> value)) :: value when value: term()
|
|
def fetch_or_store(key, ttl_ms, fun) when is_function(fun, 0) do
|
|
now = System.monotonic_time(:millisecond)
|
|
|
|
case :ets.lookup(@table, key) do
|
|
[{_, value, expires_at}] when expires_at > now ->
|
|
value
|
|
|
|
_ ->
|
|
value = fun.()
|
|
:ets.insert(@table, {key, value, now + ttl_ms})
|
|
value
|
|
end
|
|
end
|
|
|
|
@doc "Insert `value` directly, overwriting any existing entry for `key`."
|
|
@spec put(term(), term(), integer()) :: :ok
|
|
def put(key, value, ttl_ms) do
|
|
:ets.insert(@table, {key, value, System.monotonic_time(:millisecond) + ttl_ms})
|
|
:ok
|
|
end
|
|
|
|
@doc "Remove `key` from the cache, forcing the next fetch to recompute."
|
|
@spec invalidate(term()) :: :ok
|
|
def invalidate(key) do
|
|
:ets.delete(@table, key)
|
|
:ok
|
|
end
|
|
|
|
@spec clear() :: :ok
|
|
def clear do
|
|
:ets.delete_all_objects(@table)
|
|
:ok
|
|
end
|
|
|
|
@impl true
|
|
def init(_opts) do
|
|
_ =
|
|
:ets.new(@table, [
|
|
:set,
|
|
:named_table,
|
|
:public,
|
|
read_concurrency: true,
|
|
write_concurrency: true
|
|
])
|
|
|
|
{:ok, %{}}
|
|
end
|
|
end
|